{"id":21951,"url":"https://patchwork.libcamera.org/api/patches/21951/?format=json","web_url":"https://patchwork.libcamera.org/patch/21951/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241118000738.18977-10-laurent.pinchart@ideasonboard.com>","date":"2024-11-18T00:07:35","name":"[RFC,v2,09/12] ipa: libipa: vector: Add sum() function","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"dbcddb38a1672ae972ee82969b4cd1f7baf50583","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21951/mbox/","series":[{"id":4796,"url":"https://patchwork.libcamera.org/api/series/4796/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4796","date":"2024-11-18T00:07:26","name":"Improve linear algebra helpers in libipa","version":2,"mbox":"https://patchwork.libcamera.org/series/4796/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21951/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21951/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D29D1C330B\n\tfor ;\n\tMon, 18 Nov 2024 00:08:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 64C4E658C1;\n\tMon, 18 Nov 2024 01:08:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F0778658C6\n\tfor ;\n\tMon, 18 Nov 2024 01:07:59 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8F9D175A\n\tfor ;\n\tMon, 18 Nov 2024 01:07:43 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oSkgGAHp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731888463;\n\tbh=PGoQEH+1X1HTjT+lRIMi/goS/WUSGf7J50N8gAibs00=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=oSkgGAHpc2Zy7yjIs5UPl8BNwwDn4r9EBwDVErD0ebvlZW0fpP44CUj9CMZCHvf4x\n\tePoECn+d7+2H7UMWqK6kxGok3jLtHtk6XVtkg8XHsSAA9K7cpZzC4xOOmUcy0OIceL\n\t+W1ZUa9Y9zAI7w+MeOJQ8i/kqDChSSOjua6OXdCQ=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v2 09/12] ipa: libipa: vector: Add sum() function","Date":"Mon, 18 Nov 2024 02:07:35 +0200","Message-ID":"<20241118000738.18977-10-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20241118000738.18977-1-laurent.pinchart@ideasonboard.com>","References":"<20241118000738.18977-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a function to calculate the sum of a vector. It will be useful for\nalgorithms.\n\nSigned-off-by: Laurent Pinchart \n---\nChanges since v1:\n\n- Drop Vector::normalize()\n---\n src/ipa/libipa/vector.cpp | 12 ++++++++++++\n src/ipa/libipa/vector.h | 7 +++++++\n 2 files changed, 19 insertions(+)","diff":"diff --git a/src/ipa/libipa/vector.cpp b/src/ipa/libipa/vector.cpp\nindex 14816cdb5d09..19e7537f8a5a 100644\n--- a/src/ipa/libipa/vector.cpp\n+++ b/src/ipa/libipa/vector.cpp\n@@ -296,6 +296,18 @@ namespace ipa {\n * \\return The length of the vector\n */\n \n+/**\n+ * \\fn Vector::sum() const\n+ * \\brief Calculate the sum of all the vector elements\n+ * \\tparam R The type of the sum\n+ *\n+ * The type R of the sum defaults to the type T of the elements, but can be set\n+ * explicitly to use a different type in case the type T would risk\n+ * overflowing.\n+ *\n+ * \\return The sum of all the vector elements\n+ */\n+\n /**\n * \\fn Vector operator*(const Matrix &m, const Vector &v)\n * \\brief Multiply a matrix by a vector\ndiff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h\nindex 949dc4650aa4..f55da6476103 100644\n--- a/src/ipa/libipa/vector.h\n+++ b/src/ipa/libipa/vector.h\n@@ -9,6 +9,7 @@\n #include \n #include \n #include \n+#include \n #include \n #include \n \n@@ -245,6 +246,12 @@ public:\n \t\treturn std::sqrt(length2());\n \t}\n \n+\ttemplate\n+\tconstexpr R sum() const\n+\t{\n+\t\treturn std::accumulate(data_.begin(), data_.end(), R{});\n+\t}\n+\n private:\n \tstatic constexpr Vector apply(const Vector &lhs, const Vector &rhs, std::function func)\n \t{\n","prefixes":["RFC","v2","09/12"]}