{"id":21950,"url":"https://patchwork.libcamera.org/api/patches/21950/?format=json","web_url":"https://patchwork.libcamera.org/patch/21950/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241118000738.18977-9-laurent.pinchart@ideasonboard.com>","date":"2024-11-18T00:07:34","name":"[RFC,v2,08/12] ipa: libipa: vector: Add element-wise min() and max() functions","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f4c543af6b773c1b96b9e09d6c71398753a32846","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21950/mbox/","series":[{"id":4796,"url":"https://patchwork.libcamera.org/api/series/4796/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4796","date":"2024-11-18T00:07:26","name":"Improve linear algebra helpers in libipa","version":2,"mbox":"https://patchwork.libcamera.org/series/4796/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21950/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21950/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0BB21C32E7\n\tfor ;\n\tMon, 18 Nov 2024 00:08:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 421EA658C2;\n\tMon, 18 Nov 2024 01:08:08 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A1DFF658BA\n\tfor ;\n\tMon, 18 Nov 2024 01:07:58 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3410975A\n\tfor ;\n\tMon, 18 Nov 2024 01:07:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rx4wVH3t\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731888462;\n\tbh=Pfvlw6UcRF4tk7shykP8t1gr7WG5Qkv7/AxCvP7briM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=rx4wVH3tRht1/cidIuNdpfMmgrc6J8i0hJ6MbrKBvIwlCL59kK4mccq82KtqJFjb1\n\tfOnraPO5VqLY5fGOcBL5uYx+0ks+iMevrq/3IX2PU8+IQlL2dtkBSgWBfeguvJrbkp\n\tN86sdb4BEnULtWDFhfBNoEl0YjaPnnqZl78x5zfo=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v2 08/12] ipa: libipa: vector: Add element-wise min() and\n\tmax() functions","Date":"Mon, 18 Nov 2024 02:07:34 +0200","Message-ID":"<20241118000738.18977-9-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20241118000738.18977-1-laurent.pinchart@ideasonboard.com>","References":"<20241118000738.18977-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add functions to calculate the element-wise minimum and maximum of two\nvectors or of a vector and a scalar. This will be used in algorithm\nimplementations.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/libipa/vector.cpp | 28 ++++++++++++++++++++++++++++\n src/ipa/libipa/vector.h | 20 ++++++++++++++++++++\n 2 files changed, 48 insertions(+)","diff":"diff --git a/src/ipa/libipa/vector.cpp b/src/ipa/libipa/vector.cpp\nindex a45f08fde493..14816cdb5d09 100644\n--- a/src/ipa/libipa/vector.cpp\n+++ b/src/ipa/libipa/vector.cpp\n@@ -183,6 +183,34 @@ namespace ipa {\n * \\return This vector\n */\n \n+/**\n+ * \\fn Vector::min(const Vector &other) const\n+ * \\brief Calculate the minimum of this vector and \\a other element-wise\n+ * \\param[in] other The other vector\n+ * \\return The element-wise minimum of this vector and \\a other\n+ */\n+\n+/**\n+ * \\fn Vector::min(T scalar) const\n+ * \\brief Calculate the minimum of this vector and \\a scalar element-wise\n+ * \\param[in] scalar The scalar\n+ * \\return The element-wise minimum of this vector and \\a scalar\n+ */\n+\n+/**\n+ * \\fn Vector::max(const Vector &other) const\n+ * \\brief Calculate the maximum of this vector and \\a other element-wise\n+ * \\param[in] other The other vector\n+ * \\return The element-wise maximum of this vector and \\a other\n+ */\n+\n+/**\n+ * \\fn Vector::max(T scalar) const\n+ * \\brief Calculate the maximum of this vector and \\a scalar element-wise\n+ * \\param[in] scalar The scalar\n+ * \\return The element-wise maximum of this vector and \\a scalar\n+ */\n+\n /**\n * \\fn Vector::dot(const Vector &other) const\n * \\brief Compute the dot product\ndiff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h\nindex 722ffc57ea45..949dc4650aa4 100644\n--- a/src/ipa/libipa/vector.h\n+++ b/src/ipa/libipa/vector.h\n@@ -154,6 +154,26 @@ public:\n \t\treturn apply(scalar, [](T a, T b) { return a / b; });\n \t}\n \n+\tconstexpr Vector min(const Vector &other) const\n+\t{\n+\t\treturn apply(*this, other, [](T a, T b) { return std::min(a, b); });\n+\t}\n+\n+\tconstexpr Vector min(T scalar) const\n+\t{\n+\t\treturn apply(*this, scalar, [](T a, T b) { return std::min(a, b); });\n+\t}\n+\n+\tconstexpr Vector max(const Vector &other) const\n+\t{\n+\t\treturn apply(*this, other, [](T a, T b) { return std::max(a, b); });\n+\t}\n+\n+\tconstexpr Vector max(T scalar) const\n+\t{\n+\t\treturn apply(*this, scalar, [](T a, T b) -> T { return std::max(a, b); });\n+\t}\n+\n \tconstexpr T dot(const Vector &other) const\n \t{\n \t\tT ret = 0;\n","prefixes":["RFC","v2","08/12"]}