[{"id":2932,"web_url":"https://patchwork.libcamera.org/comment/2932/","msgid":"<20191020071357.GA5227@pendragon.ideasonboard.com>","date":"2019-10-20T07:13:57","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline_handler: Fix\n\ttrivial spelling","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Oct 18, 2019 at 04:39:20PM +0100, Kieran Bingham wrote:\n> Signaled is an American spelling.\n> \n> s/signaled/signalled/\n\nYou know that's a lost fight, right ? :-) I however value consistency,\nand as with started with UK spelling, we can continue with it. Care to\nimplement support for spell checking in checkstyle.py ? :-)\n\nAcked-by: Laurent Pinchart \n\n> Fixes: b2c06cf40975 (\"libcamera: Handle request completion explicitly in pipeline handlers\")\n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/pipeline_handler.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index cb4337e50eb6..bf8c86d35c4f 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -353,7 +353,7 @@ const ControlInfoMap &PipelineHandler::controls(Camera *camera)\n> * Pipeline handlers shall override this method. The base implementation in the\n> * PipelineHandler class keeps track of queued requests in order to ensure\n> * completion of all requests when the pipeline handler is stopped with stop().\n> - * Requests completion shall be signaled by the pipeline handler using the\n> + * Requests completion shall be signalled by the pipeline handler using the\n> * completeRequest() method.\n> *\n> * \\return 0 on success or a negative error code otherwise","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B54660BE0\n\tfor ;\n\tSun, 20 Oct 2019 09:14:09 +0200 (CEST)","from pendragon.ideasonboard.com (95-210-23-92.ip.skylogicnet.com\n\t[95.210.23.92])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6E47BA2C;\n\tSun, 20 Oct 2019 09:14:07 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1571555648;\n\tbh=LFuIxRn6WQUQwknYPzqi9yhG5aHGmM/A4jVbpOwXRR0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gX25JvHpshojGsZrUmX9x4Ew4fYQICerOFnXbGtC6kQs8Uy+MYB/0O4hsUL9IB+s4\n\tp3J+zwR2JNi3BGTnWL9/VOwwh8pOvyxchUXhpwjG9C1qVWPfvZmSqXTT7XcXshFWa2\n\t89YWTrjzw3FERBONwZQcX0JWYwjQFJxH3IDjqPsY=","Date":"Sun, 20 Oct 2019 10:13:57 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20191020071357.GA5227@pendragon.ideasonboard.com>","References":"<20191018153920.13394-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20191018153920.13394-1-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline_handler: Fix\n\ttrivial spelling","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 20 Oct 2019 07:14:09 -0000"}},{"id":2933,"web_url":"https://patchwork.libcamera.org/comment/2933/","msgid":"<1a85e201-efb1-ede1-cddd-354841633981@ideasonboard.com>","date":"2019-10-21T10:34:25","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline_handler: Fix\n\ttrivial spelling","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 20/10/2019 08:13, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Fri, Oct 18, 2019 at 04:39:20PM +0100, Kieran Bingham wrote:\n>> Signaled is an American spelling.\n>>\n>> s/signaled/signalled/\n> \n> You know that's a lost fight, right ? :-)\n\nYes, but we already have a usage of signalled in the code base, so this\nis consistent with our existing code base IMO.\n\n(but we also have imported headers from google with signaled which cause\nme despair, but they are external imports, so can be ignored somewhat :D)\n\n> I however value consistency,\n> and as with started with UK spelling, we can continue with it. Care to\n> implement support for spell checking in checkstyle.py ? :-)\n\nI hope to some time... yes...\n\n> Acked-by: Laurent Pinchart \n> \n>> Fixes: b2c06cf40975 (\"libcamera: Handle request completion explicitly in pipeline handlers\")\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> src/libcamera/pipeline_handler.cpp | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n>> index cb4337e50eb6..bf8c86d35c4f 100644\n>> --- a/src/libcamera/pipeline_handler.cpp\n>> +++ b/src/libcamera/pipeline_handler.cpp\n>> @@ -353,7 +353,7 @@ const ControlInfoMap &PipelineHandler::controls(Camera *camera)\n>> * Pipeline handlers shall override this method. The base implementation in the\n>> * PipelineHandler class keeps track of queued requests in order to ensure\n>> * completion of all requests when the pipeline handler is stopped with stop().\n>> - * Requests completion shall be signaled by the pipeline handler using the\n>> + * Requests completion shall be signalled by the pipeline handler using the\n>> * completeRequest() method.\n>> *\n>> * \\return 0 on success or a negative error code otherwise\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F08360BE0\n\tfor ;\n\tMon, 21 Oct 2019 12:34:29 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9244F540;\n\tMon, 21 Oct 2019 12:34:28 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1571654068;\n\tbh=F+Tmgo3KhRLS+Vmi+Mx6vQMX/BkwP9TBJBeYeKTlOwY=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=bJMqh1DH7jIwUJ1Yj2ApMYPKEAFzkl94XyNRcWVDO6ssKbqQu4Ztewfc64/AKiITy\n\tqKHeQ6M047R3v4wDr8gwd7hKrekLGdEV7mXuwGnEN37yE6jJ5qB0q8foI3gqfJICZ3\n\tpmOvfnr9wdMEWXCDwESp2qCahmP7aW+R8vp206gs=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"LibCamera Devel ","References":"<20191018153920.13394-1-kieran.bingham@ideasonboard.com>\n\t<20191020071357.GA5227@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<1a85e201-efb1-ede1-cddd-354841633981@ideasonboard.com>","Date":"Mon, 21 Oct 2019 11:34:25 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.8.0","MIME-Version":"1.0","In-Reply-To":"<20191020071357.GA5227@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline_handler: Fix\n\ttrivial spelling","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 21 Oct 2019 10:34:29 -0000"}}]