{"id":21946,"url":"https://patchwork.libcamera.org/api/patches/21946/?format=json","web_url":"https://patchwork.libcamera.org/patch/21946/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241118000738.18977-5-laurent.pinchart@ideasonboard.com>","date":"2024-11-18T00:07:30","name":"[RFC,v2,04/12] ipa: libipa: vector: Rename the dot product operator*() to dot()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c8d176fbb2ddbd374d5f79672ef7410723f5a3d4","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21946/mbox/","series":[{"id":4796,"url":"https://patchwork.libcamera.org/api/series/4796/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4796","date":"2024-11-18T00:07:26","name":"Improve linear algebra helpers in libipa","version":2,"mbox":"https://patchwork.libcamera.org/series/4796/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21946/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21946/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 885E6C32E7\n\tfor ;\n\tMon, 18 Nov 2024 00:07:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F3D32658C2;\n\tMon, 18 Nov 2024 01:07:57 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 27C62658B7\n\tfor ;\n\tMon, 18 Nov 2024 01:07:53 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BB73E8DB\n\tfor ;\n\tMon, 18 Nov 2024 01:07:36 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"J0MlWB+7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731888456;\n\tbh=zj0U/HE1hEYjvElrAo1U+PSICzRsAqaxIBvUOT/Ccpk=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=J0MlWB+7rmbqI/AxuNgpDg+1WkfyQhuqp8c5nM6C1+1p+cZohDmqLC+UrfDDHjV7c\n\tz6wb62x99e9CrrCAns1u3Ws0aiQiKvP6h4tIXLg5JWNWPIxV3dFRjjPNyWHO62TIBb\n\thbiFQJsyoENw3LBiODzRR/kG+uB39eV3xARu+z3I=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v2 04/12] ipa: libipa: vector: Rename the dot product\n\toperator*() to dot()","Date":"Mon, 18 Nov 2024 02:07:30 +0200","Message-ID":"<20241118000738.18977-5-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20241118000738.18977-1-laurent.pinchart@ideasonboard.com>","References":"<20241118000738.18977-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The Vector class defines a set of arithmetic operators between two\nvectors or a vector and a scalar. All the operators perform element-wise\noperations, except for the operator*() that computes the dot product.\nThis is inconsistent and confusing. Replace the operator with a dot()\nfunction.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/libipa/vector.cpp | 14 +++++++-------\n src/ipa/libipa/vector.h | 16 ++++++++--------\n 2 files changed, 15 insertions(+), 15 deletions(-)","diff":"diff --git a/src/ipa/libipa/vector.cpp b/src/ipa/libipa/vector.cpp\nindex df089f8aed9f..b2794c200b05 100644\n--- a/src/ipa/libipa/vector.cpp\n+++ b/src/ipa/libipa/vector.cpp\n@@ -85,13 +85,6 @@ namespace ipa {\n * \\return The sum of the two vectors\n */\n \n-/**\n- * \\fn Vector::operator*(const Vector &other) const\n- * \\brief Compute the dot product\n- * \\param[in] other The other vector\n- * \\return The dot product of the two vectors\n- */\n-\n /**\n * \\fn Vector::operator*(T factor) const\n * \\brief Multiply the vector by a scalar\n@@ -106,6 +99,13 @@ namespace ipa {\n * \\return The vector divided by \\a factor\n */\n \n+/**\n+ * \\fn Vector::dot(const Vector &other) const\n+ * \\brief Compute the dot product\n+ * \\param[in] other The other vector\n+ * \\return The dot product of the two vectors\n+ */\n+\n /**\n * \\fn T &Vector::x()\n * \\brief Convenience function to access the first element of the vector\ndiff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h\nindex 50e16250acfd..9dabdc28a540 100644\n--- a/src/ipa/libipa/vector.h\n+++ b/src/ipa/libipa/vector.h\n@@ -90,14 +90,6 @@ public:\n \t\treturn ret;\n \t}\n \n-\tconstexpr T operator*(const Vector &other) const\n-\t{\n-\t\tT ret = 0;\n-\t\tfor (unsigned int i = 0; i < Rows; i++)\n-\t\t\tret += data_[i] * other[i];\n-\t\treturn ret;\n-\t}\n-\n \tconstexpr Vector operator*(T factor) const\n \t{\n \t\tVector ret;\n@@ -114,6 +106,14 @@ public:\n \t\treturn ret;\n \t}\n \n+\tconstexpr T dot(const Vector &other) const\n+\t{\n+\t\tT ret = 0;\n+\t\tfor (unsigned int i = 0; i < Rows; i++)\n+\t\t\tret += data_[i] * other[i];\n+\t\treturn ret;\n+\t}\n+\n #ifndef __DOXYGEN__\n \ttemplate= 1>>\n #endif /* __DOXYGEN__ */\n","prefixes":["RFC","v2","04/12"]}