{"id":21945,"url":"https://patchwork.libcamera.org/api/patches/21945/?format=json","web_url":"https://patchwork.libcamera.org/patch/21945/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241118000738.18977-4-laurent.pinchart@ideasonboard.com>","date":"2024-11-18T00:07:29","name":"[RFC,v2,03/12] ipa: libipa: vector: Add copy constructor and assignment operator","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"26c41c3a69c64d6f3c713fe9f8f51eb02230423c","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21945/mbox/","series":[{"id":4796,"url":"https://patchwork.libcamera.org/api/series/4796/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4796","date":"2024-11-18T00:07:26","name":"Improve linear algebra helpers in libipa","version":2,"mbox":"https://patchwork.libcamera.org/series/4796/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21945/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21945/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3E2F1C32EF\n\tfor ;\n\tMon, 18 Nov 2024 00:07:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9664E658B5;\n\tMon, 18 Nov 2024 01:07:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD32F658B3\n\tfor ;\n\tMon, 18 Nov 2024 01:07:51 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5BB2175A\n\tfor ;\n\tMon, 18 Nov 2024 01:07:35 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M4nLx1Ky\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731888455;\n\tbh=u9dR8L8pQLloFRR66pjmoAU0G54ZdDGmseZUGeLoWa4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=M4nLx1Ky7QiL8RF7IrPx5/46Tzg+lRIIt3q0aj3FQOXhA/Bz2Iao5/1o3zEBOJU2K\n\tUkVBvp5YJcV/8Ek/T4wl1LDpKTtJi21/iq4sPL9PA9Z3r2x2d9AtRbb3C+AoF4fH9z\n\ttxIepTwUxzgPeHNwRR6ldQhQr5UzTeZ+OJmMOdTw=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v2 03/12] ipa: libipa: vector: Add copy constructor and\n\tassignment operator","Date":"Mon, 18 Nov 2024 02:07:29 +0200","Message-ID":"<20241118000738.18977-4-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20241118000738.18977-1-laurent.pinchart@ideasonboard.com>","References":"<20241118000738.18977-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"It is useful to assign a value to an existing vector. Define a copy\nconstructor and a copy assignment operator.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/libipa/vector.cpp | 13 +++++++++++++\n src/ipa/libipa/vector.h | 13 +++++++++++++\n 2 files changed, 26 insertions(+)","diff":"diff --git a/src/ipa/libipa/vector.cpp b/src/ipa/libipa/vector.cpp\nindex f14f155216f3..df089f8aed9f 100644\n--- a/src/ipa/libipa/vector.cpp\n+++ b/src/ipa/libipa/vector.cpp\n@@ -40,6 +40,19 @@ namespace ipa {\n * The size of \\a data must be equal to the dimension size Rows of the vector.\n */\n \n+/**\n+ * \\fn Vector::Vector(const Vector &other)\n+ * \\brief Construct a Vector by copying \\a other\n+ * \\param[in] other The other Vector value\n+ */\n+\n+/**\n+ * \\fn Vector &Vector::operator=(const Vector &other)\n+ * \\brief Replace the content of the Vector with a copy of the content of \\a other\n+ * \\param[in] other The other Vector value\n+ * \\return This Vector value\n+ */\n+\n /**\n * \\fn T Vector::operator[](size_t i) const\n * \\brief Index to an element in the vector\ndiff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h\nindex b72ab9851aa3..50e16250acfd 100644\n--- a/src/ipa/libipa/vector.h\n+++ b/src/ipa/libipa/vector.h\n@@ -6,6 +6,7 @@\n */\n #pragma once\n \n+#include \n #include \n #include \n #include \n@@ -41,6 +42,18 @@ public:\n \t\t\tdata_[i] = data[i];\n \t}\n \n+\tVector(const Vector &other)\n+\t\t: data_(other.data_)\n+\t{\n+\t}\n+\n+\tVector &operator=(const Vector &other)\n+\t{\n+\t\tdata_ = other.data_;\n+\n+\t\treturn *this;\n+\t}\n+\n \tconst T &operator[](size_t i) const\n \t{\n \t\tASSERT(i < data_.size());\n","prefixes":["RFC","v2","03/12"]}