[{"id":2929,"web_url":"https://patchwork.libcamera.org/comment/2929/","msgid":"<20191016232321.GA13372@bigcity.dyn.berto.se>","date":"2019-10-16T23:23:21","subject":"Re: [libcamera-devel] [PATCH] qcam: Support Qt versions earlier\n\tthan 5.9","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2019-10-17 02:20:18 +0300, Laurent Pinchart wrote:\n> The QtEventDispatcher timers implementation depends on Qt 5.9 or newer\n> due to the use of QObject::startTimer(std::chrono::milliseconds).\n> Support earlier Qt versions by using the QObject::startTimer(int)\n> version instead.\n> \n> Signed-off-by: Laurent Pinchart \n\nThis fixes the problem I ran into on gcc 6.3.0.\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/qcam/qt_event_dispatcher.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/qcam/qt_event_dispatcher.cpp b/src/qcam/qt_event_dispatcher.cpp\n> index 9e989bef7d53..2780c9123ac3 100644\n> --- a/src/qcam/qt_event_dispatcher.cpp\n> +++ b/src/qcam/qt_event_dispatcher.cpp\n> @@ -117,7 +117,7 @@ void QtEventDispatcher::registerTimer(Timer *timer)\n> \tstd::chrono::steady_clock::duration duration = timer->deadline() - now;\n> \tstd::chrono::milliseconds msec =\n> \t\tstd::chrono::duration_cast(duration);\n> -\tint timerId = startTimer(msec);\n> +\tint timerId = startTimer(msec.count());\n> \ttimers_[timerId] = timer;\n> \ttimerIds_[timer] = timerId;\n> }\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C350E60E1B\n\tfor ;\n\tThu, 17 Oct 2019 01:23:23 +0200 (CEST)","by mail-lj1-x243.google.com with SMTP id m13so454020ljj.11\n\tfor ;\n\tWed, 16 Oct 2019 16:23:23 -0700 (PDT)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tq66sm134191ljq.101.2019.10.16.16.23.22\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 16 Oct 2019 16:23:22 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=8M/gEWrfV/1Y85VPwsD+dkwb/6aTJ/qtiLz9Z5uhPzs=;\n\tb=Oh2YMZqDFYaOau7VJjnOclWyAYMKqU+lFyr4Ux4v1OSAMZfatSZJu0+Y60qP41o5Vo\n\tGdcHxF/mgAebzk77fy8eHfkuGd/uIQORZJgU0sYxKBFQoolf6nRndWGuHpiaIxWZtAQ4\n\tLQq3qjaCFBWbdEZHh2gdPzuY285XF1313i+1L9zliSjNaXy1q0GQRoZRJ3g0irtcNEtj\n\tp6B5cbHvNmNz9g9jlgJJDoq9x7iBxNx56CuPsFgdIx7LO4wdLT4fRQdlNgQxqZEARTbK\n\tTE45B4iG32gdge1ceWFbhDLSxxCGEfYWUL4+WVdYUqX/e+aA8Nv36xOQyJlb8V9CC2hp\n\tCYLQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=8M/gEWrfV/1Y85VPwsD+dkwb/6aTJ/qtiLz9Z5uhPzs=;\n\tb=UeylNtrCTNlpgc73gSiify88l3S36+rB472B62EM7+TwSaFcv4FUFhseUE1/ZglrdH\n\t0jVASi7QxK9DUBQdIbOGXZ5sikwoo+QOEj5QpL4zaGy1MMlnmYnJhtifR4hoWexPgz/w\n\t8HN0YzOSLuUOnMgmnRZ9G0+77P6vc9tBgHwP9UHfP/RN1Ygw5iYPLPg+au++9KUmqxSl\n\t1AuWsHqewou9ijSK4vxX/QMlC3Sa29BRBW1K8CgHOyhoiPpaCUUyxo7u8MWcRSePv+/o\n\tLlFSZPSdMneMSnYpC26kHhjRUnRzFiNN3NGo8BB7PaH8su5GyRywKc5021/pgHTGzR4u\n\tknyw==","X-Gm-Message-State":"APjAAAU5heDPjR8KhmeRRhB7rO2erlBAGl2Lk3MFF589jSdNsqPFShLu\n\tUohjQbRemBmVIK1ZQXKNENIXuw==","X-Google-Smtp-Source":"APXvYqxlD9OBf0GA52ztL3M2UHe65qCV2PMq/imPP2IjfIUVYaZI+ZG3CZjWNdCJsVaDxpAiPjJ1bQ==","X-Received":"by 2002:a2e:9ad0:: with SMTP id p16mr362293ljj.179.1571268202983;\n\tWed, 16 Oct 2019 16:23:22 -0700 (PDT)","Date":"Thu, 17 Oct 2019 01:23:21 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191016232321.GA13372@bigcity.dyn.berto.se>","References":"<20191016232018.30239-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191016232018.30239-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH] qcam: Support Qt versions earlier\n\tthan 5.9","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 16 Oct 2019 23:23:23 -0000"}}]