[{"id":32185,"web_url":"https://patchwork.libcamera.org/comment/32185/","msgid":"<173167345344.4187655.8752564209584239056@ping.linuxembedded.co.uk>","date":"2024-11-15T12:24:13","subject":"Re: [PATCH v6 09/14] libcamera: bayer_format: Add 20-bit bayer\n\tformats","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Daniel Scally (2024-11-15 10:13:29)\n> Add support for the 20-bit bayer formats to libcamera's BayerFormat class.\n> \n> Signed-off-by: Daniel Scally \n> ---\n> Changes in v6:\n> \n> - New patch\n> \n> src/libcamera/bayer_format.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/bayer_format.cpp b/src/libcamera/bayer_format.cpp\n> index c2120d1c..3dab91fc 100644\n> --- a/src/libcamera/bayer_format.cpp\n> +++ b/src/libcamera/bayer_format.cpp\n> @@ -225,6 +225,10 @@ const std::unordered_map mbusCodeToBayer{\n> { MEDIA_BUS_FMT_SGBRG16_1X16, { BayerFormat::GBRG, 16, BayerFormat::Packing::None } },\n> { MEDIA_BUS_FMT_SGRBG16_1X16, { BayerFormat::GRBG, 16, BayerFormat::Packing::None } },\n> { MEDIA_BUS_FMT_SRGGB16_1X16, { BayerFormat::RGGB, 16, BayerFormat::Packing::None } },\n> + { MEDIA_BUS_FMT_SBGGR20_1X20, { BayerFormat::BGGR, 20, BayerFormat::Packing::None } },\n> + { MEDIA_BUS_FMT_SGBRG20_1X20, { BayerFormat::GBRG, 20, BayerFormat::Packing::None } },\n> + { MEDIA_BUS_FMT_SGRBG20_1X20, { BayerFormat::GRBG, 20, BayerFormat::Packing::None } },\n> + { MEDIA_BUS_FMT_SRGGB20_1X20, { BayerFormat::RGGB, 20, BayerFormat::Packing::None } },\n\nThese entries are so annoyingly duplicated... (not /your/ fault).\n\nI wonder if we should/could macro this out with the preprocessor to :\n\n#define MBUS_BAYER_FORMAT_CODE(code, bits) \\\n\t{ MEDIA_BUS_FMT_S#code#bits_1X#bits, { BayerFormat::GRBG, #bits, BayerFormat::Packing::None },\n\n\n#define MBUS_BAYER_FORMAT(bits) \\\n\tMBUS_BAYER_FORMAT_CODE(BGGR, bits) \\\n MBUS_BAYER_FORMAT_CODE(GBRG, bits) \\\n MBUS_BAYER_FORMAT_CODE(GRBG, bits) \\\n MBUS_BAYER_FORMAT_CODE(RGGB, bits)\n\n\n(That string join at MEDIA_BUS_FMT_S#code#bits_1X#bits, would probably\nbe tricky)\n\n\nand then this table would have\n\t{\n\t\t...\n\t\tMBUS_BAYER_FORMAT(8),\n\t\tMBUS_BAYER_FORMAT(10),\n\t\tMBUS_BAYER_FORMAT(12),\n\t\tMBUS_BAYER_FORMAT(16),\n\t\t...\n\t}\n\n\t(names/parameters could always be changed)\n\nThe packed formats could be mapped with more specific helpers too to\nproduce the table perhaps...\n\nMaybe it's overkill - but maybe it would help maintain the table and\nmake it more readable for the 'whole' table content/intent...\n\nBut ... that's a yak ... so if you don't think that's interesting - I\nthink this patch is still valid:\n\n\n\nReviewed-by: Kieran Bingham \n\n\n\n> { MEDIA_BUS_FMT_Y8_1X8, { BayerFormat::MONO, 8, BayerFormat::Packing::None } },\n> { MEDIA_BUS_FMT_Y10_1X10, { BayerFormat::MONO, 10, BayerFormat::Packing::None } },\n> { MEDIA_BUS_FMT_Y12_1X12, { BayerFormat::MONO, 12, BayerFormat::Packing::None } },\n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E3327C3257\n\tfor ;\n\tFri, 15 Nov 2024 12:24:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 214E265879;\n\tFri, 15 Nov 2024 13:24:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D18B6580A\n\tfor ;\n\tFri, 15 Nov 2024 13:24:16 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4B839496;\n\tFri, 15 Nov 2024 13:24:01 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iY8Nabmx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731673441;\n\tbh=4Mlqs9nRLhVGLlL6rITcPZbv9QCFELte2MJWIuIOFx0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=iY8Nabmx+ZnxB1/GwCRVXhik+zCKa58ZT6nJGxrzvW3brI0xgTyaqDAUTyWLDWDEs\n\tzSI8hPGcrGheR3GPGLQal9X6aldTLZvpkD9cBGh6ELYj4lKQNZ/1/WD/dYFM2JKbbV\n\tTcMeEk4vkJuEOw7VqdzPvlUr9VDaPrgG+F7RLpVA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241115101334.453104-10-dan.scally@ideasonboard.com>","References":"<20241115101334.453104-1-dan.scally@ideasonboard.com>\n\t<20241115101334.453104-10-dan.scally@ideasonboard.com>","Subject":"Re: [PATCH v6 09/14] libcamera: bayer_format: Add 20-bit bayer\n\tformats","From":"Kieran Bingham ","Cc":"Anthony.McGivern@arm.com, Daniel Scally ","To":"Daniel Scally ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 15 Nov 2024 12:24:13 +0000","Message-ID":"<173167345344.4187655.8752564209584239056@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]