{"id":21900,"url":"https://patchwork.libcamera.org/api/patches/21900/?format=json","web_url":"https://patchwork.libcamera.org/patch/21900/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241115074628.417215-5-dan.scally@ideasonboard.com>","date":"2024-11-15T07:46:26","name":"[v3,4/6] ipa: rpi: Use centralised libipa helpers","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"70431113bedf3f74ce127c52f4d3a1d85220a0f2","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21900/mbox/","series":[{"id":4792,"url":"https://patchwork.libcamera.org/api/series/4792/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4792","date":"2024-11-15T07:46:22","name":"Centralise common functions in IPA modules","version":3,"mbox":"https://patchwork.libcamera.org/series/4792/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21900/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21900/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C929C32CE\n\tfor ;\n\tFri, 15 Nov 2024 07:46:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 51D0165873;\n\tFri, 15 Nov 2024 08:46:55 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E29C6585F\n\tfor ;\n\tFri, 15 Nov 2024 08:46:49 +0100 (CET)","from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3BF8C1114;\n\tFri, 15 Nov 2024 08:46:34 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IIg0UbqG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731656794;\n\tbh=lcrlNkc6CH1nbUiNUpE3DSZJPddES9HIFWoJs45Fifk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=IIg0UbqG41RmfD6k4zpsmay9OhQ+hdmNnJsPm9t+ecmSvMwDQN5Xvq20RVDJgWnKI\n\tYmyJc24ZESKwH8gpsqcVU1WqWeIvLMcIGlzTvgZ8Fx6FoG3hlXhG7MdRtug0FAvhbf\n\tYumQNOBW3NipJdpaVvhhgMR+sh6B8kiNmOMTTUDc=","From":"Daniel Scally ","To":"libcamera-devel@lists.libcamera.org","Cc":"mike.rudenko@gmail.com,\n\tDaniel Scally ","Subject":"[PATCH v3 4/6] ipa: rpi: Use centralised libipa helpers","Date":"Fri, 15 Nov 2024 07:46:26 +0000","Message-Id":"<20241115074628.417215-5-dan.scally@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20241115074628.417215-1-dan.scally@ideasonboard.com>","References":"<20241115074628.417215-1-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use the centralised libipa helpers rather than open coding common\nfunctions.\n\nSigned-off-by: Daniel Scally \n---\nChanges in v3:\n\n\t- None\n\nChanges in v2:\n\n\t- None. Jacopo; this isn't in the libcamera::ipa namespace. As an\n\t alternative to the prefix I could \"using namespace libcamera::ipa\" if\n\t that's better?\n\n src/ipa/rpi/controller/rpi/agc_channel.cpp | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)","diff":"diff --git a/src/ipa/rpi/controller/rpi/agc_channel.cpp b/src/ipa/rpi/controller/rpi/agc_channel.cpp\nindex c9df9b5b..8583f4f3 100644\n--- a/src/ipa/rpi/controller/rpi/agc_channel.cpp\n+++ b/src/ipa/rpi/controller/rpi/agc_channel.cpp\n@@ -12,6 +12,8 @@\n \n #include \n \n+#include \"libipa/colours.h\"\n+\n #include \"../awb_status.h\"\n #include \"../device_status.h\"\n #include \"../histogram.h\"\n@@ -694,11 +696,11 @@ static double computeInitialY(StatisticsPtr &stats, AwbStatus const &awb,\n \tdouble ySum;\n \t/* Factor in the AWB correction if needed. */\n \tif (stats->agcStatsPos == Statistics::AgcStatsPos::PreWb) {\n-\t\tySum = rSum * awb.gainR * .299 +\n-\t\t gSum * awb.gainG * .587 +\n-\t\t bSum * awb.gainB * .114;\n+\t\tySum = ipa::rec601LuminanceFromRGB(rSum * awb.gainR,\n+\t\t\t\t\t\t gSum * awb.gainG,\n+\t\t\t\t\t\t bSum * awb.gainB);\n \t} else\n-\t\tySum = rSum * .299 + gSum * .587 + bSum * .114;\n+\t\tySum = ipa::rec601LuminanceFromRGB(rSum, gSum, bSum);\n \n \treturn ySum / pixelSum / (1 << 16);\n }\n","prefixes":["v3","4/6"]}