[{"id":32181,"web_url":"https://patchwork.libcamera.org/comment/32181/","msgid":"<173167193691.4187655.3461377744688717786@ping.linuxembedded.co.uk>","date":"2024-11-15T11:58:56","subject":"Re: [PATCH v3 3/6] ipa: rkisp1: Use centralised libipa helpers","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Daniel Scally (2024-11-15 07:46:25)\n> Use the centralised libipa helpers instead of open-coding common\n> functions.\n> \n> Reviewed-by: Jacopo Mondi \n> Signed-off-by: Daniel Scally \n> ---\n> Changes in v3:\n> \n> - None\n> \n> Changes in v2:\n> \n> - Dropped the ipa:: prefix for function calls\n> \n> src/ipa/rkisp1/algorithms/awb.cpp | 18 ++----------------\n> src/ipa/rkisp1/algorithms/awb.h | 2 --\n> 2 files changed, 2 insertions(+), 18 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index b3c00bef..5c1d9511 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -16,6 +16,8 @@\n> \n> #include \n> \n> +#include \"libipa/colours.h\"\n> +\n\n\nReviewed-by: Kieran Bingham \n\n> /**\n> * \\file awb.h\n> */\n> @@ -178,22 +180,6 @@ void Awb::prepare(IPAContext &context, const uint32_t frame,\n> }\n> }\n> \n> -uint32_t Awb::estimateCCT(double red, double green, double blue)\n> -{\n> - /* Convert the RGB values to CIE tristimulus values (XYZ) */\n> - double X = (-0.14282) * (red) + (1.54924) * (green) + (-0.95641) * (blue);\n> - double Y = (-0.32466) * (red) + (1.57837) * (green) + (-0.73191) * (blue);\n> - double Z = (-0.68202) * (red) + (0.77073) * (green) + (0.56332) * (blue);\n> -\n> - /* Calculate the normalized chromaticity values */\n> - double x = X / (X + Y + Z);\n> - double y = Y / (X + Y + Z);\n> -\n> - /* Calculate CCT */\n> - double n = (x - 0.3320) / (0.1858 - y);\n> - return 449 * n * n * n + 3525 * n * n + 6823.3 * n + 5520.33;\n> -}\n> -\n> /**\n> * \\copydoc libcamera::ipa::Algorithm::process\n> */\n> diff --git a/src/ipa/rkisp1/algorithms/awb.h b/src/ipa/rkisp1/algorithms/awb.h\n> index b3b2c0bb..6ac3a5c3 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.h\n> +++ b/src/ipa/rkisp1/algorithms/awb.h\n> @@ -32,8 +32,6 @@ public:\n> ControlList &metadata) override;\n> \n> private:\n> - uint32_t estimateCCT(double red, double green, double blue);\n> -\n> bool rgbMode_;\n> };\n> \n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C6CE2C0F1B\n\tfor ;\n\tFri, 15 Nov 2024 11:59:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D6B06587B;\n\tFri, 15 Nov 2024 12:59:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC23B6580A\n\tfor ;\n\tFri, 15 Nov 2024 12:58:59 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 091BC496;\n\tFri, 15 Nov 2024 12:58:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DUPbbAhx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731671925;\n\tbh=0FpfwCEp7MQFs71IPq5mdQL9Rlwln/gf4NETyeIT6JU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=DUPbbAhxjZlFX1sqO/WrfCnez9a4EY5MxGCQt4GXmEWlZxLuH2TOnBdO8XiGsWP65\n\t1r5q1wKlcSLgulvdplVx5rCUzlDyeuhByR9DYmGHp91GKG2C5C5a/i+FKk9T/HKuwK\n\tLTZYSnGZY5WeF2G7Z91Tl1WcCC/u7K323vdG8VJw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241115074628.417215-4-dan.scally@ideasonboard.com>","References":"<20241115074628.417215-1-dan.scally@ideasonboard.com>\n\t<20241115074628.417215-4-dan.scally@ideasonboard.com>","Subject":"Re: [PATCH v3 3/6] ipa: rkisp1: Use centralised libipa helpers","From":"Kieran Bingham ","Cc":"mike.rudenko@gmail.com, Daniel Scally ,\n\tJacopo Mondi ","To":"Daniel Scally ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 15 Nov 2024 11:58:56 +0000","Message-ID":"<173167193691.4187655.3461377744688717786@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32197,"web_url":"https://patchwork.libcamera.org/comment/32197/","msgid":"<87cyiwlhsx.fsf@redhat.com>","date":"2024-11-15T13:58:54","subject":"Re: [PATCH v3 3/6] ipa: rkisp1: Use centralised libipa helpers","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Daniel Scally writes:\n\n> Use the centralised libipa helpers instead of open-coding common\n> functions.\n>\n> Reviewed-by: Jacopo Mondi \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Milan Zamazal \n\n> ---\n> Changes in v3:\n>\n> \t- None\n>\n> Changes in v2:\n>\n> \t- Dropped the ipa:: prefix for function calls\n>\n> src/ipa/rkisp1/algorithms/awb.cpp | 18 ++----------------\n> src/ipa/rkisp1/algorithms/awb.h | 2 --\n> 2 files changed, 2 insertions(+), 18 deletions(-)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index b3c00bef..5c1d9511 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -16,6 +16,8 @@\n> \n> #include \n> \n> +#include \"libipa/colours.h\"\n> +\n> /**\n> * \\file awb.h\n> */\n> @@ -178,22 +180,6 @@ void Awb::prepare(IPAContext &context, const uint32_t frame,\n> \t}\n> }\n> \n> -uint32_t Awb::estimateCCT(double red, double green, double blue)\n> -{\n> -\t/* Convert the RGB values to CIE tristimulus values (XYZ) */\n> -\tdouble X = (-0.14282) * (red) + (1.54924) * (green) + (-0.95641) * (blue);\n> -\tdouble Y = (-0.32466) * (red) + (1.57837) * (green) + (-0.73191) * (blue);\n> -\tdouble Z = (-0.68202) * (red) + (0.77073) * (green) + (0.56332) * (blue);\n> -\n> -\t/* Calculate the normalized chromaticity values */\n> -\tdouble x = X / (X + Y + Z);\n> -\tdouble y = Y / (X + Y + Z);\n> -\n> -\t/* Calculate CCT */\n> -\tdouble n = (x - 0.3320) / (0.1858 - y);\n> -\treturn 449 * n * n * n + 3525 * n * n + 6823.3 * n + 5520.33;\n> -}\n> -\n> /**\n> * \\copydoc libcamera::ipa::Algorithm::process\n> */\n> diff --git a/src/ipa/rkisp1/algorithms/awb.h b/src/ipa/rkisp1/algorithms/awb.h\n> index b3b2c0bb..6ac3a5c3 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.h\n> +++ b/src/ipa/rkisp1/algorithms/awb.h\n> @@ -32,8 +32,6 @@ public:\n> \t\t ControlList &metadata) override;\n> \n> private:\n> -\tuint32_t estimateCCT(double red, double green, double blue);\n> -\n> \tbool rgbMode_;\n> };","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B10F7C3257\n\tfor ;\n\tFri, 15 Nov 2024 13:59:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 45AB16589D;\n\tFri, 15 Nov 2024 14:59:01 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2459865892\n\tfor ;\n\tFri, 15 Nov 2024 14:59:00 +0100 (CET)","from mail-wm1-f70.google.com (mail-wm1-f70.google.com\n\t[209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-520-V4qKI6HhP2itx3jFcOuAtQ-1; Fri, 15 Nov 2024 08:58:58 -0500","by mail-wm1-f70.google.com with SMTP id\n\t5b1f17b1804b1-43152cd2843so11913045e9.3\n\tfor ;\n\tFri, 15 Nov 2024 05:58:57 -0800 (PST)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-432dab80582sm55041075e9.19.2024.11.15.05.58.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 15 Nov 2024 05:58:55 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"dI0GUNxg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1731679139;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=viDVH0txVqAMWBQiW2XdpfJ2LFlNmZJO17GJ7m8U+Nw=;\n\tb=dI0GUNxgYLOwnh8HYvjAnVfUY2fINGP6u1y15giclGlGHgv6NaZykLC8lOakwKiV+YQ/d8\n\t19K1MqzEPJs01NfpafS6/6Md9yrLsZWCm/pRt9IiDOlsHYr+u+H1ibh7eGhBR9Ufp+VwgH\n\t1WrPBf+4Fo9M81zeZ4st2ODU9HqpImo=","X-MC-Unique":"V4qKI6HhP2itx3jFcOuAtQ-1","X-Mimecast-MFC-AGG-ID":"V4qKI6HhP2itx3jFcOuAtQ","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1731679137; x=1732283937;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=viDVH0txVqAMWBQiW2XdpfJ2LFlNmZJO17GJ7m8U+Nw=;\n\tb=uqLfr38weKbDio+l8S6mF4N2uUdNqGLQ5m1kAOjEAWJa1Mg/AUFwpPKs+zO8YoYyXM\n\tRolw7JlRTnzwkeaD6jIql1otq5X7ocR0A9OCLVPGelvOyXL3EBQD3ramM4wVJQscCCXC\n\tOPqr4QiaErvlftFql+Lpi7sy0ULJL1S71DIRgGe8JQwPLGvjDDDVw2osRMoTYBb+t3eH\n\tAfNiEWueECeKzRnf8/c1vOn0qOMSvGBDBAg38B/zwgIOo9azUR7rWXucmrUpzNRRCq4e\n\t0xsAtw/y3t2wpcoJzLVIm5ccHejCnDaMvEgbqvDHizoEa9EU1u4iJLy8dHETrV1YYhtH\n\tUR1A==","X-Gm-Message-State":"AOJu0YziALZpjQgcR9WQgV0ozFbV9PxH/dRY7t8CpZLab2g5YDyVdvqb\n\t0aYfMaFsqyH8lE3W1WmY2DB/xkMDEFsnohBm9rXXimKXjBAKs9VoZGFDTeHsDjp4PEvYLPiF0ih\n\tGjzH3P5fX/pUrqCrOnqOy7nhbzwDlmhYXC2bPfz7OWyR+5QpBb6OndgUikRVJjRVompvDiaI=","X-Received":["by 2002:a05:600c:35c8:b0:430:57f2:bae2 with SMTP id\n\t5b1f17b1804b1-432df791f62mr19181565e9.23.1731679136800; \n\tFri, 15 Nov 2024 05:58:56 -0800 (PST)","by 2002:a05:600c:35c8:b0:430:57f2:bae2 with SMTP id\n\t5b1f17b1804b1-432df791f62mr19181435e9.23.1731679136465; \n\tFri, 15 Nov 2024 05:58:56 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IEm9lEhPJdag0GbYUbUDT2GFFqC7oIA5VE9djDy6mGs07RZVNJMlNN25RMhzSBIbg3ObnOdgw==","From":"Milan Zamazal ","To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org, mike.rudenko@gmail.com, Jacopo\n\tMondi ","Subject":"Re: [PATCH v3 3/6] ipa: rkisp1: Use centralised libipa helpers","In-Reply-To":"<20241115074628.417215-4-dan.scally@ideasonboard.com> (Daniel\n\tScally's message of \"Fri, 15 Nov 2024 07:46:25 +0000\")","References":"<20241115074628.417215-1-dan.scally@ideasonboard.com>\n\t<20241115074628.417215-4-dan.scally@ideasonboard.com>","Date":"Fri, 15 Nov 2024 14:58:54 +0100","Message-ID":"<87cyiwlhsx.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"3KfxwM-tww1C-vY5qV5mjUCj0ArtnV6rTTyfLDFNOxU_1731679137","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32205,"web_url":"https://patchwork.libcamera.org/comment/32205/","msgid":"<20241118004942.GG30787@pendragon.ideasonboard.com>","date":"2024-11-18T00:49:42","subject":"Re: [PATCH v3 3/6] ipa: rkisp1: Use centralised libipa helpers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dan,\n\nThank you for the patch.\n\nOn Fri, Nov 15, 2024 at 07:46:25AM +0000, Daniel Scally wrote:\n> Use the centralised libipa helpers instead of open-coding common\n> functions.\n> \n> Reviewed-by: Jacopo Mondi \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Changes in v3:\n> \n> \t- None\n> \n> Changes in v2:\n> \n> \t- Dropped the ipa:: prefix for function calls\n> \n> src/ipa/rkisp1/algorithms/awb.cpp | 18 ++----------------\n> src/ipa/rkisp1/algorithms/awb.h | 2 --\n> 2 files changed, 2 insertions(+), 18 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index b3c00bef..5c1d9511 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -16,6 +16,8 @@\n> \n> #include \n> \n> +#include \"libipa/colours.h\"\n> +\n> /**\n> * \\file awb.h\n> */\n> @@ -178,22 +180,6 @@ void Awb::prepare(IPAContext &context, const uint32_t frame,\n> \t}\n> }\n> \n> -uint32_t Awb::estimateCCT(double red, double green, double blue)\n> -{\n> -\t/* Convert the RGB values to CIE tristimulus values (XYZ) */\n> -\tdouble X = (-0.14282) * (red) + (1.54924) * (green) + (-0.95641) * (blue);\n> -\tdouble Y = (-0.32466) * (red) + (1.57837) * (green) + (-0.73191) * (blue);\n> -\tdouble Z = (-0.68202) * (red) + (0.77073) * (green) + (0.56332) * (blue);\n> -\n> -\t/* Calculate the normalized chromaticity values */\n> -\tdouble x = X / (X + Y + Z);\n> -\tdouble y = Y / (X + Y + Z);\n> -\n> -\t/* Calculate CCT */\n> -\tdouble n = (x - 0.3320) / (0.1858 - y);\n> -\treturn 449 * n * n * n + 3525 * n * n + 6823.3 * n + 5520.33;\n> -}\n> -\n> /**\n> * \\copydoc libcamera::ipa::Algorithm::process\n> */\n> diff --git a/src/ipa/rkisp1/algorithms/awb.h b/src/ipa/rkisp1/algorithms/awb.h\n> index b3b2c0bb..6ac3a5c3 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.h\n> +++ b/src/ipa/rkisp1/algorithms/awb.h\n> @@ -32,8 +32,6 @@ public:\n> \t\t ControlList &metadata) override;\n> \n> private:\n> -\tuint32_t estimateCCT(double red, double green, double blue);\n> -\n> \tbool rgbMode_;\n> };\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 492C0C32E0\n\tfor ;\n\tMon, 18 Nov 2024 00:49:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ED046658B6;\n\tMon, 18 Nov 2024 01:49:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B85F1600F2\n\tfor ;\n\tMon, 18 Nov 2024 01:49:51 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4FECE75A;\n\tMon, 18 Nov 2024 01:49:35 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YRLfysr3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731890975;\n\tbh=7Yfa3/Ml0f9B1kkVGU5wkGuqdKnndmroHvO3rD4IVUg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YRLfysr3z7Q/SxkDpK3T1Cij44wdMYP0v/QD/Beh8Lko0g/GAfjbsSC8+QianG2HU\n\tdtYQp+2mqhlLUKrqHpT0OeGe79ehZdQa6Ga2RGxbIss1G2SkknAyDK+gXJgqc1ftGk\n\tu1tfGs9pFouuHOII3AD77ub+dypcCD3G2nyeKxDM=","Date":"Mon, 18 Nov 2024 02:49:42 +0200","From":"Laurent Pinchart ","To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org, mike.rudenko@gmail.com,\n\tJacopo Mondi ","Subject":"Re: [PATCH v3 3/6] ipa: rkisp1: Use centralised libipa helpers","Message-ID":"<20241118004942.GG30787@pendragon.ideasonboard.com>","References":"<20241115074628.417215-1-dan.scally@ideasonboard.com>\n\t<20241115074628.417215-4-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241115074628.417215-4-dan.scally@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]