[{"id":32162,"web_url":"https://patchwork.libcamera.org/comment/32162/","msgid":"","date":"2024-11-14T09:00:10","subject":"Re: [PATCH 2/4] libcamera: libipa: camera_sensor: Add Sony IMX327\n\tcam helper","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Geoffrey\n\nOn Wed, Nov 13, 2024 at 11:35:55PM +0100, Geoffrey Van Landeghem wrote:\n> Signed-off-by: Geoffrey Van Landeghem \n> ---\n> src/ipa/rpi/cam_helper/cam_helper_imx290.cpp | 1 +\n\nWhy this has not been added to\nsrc/ipa/libipa/camera_sensor_helpers.cpp and\nsrc/libcamera/sensor/camera_sensor_properties.cpp ?\n\n\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> index 0cc24a6d..3b87751e 100644\n> --- a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> +++ b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> @@ -73,4 +73,5 @@ static CamHelper *create()\n> }\n>\n> static RegisterCamHelper reg(\"imx290\", &create);\n> +static RegisterCamHelper reg327(\"imx327\", &create);\n> static RegisterCamHelper reg462(\"imx462\", &create);\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 43E5BC324C\n\tfor ;\n\tThu, 14 Nov 2024 09:00:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CF92365835;\n\tThu, 14 Nov 2024 10:00:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 32AAF657DA\n\tfor ;\n\tThu, 14 Nov 2024 10:00:14 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2001:b07:6462:5de2:459e:1ee6:26ea:2d31])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 577B4827;\n\tThu, 14 Nov 2024 10:00:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hVNMuIVp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731574800;\n\tbh=mz84b4GACQ/AkNxq0LaPfK8mstzqaDREDm/fQdHI7tE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hVNMuIVpIiML97ZKo6w8RBCvEfdrlL0adKzYgNDEqXcu9KtcZSPEfSl1VOAeh+n12\n\tomr+wdNNpRI920kwF5CcLbjTVhZVO0C5DRz/nRwetP89aTiZ7PDIR1H+UKPD5/UzJs\n\tega2wcF/qPMLwkboCZc8cRBTa8iMvRCbjrgyFf/s=","Date":"Thu, 14 Nov 2024 10:00:10 +0100","From":"Jacopo Mondi ","To":"Geoffrey Van Landeghem ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/4] libcamera: libipa: camera_sensor: Add Sony IMX327\n\tcam helper","Message-ID":"","References":"<20241113223556.413637-2-geoffrey.vl@gmail.com>\n\t<20241113223556.413637-3-geoffrey.vl@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241113223556.413637-3-geoffrey.vl@gmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32170,"web_url":"https://patchwork.libcamera.org/comment/32170/","msgid":"","date":"2024-11-14T11:37:35","subject":"Re: [PATCH 2/4] libcamera: libipa: camera_sensor: Add Sony IMX327\n\tcam helper","submitter":{"id":27,"url":"https://patchwork.libcamera.org/api/people/27/","name":"Dave Stevenson","email":"dave.stevenson@raspberrypi.com"},"content":"Hi Jacopo\n\nOn Thu, 14 Nov 2024 at 09:00, Jacopo Mondi\n wrote:\n>\n> Hi Geoffrey\n>\n> On Wed, Nov 13, 2024 at 11:35:55PM +0100, Geoffrey Van Landeghem wrote:\n> > Signed-off-by: Geoffrey Van Landeghem \n> > ---\n> > src/ipa/rpi/cam_helper/cam_helper_imx290.cpp | 1 +\n>\n> Why this has not been added to\n> src/ipa/libipa/camera_sensor_helpers.cpp and\n> src/libcamera/sensor/camera_sensor_properties.cpp ?\n\nBecause it's already there\nhttps://git.linuxtv.org/libcamera.git/tree/src/ipa/libipa/camera_sensor_helper.cpp#n596\nhttps://git.linuxtv.org/libcamera.git/tree/src/libcamera/sensor/camera_sensor_properties.cpp#n133\n\n Dave\n\n>\n>\n> > 1 file changed, 1 insertion(+)\n> >\n> > diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > index 0cc24a6d..3b87751e 100644\n> > --- a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > +++ b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > @@ -73,4 +73,5 @@ static CamHelper *create()\n> > }\n> >\n> > static RegisterCamHelper reg(\"imx290\", &create);\n> > +static RegisterCamHelper reg327(\"imx327\", &create);\n> > static RegisterCamHelper reg462(\"imx462\", &create);\n> > --\n> > 2.43.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93FDEC0F1B\n\tfor ;\n\tThu, 14 Nov 2024 11:37:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B128565844;\n\tThu, 14 Nov 2024 12:37:57 +0100 (CET)","from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com\n\t[IPv6:2607:f8b0:4864:20::b32])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 58C17657E0\n\tfor ;\n\tThu, 14 Nov 2024 12:37:55 +0100 (CET)","by mail-yb1-xb32.google.com with SMTP id\n\t3f1490d57ef6-e381ad63143so281702276.3\n\tfor ;\n\tThu, 14 Nov 2024 03:37:55 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"sPeBtsHd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1731584274; x=1732189074;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=xHXxqt9rJvy3tdFHbdKmdxB4QxgifqP/l0iRKoKny08=;\n\tb=sPeBtsHd20Hg6Stjb0EyrfP+WMnQnnOLsIXVMzIKYihhZZeaGsea4HDroWSUE/SpIW\n\tGtBd29cGPK4cK0I/jtoHzrM+dodc78iLRBIt4pHU0k8XtNWfdAhSFZkkPbbcKooTLqY6\n\tX5qddm7ifeVdNen2Ar0S793R5M53Afes/uUE0qPRa4Rexlz+A7cM/KzvWzFIY6VCdJpt\n\txewgVhfsnO0vzzxy8sIXzJepj013oRKFwPiZLxnHgO8mx5VuqTQijRFZjSFM9jKQZ61k\n\tXZTQTXGhldzEAFEkm1UTic1OCbTvZ+PAqhMcfBR7nhY8AE+5v/76MmKfH8zkM/cpOT3W\n\t72uA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1731584274; x=1732189074;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=xHXxqt9rJvy3tdFHbdKmdxB4QxgifqP/l0iRKoKny08=;\n\tb=CjT49bJEAZc22NN13vAST9y/ZC4ejd/9QjZZ/hS7v+dHXQ3TMeL5GD6e97iQR/LWZh\n\tE3tuJEUjkubRVIF6Elcmg36rcGaCrerYHkMe+/u1fYOoTaY9CyD3aN82u6tLSWa4+GhQ\n\tbPFiz1wbAPF/cdGgtKM9BNJwRKgoI9EV0FwN7EFTp1hNdUTbFQ6ImiFV1lO1SD9GWEq8\n\tKeI3akBIGHRkMIj//MmIUTdsCaz6b5hQn6zaUKhtOL6YCKLlPHPbHZsVbyRzfY3/iNmv\n\t1OiBXsTJBWnFHNb7upAUKIAgQjvpNBVmM0C+YjXdx2eLu2WY2Jf1HrkBE281fOtHMgSc\n\tsLdQ==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCXvOReRA4aioVSGpWmS6WacktUtXF3FtON9gwr50+mWVGUIEj2bGnYMKrM7eND566Z9xk7dC241jVpTZmnP+HM=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YwMdRxNYsAcILab+7qDqnDE0+iWJCeVQYAiibPWrXEUJLiUc48K\n\taxEs5Hncq/GXNI/JUK7CEI9nR9JFNqxFyeV4VvLQCNSyvt81aznUS2gKW3jLFf4m1V4znRvobUp\n\tXZcW+c5Ibfo7/lHSM1Gvsd/HZ8Y+5GqXcUrc/5A==","X-Google-Smtp-Source":"AGHT+IFkvt7UL34grSOgDTV85fSryOUZIxlHGeeqvTDhqzGj2E0ki097k/JPKSqbraMODPz0aRp9O2vlNigauYtdkU0=","X-Received":"by 2002:a05:6902:1509:b0:e2b:d75b:7630 with SMTP id\n\t3f1490d57ef6-e35ed2576d3mr6331787276.35.1731584274136;\n\tThu, 14 Nov 2024 03:37:54 -0800 (PST)","MIME-Version":"1.0","References":"<20241113223556.413637-2-geoffrey.vl@gmail.com>\n\t<20241113223556.413637-3-geoffrey.vl@gmail.com>\n\t","In-Reply-To":"","From":"Dave Stevenson ","Date":"Thu, 14 Nov 2024 11:37:35 +0000","Message-ID":"","Subject":"Re: [PATCH 2/4] libcamera: libipa: camera_sensor: Add Sony IMX327\n\tcam helper","To":"Jacopo Mondi ","Cc":"Geoffrey Van Landeghem ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32177,"web_url":"https://patchwork.libcamera.org/comment/32177/","msgid":"<20241115003316.GO26171@pendragon.ideasonboard.com>","date":"2024-11-15T00:33:16","subject":"Re: [PATCH 2/4] libcamera: libipa: camera_sensor: Add Sony IMX327\n\tcam helper","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Nov 14, 2024 at 11:37:35AM +0000, Dave Stevenson wrote:\n> On Thu, 14 Nov 2024 at 09:00, Jacopo Mondi wrote:\n> > On Wed, Nov 13, 2024 at 11:35:55PM +0100, Geoffrey Van Landeghem wrote:\n> > > Signed-off-by: Geoffrey Van Landeghem \n> > > ---\n> > > src/ipa/rpi/cam_helper/cam_helper_imx290.cpp | 1 +\n> >\n> > Why this has not been added to\n> > src/ipa/libipa/camera_sensor_helpers.cpp and\n> > src/libcamera/sensor/camera_sensor_properties.cpp ?\n> \n> Because it's already there\n> https://git.linuxtv.org/libcamera.git/tree/src/ipa/libipa/camera_sensor_helper.cpp#n596\n> https://git.linuxtv.org/libcamera.git/tree/src/libcamera/sensor/camera_sensor_properties.cpp#n133\n\nimx327 is, but imx462 is missing. Geoffrey, could you please add the\nimx462 to the above files in the next version of this patch series ?\n\n> > > 1 file changed, 1 insertion(+)\n> > >\n> > > diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > > index 0cc24a6d..3b87751e 100644\n> > > --- a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > > +++ b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > > @@ -73,4 +73,5 @@ static CamHelper *create()\n> > > }\n> > >\n> > > static RegisterCamHelper reg(\"imx290\", &create);\n> > > +static RegisterCamHelper reg327(\"imx327\", &create);\n> > > static RegisterCamHelper reg462(\"imx462\", &create);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E37FC324C\n\tfor ;\n\tFri, 15 Nov 2024 00:33:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 72F366585F;\n\tFri, 15 Nov 2024 01:33:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A090F6581C\n\tfor ;\n\tFri, 15 Nov 2024 01:33:25 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 06A2F502;\n\tFri, 15 Nov 2024 01:33:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rEQFc01B\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731630791;\n\tbh=axL6kErPCoNlI4ZhIztyGN3VS5X+XG5/G3lsPhwmW+c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rEQFc01BOi1P7efCpfWfJeb8R58gAg+cGBVUGvX6TXFB2Ls9stl8OHcqi4sRTVQeo\n\tMBaCGV5GtGlNUJPf9vNbsJU8JlsnOs0QbBEqCFc0CPE9a6u8zEDjLSznshokK1tEZn\n\tqrliMLFOreGQt6vcO/aokW2wLrISVOXE0VzBxhx8=","Date":"Fri, 15 Nov 2024 02:33:16 +0200","From":"Laurent Pinchart ","To":"Dave Stevenson ","Cc":"Jacopo Mondi ,\n\tGeoffrey Van Landeghem ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/4] libcamera: libipa: camera_sensor: Add Sony IMX327\n\tcam helper","Message-ID":"<20241115003316.GO26171@pendragon.ideasonboard.com>","References":"<20241113223556.413637-2-geoffrey.vl@gmail.com>\n\t<20241113223556.413637-3-geoffrey.vl@gmail.com>\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32178,"web_url":"https://patchwork.libcamera.org/comment/32178/","msgid":"","date":"2024-11-15T07:51:15","subject":"Re: [PATCH 2/4] libcamera: libipa: camera_sensor: Add Sony IMX327\n\tcam helper","submitter":{"id":214,"url":"https://patchwork.libcamera.org/api/people/214/","name":"Geoffrey Van Landeghem","email":"geoffrey.vl@gmail.com"},"content":"Hi Laurent, not sure if I follow here but that's what I did in patch 1/4.\nSee https://lists.libcamera.org/pipermail/libcamera-devel/2024-November/046559.html.\n\nOr do you mean I should squash patch 2/4 into 1/4?\n\nKind regards,\nGeoffrey Van Landeghem\n\nOp vr 15 nov 2024 om 01:33 schreef Laurent Pinchart\n:\n>\n> On Thu, Nov 14, 2024 at 11:37:35AM +0000, Dave Stevenson wrote:\n> > On Thu, 14 Nov 2024 at 09:00, Jacopo Mondi wrote:\n> > > On Wed, Nov 13, 2024 at 11:35:55PM +0100, Geoffrey Van Landeghem wrote:\n> > > > Signed-off-by: Geoffrey Van Landeghem \n> > > > ---\n> > > > src/ipa/rpi/cam_helper/cam_helper_imx290.cpp | 1 +\n> > >\n> > > Why this has not been added to\n> > > src/ipa/libipa/camera_sensor_helpers.cpp and\n> > > src/libcamera/sensor/camera_sensor_properties.cpp ?\n> >\n> > Because it's already there\n> > https://git.linuxtv.org/libcamera.git/tree/src/ipa/libipa/camera_sensor_helper.cpp#n596\n> > https://git.linuxtv.org/libcamera.git/tree/src/libcamera/sensor/camera_sensor_properties.cpp#n133\n>\n> imx327 is, but imx462 is missing. Geoffrey, could you please add the\n> imx462 to the above files in the next version of this patch series ?\n>\n> > > > 1 file changed, 1 insertion(+)\n> > > >\n> > > > diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > > > index 0cc24a6d..3b87751e 100644\n> > > > --- a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > > > +++ b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > > > @@ -73,4 +73,5 @@ static CamHelper *create()\n> > > > }\n> > > >\n> > > > static RegisterCamHelper reg(\"imx290\", &create);\n> > > > +static RegisterCamHelper reg327(\"imx327\", &create);\n> > > > static RegisterCamHelper reg462(\"imx462\", &create);\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 14B32C324C\n\tfor ;\n\tFri, 15 Nov 2024 07:51:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5300165869;\n\tFri, 15 Nov 2024 08:51:31 +0100 (CET)","from mail-ed1-x531.google.com (mail-ed1-x531.google.com\n\t[IPv6:2a00:1450:4864:20::531])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A9EB618BB\n\tfor ;\n\tFri, 15 Nov 2024 08:51:29 +0100 (CET)","by mail-ed1-x531.google.com with SMTP id\n\t4fb4d7f45d1cf-5cef772621eso541720a12.3\n\tfor ;\n\tThu, 14 Nov 2024 23:51:29 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"XxZ43iyJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1731657089; x=1732261889;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=ILjOY/ctP4llh08Wz+15Klj1QRtsh7tqKiVFoxg8o0Y=;\n\tb=XxZ43iyJgKZ1XeoeH13WX4GLMS/dRZ20HSgs0JsOBzFot96oTTlPlvgZ+994/JfV5z\n\tTsBD3k/WGjobZhShJ+P8XAt0+Hwukf3Xnoh7gESZ66hzx7dGV4sElqzhMetiosGGtdXP\n\txiM5YEwrg35+KJrOZYX+dvPvNpnenqS60wF85AINk7SFn2C9mpK80BhLGlUB7F3ts7WK\n\tUPSXVuuR4Gysli1xZtllYeWBERpBGHBsHj5VGAoHSW52iM2JHZbcnsGRkHF1+LAZufkQ\n\t2hKHiChBXsiuiY3B3xTOI+mvv14dSq2JKICAdP1kCyXnu4UoGdOlDitw2YNuUIS3c4E6\n\tPt7A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1731657089; x=1732261889;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=ILjOY/ctP4llh08Wz+15Klj1QRtsh7tqKiVFoxg8o0Y=;\n\tb=I0HweDSj/JUiXaig59P8B5dMrtWGE/5DKg+jhujurjfKlTAR6JcZG26Qkw3r0sca2w\n\t9CWk2yuiljEMyb0Q+FRZfrkYr5jDnMvNQ+nASQ3EynXjsY127W1CTKRKa5CVfATDRjT7\n\tfDW8LU69tns5P0yFF3dkm4cRed5KjE+xwHloHhLOLwYBntlHkKJaL9jaLp7z6vs5mT+v\n\tvpoqtlb5+TUbL7m5QnRq9CaeUj6N8+FIBfv1uIYuyncQF8aU0zmhTyVcRYWrY3C0BdYw\n\tChYztM7Gzy18xeRYONZZynTE8S1xHJec7wZg8xtRYC6967fSf9cF4N8pxdASiX545eV4\n\tKqfw==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCX/0CU7X7ny1gSUu1U4d6BEShYA+O/GEdrYIRkbnH2WjCFpFzw6D9CbTsjnSMGHC8j6QqOjoa5o0xFdExGC88c=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YwS/OE464bfVg+E6KD3Wa+DiumES8pWdNa3frlCcuWfCAXNI68k\n\t/Lc7krX5jNNQ8UZuJWblcgqGQiHy1zNe8IzOpDBg+HU3VpGcW8DFaaZqeyN/SPQ/lU2bAuLb29E\n\tWAfsArAv/o9phTpapHH/TOplEjFE=","X-Google-Smtp-Source":"AGHT+IFXuMYNff6GbYaJv2JkgJUZNj2yV21rw2ntGdKSXM8WUk+zyudKE8Pp+oZugUVmDp6NgbHue58xBXoJ00M/3pU=","X-Received":"by 2002:a05:6402:430e:b0:5cb:b65d:2b6 with SMTP id\n\t4fb4d7f45d1cf-5cf8fd06852mr1154183a12.32.1731657087174;\n\tThu, 14 Nov 2024 23:51:27 -0800 (PST)","MIME-Version":"1.0","References":"<20241113223556.413637-2-geoffrey.vl@gmail.com>\n\t<20241113223556.413637-3-geoffrey.vl@gmail.com>\n\t\n\t\n\t<20241115003316.GO26171@pendragon.ideasonboard.com>","In-Reply-To":"<20241115003316.GO26171@pendragon.ideasonboard.com>","From":"Geoffrey Van Landeghem ","Date":"Fri, 15 Nov 2024 08:51:15 +0100","Message-ID":"","Subject":"Re: [PATCH 2/4] libcamera: libipa: camera_sensor: Add Sony IMX327\n\tcam helper","To":"Laurent Pinchart ","Cc":"Dave Stevenson , \n\tJacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32190,"web_url":"https://patchwork.libcamera.org/comment/32190/","msgid":"<20241115131504.GA30787@pendragon.ideasonboard.com>","date":"2024-11-15T13:15:04","subject":"Re: [PATCH 2/4] libcamera: libipa: camera_sensor: Add Sony IMX327\n\tcam helper","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Nov 15, 2024 at 08:51:15AM +0100, Geoffrey Van Landeghem wrote:\n> Hi Laurent, not sure if I follow here but that's what I did in patch 1/4.\n> See https://lists.libcamera.org/pipermail/libcamera-devel/2024-November/046559.html.\n\nMy bad, seems I should have started by waking up before replying.\n\n> Or do you mean I should squash patch 2/4 into 1/4?\n\nNo, you've done it right.\n\nBy the way, the title of this patch should be \"ipa: rpi: cam_helper: Add\nSony IMX327\" as it doesn't touch libipa.\n\n> Op vr 15 nov 2024 om 01:33 schreef Laurent Pinchart:\n> > On Thu, Nov 14, 2024 at 11:37:35AM +0000, Dave Stevenson wrote:\n> > > On Thu, 14 Nov 2024 at 09:00, Jacopo Mondi wrote:\n> > > > On Wed, Nov 13, 2024 at 11:35:55PM +0100, Geoffrey Van Landeghem wrote:\n> > > > > Signed-off-by: Geoffrey Van Landeghem \n> > > > > ---\n> > > > > src/ipa/rpi/cam_helper/cam_helper_imx290.cpp | 1 +\n> > > >\n> > > > Why this has not been added to\n> > > > src/ipa/libipa/camera_sensor_helpers.cpp and\n> > > > src/libcamera/sensor/camera_sensor_properties.cpp ?\n> > >\n> > > Because it's already there\n> > > https://git.linuxtv.org/libcamera.git/tree/src/ipa/libipa/camera_sensor_helper.cpp#n596\n> > > https://git.linuxtv.org/libcamera.git/tree/src/libcamera/sensor/camera_sensor_properties.cpp#n133\n> >\n> > imx327 is, but imx462 is missing. Geoffrey, could you please add the\n> > imx462 to the above files in the next version of this patch series ?\n> >\n> > > > > 1 file changed, 1 insertion(+)\n> > > > >\n> > > > > diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > > > > index 0cc24a6d..3b87751e 100644\n> > > > > --- a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > > > > +++ b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > > > > @@ -73,4 +73,5 @@ static CamHelper *create()\n> > > > > }\n> > > > >\n> > > > > static RegisterCamHelper reg(\"imx290\", &create);\n> > > > > +static RegisterCamHelper reg327(\"imx327\", &create);\n> > > > > static RegisterCamHelper reg462(\"imx462\", &create);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 11A8CC0F1B\n\tfor ;\n\tFri, 15 Nov 2024 13:15:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4809A65892;\n\tFri, 15 Nov 2024 14:15:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D77765882\n\tfor ;\n\tFri, 15 Nov 2024 14:15:13 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CDB5E9CE;\n\tFri, 15 Nov 2024 14:14:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"i8M+oLGU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731676498;\n\tbh=vckG889QorPTLbRwxpeY0jgVE6iV8X7pUr803lVP/Hs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=i8M+oLGUqZE65FEcME+vPx2ADQhQNQix2ouAK5mW1Aj61rduM93Bh2acFi1kTuh1A\n\t4D1mhdTSZU809pKv0qNqFkmzbmhtmQRWzrJcHZdd8wHM/cZysDgpEM3yLNlVX7bHUk\n\tbiCS7Xofas+HjV6v6aNpDLY6c0KCV9HZ7E70ifQE=","Date":"Fri, 15 Nov 2024 15:15:04 +0200","From":"Laurent Pinchart ","To":"Geoffrey Van Landeghem ","Cc":"Dave Stevenson ,\n\tJacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/4] libcamera: libipa: camera_sensor: Add Sony IMX327\n\tcam helper","Message-ID":"<20241115131504.GA30787@pendragon.ideasonboard.com>","References":"<20241113223556.413637-2-geoffrey.vl@gmail.com>\n\t<20241113223556.413637-3-geoffrey.vl@gmail.com>\n\t\n\t\n\t<20241115003316.GO26171@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]