[{"id":32161,"web_url":"https://patchwork.libcamera.org/comment/32161/","msgid":"<5ukdeebednnwrmn65p2434ycqyafsizmry7pmv7qszaoi7hyhw@pdfyt5urjjgj>","date":"2024-11-14T08:58:56","subject":"Re: [PATCH 1/4] libcamera: libipa: camera_sensor: Add Sony IMX462\n\tsensor properties","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Geoffrey\n thanks for the patch\n\nOn Wed, Nov 13, 2024 at 11:35:54PM +0100, Geoffrey Van Landeghem wrote:\n> Hi,\n\nHi to you, but this is a commit message and the text in here will\nremain in the git log history. It's nice to be greet when meeting, but\nprobably we don't want this in the commit history :)\n\n> This patch-set comes as part of an ongoing effort to support Sony IMX327 and IMX462 sensors better in the linux kernel.\n> For the kernel following changes are proposed:\n\n\nI suggest to read https://cbea.ms/git-commit/. In example, I would\nhave:\n\nProvide a CameraSensorHelper and CameraSensorProperties for\nthe Sony IMX462 image sensor.\n\nThe sensor is largely compatible with the already supported\nSony IMX290 so we can reuse the same helpers for the analogue\ngain conversion functions.\n\n\n> https://github.com/raspberrypi/linux/pull/5859\n\nDo you plan to send the same patches to linux-media ? We're happy to\ntake in changes before they get merged in mainline linux, but they\nshould be at least posted to the mailing list to have them available\nto everyone.\n\n>\n> After those changes have been applied, the 2 Starvis sensors will no longer be identied by libcamera as a IMX290 and therefore require this patch-set to work correctly.\n\nIf you want to provide context around a set of patches you can write a\ncover letter. Generate it the --cover-letter option to git\nformat-patch and put there the context, while focusing on the single\nchanges in each patch's commit message.\n\nOh, and looking at the other patches, even if trivial, we always\nrequire a commit message for each patch.\n\nThanks\n j\n\n>\n> Signed-off-by: Geoffrey Van Landeghem \n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 5 +++++\n> src/ipa/rpi/cam_helper/cam_helper_imx290.cpp | 1 +\n> src/libcamera/sensor/camera_sensor_properties.cpp | 4 ++++\n> 3 files changed, 10 insertions(+)\n>\n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index c6169bdc..f870dc28 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -622,6 +622,11 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"imx415\", CameraSensorHelperImx415)\n>\n> +class CameraSensorHelperImx462 : public CameraSensorHelperImx290\n> +{\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"imx462\", CameraSensorHelperImx462)\n> +\n> class CameraSensorHelperImx477 : public CameraSensorHelper\n> {\n> public:\n> diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> index e57ab538..0cc24a6d 100644\n> --- a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> +++ b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> @@ -73,3 +73,4 @@ static CamHelper *create()\n> }\n>\n> static RegisterCamHelper reg(\"imx290\", &create);\n> +static RegisterCamHelper reg462(\"imx462\", &create);\n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index 6d4136d0..e2305166 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -142,6 +142,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t.unitCellSize = { 1450, 1450 },\n> \t\t\t.testPatternModes = {},\n> \t\t} },\n> +\t\t{ \"imx462\", {\n> +\t\t\t.unitCellSize = { 2900, 2900 },\n> +\t\t\t.testPatternModes = {},\n> +\t\t} },\n> \t\t{ \"imx477\", {\n> \t\t\t.unitCellSize = { 1550, 1550 },\n> \t\t\t.testPatternModes = {},\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E58C5C0F1B\n\tfor ;\n\tThu, 14 Nov 2024 08:59:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1658F65833;\n\tThu, 14 Nov 2024 09:59:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 041C1657DA\n\tfor ;\n\tThu, 14 Nov 2024 09:59:00 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2001:b07:6462:5de2:459e:1ee6:26ea:2d31])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 15D99827;\n\tThu, 14 Nov 2024 09:58:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZmHvrjac\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731574727;\n\tbh=G3/y895NAWlw3VPxtZNOj/HbFGyExuNk7Sk7ZPmyswc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZmHvrjacSjGl3o71KvXmt/G7qph5+9OqnpdDKVjI86XycJJ1KaJgbbKFS+42bb5m8\n\tWiP2ok7JZxnNRcXu3KmVPQG//wb4f6lfSfG879dq/mmoRoEM3t3biRBNRwia+Behw9\n\teMvwNm0j68f2FGA9PjRslSl7zoYRu/kNtrcAmFvo=","Date":"Thu, 14 Nov 2024 09:58:56 +0100","From":"Jacopo Mondi ","To":"Geoffrey Van Landeghem ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/4] libcamera: libipa: camera_sensor: Add Sony IMX462\n\tsensor properties","Message-ID":"<5ukdeebednnwrmn65p2434ycqyafsizmry7pmv7qszaoi7hyhw@pdfyt5urjjgj>","References":"<20241113223556.413637-2-geoffrey.vl@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241113223556.413637-2-geoffrey.vl@gmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32171,"web_url":"https://patchwork.libcamera.org/comment/32171/","msgid":"","date":"2024-11-14T11:43:11","subject":"Re: [PATCH 1/4] libcamera: libipa: camera_sensor: Add Sony IMX462\n\tsensor properties","submitter":{"id":27,"url":"https://patchwork.libcamera.org/api/people/27/","name":"Dave Stevenson","email":"dave.stevenson@raspberrypi.com"},"content":"Hi Jacopo\n\nOn Thu, 14 Nov 2024 at 08:59, Jacopo Mondi\n wrote:\n>\n> Hi Geoffrey\n> thanks for the patch\n>\n> On Wed, Nov 13, 2024 at 11:35:54PM +0100, Geoffrey Van Landeghem wrote:\n> > Hi,\n>\n> Hi to you, but this is a commit message and the text in here will\n> remain in the git log history. It's nice to be greet when meeting, but\n> probably we don't want this in the commit history :)\n>\n> > This patch-set comes as part of an ongoing effort to support Sony IMX327 and IMX462 sensors better in the linux kernel.\n> > For the kernel following changes are proposed:\n>\n>\n> I suggest to read https://cbea.ms/git-commit/. In example, I would\n> have:\n>\n> Provide a CameraSensorHelper and CameraSensorProperties for\n> the Sony IMX462 image sensor.\n>\n> The sensor is largely compatible with the already supported\n> Sony IMX290 so we can reuse the same helpers for the analogue\n> gain conversion functions.\n>\n>\n> > https://github.com/raspberrypi/linux/pull/5859\n>\n> Do you plan to send the same patches to linux-media ? We're happy to\n> take in changes before they get merged in mainline linux, but they\n> should be at least posted to the mailing list to have them available\n> to everyone.\n\nimx327 will already be advertised by the kernel driver if that\ncompatible string is used.\n\nimx462 I only looked at this week following on from checking out the\nHigh Conversion Gain option.\nI'll look to send the couple of patches\n637c995d8763 media: i2c: imx290: Add configuration for IMX462\nc21f2153831b media: dt-bindings: media: i2c: Add IMX462 to the bindings\n22393df4e814 media: imx290: Limit analogue gain according to module\nto linux-media next week.\n\n Dave\n\n> >\n> > After those changes have been applied, the 2 Starvis sensors will no longer be identied by libcamera as a IMX290 and therefore require this patch-set to work correctly.\n>\n> If you want to provide context around a set of patches you can write a\n> cover letter. Generate it the --cover-letter option to git\n> format-patch and put there the context, while focusing on the single\n> changes in each patch's commit message.\n>\n> Oh, and looking at the other patches, even if trivial, we always\n> require a commit message for each patch.\n>\n> Thanks\n> j\n>\n> >\n> > Signed-off-by: Geoffrey Van Landeghem \n> > ---\n> > src/ipa/libipa/camera_sensor_helper.cpp | 5 +++++\n> > src/ipa/rpi/cam_helper/cam_helper_imx290.cpp | 1 +\n> > src/libcamera/sensor/camera_sensor_properties.cpp | 4 ++++\n> > 3 files changed, 10 insertions(+)\n> >\n> > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> > index c6169bdc..f870dc28 100644\n> > --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> > +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> > @@ -622,6 +622,11 @@ public:\n> > };\n> > REGISTER_CAMERA_SENSOR_HELPER(\"imx415\", CameraSensorHelperImx415)\n> >\n> > +class CameraSensorHelperImx462 : public CameraSensorHelperImx290\n> > +{\n> > +};\n> > +REGISTER_CAMERA_SENSOR_HELPER(\"imx462\", CameraSensorHelperImx462)\n> > +\n> > class CameraSensorHelperImx477 : public CameraSensorHelper\n> > {\n> > public:\n> > diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > index e57ab538..0cc24a6d 100644\n> > --- a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > +++ b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > @@ -73,3 +73,4 @@ static CamHelper *create()\n> > }\n> >\n> > static RegisterCamHelper reg(\"imx290\", &create);\n> > +static RegisterCamHelper reg462(\"imx462\", &create);\n> > diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> > index 6d4136d0..e2305166 100644\n> > --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> > +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> > @@ -142,6 +142,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > .unitCellSize = { 1450, 1450 },\n> > .testPatternModes = {},\n> > } },\n> > + { \"imx462\", {\n> > + .unitCellSize = { 2900, 2900 },\n> > + .testPatternModes = {},\n> > + } },\n> > { \"imx477\", {\n> > .unitCellSize = { 1550, 1550 },\n> > .testPatternModes = {},\n> > --\n> > 2.43.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B011EC324C\n\tfor ;\n\tThu, 14 Nov 2024 11:43:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D5FB265844;\n\tThu, 14 Nov 2024 12:43:33 +0100 (CET)","from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com\n\t[IPv6:2607:f8b0:4864:20::b2c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6128E657E0\n\tfor ;\n\tThu, 14 Nov 2024 12:43:31 +0100 (CET)","by mail-yb1-xb2c.google.com with SMTP id\n\t3f1490d57ef6-e29218d34f8so328484276.1\n\tfor ;\n\tThu, 14 Nov 2024 03:43:31 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"RwA0fABl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1731584610; x=1732189410;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=jWn7l3pz1112xF7Xw8PtHGjnd62MT1VbMTPOJeNL1nY=;\n\tb=RwA0fABl3HwHs7FTLitg/u1R3IOKWAO8mDM/10Ymvj314fxkiIEHakmMeK4f2xKKDP\n\tAw5E0mfD5BFgVaPoam3IYJwQMFk0bofAGqVLZ2Br9P8gvDoTAhise5mGVZqgsoTjxcri\n\t+fO2dTAauauYSs2hJjJJiTanOJfyKTa+4C98OVxRrEwQS/NasV7EdKqAmbp1E7wtEnIX\n\tmyJLbDyDHRlisXDYNGUOx9k2ignGukmyfCNRQJyUF4dKys7MkroilFUCRz8M5scwegn5\n\tFvEPPar8cT3f4K4KhZtFq7GJbsPq5IMdL0fRAJkuzGLKToP4ZDkPwPnZPmpx6NcFdxox\n\tENew==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1731584610; x=1732189410;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=jWn7l3pz1112xF7Xw8PtHGjnd62MT1VbMTPOJeNL1nY=;\n\tb=vCsax8ov35I0ruMliclmE9pI04IUkuboXbu/SN8yXf6wimGE71hpBDTC/4jKlEOSxt\n\tlG4ek7i6eDcyBlbXcvRpq4Innbpji3Dj6aE2VdZgSgWWyQ7+RebI9nEGhzPJ7Ku5QhG0\n\tni31K2dZTVgMK0Gvj6zmaOWq65tbZvjCzLT7pg7X2qs641csmrKzGeZqPJoqE/vwI37+\n\tA0H+Gv3GiaG5Y76LFrX+CiWBG+TkxaAyKZgL18lfznkUxAsr+JkV2jFqKWIE2CzektDT\n\tt/6cocNo4sGXbhAJ8nLhsypBzJYohsZqpMzFuXHZbnVykUS1OR8kPQikQJAahIn1wpeR\n\tgEIQ==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCURXn2qOjZE3i2QgSK9DuI/dEMoj/+3tYhAUvj52B10DROWQaUV3nRF1kjOJ0DTeJMQbtPS/JvB9/6bot9mNXs=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YzHEA2DkzwIuN2/fPL5p9zGk9bjrJp4C+CtzgVa5xjmPTOdsKru\n\tIUxib8RenxcpbAZWLp3N62frL6U6CEusMqzyRUx2ofNlBlIAGnb3mW+p0Ec0griGZjc7QBfzuf8\n\ttml5OwI1W6SPqjLPZBpc2RGlG8ZXs/T8U22VEFw==","X-Google-Smtp-Source":"AGHT+IH9n9DpAyf4+vCZR0TnKFqfE6w0NjG2tYPW3fUcI0UVFNpZoi9HAKz0HL2+9CpINhqe4gEuEZeO22l9IViQBCI=","X-Received":"by 2002:a05:6902:4ac:b0:e2e:447b:7048 with SMTP id\n\t3f1490d57ef6-e380e0d7217mr2184569276.12.1731584610184;\n\tThu, 14 Nov 2024 03:43:30 -0800 (PST)","MIME-Version":"1.0","References":"<20241113223556.413637-2-geoffrey.vl@gmail.com>\n\t<5ukdeebednnwrmn65p2434ycqyafsizmry7pmv7qszaoi7hyhw@pdfyt5urjjgj>","In-Reply-To":"<5ukdeebednnwrmn65p2434ycqyafsizmry7pmv7qszaoi7hyhw@pdfyt5urjjgj>","From":"Dave Stevenson ","Date":"Thu, 14 Nov 2024 11:43:11 +0000","Message-ID":"","Subject":"Re: [PATCH 1/4] libcamera: libipa: camera_sensor: Add Sony IMX462\n\tsensor properties","To":"Jacopo Mondi ","Cc":"Geoffrey Van Landeghem ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32175,"web_url":"https://patchwork.libcamera.org/comment/32175/","msgid":"","date":"2024-11-14T16:05:46","subject":"Re: [PATCH 1/4] libcamera: libipa: camera_sensor: Add Sony IMX462\n\tsensor properties","submitter":{"id":27,"url":"https://patchwork.libcamera.org/api/people/27/","name":"Dave Stevenson","email":"dave.stevenson@raspberrypi.com"},"content":"On Thu, 14 Nov 2024 at 11:43, Dave Stevenson\n wrote:\n>\n> Hi Jacopo\n>\n> On Thu, 14 Nov 2024 at 08:59, Jacopo Mondi\n> wrote:\n> >\n> > Hi Geoffrey\n> > thanks for the patch\n> >\n> > On Wed, Nov 13, 2024 at 11:35:54PM +0100, Geoffrey Van Landeghem wrote:\n> > > Hi,\n> >\n> > Hi to you, but this is a commit message and the text in here will\n> > remain in the git log history. It's nice to be greet when meeting, but\n> > probably we don't want this in the commit history :)\n> >\n> > > This patch-set comes as part of an ongoing effort to support Sony IMX327 and IMX462 sensors better in the linux kernel.\n> > > For the kernel following changes are proposed:\n> >\n> >\n> > I suggest to read https://cbea.ms/git-commit/. In example, I would\n> > have:\n> >\n> > Provide a CameraSensorHelper and CameraSensorProperties for\n> > the Sony IMX462 image sensor.\n> >\n> > The sensor is largely compatible with the already supported\n> > Sony IMX290 so we can reuse the same helpers for the analogue\n> > gain conversion functions.\n> >\n> >\n> > > https://github.com/raspberrypi/linux/pull/5859\n> >\n> > Do you plan to send the same patches to linux-media ? We're happy to\n> > take in changes before they get merged in mainline linux, but they\n> > should be at least posted to the mailing list to have them available\n> > to everyone.\n>\n> imx327 will already be advertised by the kernel driver if that\n> compatible string is used.\n>\n> imx462 I only looked at this week following on from checking out the\n> High Conversion Gain option.\n> I'll look to send the couple of patches\n> 637c995d8763 media: i2c: imx290: Add configuration for IMX462\n> c21f2153831b media: dt-bindings: media: i2c: Add IMX462 to the bindings\n> 22393df4e814 media: imx290: Limit analogue gain according to module\n> to linux-media next week.\n\nOK, they got done today instead -\nhttps://lore.kernel.org/linux-media/20241114-media-imx290-imx462-v1-0-c538a2e24786@raspberrypi.com/\n\n> Dave\n>\n> > >\n> > > After those changes have been applied, the 2 Starvis sensors will no longer be identied by libcamera as a IMX290 and therefore require this patch-set to work correctly.\n> >\n> > If you want to provide context around a set of patches you can write a\n> > cover letter. Generate it the --cover-letter option to git\n> > format-patch and put there the context, while focusing on the single\n> > changes in each patch's commit message.\n> >\n> > Oh, and looking at the other patches, even if trivial, we always\n> > require a commit message for each patch.\n> >\n> > Thanks\n> > j\n> >\n> > >\n> > > Signed-off-by: Geoffrey Van Landeghem \n> > > ---\n> > > src/ipa/libipa/camera_sensor_helper.cpp | 5 +++++\n> > > src/ipa/rpi/cam_helper/cam_helper_imx290.cpp | 1 +\n> > > src/libcamera/sensor/camera_sensor_properties.cpp | 4 ++++\n> > > 3 files changed, 10 insertions(+)\n> > >\n> > > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> > > index c6169bdc..f870dc28 100644\n> > > --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> > > +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> > > @@ -622,6 +622,11 @@ public:\n> > > };\n> > > REGISTER_CAMERA_SENSOR_HELPER(\"imx415\", CameraSensorHelperImx415)\n> > >\n> > > +class CameraSensorHelperImx462 : public CameraSensorHelperImx290\n> > > +{\n> > > +};\n> > > +REGISTER_CAMERA_SENSOR_HELPER(\"imx462\", CameraSensorHelperImx462)\n> > > +\n> > > class CameraSensorHelperImx477 : public CameraSensorHelper\n> > > {\n> > > public:\n> > > diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > > index e57ab538..0cc24a6d 100644\n> > > --- a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > > +++ b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > > @@ -73,3 +73,4 @@ static CamHelper *create()\n> > > }\n> > >\n> > > static RegisterCamHelper reg(\"imx290\", &create);\n> > > +static RegisterCamHelper reg462(\"imx462\", &create);\n> > > diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> > > index 6d4136d0..e2305166 100644\n> > > --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> > > +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> > > @@ -142,6 +142,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > > .unitCellSize = { 1450, 1450 },\n> > > .testPatternModes = {},\n> > > } },\n> > > + { \"imx462\", {\n> > > + .unitCellSize = { 2900, 2900 },\n> > > + .testPatternModes = {},\n> > > + } },\n> > > { \"imx477\", {\n> > > .unitCellSize = { 1550, 1550 },\n> > > .testPatternModes = {},\n> > > --\n> > > 2.43.0\n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B803BC324C\n\tfor ;\n\tThu, 14 Nov 2024 16:06:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE3936584D;\n\tThu, 14 Nov 2024 17:06:11 +0100 (CET)","from mail-lf1-x135.google.com (mail-lf1-x135.google.com\n\t[IPv6:2a00:1450:4864:20::135])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E5103657E0\n\tfor ;\n\tThu, 14 Nov 2024 17:06:05 +0100 (CET)","by mail-lf1-x135.google.com with SMTP id\n\t2adb3069b0e04-539e63c8678so782914e87.0\n\tfor ;\n\tThu, 14 Nov 2024 08:06:05 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"NC7dZ/M7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1731600365; x=1732205165;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=iNzfs4sfe6CC1q3iUGdFuTtSOKH6K/iykvudxxl7+fA=;\n\tb=NC7dZ/M7aEdtIZDxSapmRTy8ZsCZjaFAmekTugmqraSwXuPqK5OeuQS7x93EN88mhx\n\tDLJzL1w7QXTxKiVr7daHBoRrfPvD4g9gxFsR2sU1tk9444r2Ax9qlAl+rC4oJXaYWKr6\n\trirmOm5yw8lG5qG2lXk/RMBmHg7a560x9nd4wtNktWM6EFORB/VAkjbovhn++kH5ox9d\n\tj/39VSSboM+IQVwQTjifaM1tiI8fFEwHypjAQeJ9A4LVOiPjB6w39omAG3pHwOAYiOGn\n\tm4cF7Nsv+oM++j+T2pxHpPYbwpXd2QAl+TwOdR/bsVC+xFcVOzLqfOFEJ2k79b54zOYL\n\tWTvw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1731600365; x=1732205165;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=iNzfs4sfe6CC1q3iUGdFuTtSOKH6K/iykvudxxl7+fA=;\n\tb=uqtgCEzunB5mTj9munuoEbfXxz4RiNsdCwGIj9HD+moj8UnRLKEA/e+0QA0vMLH0Wl\n\to9DVSpnWH3CUdvIVWtS2YeY7Dlz/If+n2Av3giIv1yH49bnz8uqS7wnsItPc9YkH+lR9\n\tZpcxopcnohDYMe3ezOXu5LXWyqbxANMijM7O6YB10IbvSuLjNXDe70Ey7ttruR2fYV0j\n\t2Mdc4eI2zjksG1DTwWjKEYvDD+UAarLB1W0T/ZlMmtp1IQoVyruhGP27Et++zpszoj7F\n\ttDo9GHmibBvIxEubufOTSZrc8Yq5USvsdwE1SAIaxsU0QyiK9ILQ8kt3ZV8wSbo8+UNY\n\tyBxw==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCUt+AQZwu+a3ADE8aWrqfLaiyzhUJJTe2Rzv3qzwzdnVLGBXyPGMcjvON3mWSQNhYK3vI+s0RvPT3YhZllhoAs=@lists.libcamera.org","X-Gm-Message-State":"AOJu0Ywx0WsQbVSITZoVbfaExxVgLDUggVPdePdJtwDNC5u2wJimf6yP\n\t/Xzw5WDwZipJgT5YZRtONXZOkwa29PGFehv/jC05hQeCdm/PLYOvkzs2eCEelsXZnrVDJlQHWU5\n\tI00Tr4dcmzq3LDBnRTs32GyNWzByWLwnIEu55Aw==","X-Google-Smtp-Source":"AGHT+IGhj+h5qWajSczDmROaVvwKmW8mrF6Ov/fFduBVqsnAm/mJ/Baztp2cYFf0J/yxYz35o9f/QUPTLuqkvNHPB5g=","X-Received":"by 2002:a05:6512:693:b0:53d:a1eb:a0ce with SMTP id\n\t2adb3069b0e04-53da5c7b664mr1359615e87.55.1731600364685;\n\tThu, 14 Nov 2024 08:06:04 -0800 (PST)","MIME-Version":"1.0","References":"<20241113223556.413637-2-geoffrey.vl@gmail.com>\n\t<5ukdeebednnwrmn65p2434ycqyafsizmry7pmv7qszaoi7hyhw@pdfyt5urjjgj>\n\t","In-Reply-To":"","From":"Dave Stevenson ","Date":"Thu, 14 Nov 2024 16:05:46 +0000","Message-ID":"","Subject":"Re: [PATCH 1/4] libcamera: libipa: camera_sensor: Add Sony IMX462\n\tsensor properties","To":"Jacopo Mondi ","Cc":"Geoffrey Van Landeghem ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]