[{"id":32151,"web_url":"https://patchwork.libcamera.org/comment/32151/","msgid":"","date":"2024-11-13T18:47:23","subject":"Re: [PATCH v3 7/8] gstreamer: Generate the new AEGC controls","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Hi,\n\nLe mercredi 13 novembre 2024 à 22:12 +0900, Paul Elder a écrit :\n> Since AeEnable will be replaced with ExposureTimeMode and\n> AnalogueGainMode so that the two can be set between auto/manual\n> independently, update the gstreamer control ids generation to conform\n> with this.\n\nThanks for keeping GStreamer up-to-date!\n\nJust an informative note, this is an API change, in this case we haven't\nreleased libcamera with ae-enable property yet, so no action needed. A similar\nchange in the future would require emulating ae-enable on top of\nExposureTimeMode, or some clear notice for the next release note.\n\nReviewed-by: Nicolas Nicolas \n\n> \n> Signed-off-by: Paul Elder \n> \n> ---\n> New in v3\n> ---\n> utils/codegen/gen-gst-controls.py | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/utils/codegen/gen-gst-controls.py b/utils/codegen/gen-gst-controls.py\n> index 2601a67588a3..7dfd6b623b3d 100755\n> --- a/utils/codegen/gen-gst-controls.py\n> +++ b/utils/codegen/gen-gst-controls.py\n> @@ -19,8 +19,9 @@ from controls import Control\n> \n> \n> exposed_controls = [\n> - 'AeEnable', 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n> - 'ExposureValue', 'ExposureTime', 'AnalogueGain', 'AeFlickerPeriod',\n> + 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n> + 'ExposureValue', 'ExposureTime', 'ExposureTimeMode',\n> + 'AnalogueGain', 'AnalogueGainMode', 'AeFlickerPeriod',\n> 'Brightness', 'Contrast', 'AwbEnable', 'AwbMode', 'ColourGains',\n> 'Saturation', 'Sharpness', 'ColourCorrectionMatrix', 'ScalerCrop',\n> 'DigitalGain', 'AfMode', 'AfRange', 'AfSpeed', 'AfMetering', 'AfWindows',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 861BDC324C\n\tfor ;\n\tWed, 13 Nov 2024 18:47:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F60265819;\n\tWed, 13 Nov 2024 19:47:27 +0100 (CET)","from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com\n\t[IPv6:2607:f8b0:4864:20::f36])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2C19B657CF\n\tfor ;\n\tWed, 13 Nov 2024 19:47:26 +0100 (CET)","by mail-qv1-xf36.google.com with SMTP id\n\t6a1803df08f44-6cbd12b38b4so46744526d6.2\n\tfor ;\n\tWed, 13 Nov 2024 10:47:26 -0800 (PST)","from nicolas-tpx395.localdomain ([2606:6d00:15:862e::580])\n\tby smtp.gmail.com with ESMTPSA id\n\t6a1803df08f44-6d3961f4a0fsm87582606d6.41.2024.11.13.10.47.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 13 Nov 2024 10:47:24 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ndufresne-ca.20230601.gappssmtp.com\n\theader.i=@ndufresne-ca.20230601.gappssmtp.com\n\theader.b=\"axWSg3NC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20230601.gappssmtp.com; s=20230601; t=1731523645;\n\tx=1732128445; darn=lists.libcamera.org; \n\th=mime-version:user-agent:content-transfer-encoding:references\n\t:in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=sMAyRI9CWxlwEmLuV+M0u6P6E4oCC1mtM+ByIizc0eQ=;\n\tb=axWSg3NC+VwhUM+ybLwzVzLvT0XjhTRc5S0hwI//AoL4FGs1m4cnBKP/6tJUdCZYzm\n\taBK1EXHGM6KUPayxDMydPA+cOuI7JndF1wNgvix2wQDuKy6MDAxSBYlPUObkdK6ilb0n\n\tQQa9jXmpCJSlOYGDan6LDotpYxSVtAnxwZZ+4bbZd0XAQPFUHvtvRGKQ7Qn9R1S0gdkQ\n\tywrdjNZWVWNpgLLTY4WXkSI5mv9GHiHXS6eSOzw466GZGXAGa6FgIKUJnOQwmYgiecI+\n\tqP3N2Z3TYiGdU6kllWE1Y7gluZlUEKHHQDN3BmwQIh8nAS1AWAplBF1owlI3z/aSwPLW\n\tByhA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1731523645; x=1732128445;\n\th=mime-version:user-agent:content-transfer-encoding:references\n\t:in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=sMAyRI9CWxlwEmLuV+M0u6P6E4oCC1mtM+ByIizc0eQ=;\n\tb=Zv7LleYIeFkd2BW9SBk229M5RfC80wWzbfysS43yBHljArVBnXNrsXiA/b/mcTn9B3\n\t8fv2mQOsDbOlt14CQ89VaObKmGpVEOEKmtb2hcLW0SNlAjy+8ShcQFd2OdDaNTENJJ9X\n\tqB0cfs9NQRGPOGFgqoyAmU7A2/cblZdf6UytBQq9914E0OceAi6ZhJZLtvTw6Ki2LUqG\n\tznVVwCmgT0ZYJJjJn4Rffl/LSSKVtJFRvTLFU+FkXDisvWZ3Yh/98WldVMPxx9gh6JPf\n\thuoGrkBUb/9NarCsBYzQ5YzhZG/d9/9aoNaITQ7V3Aie1m5LweuDry8+1804jO8yJ+zY\n\tqT3g==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCVvH+1hdsDKPscNWb68JCZBey5EQObwopKN4eADXFtWcq7n3PmFqHo4Rnxb1/MjZ0Aa2O36RqW6XpHh/9A+P80=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YwLKICumaPwBDTIbyQe3U6TN0HMXylrab175Tv0Kmmw9Bg7mihI\n\t3tGRY72/qfyPKIf+qEFKFD/eQP9iTdCVtU9InaZTdCYo3g90Dz09NPGtcPZCJ7c=","X-Google-Smtp-Source":"AGHT+IGt715j/cUP3M99xe7UObPaW7hm3z//54v0iNqPDiE8yYy6gK+V2wMDZdKLY7IWHr0lkQaypw==","X-Received":"by 2002:a0c:f40f:0:b0:6cd:e38a:a91e with SMTP id\n\t6a1803df08f44-6d39e16d0b0mr317709626d6.18.1731523645018; \n\tWed, 13 Nov 2024 10:47:25 -0800 (PST)","Message-ID":"","Subject":"Re: [PATCH v3 7/8] gstreamer: Generate the new AEGC controls","From":"Nicolas Dufresne ","To":"Paul Elder , \n\tlibcamera-devel@lists.libcamera.org","Cc":"laurent.pinchart@ideasonboard.com, jacopo.mondi@ideasonboard.com, \n\tnaush@raspberrypi.com, david.plowman@raspberrypi.com","Date":"Wed, 13 Nov 2024 13:47:23 -0500","In-Reply-To":"<20241113131256.3170817-8-paul.elder@ideasonboard.com>","References":"<20241113131256.3170817-1-paul.elder@ideasonboard.com>\n\t<20241113131256.3170817-8-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.54.1 (3.54.1-1.fc41) ","MIME-Version":"1.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32152,"web_url":"https://patchwork.libcamera.org/comment/32152/","msgid":"<20241113185128.GB26171@pendragon.ideasonboard.com>","date":"2024-11-13T18:51:28","subject":"Re: [PATCH v3 7/8] gstreamer: Generate the new AEGC controls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nOn Wed, Nov 13, 2024 at 01:47:23PM -0500, Nicolas Dufresne wrote:\n> Le mercredi 13 novembre 2024 à 22:12 +0900, Paul Elder a écrit :\n> > Since AeEnable will be replaced with ExposureTimeMode and\n> > AnalogueGainMode so that the two can be set between auto/manual\n> > independently, update the gstreamer control ids generation to conform\n> > with this.\n> \n> Thanks for keeping GStreamer up-to-date!\n> \n> Just an informative note, this is an API change, in this case we haven't\n> released libcamera with ae-enable property yet, so no action needed. A similar\n> change in the future would require emulating ae-enable on top of\n> ExposureTimeMode, or some clear notice for the next release note.\n\nWe would opt for a clear notice, as we don't maintain backward\ncompatibility yet. Kieran already mentions ABI breakages in the release\nnotes, is there somewhere else the notice would need to be posted ?\n\n> Reviewed-by: Nicolas Nicolas \n> \n> > Signed-off-by: Paul Elder \n> > \n> > ---\n> > New in v3\n> > ---\n> > utils/codegen/gen-gst-controls.py | 5 +++--\n> > 1 file changed, 3 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/utils/codegen/gen-gst-controls.py b/utils/codegen/gen-gst-controls.py\n> > index 2601a67588a3..7dfd6b623b3d 100755\n> > --- a/utils/codegen/gen-gst-controls.py\n> > +++ b/utils/codegen/gen-gst-controls.py\n> > @@ -19,8 +19,9 @@ from controls import Control\n> > \n> > \n> > exposed_controls = [\n> > - 'AeEnable', 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n> > - 'ExposureValue', 'ExposureTime', 'AnalogueGain', 'AeFlickerPeriod',\n> > + 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n> > + 'ExposureValue', 'ExposureTime', 'ExposureTimeMode',\n> > + 'AnalogueGain', 'AnalogueGainMode', 'AeFlickerPeriod',\n> > 'Brightness', 'Contrast', 'AwbEnable', 'AwbMode', 'ColourGains',\n> > 'Saturation', 'Sharpness', 'ColourCorrectionMatrix', 'ScalerCrop',\n> > 'DigitalGain', 'AfMode', 'AfRange', 'AfSpeed', 'AfMetering', 'AfWindows',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3B0FDBE173\n\tfor ;\n\tWed, 13 Nov 2024 18:51:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6D43165824;\n\tWed, 13 Nov 2024 19:51:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C21D657CF\n\tfor ;\n\tWed, 13 Nov 2024 19:51:37 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC833502;\n\tWed, 13 Nov 2024 19:51:23 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JLe/H/Ao\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731523884;\n\tbh=7WjNA1ja2M84z4WTR8NU7BfOnLtz586mlaNrE8GSqCg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=JLe/H/Aol1oPGXxBh9eHnn2ksuFl8quJcPLmSbqAj2+XTAhwz9gMaTK/5SPj/juuN\n\tAjN6p1uJi9DA0P5p8bKf63Knp+YNz7/HX5KYxAmV2Mxub4wN+WUhHztXAz/amr28Sc\n\tI5u5mzWXYmEPgqnvAuB+0US7rs7hBarYaaOf2/VE=","Date":"Wed, 13 Nov 2024 20:51:28 +0200","From":"Laurent Pinchart ","To":"Nicolas Dufresne ","Cc":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org, jacopo.mondi@ideasonboard.com,\n\tnaush@raspberrypi.com, david.plowman@raspberrypi.com","Subject":"Re: [PATCH v3 7/8] gstreamer: Generate the new AEGC controls","Message-ID":"<20241113185128.GB26171@pendragon.ideasonboard.com>","References":"<20241113131256.3170817-1-paul.elder@ideasonboard.com>\n\t<20241113131256.3170817-8-paul.elder@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32156,"web_url":"https://patchwork.libcamera.org/comment/32156/","msgid":"<0e86a8d615c1a9cb5ffb88c122605a94351e5e35.camel@ndufresne.ca>","date":"2024-11-13T19:31:12","subject":"Re: [PATCH v3 7/8] gstreamer: Generate the new AEGC controls","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Le mercredi 13 novembre 2024 à 20:51 +0200, Laurent Pinchart a écrit :\n> Hi Nicolas,\n> \n> On Wed, Nov 13, 2024 at 01:47:23PM -0500, Nicolas Dufresne wrote:\n> > Le mercredi 13 novembre 2024 à 22:12 +0900, Paul Elder a écrit :\n> > > Since AeEnable will be replaced with ExposureTimeMode and\n> > > AnalogueGainMode so that the two can be set between auto/manual\n> > > independently, update the gstreamer control ids generation to conform\n> > > with this.\n> > \n> > Thanks for keeping GStreamer up-to-date!\n> > \n> > Just an informative note, this is an API change, in this case we haven't\n> > released libcamera with ae-enable property yet, so no action needed. A similar\n> > change in the future would require emulating ae-enable on top of\n> > ExposureTimeMode, or some clear notice for the next release note.\n> \n> We would opt for a clear notice, as we don't maintain backward\n> compatibility yet. Kieran already mentions ABI breakages in the release\n> notes, is there somewhere else the notice would need to be posted ?\n\nI was under the impression this one wasn't a problem since we haven't released\nin between, perhaps I'm wrong ;-P But clear a short live for these properties.\n\n> \n> > Reviewed-by: Nicolas Nicolas \n> > \n> > > Signed-off-by: Paul Elder \n> > > \n> > > ---\n> > > New in v3\n> > > ---\n> > > utils/codegen/gen-gst-controls.py | 5 +++--\n> > > 1 file changed, 3 insertions(+), 2 deletions(-)\n> > > \n> > > diff --git a/utils/codegen/gen-gst-controls.py b/utils/codegen/gen-gst-controls.py\n> > > index 2601a67588a3..7dfd6b623b3d 100755\n> > > --- a/utils/codegen/gen-gst-controls.py\n> > > +++ b/utils/codegen/gen-gst-controls.py\n> > > @@ -19,8 +19,9 @@ from controls import Control\n> > > \n> > > \n> > > exposed_controls = [\n> > > - 'AeEnable', 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n> > > - 'ExposureValue', 'ExposureTime', 'AnalogueGain', 'AeFlickerPeriod',\n> > > + 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n> > > + 'ExposureValue', 'ExposureTime', 'ExposureTimeMode',\n> > > + 'AnalogueGain', 'AnalogueGainMode', 'AeFlickerPeriod',\n> > > 'Brightness', 'Contrast', 'AwbEnable', 'AwbMode', 'ColourGains',\n> > > 'Saturation', 'Sharpness', 'ColourCorrectionMatrix', 'ScalerCrop',\n> > > 'DigitalGain', 'AfMode', 'AfRange', 'AfSpeed', 'AfMetering', 'AfWindows',\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B4F35BE173\n\tfor ;\n\tWed, 13 Nov 2024 19:31:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0EC7F6581C;\n\tWed, 13 Nov 2024 20:31:16 +0100 (CET)","from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com\n\t[IPv6:2607:f8b0:4864:20::f35])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3D9646581C\n\tfor ;\n\tWed, 13 Nov 2024 20:31:14 +0100 (CET)","by mail-qv1-xf35.google.com with SMTP id\n\t6a1803df08f44-6cbd1ae26a6so51070546d6.1\n\tfor ;\n\tWed, 13 Nov 2024 11:31:14 -0800 (PST)","from nicolas-tpx395.localdomain ([2606:6d00:15:862e::580])\n\tby smtp.gmail.com with ESMTPSA id\n\t6a1803df08f44-6d39643c7afsm87927916d6.72.2024.11.13.11.31.12\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 13 Nov 2024 11:31:12 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ndufresne-ca.20230601.gappssmtp.com\n\theader.i=@ndufresne-ca.20230601.gappssmtp.com\n\theader.b=\"N9I3Zfju\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20230601.gappssmtp.com; s=20230601; t=1731526273;\n\tx=1732131073; darn=lists.libcamera.org; \n\th=mime-version:user-agent:content-transfer-encoding:references\n\t:in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=iBDmP5WabkkyjDkDD1vQnjYvEJtyZ8tocfUZ+TfkFNs=;\n\tb=N9I3Zfju/nZTqvQD3Rjfr8V8Dc9c0J8HoI0i8YdIJX6FEwzXVkBD/PDK3goDqk4j79\n\tRIX3DSosxFwWS15TihovwC4b9km+8k95U/hoymB8krEDahIIKSIiOpQz9v65cBd+MIYA\n\tMlhB1nyTCjhXnXDEkkk63DzXr6CFRSJLvznffl6ftkmgtl8iDdUoqhWpeyE1pzjTeqn/\n\tqOxowWwn7caQzlcyVOY+3WmrJKEMatFZkwkNSnVSGSaxAC8FpDs0cKqI2umLIgOhaXlo\n\tjmus6fRnhibRUNASKbDNwARGKoqAwgazlihhqOLpSWB9MzBkhrHf6utnsIvybEl/elFm\n\tePpg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1731526273; x=1732131073;\n\th=mime-version:user-agent:content-transfer-encoding:references\n\t:in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=iBDmP5WabkkyjDkDD1vQnjYvEJtyZ8tocfUZ+TfkFNs=;\n\tb=dnUpBDZzUhCBCG6k8cLPR1rQFQQPxNyEwDdD6dUOZHrhs/GbGJ2QwYVLABde7Lf1Ye\n\tlYtl1/wz+jjPZiJaNIv2Ssx+Ky4BSIuDbsdi7ZBflICxRsU30xLwkQuabVnkk/B2Bkzc\n\tlL98x9E7tYMtOcE2w/Ks6cIhqOdqvaD2S5qMNSAmQeaeus72xrg4s0ZkoYoBOjq+Alvs\n\tAWrVnzvNy6pbO4uGp31CwYEtkIN/g0B/vfRMSf7ZLdC0IXlP1l7YTTzBzEnjRCcbpNP1\n\t+rw4JLvKyHr8Pe1tczIhy8USYuFenQ3bc8xXMvtIZCmLv+dlBE2oTyTUePkJq5mXVwSF\n\tzccA==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCXBg4BD1n8kt3VwWem/WtbA6zLkfvPtjRuobuo9OMGRfskBtZZvgI3DggQJeuswDlYJbk/wz5GFKAmLddiTM58=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YxeEbUK1j90BmXz10vSL31lTn+pb0aqY95fXaQV/5AuPPGg4Fu+\n\t3JaIN7Kgz5MBJN3U3kcQAXL9XIKsele12nhQJE6k+CvESztCupTwqcmmtzOu3lE=","X-Google-Smtp-Source":"AGHT+IHykHRsHBlhlLgPj0etq4VwZ45ok7DJEiSTr1B9wT/cOZBEQV2ShAE2/V86T/mjlCSZhFMTag==","X-Received":"by 2002:a05:6214:3bc7:b0:6d3:65ad:5cf9 with SMTP id\n\t6a1803df08f44-6d39e1263d8mr298826616d6.15.1731526273243; \n\tWed, 13 Nov 2024 11:31:13 -0800 (PST)","Message-ID":"<0e86a8d615c1a9cb5ffb88c122605a94351e5e35.camel@ndufresne.ca>","Subject":"Re: [PATCH v3 7/8] gstreamer: Generate the new AEGC controls","From":"Nicolas Dufresne ","To":"Laurent Pinchart ","Cc":"Paul Elder , \n\tlibcamera-devel@lists.libcamera.org, jacopo.mondi@ideasonboard.com, \n\tnaush@raspberrypi.com, david.plowman@raspberrypi.com","Date":"Wed, 13 Nov 2024 14:31:12 -0500","In-Reply-To":"<20241113185128.GB26171@pendragon.ideasonboard.com>","References":"<20241113131256.3170817-1-paul.elder@ideasonboard.com>\n\t<20241113131256.3170817-8-paul.elder@ideasonboard.com>\n\t\n\t<20241113185128.GB26171@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.54.1 (3.54.1-1.fc41) ","MIME-Version":"1.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32188,"web_url":"https://patchwork.libcamera.org/comment/32188/","msgid":"","date":"2024-11-15T13:10:30","subject":"Re: [PATCH v3 7/8] gstreamer: Generate the new AEGC controls","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Nov 13, 2024 at 01:47:23PM -0500, Nicolas Dufresne wrote:\n> Hi,\n> \n> Le mercredi 13 novembre 2024 à 22:12 +0900, Paul Elder a écrit :\n> > Since AeEnable will be replaced with ExposureTimeMode and\n> > AnalogueGainMode so that the two can be set between auto/manual\n> > independently, update the gstreamer control ids generation to conform\n> > with this.\n> \n> Thanks for keeping GStreamer up-to-date!\n> \n> Just an informative note, this is an API change, in this case we haven't\n> released libcamera with ae-enable property yet, so no action needed. A similar\n> change in the future would require emulating ae-enable on top of\n> ExposureTimeMode, or some clear notice for the next release note.\n\nNoted.\n\n> \n> Reviewed-by: Nicolas Nicolas \n\nThanks!\n\nPaul\n\n> \n> > \n> > Signed-off-by: Paul Elder \n> > \n> > ---\n> > New in v3\n> > ---\n> > utils/codegen/gen-gst-controls.py | 5 +++--\n> > 1 file changed, 3 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/utils/codegen/gen-gst-controls.py b/utils/codegen/gen-gst-controls.py\n> > index 2601a67588a3..7dfd6b623b3d 100755\n> > --- a/utils/codegen/gen-gst-controls.py\n> > +++ b/utils/codegen/gen-gst-controls.py\n> > @@ -19,8 +19,9 @@ from controls import Control\n> > \n> > \n> > exposed_controls = [\n> > - 'AeEnable', 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n> > - 'ExposureValue', 'ExposureTime', 'AnalogueGain', 'AeFlickerPeriod',\n> > + 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n> > + 'ExposureValue', 'ExposureTime', 'ExposureTimeMode',\n> > + 'AnalogueGain', 'AnalogueGainMode', 'AeFlickerPeriod',\n> > 'Brightness', 'Contrast', 'AwbEnable', 'AwbMode', 'ColourGains',\n> > 'Saturation', 'Sharpness', 'ColourCorrectionMatrix', 'ScalerCrop',\n> > 'DigitalGain', 'AfMode', 'AfRange', 'AfSpeed', 'AfMetering', 'AfWindows',\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 73749C3257\n\tfor ;\n\tFri, 15 Nov 2024 13:10:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D60306580A;\n\tFri, 15 Nov 2024 14:10:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E2B0B6580A\n\tfor ;\n\tFri, 15 Nov 2024 14:10:37 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:bd6c:1638:cb26:1bfa])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6B5CA9CE;\n\tFri, 15 Nov 2024 14:10:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bUbw2srC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731676223;\n\tbh=MdmvEmA/7JDZRg6efNHfSWVahv6BQt/WDnElutz/3zE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bUbw2srCNfaG1wsqDw3GMDBCyMLMDgwtIwrDYymisVFzRLevZ2wOX7neTYn9y/uPi\n\ttdn6bFlEH5r4fph4eVeNFYpWXz+4YfH91JN09SwuiiOT5zis3hj9s7eMlSDlcaHkix\n\tJe2c427dPFo8wOrnEXXppdanSw72W1x3fHvysSBc=","Date":"Fri, 15 Nov 2024 22:10:30 +0900","From":"Paul Elder ","To":"Nicolas Dufresne ","Cc":"libcamera-devel@lists.libcamera.org, laurent.pinchart@ideasonboard.com, \n\tjacopo.mondi@ideasonboard.com, naush@raspberrypi.com,\n\tdavid.plowman@raspberrypi.com","Subject":"Re: [PATCH v3 7/8] gstreamer: Generate the new AEGC controls","Message-ID":"","References":"<20241113131256.3170817-1-paul.elder@ideasonboard.com>\n\t<20241113131256.3170817-8-paul.elder@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32308,"web_url":"https://patchwork.libcamera.org/comment/32308/","msgid":"<20241120134429.GS12409@pendragon.ideasonboard.com>","date":"2024-11-20T13:44:29","subject":"Re: [PATCH v3 7/8] gstreamer: Generate the new AEGC controls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Nov 13, 2024 at 10:12:55PM +0900, Paul Elder wrote:\n> Since AeEnable will be replaced with ExposureTimeMode and\n> AnalogueGainMode so that the two can be set between auto/manual\n> independently, update the gstreamer control ids generation to conform\n> with this.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> \n> ---\n> New in v3\n> ---\n> utils/codegen/gen-gst-controls.py | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/utils/codegen/gen-gst-controls.py b/utils/codegen/gen-gst-controls.py\n> index 2601a67588a3..7dfd6b623b3d 100755\n> --- a/utils/codegen/gen-gst-controls.py\n> +++ b/utils/codegen/gen-gst-controls.py\n> @@ -19,8 +19,9 @@ from controls import Control\n> \n> \n> exposed_controls = [\n> - 'AeEnable', 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n> - 'ExposureValue', 'ExposureTime', 'AnalogueGain', 'AeFlickerPeriod',\n> + 'AeMeteringMode', 'AeConstraintMode', 'AeExposureMode',\n> + 'ExposureValue', 'ExposureTime', 'ExposureTimeMode',\n> + 'AnalogueGain', 'AnalogueGainMode', 'AeFlickerPeriod',\n> 'Brightness', 'Contrast', 'AwbEnable', 'AwbMode', 'ColourGains',\n> 'Saturation', 'Sharpness', 'ColourCorrectionMatrix', 'ScalerCrop',\n> 'DigitalGain', 'AfMode', 'AfRange', 'AfSpeed', 'AfMetering', 'AfWindows',","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 43063C32F5\n\tfor ;\n\tWed, 20 Nov 2024 13:44:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 51E5E65F54;\n\tWed, 20 Nov 2024 14:44:41 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 55CAD65898\n\tfor ;\n\tWed, 20 Nov 2024 14:44:39 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 978B7675;\n\tWed, 20 Nov 2024 14:44:20 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Est/fBW5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732110260;\n\tbh=IUtFO5ArHycxZQIJeYyguAzIPPefBOAwILlzjOyilAs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Est/fBW5iTz7MtfP0Ux12hDL3AOjXfCOeiAJmmMFZgSTJVixyNL9npB/K2vUyC4ky\n\tsS+09FLmbWaKstwxyj2DG/nBLjWUCXMwQXqIfy/sGM6vhzO9vdsB8ggmZeu2nPtb7T\n\tzXnJnmJ6k7ahFlJzHCrmLL5SH49AI6u/T02HLEnM=","Date":"Wed, 20 Nov 2024 15:44:29 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org, jacopo.mondi@ideasonboard.com,\n\tnaush@raspberrypi.com, david.plowman@raspberrypi.com","Subject":"Re: [PATCH v3 7/8] gstreamer: Generate the new AEGC controls","Message-ID":"<20241120134429.GS12409@pendragon.ideasonboard.com>","References":"<20241113131256.3170817-1-paul.elder@ideasonboard.com>\n\t<20241113131256.3170817-8-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241113131256.3170817-8-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]