[{"id":32309,"web_url":"https://patchwork.libcamera.org/comment/32309/","msgid":"<20241120134811.GU12409@pendragon.ideasonboard.com>","date":"2024-11-20T13:48:11","subject":"Re: [PATCH v3 4/8] test: ipa_data_serialization: Use\n\tExposureTimeMode","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Nov 13, 2024 at 10:12:52PM +0900, Paul Elder wrote:\n> From: Jacopo Mondi \n> \n> Replace the deprecated AeEnable control with ExposureTimeMode\n> in ipa_data_serialization test.\n> \n> Signed-off-by: Jacopo Mondi \n> Signed-off-by: Paul Elder \n> Reviewed-by: Paul Elder \n> \n> ---\n> No change in v3\n> ---\n> test/serialization/ipa_data_serializer_test.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/test/serialization/ipa_data_serializer_test.cpp b/test/serialization/ipa_data_serializer_test.cpp\n> index aea63c73187e..1ec8b2b469b4 100644\n> --- a/test/serialization/ipa_data_serializer_test.cpp\n> +++ b/test/serialization/ipa_data_serializer_test.cpp\n> @@ -29,7 +29,7 @@ using namespace std;\n> using namespace libcamera;\n> \n> static const ControlInfoMap Controls = ControlInfoMap({\n> -\t\t{ &controls::AeEnable, ControlInfo(false, true) },\n> +\t\t{ &controls::ExposureTimeMode, ControlInfo(false, true) },\n\nThe ExposureTimeMode control is an enum, not a boolean control.\n\nYou could use AwbEnable instead, although that may disappear in the\nfuture as it gets reworked in a similar way as the AGC controls.\nDebugMetadataEnable is another option.\n\n> \t\t{ &controls::ExposureTime, ControlInfo(0, 999999) },\n> \t\t{ &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) },\n> \t\t{ &controls::ColourGains, ControlInfo(0.0f, 32.0f) },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E52F6C0F2A\n\tfor ;\n\tWed, 20 Nov 2024 13:48:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F1AAF65F56;\n\tWed, 20 Nov 2024 14:48:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D2F5A65904\n\tfor ;\n\tWed, 20 Nov 2024 14:48:20 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 42BFD75A;\n\tWed, 20 Nov 2024 14:48:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Lg8G7/NH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732110482;\n\tbh=Txdk7ErbPera7wSKKyzIUWWLioLAIn0NWOLVtZ6nT7Q=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Lg8G7/NHryJJTFoYJ3aFCB26GSkLppm0l06aAw4DJtNstwV4aE0PKMpRHYRwUqEUa\n\tr2qaXjzdXpB218G+WZEtI8vfCPdlczELFPEB2bowT65anZoGYvm8zQksSj2boQhxFP\n\tbhjHGIDfUk1tmZcVvKJgpr1wwa11UKoLBMjYJCcw=","Date":"Wed, 20 Nov 2024 15:48:11 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org, jacopo.mondi@ideasonboard.com,\n\tnaush@raspberrypi.com, david.plowman@raspberrypi.com,\n\tJacopo Mondi ","Subject":"Re: [PATCH v3 4/8] test: ipa_data_serialization: Use\n\tExposureTimeMode","Message-ID":"<20241120134811.GU12409@pendragon.ideasonboard.com>","References":"<20241113131256.3170817-1-paul.elder@ideasonboard.com>\n\t<20241113131256.3170817-5-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241113131256.3170817-5-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]