[{"id":2899,"web_url":"https://patchwork.libcamera.org/comment/2899/","msgid":"<20191015001821.GE5976@bigcity.dyn.berto.se>","date":"2019-10-15T00:18:21","subject":"Re: [libcamera-devel] [PATCH 05/10] test: v4l2_videodevice:\n\tcontrols: Use correct control range in check","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your fix.\n\nOn 2019-10-14 02:27:51 +0300, Laurent Pinchart wrote:\n> A value check on the V4L2_CID_CONTRAST control is using the brightness\n> control range. Fix it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> test/v4l2_videodevice/controls.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/test/v4l2_videodevice/controls.cpp b/test/v4l2_videodevice/controls.cpp\n> index e59387ab9eba..3add6e67d2cf 100644\n> --- a/test/v4l2_videodevice/controls.cpp\n> +++ b/test/v4l2_videodevice/controls.cpp\n> @@ -87,7 +87,7 @@ protected:\n> \t\t}\n> \n> \t\tif (ctrls.get(V4L2_CID_BRIGHTNESS) != brightness.range().min() ||\n> -\t\t ctrls.get(V4L2_CID_CONTRAST) != brightness.range().max() ||\n> +\t\t ctrls.get(V4L2_CID_CONTRAST) != contrast.range().max() ||\n> \t\t ctrls.get(V4L2_CID_SATURATION) != saturation.range().min().get() + 1) {\n> \t\t\tcerr << \"Controls not updated when set\" << endl;\n> \t\t\treturn TestFail;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E73ED600F9\n\tfor ;\n\tTue, 15 Oct 2019 02:18:22 +0200 (CEST)","by mail-lj1-x243.google.com with SMTP id 7so18323002ljw.7\n\tfor ;\n\tMon, 14 Oct 2019 17:18:22 -0700 (PDT)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tb19sm4638009lji.41.2019.10.14.17.18.21\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 14 Oct 2019 17:18:21 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=ruaX686umjOxsbBpZjLBk6llDJM6kKcqrtwqNqc1cx8=;\n\tb=qsGESBDLOA6+8WpURoKjVB1+uAVeaRUV4b+aSCwUMAUW4OGFLyme6j7ebZVuZlFZAD\n\t5mdsU1kzOXx5iGlCFD/qHkoTJ3+XKfwRhsqS8sdBPikq6ads0fjhF2gksCekEs0a1S/M\n\tgQlB53SdTM0+297lkRAD1EzESrPxifMGq4DSUufmnDeJkNH2Mw0cBvsvpsasUifvNUIM\n\tCCwJroogeSmMY9ykZXtSgLmR/60i2XUFLd8GqBN1CRK6OEft0MxKCuShd+jtSGAGOFsO\n\tf6oIqIx6t9qLxBNjQv3nHwNMuLocgFQDb9AmNhoM9989vsGVi2UvEWr+0DPI1yeuPDpw\n\twghQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=ruaX686umjOxsbBpZjLBk6llDJM6kKcqrtwqNqc1cx8=;\n\tb=YhQhl5yyshrX0dAhwh2XFfrbdirktIS/1hZUeuP4f9hszEWUDWHcBmfP50Dsyp90Ne\n\tuUFuU0te7epBytXyi1vnkCxnxNqKKbLGiw6Hwm2f5Dn8lpScBdfKOo3Y+jR6cwNxnSlS\n\tNUQA2f7PoQ+/aZzopeoZ2ORSFFZY4Ed8qiB4zuNGfbTpVRpK9LoyqXZfGDDNjtv6ziAj\n\tkJIWjYGLIOtglh/P814IErBG5N/8D4XtRq4sBvxu/wiLM59VURBP+QOc6AtFJR69+bP7\n\tVhol0J50m8U9h2Hy6XR6IzZQiUdQ/n5KVEeBGrA0KAuJTDTA6NcN/Hg8BK/FNfmipumR\n\tXbAw==","X-Gm-Message-State":"APjAAAXtI1FpIT9e/v6D2O4bFUjNUINB4HhYj+Z1uYHi5ZCsNhwuputr\n\tEf+zgFVMkin3MBojv8XAkW2g0CHJ+Vo=","X-Google-Smtp-Source":"APXvYqxPQV/B0hb8vStf380UWOq+Pb9kkUV7fG107R5/K7CzMvxQtquICrpyILRq0gcTmD/X5CQGNg==","X-Received":"by 2002:a05:651c:1031:: with SMTP id\n\tw17mr20227316ljm.38.1571098702393; \n\tMon, 14 Oct 2019 17:18:22 -0700 (PDT)","Date":"Tue, 15 Oct 2019 02:18:21 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191015001821.GE5976@bigcity.dyn.berto.se>","References":"<20191013232755.3292-1-laurent.pinchart@ideasonboard.com>\n\t<20191013232755.3292-6-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191013232755.3292-6-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH 05/10] test: v4l2_videodevice:\n\tcontrols: Use correct control range in check","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 15 Oct 2019 00:18:23 -0000"}},{"id":2916,"web_url":"https://patchwork.libcamera.org/comment/2916/","msgid":"<20191015151648.jqqxwpwhxgfuz5d4@uno.localdomain>","date":"2019-10-15T15:16:48","subject":"Re: [libcamera-devel] [PATCH 05/10] test: v4l2_videodevice:\n\tcontrols: Use correct control range in check","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Oct 14, 2019 at 02:27:51AM +0300, Laurent Pinchart wrote:\n> A value check on the V4L2_CID_CONTRAST control is using the brightness\n> control range. Fix it.\n>\n\nOuch! Thanks for fixing\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> test/v4l2_videodevice/controls.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/test/v4l2_videodevice/controls.cpp b/test/v4l2_videodevice/controls.cpp\n> index e59387ab9eba..3add6e67d2cf 100644\n> --- a/test/v4l2_videodevice/controls.cpp\n> +++ b/test/v4l2_videodevice/controls.cpp\n> @@ -87,7 +87,7 @@ protected:\n> \t\t}\n>\n> \t\tif (ctrls.get(V4L2_CID_BRIGHTNESS) != brightness.range().min() ||\n> -\t\t ctrls.get(V4L2_CID_CONTRAST) != brightness.range().max() ||\n> +\t\t ctrls.get(V4L2_CID_CONTRAST) != contrast.range().max() ||\n> \t\t ctrls.get(V4L2_CID_SATURATION) != saturation.range().min().get() + 1) {\n> \t\t\tcerr << \"Controls not updated when set\" << endl;\n> \t\t\treturn TestFail;\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 83BEE61562\n\tfor ;\n\tTue, 15 Oct 2019 17:15:00 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 2F67F40016;\n\tTue, 15 Oct 2019 15:15:00 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Tue, 15 Oct 2019 17:16:48 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191015151648.jqqxwpwhxgfuz5d4@uno.localdomain>","References":"<20191013232755.3292-1-laurent.pinchart@ideasonboard.com>\n\t<20191013232755.3292-6-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"2mni2xhlp6sty4yy\"","Content-Disposition":"inline","In-Reply-To":"<20191013232755.3292-6-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 05/10] test: v4l2_videodevice:\n\tcontrols: Use correct control range in check","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 15 Oct 2019 15:15:00 -0000"}}]