[{"id":32113,"web_url":"https://patchwork.libcamera.org/comment/32113/","msgid":"<20241112065603.GE5877@pendragon.ideasonboard.com>","date":"2024-11-12T06:56:03","subject":"Re: [PATCH v3 03/11] include: linux: Add Mali-C55 Stats and Params\n\tV4L2 format","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dan,\n\nThank you for the patch.\n\nOn Thu, Nov 07, 2024 at 11:48:11AM +0000, Daniel Scally wrote:\n> Add the new format describing the Mali C55's Statistics and Parameters\n> to videodev2.\n\nPlease indicate where this comes from (with a link to the corresponding\nC55 driver patch series). Also, same comment as for '[PATCH v5 07/13]\ninclude: media-bus-formats: Add Mali-C55 mbus codes', please explain in\nthe commit message that these manual changes are temporary, until the\nC55 kernel driver gets merged, at which point the media bus codes will\nbe provided by upstream kernel headers.\n\nWith that,\n\nReviewed-by: Laurent Pinchart \n\n> Acked-by: Kieran Bingham \n> Acked-by: Nayden Kanchev \n> Co-developed-by: Jacopo Mondi \n> Signed-off-by: Jacopo Mondi \n> Signed-off-by: Daniel Scally \n> ---\n> Changes in v2:\n> \n> \t- None\n> \n> Changes in v3:\n> \n> \t- None\n> \n> include/linux/videodev2.h | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h\n> index 3829c0b6..d2653b2e 100644\n> --- a/include/linux/videodev2.h\n> +++ b/include/linux/videodev2.h\n> @@ -840,6 +840,9 @@ struct v4l2_pix_format {\n> /* The metadata format identifier for FE stats buffers. */\n> #define V4L2_META_FMT_RPI_FE_STATS v4l2_fourcc('R', 'P', 'F', 'S')\n> \n> +#define V4L2_META_FMT_MALI_C55_PARAMS\tv4l2_fourcc('C', '5', '5', 'P') /* ARM Mali-C55 Parameters */\n> +#define V4L2_META_FMT_MALI_C55_3A_STATS v4l2_fourcc('C', '5', '5', 'S') /* ARM Mali-C55 3A Statistics */\n> +\n> /* priv field value to indicates that subsequent fields are valid. */\n> #define V4L2_PIX_FMT_PRIV_MAGIC\t\t0xfeedcafe\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 69A62C324C\n\tfor ;\n\tTue, 12 Nov 2024 06:56:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A8FCB657E2;\n\tTue, 12 Nov 2024 07:56:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2BF03618BE\n\tfor ;\n\tTue, 12 Nov 2024 07:56:12 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 76CB36AF;\n\tTue, 12 Nov 2024 07:55:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZhwcY5Nt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731394559;\n\tbh=6iO+PrqCFtMx44yRLEInkjHKOrevljkuWK2TbTEQf/0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZhwcY5Nt5amnO1tL/7gk11G5ovTOF9+3rljfAjEMLZd2GdCsBiY9da5+yZmJc2yXX\n\tleRtss/yZm6q5Dmre37cUhigCVI8GknVwuaXVXgHZdRnsaZo9iwZKxJ3LXP7E1RFtS\n\tRzwXtuidi/wlCU36ttMLEG0ktQgw0wDmzdQVAGQw=","Date":"Tue, 12 Nov 2024 08:56:03 +0200","From":"Laurent Pinchart ","To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org, Anthony.McGivern@arm.com,\n\tKieran Bingham ,\n\tNayden Kanchev ,\n\tJacopo Mondi ","Subject":"Re: [PATCH v3 03/11] include: linux: Add Mali-C55 Stats and Params\n\tV4L2 format","Message-ID":"<20241112065603.GE5877@pendragon.ideasonboard.com>","References":"<20241107114819.57599-1-dan.scally@ideasonboard.com>\n\t<20241107114819.57599-4-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241107114819.57599-4-dan.scally@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]