[{"id":2897,"web_url":"https://patchwork.libcamera.org/comment/2897/","msgid":"<20191015001242.GC5976@bigcity.dyn.berto.se>","date":"2019-10-15T00:12:42","subject":"Re: [libcamera-devel] [PATCH 03/10] libcamera: controls: Prevent\n\tcopies of ControlId class","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-10-14 02:27:49 +0300, Laurent Pinchart wrote:\n> Now that the V4L2ControlId embedded in V4L2ControlInfo has been moved\n> out and doesn't require to be copied anymore, the base ControlId class\n> doesn't need to be copyable either. Delete the ControlId copy\n> constructor and copy assignment operator.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/controls.h | 7 +++----\n> 1 file changed, 3 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index ebc4204f98fd..5534a2edb567 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -68,12 +68,11 @@ protected:\n> \t\t: id_(id), name_(name), type_(type)\n> \t{\n> \t}\n> -#ifndef __DOXYGEN__\n> -\tControlId &operator=(const ControlId &) = default;\n> -\tControlId(const ControlId &) = default;\n> -#endif\n> \n> private:\n> +\tControlId &operator=(const ControlId &) = delete;\n> +\tControlId(const ControlId &) = delete;\n> +\n> \tunsigned int id_;\n> \tstd::string name_;\n> \tControlType type_;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8EA5F600F9\n\tfor ;\n\tTue, 15 Oct 2019 02:12:43 +0200 (CEST)","by mail-lj1-x243.google.com with SMTP id f5so18316581ljg.8\n\tfor ;\n\tMon, 14 Oct 2019 17:12:43 -0700 (PDT)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\t202sm4624417ljf.75.2019.10.14.17.12.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 14 Oct 2019 17:12:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=E1Wp6GnQxB4AHpNqnAT/oVOtIKiC5zCEqH840/LxZnA=;\n\tb=bbFLxa+c07GB7masqRU3ASIW8wKhG8z7vAhSlnhbApxnAi7T2zcsPjhMDboaoyUTFJ\n\tOL8K2U+9gjXef6iK8vf0o7VXaUaJQu3t+mTExs9Om5AeKWPpK6K0t+Y5IrbOmAxr/75i\n\t9jxD6+VTbggo3ITDb0+HRKap7uWvH06BY5bJkDDoBZVBRRW+6amLTGX1LXPDigUnZBs6\n\tI1Wp8dc8UfdBQhK93h8RWneOp8h6ZBL7dJZDBK7jVEkckLLLXLLgGCzcab0quuxQSVti\n\tLflICrJwSFO1p37tJw9zczScHoHQhXOtXLMS6WliRPxiTgp6QB1na2kTUNYqW6HG2Jcg\n\tfDRQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=E1Wp6GnQxB4AHpNqnAT/oVOtIKiC5zCEqH840/LxZnA=;\n\tb=gD2w3PP9eALovTvgQjej4KY49Sm9+0lNGmTx6I4QxijPiuY+7XGQFMz+FNali/wldG\n\t4LElDNMI+FbQkkKuvmzUeI55RzZFIQdn+ZUfvVIl0FaEvBnRvnzBem4jFIIalPLh6OES\n\taiRPhY+vKzHWcJ0NR62PhHp48X4jAzSsoAi80dUL4uBoGClZenW3CgHyltyXqN5WHigp\n\tqbGGPcy2Qq0vKdh1+NsOICqV7/p99B149FtsKe70GWcPldsyPWIj+f0SAMaineVXmBKt\n\t1do6PWx7RVR1bDoq3ZsbejqfJN89wkjDd0VbFVC8JE0VIR8oHW3SoWvwH7yVN/SUhmpA\n\t86cA==","X-Gm-Message-State":"APjAAAUKlWCvqUwYfAHQP6xtv8iM9K7LFwwvm5XE6hg+nN8KFkp2Czb+\n\twsq0/QVZ62t8JHwjV01JSAV9awqEgJo=","X-Google-Smtp-Source":"APXvYqxISJlHkIOqif8S+GqsdKd9KxBQIlukCvPOjstzFjEGXTc2CzVdQ6d5X3QCDmOlwR2i9FvPRg==","X-Received":"by 2002:a2e:8793:: with SMTP id\n\tn19mr9962150lji.139.1571098363021; \n\tMon, 14 Oct 2019 17:12:43 -0700 (PDT)","Date":"Tue, 15 Oct 2019 02:12:42 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191015001242.GC5976@bigcity.dyn.berto.se>","References":"<20191013232755.3292-1-laurent.pinchart@ideasonboard.com>\n\t<20191013232755.3292-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191013232755.3292-4-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH 03/10] libcamera: controls: Prevent\n\tcopies of ControlId class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 15 Oct 2019 00:12:43 -0000"}},{"id":2912,"web_url":"https://patchwork.libcamera.org/comment/2912/","msgid":"<20191015145558.nmvu533gxbsoktzg@uno.localdomain>","date":"2019-10-15T14:55:58","subject":"Re: [libcamera-devel] [PATCH 03/10] libcamera: controls: Prevent\n\tcopies of ControlId class","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Oct 14, 2019 at 02:27:49AM +0300, Laurent Pinchart wrote:\n> Now that the V4L2ControlId embedded in V4L2ControlInfo has been moved\n> out and doesn't require to be copied anymore, the base ControlId class\n> doesn't need to be copyable either. Delete the ControlId copy\n> constructor and copy assignment operator.\n\nSeems good!\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/controls.h | 7 +++----\n> 1 file changed, 3 insertions(+), 4 deletions(-)\n>\n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index ebc4204f98fd..5534a2edb567 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -68,12 +68,11 @@ protected:\n> \t\t: id_(id), name_(name), type_(type)\n> \t{\n> \t}\n> -#ifndef __DOXYGEN__\n> -\tControlId &operator=(const ControlId &) = default;\n> -\tControlId(const ControlId &) = default;\n> -#endif\n>\n> private:\n> +\tControlId &operator=(const ControlId &) = delete;\n> +\tControlId(const ControlId &) = delete;\n> +\n> \tunsigned int id_;\n> \tstd::string name_;\n> \tControlType type_;\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E103E61562\n\tfor ;\n\tTue, 15 Oct 2019 16:54:14 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 77268C0003;\n\tTue, 15 Oct 2019 14:54:14 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Tue, 15 Oct 2019 16:55:58 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191015145558.nmvu533gxbsoktzg@uno.localdomain>","References":"<20191013232755.3292-1-laurent.pinchart@ideasonboard.com>\n\t<20191013232755.3292-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"fi3bvnwkuhapeimm\"","Content-Disposition":"inline","In-Reply-To":"<20191013232755.3292-4-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 03/10] libcamera: controls: Prevent\n\tcopies of ControlId class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 15 Oct 2019 14:54:15 -0000"}}]