{"id":21844,"url":"https://patchwork.libcamera.org/api/patches/21844/?format=json","web_url":"https://patchwork.libcamera.org/patch/21844/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241107105846.52287-12-dan.scally@ideasonboard.com>","date":"2024-11-07T10:58:44","name":"[v5,11/13] libcamera: mali-c55: Enable links between resizer and video node","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c12fcd0825f9e12ba809a4b7f3ff73a0f2e8c58b","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21844/mbox/","series":[{"id":4776,"url":"https://patchwork.libcamera.org/api/series/4776/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4776","date":"2024-11-07T10:58:33","name":"Miscellaneous Mali-C55 Pipeline Fixes","version":5,"mbox":"https://patchwork.libcamera.org/series/4776/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21844/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21844/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80982C330B\n\tfor ;\n\tThu, 7 Nov 2024 10:59:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F404765485;\n\tThu, 7 Nov 2024 11:59:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E58E76547F\n\tfor ;\n\tThu, 7 Nov 2024 11:58:57 +0100 (CET)","from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BA7651890;\n\tThu, 7 Nov 2024 11:58:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MjuiAsLx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730977128;\n\tbh=1BWGNjNH+ArkioShSA1zbZVIsnJfSG1BVW5CkmaxX6Y=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=MjuiAsLxZzwbA4yagS/EfDfpmr7c1NVDe+Xdlu2Kz+vEJAYrDqAsOe9EsKMbqgCYM\n\tVcozw74f6CE0NITbfR0pzLaJauxhMe2ZvVut2bI2Zxw17VUm3HenweaY4wSXqyM25M\n\t4r4t4VqX52K9u7V2aADBLW/KtvJtNCTt9jO9DGVc=","From":"Daniel Scally ","To":"libcamera-devel@lists.libcamera.org","Cc":"Daniel Scally ,\n\tKieran Bingham ","Subject":"[PATCH v5 11/13] libcamera: mali-c55: Enable links between resizer\n\tand video node","Date":"Thu, 7 Nov 2024 10:58:44 +0000","Message-Id":"<20241107105846.52287-12-dan.scally@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20241107105846.52287-1-dan.scally@ideasonboard.com>","References":"<20241107105846.52287-1-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The mali-c55 driver now expects links to video devices to be enabled\nin order for those devices to be streamed from / to. Enable the media\nlink between the resizers and their associated video device to fulfil\nthe requirement.\n\nReviewed-by: Kieran Bingham \nSigned-off-by: Daniel Scally \n---\nChanges in v5:\n\n\t- None\n\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 11 +++++++++++\n 1 file changed, 11 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 97827abd..b00cbce5 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -834,6 +834,17 @@ int PipelineHandlerMaliC55::configure(Camera *camera,\n \t\tStream *stream = streamConfig.stream();\n \t\tMaliC55Pipe *pipe = pipeFromStream(data, stream);\n \n+\t\t/*\n+\t\t * Enable the media link between the pipe's resizer and the\n+\t\t * capture video device\n+\t\t */\n+\t\tconst MediaEntity *rszEntity = pipe->resizer->entity();\n+\t\tret = rszEntity->getPadByIndex(1)->links()[0]->setEnabled(true);\n+\t\tif (ret) {\n+\t\t\tLOG(MaliC55, Error) << \"Couldn't enable resizer's link\";\n+\t\t\treturn ret;\n+\t\t}\n+\n \t\tif (isFormatRaw(streamConfig.pixelFormat))\n \t\t\tret = configureRawStream(data, streamConfig, subdevFormat);\n \t\telse\n","prefixes":["v5","11/13"]}