{"id":21837,"url":"https://patchwork.libcamera.org/api/patches/21837/?format=json","web_url":"https://patchwork.libcamera.org/patch/21837/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241107105846.52287-5-dan.scally@ideasonboard.com>","date":"2024-11-07T10:58:37","name":"[v5,04/13] libcamera: mali-c55: Simplify bufferReady()","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9c8ac22179241956c6f87fbeeef692ede126f6b6","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21837/mbox/","series":[{"id":4776,"url":"https://patchwork.libcamera.org/api/series/4776/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4776","date":"2024-11-07T10:58:33","name":"Miscellaneous Mali-C55 Pipeline Fixes","version":5,"mbox":"https://patchwork.libcamera.org/series/4776/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21837/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21837/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 862F9BE173\n\tfor ;\n\tThu, 7 Nov 2024 10:59:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5FE6B65480;\n\tThu, 7 Nov 2024 11:58:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 277466546A\n\tfor ;\n\tThu, 7 Nov 2024 11:58:55 +0100 (CET)","from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 361E7A47;\n\tThu, 7 Nov 2024 11:58:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Lqf34TAw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730977126;\n\tbh=TZXN9wNPr2IgJJm1mjh+s8JFocnhUPvisAH+/FsdMo4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Lqf34TAwcxYcaYzo9069XJvhAIIYLhSK3XgWOLwSZqBfC3Tx5Viop1YOT4jqRcKfv\n\tk2MW6aUgicQT5iD8chPNhm+ekhE1JD45JIu04dpyh6ovelBN1peFDJu4UDZm1rM8GH\n\twURMJ0aSfsGHeCWxx80h/hsxPOXydr1HG9I3H7p8=","From":"Daniel Scally ","To":"libcamera-devel@lists.libcamera.org","Cc":"Daniel Scally ,\n\tJacopo Mondi ,\n\tKieran Bingham ,\n\tLaurent Pinchart ","Subject":"[PATCH v5 04/13] libcamera: mali-c55: Simplify bufferReady()","Date":"Thu, 7 Nov 2024 10:58:37 +0000","Message-Id":"<20241107105846.52287-5-dan.scally@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20241107105846.52287-1-dan.scally@ideasonboard.com>","References":"<20241107105846.52287-1-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The PipelineHandler::completeBuffer() base class function returns\na boolean to indicate if there still are pending buffers in the\nRequest.\n\nSimplify the bufferReady() function in the Mali-C55 pipeline handler\nusing the completeBuffer() return value.\n\nSigned-off-by: Daniel Scally \nSigned-off-by: Jacopo Mondi \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\nChanges in v5:\n\n\t- None\n\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 8 ++------\n 1 file changed, 2 insertions(+), 6 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex bffd842c..12e32f23 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -894,12 +894,8 @@ void PipelineHandlerMaliC55::bufferReady(FrameBuffer *buffer)\n {\n \tRequest *request = buffer->request();\n \n-\tcompleteBuffer(request, buffer);\n-\n-\tif (request->hasPendingBuffers())\n-\t\treturn;\n-\n-\tcompleteRequest(request);\n+\tif (completeBuffer(request, buffer))\n+\t\tcompleteRequest(request);\n }\n \n void PipelineHandlerMaliC55::registerMaliCamera(std::unique_ptr data,\n","prefixes":["v5","04/13"]}