{"id":21829,"url":"https://patchwork.libcamera.org/api/patches/21829/?format=json","web_url":"https://patchwork.libcamera.org/patch/21829/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241107102508.48322-4-dan.scally@ideasonboard.com>","date":"2024-11-07T10:25:05","name":"[v2,3/6] ipa: rkisp1: Use centralised libipa helpers","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"8d2836efd91f2531cefae7db8396c1eb43b75cb5","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/?format=json","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21829/mbox/","series":[{"id":4775,"url":"https://patchwork.libcamera.org/api/series/4775/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4775","date":"2024-11-07T10:25:03","name":"Centralise common functions in IPA modules","version":2,"mbox":"https://patchwork.libcamera.org/series/4775/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21829/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21829/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B7E58C324E\n\tfor ;\n\tThu, 7 Nov 2024 10:25:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C3736546A;\n\tThu, 7 Nov 2024 11:25:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B0D065461\n\tfor ;\n\tThu, 7 Nov 2024 11:25:25 +0100 (CET)","from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 35146A47;\n\tThu, 7 Nov 2024 11:25:16 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ArKqoVLS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730975116;\n\tbh=BwEUT8FYeYLXaHND3HTKt1hkwG1fTX2LYd7awR8CRiI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ArKqoVLSUFl2DlxXOh7ciilSrEFgnK1QGbt6pTOD7pKgIQA1HibwEvIJTiTXnxfbu\n\tmU/QnFC9RWQCAoYyieIfy5H4vh0++GwNMyhBGzKoWVFDAfBfYyzncrRZQgKrWgk6vI\n\t5JY2+AqMVjTiCRm6rdnqDL0beLlTFXzkofNxFvXM=","From":"Daniel Scally ","To":"libcamera-devel@lists.libcamera.org","Cc":"mike.rudenko@gmail.com, Daniel Scally ,\n\tJacopo Mondi ","Subject":"[PATCH v2 3/6] ipa: rkisp1: Use centralised libipa helpers","Date":"Thu, 7 Nov 2024 10:25:05 +0000","Message-Id":"<20241107102508.48322-4-dan.scally@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20241107102508.48322-1-dan.scally@ideasonboard.com>","References":"<20241107102508.48322-1-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use the centralised libipa helpers instead of open-coding common\nfunctions.\n\nReviewed-by: Jacopo Mondi \nSigned-off-by: Daniel Scally \n---\nChanges in v2:\n\n\t- Dropped the ipa:: prefix for function calls\n\n src/ipa/rkisp1/algorithms/awb.cpp | 18 ++----------------\n src/ipa/rkisp1/algorithms/awb.h | 2 --\n 2 files changed, 2 insertions(+), 18 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex b3c00bef..b8cdfa91 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -16,6 +16,8 @@\n \n #include \n \n+#include \"libipa/helpers.h\"\n+\n /**\n * \\file awb.h\n */\n@@ -178,22 +180,6 @@ void Awb::prepare(IPAContext &context, const uint32_t frame,\n \t}\n }\n \n-uint32_t Awb::estimateCCT(double red, double green, double blue)\n-{\n-\t/* Convert the RGB values to CIE tristimulus values (XYZ) */\n-\tdouble X = (-0.14282) * (red) + (1.54924) * (green) + (-0.95641) * (blue);\n-\tdouble Y = (-0.32466) * (red) + (1.57837) * (green) + (-0.73191) * (blue);\n-\tdouble Z = (-0.68202) * (red) + (0.77073) * (green) + (0.56332) * (blue);\n-\n-\t/* Calculate the normalized chromaticity values */\n-\tdouble x = X / (X + Y + Z);\n-\tdouble y = Y / (X + Y + Z);\n-\n-\t/* Calculate CCT */\n-\tdouble n = (x - 0.3320) / (0.1858 - y);\n-\treturn 449 * n * n * n + 3525 * n * n + 6823.3 * n + 5520.33;\n-}\n-\n /**\n * \\copydoc libcamera::ipa::Algorithm::process\n */\ndiff --git a/src/ipa/rkisp1/algorithms/awb.h b/src/ipa/rkisp1/algorithms/awb.h\nindex b3b2c0bb..6ac3a5c3 100644\n--- a/src/ipa/rkisp1/algorithms/awb.h\n+++ b/src/ipa/rkisp1/algorithms/awb.h\n@@ -32,8 +32,6 @@ public:\n \t\t ControlList &metadata) override;\n \n private:\n-\tuint32_t estimateCCT(double red, double green, double blue);\n-\n \tbool rgbMode_;\n };\n \n","prefixes":["v2","3/6"]}