[{"id":32025,"web_url":"https://patchwork.libcamera.org/comment/32025/","msgid":"<173080166804.3353069.17936706555702450813@ping.linuxembedded.co.uk>","date":"2024-11-05T10:14:28","subject":"Re: [PATCH 1/2] test: py: Replace environment array with environment\n\tobject","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-11-05 01:49:48)\n> The environment for pyunittests is stored in an array. Meson provides an\n> environment object, which makes handling of multi-value environment\n> variables easier and increases code clarity. Switch to using the\n> environment object.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> test/py/meson.build | 8 ++++++--\n> 1 file changed, 6 insertions(+), 2 deletions(-)\n> \n> diff --git a/test/py/meson.build b/test/py/meson.build\n> index 0b679d31ff34..481bb481c110 100644\n> --- a/test/py/meson.build\n> +++ b/test/py/meson.build\n> @@ -13,15 +13,19 @@ if asan_runtime_missing\n> subdir_done()\n> endif\n> \n> +py_env = environment()\n> +\n> pymod = import('python')\n> py3 = pymod.find_installation('python3')\n> \n> pypathdir = meson.project_build_root() / 'src' / 'py'\n> -py_env = ['PYTHONPATH=' + pypathdir]\n> +py_env.append('PYTHONPATH', pypathdir)\n> \n> if asan_enabled\n> + py_env.append('LD_PRELOAD', asan_runtime)\n> +\n> # Disable leak detection as the Python interpreter is full of leaks.\n> - py_env += ['LD_PRELOAD=' + asan_runtime, 'ASAN_OPTIONS=detect_leaks=0']\n> + py_env.append('ASAN_OPTIONS', 'detect_leaks=0')\n> endif\n\nThat looks cleaner:\n\n\nReviewed-by: Kieran Bingham \n\n> \n> test('pyunittests',\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 39694BE173\n\tfor ;\n\tTue, 5 Nov 2024 10:14:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 13AAB653EA;\n\tTue, 5 Nov 2024 11:14:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 84A0B6035B\n\tfor ;\n\tTue, 5 Nov 2024 11:14:33 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7D2C422E;\n\tTue, 5 Nov 2024 11:14:25 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sgm3m3Qo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730801665;\n\tbh=iRTNPAd+o7sV1yJKY+lscT9apsEnCCyRWiRvp0UC7hs=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=sgm3m3QomGiWj/R0uuPaReBfPHV1pSxhndcQ2Cu+1qLz6m4lrAEODTKCNwFAfxtmV\n\tccKomMtdE3gCaT1+zCKeOnf/X5Ul7srOu1GWpDAa+lIaQELzuIiUavX3U2MBSFMVaK\n\tX+XqEBoVUNOESofQQJ91CLhQdww9KM92Gygawx/U=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241105014949.32244-2-laurent.pinchart@ideasonboard.com>","References":"<20241105014949.32244-1-laurent.pinchart@ideasonboard.com>\n\t<20241105014949.32244-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH 1/2] test: py: Replace environment array with environment\n\tobject","From":"Kieran Bingham ","Cc":"Tomi Valkeinen ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 05 Nov 2024 10:14:28 +0000","Message-ID":"<173080166804.3353069.17936706555702450813@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]