[{"id":32016,"web_url":"https://patchwork.libcamera.org/comment/32016/","msgid":"<87wmhivo8i.fsf@redhat.com>","date":"2024-11-04T18:38:05","subject":"Re: [PATCH 3/8] libcamera: swstats_cpu: Move header to\n\tlibcamera/internal/software_isp","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hans de Goede writes:\n\n> Move the swstats_cpu.h file to include/libcamera/internal/software_isp/\n> so that it can be used outside the src/libcamera/software_isp/ directory.\n>\n> Signed-off-by: Hans de Goede \n\nReviewed-by: Milan Zamazal \n\n> ---\n> include/libcamera/internal/software_isp/meson.build | 1 +\n> .../libcamera/internal}/software_isp/swstats_cpu.h | 0\n> src/libcamera/software_isp/debayer_cpu.h | 2 +-\n> src/libcamera/software_isp/swstats_cpu.cpp | 2 +-\n> 4 files changed, 3 insertions(+), 2 deletions(-)\n> rename {src/libcamera => include/libcamera/internal}/software_isp/swstats_cpu.h (100%)\n>\n> diff --git a/include/libcamera/internal/software_isp/meson.build b/include/libcamera/internal/software_isp/meson.build\n> index 508ddddc..ea3f3f1c 100644\n> --- a/include/libcamera/internal/software_isp/meson.build\n> +++ b/include/libcamera/internal/software_isp/meson.build\n> @@ -4,4 +4,5 @@ libcamera_internal_headers += files([\n> 'debayer_params.h',\n> 'software_isp.h',\n> 'swisp_stats.h',\n> + 'swstats_cpu.h',\n> ])\n> diff --git a/src/libcamera/software_isp/swstats_cpu.h b/include/libcamera/internal/software_isp/swstats_cpu.h\n> similarity index 100%\n> rename from src/libcamera/software_isp/swstats_cpu.h\n> rename to include/libcamera/internal/software_isp/swstats_cpu.h\n> diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h\n> index 2c47e7c6..feb0452e 100644\n> --- a/src/libcamera/software_isp/debayer_cpu.h\n> +++ b/src/libcamera/software_isp/debayer_cpu.h\n> @@ -18,9 +18,9 @@\n> #include \n> \n> #include \"libcamera/internal/bayer_format.h\"\n> +#include \"libcamera/internal/software_isp/swstats_cpu.h\"\n> \n> #include \"debayer.h\"\n> -#include \"swstats_cpu.h\"\n> \n> namespace libcamera {\n> \n> diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\n> index 5e4246a9..aa5654dc 100644\n> --- a/src/libcamera/software_isp/swstats_cpu.cpp\n> +++ b/src/libcamera/software_isp/swstats_cpu.cpp\n> @@ -9,7 +9,7 @@\n> * CPU based software statistics implementation\n> */\n> \n> -#include \"swstats_cpu.h\"\n> +#include \"libcamera/internal/software_isp/swstats_cpu.h\"\n> \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C639BDB1C\n\tfor ;\n\tMon, 4 Nov 2024 18:38:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CB146653DF;\n\tMon, 4 Nov 2024 19:38:16 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AA4AC65399\n\tfor ;\n\tMon, 4 Nov 2024 19:38:14 +0100 (CET)","from mail-ej1-f69.google.com (mail-ej1-f69.google.com\n\t[209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-298-mnR1phtlNOK7cjAlQu5wFQ-1; Mon, 04 Nov 2024 13:38:10 -0500","by mail-ej1-f69.google.com with SMTP id\n\ta640c23a62f3a-a9a2a81ab82so352730966b.1\n\tfor ;\n\tMon, 04 Nov 2024 10:38:10 -0800 (PST)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-a9eb16a3b6esm15593866b.18.2024.11.04.10.38.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 04 Nov 2024 10:38:06 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"WJMff8sC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1730745493;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=WTxQSF5JYTqpUxF67XX/B1JAFt+IgAWG8WxwAdjbX6o=;\n\tb=WJMff8sCoQv7DcwlJEYSHAnKKlmahPvXMZIOHl3RwR3mhv3ssxTDWaBXetwzirxZawfNri\n\tc5fmrNCgtatKgS3T0cw1lowwyZCYYOBXyxVyD8y3VT4x3YC2C9cd1i5JcKEGmKscFb5+AN\n\tt4AAgi6imABog8V7GX3hhLULVv+D1yY=","X-MC-Unique":"mnR1phtlNOK7cjAlQu5wFQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1730745488; x=1731350288;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=WTxQSF5JYTqpUxF67XX/B1JAFt+IgAWG8WxwAdjbX6o=;\n\tb=BxbAm0HINF+1ql/1ynYwDYZvxKwY3iVBSMhUu7lawR39nZcm0g+YMhL+l2U5a+s1Aw\n\tVzTm6R4WWRnRln8wkKZhT9W7piKliOeQIs3gDb8GaWjVtqsn1etmVCqaJmK63HCCvOTm\n\tmPXlzbdhHbABT+a/caew94iTTPakr11BCWBQ+GkpBq9YnNibGhvrPY6UmP1AWXMaeXSe\n\tLvJ4W9juY0djVIepzXSSfUtpJ2jxm6XSOW4nLJXRoiAFYhC5lEZUKUkK4tJBuS3t3CMf\n\trIUGmGhx1s3SkAsJQr6Y3c2tcT3c9zqS5JlqsFAE8iEyBg18W1xzwllUvYyMMry89Epf\n\tjxug==","X-Gm-Message-State":"AOJu0YwlC2anH+LtX9kNn58LmLfVXqcMy6hWMGjZfN1r/dNf1j7foxPx\n\tFjtApYSBM4DrmTpSdYvvdW46d7NcPkCUWDi3WKl/KCpPpBgzzozQoiH/JTO39qiaHOWKBwk1sJh\n\thBWrEjLwn6lquozv2B6vFpzDZIhCCgLSr2wvNZ/DYKKQbxlMiWiFPL3Crm3ix7p7u2daMSjaiGG\n\tZTBFE=","X-Received":["by 2002:a17:907:9719:b0:a9a:67a9:dc45 with SMTP id\n\ta640c23a62f3a-a9de5d6eb93mr3388989366b.3.1730745487830; \n\tMon, 04 Nov 2024 10:38:07 -0800 (PST)","by 2002:a17:907:9719:b0:a9a:67a9:dc45 with SMTP id\n\ta640c23a62f3a-a9de5d6eb93mr3388986766b.3.1730745487342; \n\tMon, 04 Nov 2024 10:38:07 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IGIwVvQ7ivC6FbeJLBtuqGH9GJN3+RrY+n4q6b1LP4LaIU+5LvFmspMvYAsukJZG1BxS1qKeQ==","From":"Milan Zamazal ","To":"Hans de Goede ","Cc":"libcamera-devel@lists.libcamera.org, Maxime Ripard ","Subject":"Re: [PATCH 3/8] libcamera: swstats_cpu: Move header to\n\tlibcamera/internal/software_isp","In-Reply-To":"<20241103152205.29219-4-hdegoede@redhat.com> (Hans de Goede's\n\tmessage of \"Sun, 3 Nov 2024 16:22:00 +0100\")","References":"<20241103152205.29219-1-hdegoede@redhat.com>\n\t<20241103152205.29219-4-hdegoede@redhat.com>","Date":"Mon, 04 Nov 2024 19:38:05 +0100","Message-ID":"<87wmhivo8i.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]