[{"id":32001,"web_url":"https://patchwork.libcamera.org/comment/32001/","msgid":"<6l2rcfpbaq54nvajpkhnqthcug5ixhw4ghoptukt66hscopwh4@tqe4wsckdmdo>","date":"2024-11-04T11:09:10","subject":"Re: [PATCH 4/6] ipa: rpi: Use centralised libipa helpers","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Dan\n\nOn Thu, Oct 31, 2024 at 04:07:39PM +0000, Daniel Scally wrote:\n> Use the centralised libipa helpers rather than open coding common\n> functions.\n>\n> Signed-off-by: Daniel Scally \n\nWith the ipa:: prefix dropped\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/ipa/rpi/controller/rpi/agc_channel.cpp | 10 ++++++----\n> 1 file changed, 6 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/ipa/rpi/controller/rpi/agc_channel.cpp b/src/ipa/rpi/controller/rpi/agc_channel.cpp\n> index c9df9b5b..0c8252a0 100644\n> --- a/src/ipa/rpi/controller/rpi/agc_channel.cpp\n> +++ b/src/ipa/rpi/controller/rpi/agc_channel.cpp\n> @@ -12,6 +12,8 @@\n>\n> #include \n>\n> +#include \"libipa/helpers.h\"\n> +\n> #include \"../awb_status.h\"\n> #include \"../device_status.h\"\n> #include \"../histogram.h\"\n> @@ -694,11 +696,11 @@ static double computeInitialY(StatisticsPtr &stats, AwbStatus const &awb,\n> \tdouble ySum;\n> \t/* Factor in the AWB correction if needed. */\n> \tif (stats->agcStatsPos == Statistics::AgcStatsPos::PreWb) {\n> -\t\tySum = rSum * awb.gainR * .299 +\n> -\t\t gSum * awb.gainG * .587 +\n> -\t\t bSum * awb.gainB * .114;\n> +\t\tySum = ipa::rec601LuminanceFromRGB(rSum * awb.gainR,\n> +\t\t\t\t\t\t gSum * awb.gainG,\n> +\t\t\t\t\t\t bSum * awb.gainB);\n> \t} else\n> -\t\tySum = rSum * .299 + gSum * .587 + bSum * .114;\n> +\t\tySum = ipa::rec601LuminanceFromRGB(rSum, gSum, bSum);\n>\n> \treturn ySum / pixelSum / (1 << 16);\n> }\n> --\n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 103A1BDB1C\n\tfor ;\n\tMon, 4 Nov 2024 11:09:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C00C2653CD;\n\tMon, 4 Nov 2024 12:09:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4FF1D653C6\n\tfor ;\n\tMon, 4 Nov 2024 12:09:13 +0100 (CET)","from ideasonboard.com (mob-5-90-48-188.net.vodafone.it\n\t[5.90.48.188])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9036522E;\n\tMon, 4 Nov 2024 12:09:06 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Fa0CSDV5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730718546;\n\tbh=sjipCLhciKQDK6rreuq8mahIM27hOG1znnSm9hRtNNA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Fa0CSDV5rfaLubD+zQ2+xi7E8EFVNXAujSInCVlGz5IOUf3rddg1EOoqhHKyHaw88\n\ts4/kYM53lcfP/b2DsziwvORTlDVuNlSBB58heXtWt2jgCL09tKCs2kjlXlXi6Jlr7a\n\tXgQ59aFEa5PbuBqhvkEbIB9RIZ3raEqUmmRMLmRI=","Date":"Mon, 4 Nov 2024 12:09:10 +0100","From":"Jacopo Mondi ","To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org, mike.rudenko@gmail.com","Subject":"Re: [PATCH 4/6] ipa: rpi: Use centralised libipa helpers","Message-ID":"<6l2rcfpbaq54nvajpkhnqthcug5ixhw4ghoptukt66hscopwh4@tqe4wsckdmdo>","References":"<20241031160741.253855-1-dan.scally@ideasonboard.com>\n\t<20241031160741.253855-5-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241031160741.253855-5-dan.scally@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]