{"id":21775,"url":"https://patchwork.libcamera.org/api/patches/21775/?format=json","web_url":"https://patchwork.libcamera.org/patch/21775/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241030163439.245035-1-stefan.klug@ideasonboard.com>","date":"2024-10-30T16:34:21","name":"media: imx283: Report correct V4L2_SEL_TGT_CROP","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"f860745b3f0648437d82bf14d0bfb7358896b865","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21775/mbox/","series":[{"id":4756,"url":"https://patchwork.libcamera.org/api/series/4756/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4756","date":"2024-10-30T16:34:21","name":"media: imx283: Report correct V4L2_SEL_TGT_CROP","version":1,"mbox":"https://patchwork.libcamera.org/series/4756/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21775/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21775/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EEBFCC3237\n\tfor ;\n\tWed, 30 Oct 2024 16:35:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 096AD65392;\n\tWed, 30 Oct 2024 17:35:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D68A965392\n\tfor ;\n\tWed, 30 Oct 2024 17:35:07 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:a7a3:a679:a325:f9b7])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8FEEB1083;\n\tWed, 30 Oct 2024 17:35:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QYofRV1r\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730306103;\n\tbh=8aIoP0AITAVflNZ02qtNP/BZx4ZXfd+7ncAMgQYji4Q=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=QYofRV1rnjD+1WphbZ8+WiiZBdtERciBx3EEzuCgTNLktQJWKGiRvLBN1k4whBX5f\n\tEVYgDph54PY2pesCNO7QqK0UHvw2riGrjN0YItiQEyFqdaqBi+MRkmHtveNdJTJlR+\n\tTQhOrUbKgM08mRuxst/Ac5qofHPlrD8aQBZgwxuQ=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org, linux-media@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Cc":"Stefan Klug ,\n\tSakari Ailus ,\n\tKieran Bingham ,\n\tUmang Jain ,\n\tMauro Carvalho Chehab ","Subject":"[PATCH] media: imx283: Report correct V4L2_SEL_TGT_CROP","Date":"Wed, 30 Oct 2024 17:34:21 +0100","Message-ID":"<20241030163439.245035-1-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The target crop rectangle is initialized with the crop of the default\nsensor mode. This is incorrect when a different sensor mode gets\nselected. Fix that by updating the crop rectangle when changing the\nsensor mode.\n\nSigned-off-by: Stefan Klug \n---\n drivers/media/i2c/imx283.c | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/drivers/media/i2c/imx283.c b/drivers/media/i2c/imx283.c\nindex 3174d5ffd2d7..c8863c9e0ccf 100644\n--- a/drivers/media/i2c/imx283.c\n+++ b/drivers/media/i2c/imx283.c\n@@ -1123,6 +1123,7 @@ static int imx283_set_pad_format(struct v4l2_subdev *sd,\n \t\t\t\t struct v4l2_subdev_state *sd_state,\n \t\t\t\t struct v4l2_subdev_format *fmt)\n {\n+\tstruct v4l2_rect *crop;\n \tstruct v4l2_mbus_framefmt *format;\n \tconst struct imx283_mode *mode;\n \tstruct imx283 *imx283 = to_imx283(sd);\n@@ -1149,6 +1150,9 @@ static int imx283_set_pad_format(struct v4l2_subdev *sd,\n \n \t*format = fmt->format;\n \n+\tcrop = v4l2_subdev_state_get_crop(sd_state, IMAGE_PAD);\n+\t*crop = mode->crop;\n+\n \treturn 0;\n }\n \n","prefixes":[]}