[{"id":32442,"web_url":"https://patchwork.libcamera.org/comment/32442/","msgid":"<74jus3f63a6hzyhaoa3evd3twhet73wauxf3gaoaz7jagscfzi@nd636f43pcpf>","date":"2024-11-28T17:39:23","subject":"Re: [PATCH v5 2/2] libcamera: Extend u16 control type","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Harvey\n\nOn Tue, Oct 29, 2024 at 04:07:13PM +0000, Harvey Yang wrote:\n> From: Yudhistira Erlandinata \n>\n> V4L2 Controls support a wide variety of types not yet supported by the\n> ControlValue type system.\n>\n> Extend the libcamera ControlValue types to support an explicit 16 bit\n> unsigned integer type, and map that to the corresponding\n> V4L2_CTRL_TYPE_U16 type within the v4l2_device support class.\n>\n> It's used on some camera metadata that is of length 16-bits,\n> for example JPEG metadata headers.\n>\n> Signed-off-by: Yudhistira Erlandinata \n> Co-developed-by: Harvey Yang \n> Signed-off-by: Harvey Yang \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> include/libcamera/controls.h | 7 ++++++\n> src/libcamera/controls.cpp | 8 +++++++\n> src/libcamera/v4l2_device.cpp | 28 +++++++++++++++++++++++\n> test/controls/control_value.cpp | 40 +++++++++++++++++++++++++++++++++\n> 4 files changed, 83 insertions(+)\n>\n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index 6da8ad2c3..162115bb5 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -29,6 +29,7 @@ enum ControlType {\n> \tControlTypeNone,\n> \tControlTypeBool,\n> \tControlTypeByte,\n> +\tControlTypeUnsigned16,\n> \tControlTypeUnsigned32,\n> \tControlTypeInteger32,\n> \tControlTypeInteger64,\n> @@ -63,6 +64,12 @@ struct control_type {\n> \tstatic constexpr std::size_t size = 0;\n> };\n>\n> +template<>\n> +struct control_type {\n> +\tstatic constexpr ControlType value = ControlTypeUnsigned16;\n> +\tstatic constexpr std::size_t size = 0;\n> +};\n> +\n> template<>\n> struct control_type {\n> \tstatic constexpr ControlType value = ControlTypeUnsigned32;\n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index 8ae295191..3a840bb22 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -54,6 +54,7 @@ static constexpr size_t ControlValueSize[] = {\n> \t[ControlTypeNone]\t\t= 0,\n> \t[ControlTypeBool]\t\t= sizeof(bool),\n> \t[ControlTypeByte]\t\t= sizeof(uint8_t),\n> +\t[ControlTypeUnsigned16]\t\t= sizeof(uint16_t),\n> \t[ControlTypeUnsigned32]\t\t= sizeof(uint32_t),\n> \t[ControlTypeInteger32]\t\t= sizeof(int32_t),\n> \t[ControlTypeInteger64]\t\t= sizeof(int64_t),\n> @@ -75,6 +76,8 @@ static constexpr size_t ControlValueSize[] = {\n> * The control stores a boolean value\n> * \\var ControlTypeByte\n> * The control stores a byte value as an unsigned 8-bit integer\n> + * \\var ControlTypeUnsigned16\n> + * The control stores an unsigned 16-bit integer value\n> * \\var ControlTypeUnsigned32\n> * The control stores an unsigned 32-bit integer value\n> * \\var ControlTypeInteger32\n> @@ -233,6 +236,11 @@ std::string ControlValue::toString() const\n> \t\t\tstr += std::to_string(*value);\n> \t\t\tbreak;\n> \t\t}\n> +\t\tcase ControlTypeUnsigned16: {\n> +\t\t\tconst uint16_t *value = reinterpret_cast(data);\n> +\t\t\tstr += std::to_string(*value);\n> +\t\t\tbreak;\n> +\t\t}\n> \t\tcase ControlTypeUnsigned32: {\n> \t\t\tconst uint32_t *value = reinterpret_cast(data);\n> \t\t\tstr += std::to_string(*value);\n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index 90fa6b278..f0c6fa63d 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -216,6 +216,13 @@ ControlList V4L2Device::getControls(const std::vector &ids)\n> \t\t\t\tv4l2Ctrl.p_u8 = data.data();\n> \t\t\t\tbreak;\n>\n> +\t\t\tcase V4L2_CTRL_TYPE_U16:\n> +\t\t\t\ttype = ControlTypeUnsigned16;\n> +\t\t\t\tvalue.reserve(type, true, info.elems);\n> +\t\t\t\tdata = value.data();\n> +\t\t\t\tv4l2Ctrl.p_u16 = reinterpret_cast(data.data());\n> +\t\t\t\tbreak;\n> +\n> \t\t\tcase V4L2_CTRL_TYPE_U32:\n> \t\t\t\ttype = ControlTypeUnsigned32;\n> \t\t\t\tvalue.reserve(type, true, info.elems);\n> @@ -307,6 +314,18 @@ int V4L2Device::setControls(ControlList *ctrls)\n> \t\t/* Set the v4l2_ext_control value for the write operation. */\n> \t\tControlValue &value = ctrl->second;\n> \t\tswitch (iter->first->type()) {\n> +\t\tcase ControlTypeUnsigned16: {\n> +\t\t\tif (value.isArray()) {\n> +\t\t\t\tSpan data = value.data();\n> +\t\t\t\tv4l2Ctrl.p_u16 = reinterpret_cast(data.data());\n> +\t\t\t\tv4l2Ctrl.size = data.size();\n> +\t\t\t} else {\n> +\t\t\t\tv4l2Ctrl.value = value.get();\n> +\t\t\t}\n> +\n> +\t\t\tbreak;\n> +\t\t}\n> +\n> \t\tcase ControlTypeUnsigned32: {\n> \t\t\tif (value.isArray()) {\n> \t\t\t\tSpan data = value.data();\n> @@ -508,6 +527,9 @@ ControlType V4L2Device::v4l2CtrlType(uint32_t ctrlType)\n> \tcase V4L2_CTRL_TYPE_BOOLEAN:\n> \t\treturn ControlTypeBool;\n>\n> +\tcase V4L2_CTRL_TYPE_U16:\n> +\t\treturn ControlTypeUnsigned16;\n> +\n> \tcase V4L2_CTRL_TYPE_U32:\n> \t\treturn ControlTypeUnsigned32;\n>\n> @@ -559,6 +581,11 @@ std::optional V4L2Device::v4l2ControlInfo(const v4l2_query_ext_ctrl\n> \t\t\t\t static_cast(ctrl.maximum),\n> \t\t\t\t static_cast(ctrl.default_value));\n>\n> +\tcase V4L2_CTRL_TYPE_U16:\n> +\t\treturn ControlInfo(static_cast(ctrl.minimum),\n> +\t\t\t\t static_cast(ctrl.maximum),\n> +\t\t\t\t static_cast(ctrl.default_value));\n> +\n> \tcase V4L2_CTRL_TYPE_U32:\n> \t\treturn ControlInfo(static_cast(ctrl.minimum),\n> \t\t\t\t static_cast(ctrl.maximum),\n> @@ -650,6 +677,7 @@ void V4L2Device::listControls()\n> \t\tcase V4L2_CTRL_TYPE_BITMASK:\n> \t\tcase V4L2_CTRL_TYPE_INTEGER_MENU:\n> \t\tcase V4L2_CTRL_TYPE_U8:\n> +\t\tcase V4L2_CTRL_TYPE_U16:\n> \t\tcase V4L2_CTRL_TYPE_U32:\n> \t\t\tbreak;\n> \t\t/* \\todo Support other control types. */\n> diff --git a/test/controls/control_value.cpp b/test/controls/control_value.cpp\n> index 6ca85b739..5084fd0cf 100644\n> --- a/test/controls/control_value.cpp\n> +++ b/test/controls/control_value.cpp\n> @@ -109,6 +109,46 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n>\n> +\t\t/*\n> +\t\t * Unsigned Integer16 type.\n> +\t\t */\n> +\t\tvalue.set(static_cast(42));\n> +\t\tif (value.isNone() || value.isArray() ||\n> +\t\t value.type() != ControlTypeUnsigned16) {\n> +\t\t\tcerr << \"Control type mismatch after setting to uint16_t\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (value.get() != 42) {\n> +\t\t\tcerr << \"Control value mismatch after setting to uint16_t\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (value.toString() != \"42\") {\n> +\t\t\tcerr << \"Control string mismatch after setting to uint16_t\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tstd::array uint16s{ 3, 14, 15, 9 };\n> +\t\tvalue.set(Span(uint16s));\n> +\t\tif (value.isNone() || !value.isArray() ||\n> +\t\t value.type() != ControlTypeUnsigned16) {\n> +\t\t\tcerr << \"Control type mismatch after setting to uint16_t array\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tSpan uint16sResult = value.get>();\n> +\t\tif (uint16s.size() != uint16sResult.size() ||\n> +\t\t !std::equal(uint16s.begin(), uint16s.end(), uint16sResult.begin())) {\n> +\t\t\tcerr << \"Control value mismatch after setting to uint16_t array\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (value.toString() != \"[ 3, 14, 15, 9 ]\") {\n> +\t\t\tcerr << \"Control string mismatch after setting to uint16_t array\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> \t\t/*\n> \t\t * Unsigned Integer32 type.\n> \t\t */\n> --\n> 2.47.0.163.g1226f6d8fa-goog\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B93DBBD78E\n\tfor ;\n\tThu, 28 Nov 2024 17:39:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6ADD265FCE;\n\tThu, 28 Nov 2024 18:39:27 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 40BC965FBE\n\tfor ;\n\tThu, 28 Nov 2024 18:39:26 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5DC5E59D;\n\tThu, 28 Nov 2024 18:39:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PjfAq3lg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732815542;\n\tbh=OfPeCs5pU6IUOr+yQl8+ItykoGs+AiERwChqK2PgQm8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PjfAq3lg0KEQJMPkt4kL/yzos/kS5BnaPotdNA2QYpLmyRuNKqpmntBgrlX7ragBV\n\tu/2eMu5qJD9760BqkNraLDjsfWrnT9nOisCkZzizdkW4MbwvNYPLcQ58UVPyLaiaoy\n\tskdiZhr7VB6RwgTU3cMOKWkI+G8hsM0v7aUjaxzw=","Date":"Thu, 28 Nov 2024 18:39:23 +0100","From":"Jacopo Mondi ","To":"Harvey Yang ","Cc":"libcamera-devel@lists.libcamera.org, \n\tYudhistira Erlandinata ","Subject":"Re: [PATCH v5 2/2] libcamera: Extend u16 control type","Message-ID":"<74jus3f63a6hzyhaoa3evd3twhet73wauxf3gaoaz7jagscfzi@nd636f43pcpf>","References":"<20241029161117.1197603-1-chenghaoyang@chromium.org>\n\t<20241029161117.1197603-3-chenghaoyang@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241029161117.1197603-3-chenghaoyang@chromium.org>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32444,"web_url":"https://patchwork.libcamera.org/comment/32444/","msgid":"<173281594798.1605529.13934290802133496340@ping.linuxembedded.co.uk>","date":"2024-11-28T17:45:47","subject":"Re: [PATCH v5 2/2] libcamera: Extend u16 control type","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi (2024-11-28 17:39:23)\n> Hi Harvey\n> \n> On Tue, Oct 29, 2024 at 04:07:13PM +0000, Harvey Yang wrote:\n> > From: Yudhistira Erlandinata \n> >\n> > V4L2 Controls support a wide variety of types not yet supported by the\n> > ControlValue type system.\n> >\n> > Extend the libcamera ControlValue types to support an explicit 16 bit\n> > unsigned integer type, and map that to the corresponding\n> > V4L2_CTRL_TYPE_U16 type within the v4l2_device support class.\n> >\n> > It's used on some camera metadata that is of length 16-bits,\n> > for example JPEG metadata headers.\n> >\n> > Signed-off-by: Yudhistira Erlandinata \n> > Co-developed-by: Harvey Yang \n> > Signed-off-by: Harvey Yang \n> \n> Reviewed-by: Jacopo Mondi \n\n\nReviewed-by: Kieran Bingham \n\n> \n> Thanks\n> j\n> \n> > ---\n> > include/libcamera/controls.h | 7 ++++++\n> > src/libcamera/controls.cpp | 8 +++++++\n> > src/libcamera/v4l2_device.cpp | 28 +++++++++++++++++++++++\n> > test/controls/control_value.cpp | 40 +++++++++++++++++++++++++++++++++\n> > 4 files changed, 83 insertions(+)\n> >\n> > diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> > index 6da8ad2c3..162115bb5 100644\n> > --- a/include/libcamera/controls.h\n> > +++ b/include/libcamera/controls.h\n> > @@ -29,6 +29,7 @@ enum ControlType {\n> > ControlTypeNone,\n> > ControlTypeBool,\n> > ControlTypeByte,\n> > + ControlTypeUnsigned16,\n> > ControlTypeUnsigned32,\n> > ControlTypeInteger32,\n> > ControlTypeInteger64,\n> > @@ -63,6 +64,12 @@ struct control_type {\n> > static constexpr std::size_t size = 0;\n> > };\n> >\n> > +template<>\n> > +struct control_type {\n> > + static constexpr ControlType value = ControlTypeUnsigned16;\n> > + static constexpr std::size_t size = 0;\n> > +};\n> > +\n> > template<>\n> > struct control_type {\n> > static constexpr ControlType value = ControlTypeUnsigned32;\n> > diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> > index 8ae295191..3a840bb22 100644\n> > --- a/src/libcamera/controls.cpp\n> > +++ b/src/libcamera/controls.cpp\n> > @@ -54,6 +54,7 @@ static constexpr size_t ControlValueSize[] = {\n> > [ControlTypeNone] = 0,\n> > [ControlTypeBool] = sizeof(bool),\n> > [ControlTypeByte] = sizeof(uint8_t),\n> > + [ControlTypeUnsigned16] = sizeof(uint16_t),\n> > [ControlTypeUnsigned32] = sizeof(uint32_t),\n> > [ControlTypeInteger32] = sizeof(int32_t),\n> > [ControlTypeInteger64] = sizeof(int64_t),\n> > @@ -75,6 +76,8 @@ static constexpr size_t ControlValueSize[] = {\n> > * The control stores a boolean value\n> > * \\var ControlTypeByte\n> > * The control stores a byte value as an unsigned 8-bit integer\n> > + * \\var ControlTypeUnsigned16\n> > + * The control stores an unsigned 16-bit integer value\n> > * \\var ControlTypeUnsigned32\n> > * The control stores an unsigned 32-bit integer value\n> > * \\var ControlTypeInteger32\n> > @@ -233,6 +236,11 @@ std::string ControlValue::toString() const\n> > str += std::to_string(*value);\n> > break;\n> > }\n> > + case ControlTypeUnsigned16: {\n> > + const uint16_t *value = reinterpret_cast(data);\n> > + str += std::to_string(*value);\n> > + break;\n> > + }\n> > case ControlTypeUnsigned32: {\n> > const uint32_t *value = reinterpret_cast(data);\n> > str += std::to_string(*value);\n> > diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> > index 90fa6b278..f0c6fa63d 100644\n> > --- a/src/libcamera/v4l2_device.cpp\n> > +++ b/src/libcamera/v4l2_device.cpp\n> > @@ -216,6 +216,13 @@ ControlList V4L2Device::getControls(const std::vector &ids)\n> > v4l2Ctrl.p_u8 = data.data();\n> > break;\n> >\n> > + case V4L2_CTRL_TYPE_U16:\n> > + type = ControlTypeUnsigned16;\n> > + value.reserve(type, true, info.elems);\n> > + data = value.data();\n> > + v4l2Ctrl.p_u16 = reinterpret_cast(data.data());\n> > + break;\n> > +\n> > case V4L2_CTRL_TYPE_U32:\n> > type = ControlTypeUnsigned32;\n> > value.reserve(type, true, info.elems);\n> > @@ -307,6 +314,18 @@ int V4L2Device::setControls(ControlList *ctrls)\n> > /* Set the v4l2_ext_control value for the write operation. */\n> > ControlValue &value = ctrl->second;\n> > switch (iter->first->type()) {\n> > + case ControlTypeUnsigned16: {\n> > + if (value.isArray()) {\n> > + Span data = value.data();\n> > + v4l2Ctrl.p_u16 = reinterpret_cast(data.data());\n> > + v4l2Ctrl.size = data.size();\n> > + } else {\n> > + v4l2Ctrl.value = value.get();\n> > + }\n> > +\n> > + break;\n> > + }\n> > +\n> > case ControlTypeUnsigned32: {\n> > if (value.isArray()) {\n> > Span data = value.data();\n> > @@ -508,6 +527,9 @@ ControlType V4L2Device::v4l2CtrlType(uint32_t ctrlType)\n> > case V4L2_CTRL_TYPE_BOOLEAN:\n> > return ControlTypeBool;\n> >\n> > + case V4L2_CTRL_TYPE_U16:\n> > + return ControlTypeUnsigned16;\n> > +\n> > case V4L2_CTRL_TYPE_U32:\n> > return ControlTypeUnsigned32;\n> >\n> > @@ -559,6 +581,11 @@ std::optional V4L2Device::v4l2ControlInfo(const v4l2_query_ext_ctrl\n> > static_cast(ctrl.maximum),\n> > static_cast(ctrl.default_value));\n> >\n> > + case V4L2_CTRL_TYPE_U16:\n> > + return ControlInfo(static_cast(ctrl.minimum),\n> > + static_cast(ctrl.maximum),\n> > + static_cast(ctrl.default_value));\n> > +\n> > case V4L2_CTRL_TYPE_U32:\n> > return ControlInfo(static_cast(ctrl.minimum),\n> > static_cast(ctrl.maximum),\n> > @@ -650,6 +677,7 @@ void V4L2Device::listControls()\n> > case V4L2_CTRL_TYPE_BITMASK:\n> > case V4L2_CTRL_TYPE_INTEGER_MENU:\n> > case V4L2_CTRL_TYPE_U8:\n> > + case V4L2_CTRL_TYPE_U16:\n> > case V4L2_CTRL_TYPE_U32:\n> > break;\n> > /* \\todo Support other control types. */\n> > diff --git a/test/controls/control_value.cpp b/test/controls/control_value.cpp\n> > index 6ca85b739..5084fd0cf 100644\n> > --- a/test/controls/control_value.cpp\n> > +++ b/test/controls/control_value.cpp\n> > @@ -109,6 +109,46 @@ protected:\n> > return TestFail;\n> > }\n> >\n> > + /*\n> > + * Unsigned Integer16 type.\n> > + */\n> > + value.set(static_cast(42));\n> > + if (value.isNone() || value.isArray() ||\n> > + value.type() != ControlTypeUnsigned16) {\n> > + cerr << \"Control type mismatch after setting to uint16_t\" << endl;\n> > + return TestFail;\n> > + }\n> > +\n> > + if (value.get() != 42) {\n> > + cerr << \"Control value mismatch after setting to uint16_t\" << endl;\n> > + return TestFail;\n> > + }\n> > +\n> > + if (value.toString() != \"42\") {\n> > + cerr << \"Control string mismatch after setting to uint16_t\" << endl;\n> > + return TestFail;\n> > + }\n> > +\n> > + std::array uint16s{ 3, 14, 15, 9 };\n> > + value.set(Span(uint16s));\n> > + if (value.isNone() || !value.isArray() ||\n> > + value.type() != ControlTypeUnsigned16) {\n> > + cerr << \"Control type mismatch after setting to uint16_t array\" << endl;\n> > + return TestFail;\n> > + }\n> > +\n> > + Span uint16sResult = value.get>();\n> > + if (uint16s.size() != uint16sResult.size() ||\n> > + !std::equal(uint16s.begin(), uint16s.end(), uint16sResult.begin())) {\n> > + cerr << \"Control value mismatch after setting to uint16_t array\" << endl;\n> > + return TestFail;\n> > + }\n> > +\n> > + if (value.toString() != \"[ 3, 14, 15, 9 ]\") {\n> > + cerr << \"Control string mismatch after setting to uint16_t array\" << endl;\n> > + return TestFail;\n> > + }\n> > +\n> > /*\n> > * Unsigned Integer32 type.\n> > */\n> > --\n> > 2.47.0.163.g1226f6d8fa-goog\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB580BDE6B\n\tfor ;\n\tThu, 28 Nov 2024 17:45:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 759AB65FE0;\n\tThu, 28 Nov 2024 18:45:51 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 88AB665FCC\n\tfor ;\n\tThu, 28 Nov 2024 18:45:50 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A826F526;\n\tThu, 28 Nov 2024 18:45:26 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JmRnTm/z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732815926;\n\tbh=wxU22IzVIpgTipMiJifSY5mWC+k6+IAeC1GbpzVZv2A=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=JmRnTm/zaHgs90sC53wnmK5yCzOmc2Ot2sdjTfmY6uCXVlJ7NZHaIQjrB4Hk3SciJ\n\tiW71Z4L3khOPtXdgcPEXmFERI4MVQ0rie+ZMUjskTBnvJjq9GP9UzAV0nVN9fDHzQ1\n\tmqr+Rp8TqjgV/LaUS8lZoqbhtZU+RV6buktctCnY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<74jus3f63a6hzyhaoa3evd3twhet73wauxf3gaoaz7jagscfzi@nd636f43pcpf>","References":"<20241029161117.1197603-1-chenghaoyang@chromium.org>\n\t<20241029161117.1197603-3-chenghaoyang@chromium.org>\n\t<74jus3f63a6hzyhaoa3evd3twhet73wauxf3gaoaz7jagscfzi@nd636f43pcpf>","Subject":"Re: [PATCH v5 2/2] libcamera: Extend u16 control type","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org,\n\tYudhistira Erlandinata ","To":"Harvey Yang ,\n\tJacopo Mondi ","Date":"Thu, 28 Nov 2024 17:45:47 +0000","Message-ID":"<173281594798.1605529.13934290802133496340@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]