[{"id":2893,"web_url":"https://patchwork.libcamera.org/comment/2893/","msgid":"<20191013193206.GY23166@bigcity.dyn.berto.se>","date":"2019-10-13T19:32:06","subject":"Re: [libcamera-devel] [PATCH/RFC v2 1/4] libcamera: buffer: Add\n\tconst accessor to Buffer planes","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-10-13 03:13:37 +0300, Laurent Pinchart wrote:\n> In order to inspect planes of a const Buffer, add a const accessor.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/buffer.h | 1 +\n> src/libcamera/buffer.cpp | 6 ++++++\n> 2 files changed, 7 insertions(+)\n> \n> diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h\n> index 7b657509ab5f..7a070205f0b5 100644\n> --- a/include/libcamera/buffer.h\n> +++ b/include/libcamera/buffer.h\n> @@ -43,6 +43,7 @@ private:\n> class BufferMemory final\n> {\n> public:\n> +\tconst std::vector &planes() const { return planes_; }\n> \tstd::vector &planes() { return planes_; }\n> \n> private:\n> diff --git a/src/libcamera/buffer.cpp b/src/libcamera/buffer.cpp\n> index 4407201bd81c..960eeb8f7d19 100644\n> --- a/src/libcamera/buffer.cpp\n> +++ b/src/libcamera/buffer.cpp\n> @@ -181,6 +181,12 @@ void *Plane::mem()\n> * image format is multi-planar.\n> */\n> \n> +/**\n> + * \\fn BufferMemory::planes() const\n> + * \\brief Retrieve the planes within the buffer\n> + * \\return A const reference to a vector holding all Planes within the buffer\n> + */\n> +\n> /**\n> * \\fn BufferMemory::planes()\n> * \\brief Retrieve the planes within the buffer\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com\n\t[IPv6:2a00:1450:4864:20::22b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2DB14600F9\n\tfor ;\n\tSun, 13 Oct 2019 21:32:08 +0200 (CEST)","by mail-lj1-x22b.google.com with SMTP id y23so14468481lje.9\n\tfor ;\n\tSun, 13 Oct 2019 12:32:08 -0700 (PDT)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tn11sm3604804lfe.59.2019.10.13.12.32.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 13 Oct 2019 12:32:06 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=BghK3RD2P5Vudm6DW70gNj2ZcfJah1uc8kXjA78IEwo=;\n\tb=ao+oMVa5pOs8xV9B/OgXy5VOWvhnY8+q2A4dG9IG5S965RaFoaRvmkam80XCWsUUDk\n\t86urHACfVgs7fEbhMvS4TQKI5zDsgRFleHwHNCv+gaPcXedaTpLv5aD0vhSH5nQw5Wo4\n\tNa03kIuNwHUPZR+TlIW/dreNdjaPGNTmTjRSvRt33SJ+J6RAGIiRdf24xMtkHrbs7EP4\n\tA5bQdaZMKDB/8OPMy6z5iHQWtAQA1u7hL+XFXKbbw83RoZOn0Cv/5A7HELEjkssL/TjQ\n\t0l6cBys2dPCm9dfQA66W0jXx8G69qBl6gETv3HS1OXmHt60medzQXsV/0hXQmne3qT5U\n\t7r0A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=BghK3RD2P5Vudm6DW70gNj2ZcfJah1uc8kXjA78IEwo=;\n\tb=ebOMV8g+sEWkI4tYRjGD4HfYa2jQ4Z9m6PyhtB2VBoaVZcBOa1mCTlsI+4CfgbDFJt\n\tJRZBeUqv4ShVCGygQpdNcMY/gJiyyP0nd9oQBCR9UQAxMdt+BRbmGPuSA5qIUaR6z9L2\n\tchql/QtYb7Mfcz6cj/1E6ldgplFkMUmfbMdB8DrbXSjaGGfQTugphvXi7Oo0EslsXcHP\n\tiDUZbtQNerael2WycjFA6EIJP+DF+GKMBWVmXSZIkuyNsEO/+Ejhukp2EPT2e08AcsFs\n\txwbUoUY6e1ylodT6LBBB73n4sDQ/MZ8HLMM3SupRuO5Uda3h1MAQWsGRfUWMC6amhjuh\n\tN3AQ==","X-Gm-Message-State":"APjAAAXuRU+eh0VjyvahBsvHIFUHpVAhT5x+oHx5/at9a6xcp/1ahyIV\n\tT8sweyDaAtUDTFhMhJsg0a2vjvmMwMo=","X-Google-Smtp-Source":"APXvYqwljl9TFWtM8rxlLqfDKg8kAK4BWeHBLW0+gS434eiDHyJiPaczxyfhBX3FjhPoEIicJSpFZA==","X-Received":"by 2002:a2e:85c1:: with SMTP id\n\th1mr16433543ljj.169.1570995127308; \n\tSun, 13 Oct 2019 12:32:07 -0700 (PDT)","Date":"Sun, 13 Oct 2019 21:32:06 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191013193206.GY23166@bigcity.dyn.berto.se>","References":"<20191013001340.14266-1-laurent.pinchart@ideasonboard.com>\n\t<20191013001340.14266-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191013001340.14266-2-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH/RFC v2 1/4] libcamera: buffer: Add\n\tconst accessor to Buffer planes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 13 Oct 2019 19:32:08 -0000"}}]