[{"id":31961,"web_url":"https://patchwork.libcamera.org/comment/31961/","msgid":"<87bjz3ne7f.fsf@redhat.com>","date":"2024-10-29T15:03:48","subject":"Re: [PATCH 2/2] libcamera: software_isp: Remove unused\n\tIPAActiveState fields","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Stanislaw Gruszka writes:\n\n> Now agc struct in IPAActiveState is not used any longer. If there\n> will be need to have this struct, this patch can be reverted.\n>\n> Signed-off-by: Stanislaw Gruszka \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/ipa/simple/ipa_context.h | 5 -----\n> 1 file changed, 5 deletions(-)\n>\n> diff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\n> index c510c436..2885a851 100644\n> --- a/src/ipa/simple/ipa_context.h\n> +++ b/src/ipa/simple/ipa_context.h\n> @@ -39,11 +39,6 @@ struct IPAActiveState {\n> \t\tdouble blue;\n> \t} gains;\n> \n> -\tstruct {\n> -\t\tint32_t exposure;\n> -\t\tdouble again;\n> -\t} agc;\n> -\n> \tstatic constexpr unsigned int kGammaLookupSize = 1024;\n> \tstruct {\n> \t\tstd::array gammaTable;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52AF1C3220\n\tfor ;\n\tTue, 29 Oct 2024 15:03:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0954765399;\n\tTue, 29 Oct 2024 16:03:58 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C08A360366\n\tfor ;\n\tTue, 29 Oct 2024 16:03:56 +0100 (CET)","from mail-lf1-f71.google.com (mail-lf1-f71.google.com\n\t[209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-417-LeYQUTG6MU-U5CuDtSL5fA-1; Tue, 29 Oct 2024 11:03:53 -0400","by mail-lf1-f71.google.com with SMTP id\n\t2adb3069b0e04-539eaa0561bso4540592e87.0\n\tfor ;\n\tTue, 29 Oct 2024 08:03:52 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-431935f6df1sm149866245e9.35.2024.10.29.08.03.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 29 Oct 2024 08:03:49 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"dKqHczyH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1730214235;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=/DgRjVuFJ3ZIhCnYtqyShzmzDg9bXdrDZJJBhvfIKa8=;\n\tb=dKqHczyHRXEqmm7UfhNjH3EV+ZDrn+Ptm1knw/k0OOCfcCMIkhQZarYNfDQLIssEH/NcWT\n\t0gsFoqkaj+JvFZoDXU9NtMALx+Dn4THLLHr4kKyTT8eT7s/xesCsxJI6E1SwqMPg9JvXG7\n\taM108hUBVVzI1A4fDbqTJSGL5Zko23M=","X-MC-Unique":"LeYQUTG6MU-U5CuDtSL5fA-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1730214231; x=1730819031;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=/DgRjVuFJ3ZIhCnYtqyShzmzDg9bXdrDZJJBhvfIKa8=;\n\tb=jvePF8zqJYIvcqvQ3tFOU9fanMW8GbFmX5PsbrTQiZ3p6Nb0broJEkeEUiV8Bj6Jid\n\tLHuGG16elJ2JliAzok3SUy7djSdt/uFCCtk/IT46ui28iDJJcHeidsIqFF7uTg0IRuXl\n\twmK9jFaI8pf2cPkL12CKuP20FZ7T+5fzFEC3ZQMNwwyh3s5mjxYWf1kOeF+oV7qygDpn\n\th3vNMfBVE6dpmnUW9VUht+ZtxlvdPznl2rlHQzF6Nkk5aWqjosG8E2IHUoiHPK4ws7MC\n\tTw8vfK4UvOQCE9/O2G+wUE9YtwbSMpI3k4bGWw5rTGtABNh32iyzJyCPwJ4x7ahTdOtx\n\t5LCg==","X-Gm-Message-State":"AOJu0Yz5vnkHXNsN4Sld3SbWuOXlqQxuxsWVSuxzJ97AZ9BIAfrZ6aQy\n\tSIZj4cWmvkfPoudM09JDfmoGXxJcLkcM9SKOqa4DbPNcVl1Av542jilBaevyuipP7IFLCUUy1V+\n\tj6HkuDChjqCWcE//FM6ETrBZ+kvl3H/8J2WshxIu++EJ2dbLIN58Vy85nWyYRFnUMRGx5t09Mzn\n\ts9JDqrpzqiV1m+Fd5CCuv7mymUKwM1L/1gDDys230/FdkiSIWP8KjsU/A=","X-Received":["by 2002:a05:6512:2344:b0:539:951f:27c2 with SMTP id\n\t2adb3069b0e04-53b34c40235mr4376397e87.61.1730214230861; \n\tTue, 29 Oct 2024 08:03:50 -0700 (PDT)","by 2002:a05:6512:2344:b0:539:951f:27c2 with SMTP id\n\t2adb3069b0e04-53b34c40235mr4376358e87.61.1730214230256; \n\tTue, 29 Oct 2024 08:03:50 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IF55T4edvbW1dRKUfE+Rywkya5X3NzYqT74Jkxt3qghQyhaX0N1eeWWIRTP2+oo/+gYqT3gdA==","From":"Milan Zamazal ","To":"Stanislaw Gruszka ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/2] libcamera: software_isp: Remove unused\n\tIPAActiveState fields","In-Reply-To":"<20241029112501.140252-2-stanislaw.gruszka@linux.intel.com>\n\t(Stanislaw Gruszka's message of \"Tue, 29 Oct 2024 12:25:01 +0100\")","References":"<20241029112501.140252-1-stanislaw.gruszka@linux.intel.com>\n\t<20241029112501.140252-2-stanislaw.gruszka@linux.intel.com>","Date":"Tue, 29 Oct 2024 16:03:48 +0100","Message-ID":"<87bjz3ne7f.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32472,"web_url":"https://patchwork.libcamera.org/comment/32472/","msgid":"<173291810266.4100433.8708866250067466224@ping.linuxembedded.co.uk>","date":"2024-11-29T22:08:22","subject":"Re: [PATCH 2/2] libcamera: software_isp: Remove unused\n\tIPAActiveState fields","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stanislaw Gruszka (2024-10-29 11:25:01)\n> Now agc struct in IPAActiveState is not used any longer. If there\n> will be need to have this struct, this patch can be reverted.\n> \n> Signed-off-by: Stanislaw Gruszka \nReviewed-by: Kieran Bingham \n> ---\n> src/ipa/simple/ipa_context.h | 5 -----\n> 1 file changed, 5 deletions(-)\n> \n> diff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\n> index c510c436..2885a851 100644\n> --- a/src/ipa/simple/ipa_context.h\n> +++ b/src/ipa/simple/ipa_context.h\n> @@ -39,11 +39,6 @@ struct IPAActiveState {\n> double blue;\n> } gains;\n> \n> - struct {\n> - int32_t exposure;\n> - double again;\n> - } agc;\n> -\n> static constexpr unsigned int kGammaLookupSize = 1024;\n> struct {\n> std::array gammaTable;\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 305AABE175\n\tfor ;\n\tFri, 29 Nov 2024 22:08:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DEE4766046;\n\tFri, 29 Nov 2024 23:08:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E96E6603E\n\tfor ;\n\tFri, 29 Nov 2024 23:08:25 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D176F80A;\n\tFri, 29 Nov 2024 23:08:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"a3NQcuMd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732918080;\n\tbh=6f6ZNAsfDRCu3xpqdbS5o8qy+zPVD7H3lqwxnuVQC1g=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=a3NQcuMdJFbbz16FssNuySmqo5D147t4UyVwxPAX0mMwLq+sRk/7wJDyXQ8FRoL3q\n\tI/JuQA4djNOLGc15FU5p44xjUQuZp6XRT83IqdeMusGKQFgiCkgaVv/RX7J+hVjLqz\n\tDZobkMUf5ijPzmjOsnVkpzU0NpthwdEPiIEEQUgk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241029112501.140252-2-stanislaw.gruszka@linux.intel.com>","References":"<20241029112501.140252-1-stanislaw.gruszka@linux.intel.com>\n\t<20241029112501.140252-2-stanislaw.gruszka@linux.intel.com>","Subject":"Re: [PATCH 2/2] libcamera: software_isp: Remove unused\n\tIPAActiveState fields","From":"Kieran Bingham ","Cc":"Milan Zamazal ","To":"Stanislaw Gruszka ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 29 Nov 2024 22:08:22 +0000","Message-ID":"<173291810266.4100433.8708866250067466224@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]