{"id":21769,"url":"https://patchwork.libcamera.org/api/patches/21769/?format=json","web_url":"https://patchwork.libcamera.org/patch/21769/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241029112501.140252-2-stanislaw.gruszka@linux.intel.com>","date":"2024-10-29T11:25:01","name":"[2/2] libcamera: software_isp: Remove unused IPAActiveState fields","commit_ref":"1a2be886c08aea0e97da9b44bda639b59a2cd036","pull_url":null,"state":"accepted","archived":false,"hash":"b85d626a2833e4bf510d1ffdd5d26af94008574f","submitter":{"id":211,"url":"https://patchwork.libcamera.org/api/people/211/?format=json","name":"Stanislaw Gruszka","email":"stanislaw.gruszka@linux.intel.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21769/mbox/","series":[{"id":4752,"url":"https://patchwork.libcamera.org/api/series/4752/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4752","date":"2024-10-29T11:25:00","name":"[1/2] libcamera: software_isp: Initialize exposure+gain before agc calculations","version":1,"mbox":"https://patchwork.libcamera.org/series/4752/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21769/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21769/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 46F68C31E9\n\tfor ;\n\tTue, 29 Oct 2024 11:25:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D748653A0;\n\tTue, 29 Oct 2024 12:25:11 +0100 (CET)","from mgamail.intel.com (mgamail.intel.com [192.198.163.19])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E00BA60366\n\tfor ;\n\tTue, 29 Oct 2024 12:25:07 +0100 (CET)","from fmviesa003.fm.intel.com ([10.60.135.143])\n\tby fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n\t29 Oct 2024 04:25:08 -0700","from sgruszka-mobl.ger.corp.intel.com (HELO localhost)\n\t([10.246.8.237]) by fmviesa003-auth.fm.intel.com with\n\tESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2024 04:25:07 -0700"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"loG5AZYr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n\tt=1730201108; x=1761737108;\n\th=from:to:cc:subject:date:message-id:in-reply-to:\n\treferences:mime-version:content-transfer-encoding;\n\tbh=9zmMjx0bGyfmYhQd+Taa6ZfjWcAKr04ll4MRai2cMEE=;\n\tb=loG5AZYr1X2AEyel7FFRmC8T43olfCIz3o57hCKS/9/7Ud0rnt16wjNx\n\teUhAem5eg5+aCwTDCwIkVvkaLX1/cp4w7m6/7/PQBr9BC9jNCHWqVJWlv\n\t6iuWxtOa8t8SBSKX6BQF1XHet3Pf4rmOoFD9n5ikXvO4ySmML3b4ydljL\n\tdv90lYzrSs06lJ5gMWEj6Xd2hOhMpCHBBZxDVhF6qyc0IJo77AvG8uX6i\n\tfj8tXnptSWevAUlu5M6vhhAbxzTC7L9k7lBbadUDw4FQj+qXHzq0af2dm\n\tWczc1IZPUJJeuIialzfr99zLjLvbRBDqF27iP0mSh7grCx4Df+FlpJtrq w==;","X-CSE-ConnectionGUID":["NDk35Cp4Q2CqpZwwZTXxTw==","AJrsAvU2SEaWC7sUlgIwdA=="],"X-CSE-MsgGUID":["+Y3IEcWYTaW0MV+atFvySQ==","afM7rZFbS/2pzdCOpJqbXQ=="],"X-IronPort-AV":["E=McAfee;i=\"6700,10204,11239\"; a=\"29289320\"","E=Sophos;i=\"6.11,241,1725346800\"; d=\"scan'208\";a=\"29289320\"","E=Sophos;i=\"6.11,241,1725346800\"; d=\"scan'208\";a=\"85890428\""],"X-ExtLoop1":"1","From":"Stanislaw Gruszka ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ","Subject":"[PATCH 2/2] libcamera: software_isp: Remove unused IPAActiveState\n\tfields","Date":"Tue, 29 Oct 2024 12:25:01 +0100","Message-Id":"<20241029112501.140252-2-stanislaw.gruszka@linux.intel.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20241029112501.140252-1-stanislaw.gruszka@linux.intel.com>","References":"<20241029112501.140252-1-stanislaw.gruszka@linux.intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now agc struct in IPAActiveState is not used any longer. If there\nwill be need to have this struct, this patch can be reverted.\n\nSigned-off-by: Stanislaw Gruszka \n---\n src/ipa/simple/ipa_context.h | 5 -----\n 1 file changed, 5 deletions(-)","diff":"diff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex c510c436..2885a851 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -39,11 +39,6 @@ struct IPAActiveState {\n \t\tdouble blue;\n \t} gains;\n \n-\tstruct {\n-\t\tint32_t exposure;\n-\t\tdouble again;\n-\t} agc;\n-\n \tstatic constexpr unsigned int kGammaLookupSize = 1024;\n \tstruct {\n \t\tstd::array gammaTable;\n","prefixes":["2/2"]}