[{"id":31980,"web_url":"https://patchwork.libcamera.org/comment/31980/","msgid":"<87v7x8inz9.fsf@redhat.com>","date":"2024-10-31T10:08:26","subject":"Re: [PATCH RFC 1/3] ipa: core: add IPASensorDelays structure","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Mikhail Rudenko writes:\n\n> Add struct IPASensorDelays for passing sensor delays from\n> a CameraSensorHelper to a pipeline handler at initialization\n> time. Distinct member variables instead of a map ensure at compile\n> time that all delays required by the pipeline handler are defined.\n>\n> Signed-off-by: Mikhail Rudenko \n> ---\n> include/libcamera/ipa/core.mojom | 35 ++++++++++++++++++++++++++++++++\n> 1 file changed, 35 insertions(+)\n>\n> diff --git a/include/libcamera/ipa/core.mojom b/include/libcamera/ipa/core.mojom\n> index bce79724..c95cce4b 100644\n> --- a/include/libcamera/ipa/core.mojom\n> +++ b/include/libcamera/ipa/core.mojom\n> @@ -341,3 +341,38 @@ struct IPAStream {\n> \tuint32 pixelFormat;\n> \tSize size;\n> };\n> +\n> +/**\n> + * \\struct IPASensorDelays\n> + * \\brief Sensor control delays for the IPA interface\n> + *\n> + * The IPASensorDelays structure is used to pass sensoer control delays from\n\nsensoer -> sensor\n\n> + * the CameraSensorHelper instance in an IPA to the DelayedControls instance\n> + * in a pipeline handler.\n> + */\n> +\n> +/**\n> + * \\var IPASensorDelays::exposureDelay\n> + * \\brief The delay for CID_EXPOSURE\n> + */\n> +\n> +/**\n> + * \\var IPASensorDelays::gainDelay\n> + * \\brief The delay for CID_ANALOGUE_GAIN\n> + */\n> +\n> +/**\n> + * \\var IPASensorDelays::hblankDelay\n> + * \\brief The delay for CID_HBLANK\n> + */\n> +\n> +/**\n> + * \\var IPASensorDelays::vblankDelay\n> + * \\brief The delay for CID_VBLANK\n> + */\n> +struct IPASensorDelays {\n> +\tuint32 exposureDelay;\n> +\tuint32 gainDelay;\n> +\tuint32 hblankDelay;\n> +\tuint32 vblankDelay;\n> +};","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 289B7C3237\n\tfor ;\n\tThu, 31 Oct 2024 10:08:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C2DD9653AA;\n\tThu, 31 Oct 2024 11:08:34 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C869653A6\n\tfor ;\n\tThu, 31 Oct 2024 11:08:32 +0100 (CET)","from mail-lf1-f70.google.com (mail-lf1-f70.google.com\n\t[209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-392-5awvkrbuM5yuc9-yOoCMAQ-1; Thu, 31 Oct 2024 06:08:30 -0400","by mail-lf1-f70.google.com with SMTP id\n\t2adb3069b0e04-53a0b48e8d4so499471e87.3\n\tfor ;\n\tThu, 31 Oct 2024 03:08:29 -0700 (PDT)","from nuthatch (nat-pool-brq-t.redhat.com. [213.175.37.10])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-381c10d437bsm1639319f8f.30.2024.10.31.03.08.27\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 31 Oct 2024 03:08:27 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"BZ5+trKI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1730369311;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=OClEm1vi2pk0RzG0MIVe1CbzdsodhO7BeZ2jONWEwzU=;\n\tb=BZ5+trKI6CVYVVkaobTnngiP32S4BFsdDvi1nV4hWUT87OfhCA/ozOFM1GIvwB+nj4yU1N\n\tZNqWTZXfntrNevXLAn0aTuHIqrzqdKCMiwLU1Bfd6QrYJqI+aE9LqzZJSjoQjiRxTRmWMT\n\tL8cJeFCX6/DrEE16mwIr8sGzvECg1KQ=","X-MC-Unique":"5awvkrbuM5yuc9-yOoCMAQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1730369309; x=1730974109;\n\th=mime-version:user-agent:message-id:date:importance:references\n\t:in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=OClEm1vi2pk0RzG0MIVe1CbzdsodhO7BeZ2jONWEwzU=;\n\tb=WInNgUpHHew8WFCS8WL1wH188R3HK8Fjf8ImDNv59wNTxlpHkJjEFEmWH/ligIHuW1\n\tru2212aPAMntSGszxvcWBzU8Ais3/XHa+Z6VN4lS3IRregO67J31MSXt3A/AGJdLd/QC\n\tck3pUCh8eclunghcGQPkbe2tM9StJ6otvy3GZIunZ1ZC83lXX4p3SfR+1heIqmWSA1RV\n\t0hjGsvP0jl2K1mgHCKbWlWMs+ipK5lMwmVxWRlf9Ppm3mZKA+61EQcRoNT4572h4vFN9\n\tXXpJrDwua1tVH25WRJtTvKqkOReXTzVslfdZrpC5ocMPFVTDekje2tJcHjcXA7j5JOAU\n\tfWXw==","X-Gm-Message-State":"AOJu0Yw5ae/Edns5kSMXO3xk3Cim0R5Mfx+87YsGJM3xw+iVaSXG8oFo\n\tDDsl98dxFD7n5b3ysr/GA6xg1YXNydLdEfyBZxYxhOcSVBRZuf7lkDWadPwaoonJEF/1nnfgWje\n\tctJJnOiZ6LOHkCm/intpx0hw/H+S+jxw8M4TiipeObsW325Dde82hAmTXcuBTyzPZ+JESRuM=","X-Received":["by 2002:a05:6512:1385:b0:539:e60a:6dd0 with SMTP id\n\t2adb3069b0e04-53b34b373admr8988828e87.51.1730369308647; \n\tThu, 31 Oct 2024 03:08:28 -0700 (PDT)","by 2002:a05:6512:1385:b0:539:e60a:6dd0 with SMTP id\n\t2adb3069b0e04-53b34b373admr8988798e87.51.1730369308054; \n\tThu, 31 Oct 2024 03:08:28 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IGPAf7WHvqeH3HR+ld/GtIpQHzIcL7JmEwAIYJGzoTCoU0DndPSv5l5oCgRPaw54G9CkxYQJg==","From":"Milan Zamazal ","To":"Mikhail Rudenko ","Cc":"libcamera-devel@lists.libcamera.org, Kieran Bingham\n\t, Laurent Pinchart\n\t","Subject":"Re: [PATCH RFC 1/3] ipa: core: add IPASensorDelays structure","In-Reply-To":"<20241028173659.247353-2-mike.rudenko@gmail.com> (Mikhail\n\tRudenko's message of \"Mon, 28 Oct 2024 20:36:57 +0300\")","References":"<20241028173659.247353-1-mike.rudenko@gmail.com>\n\t<20241028173659.247353-2-mike.rudenko@gmail.com>","Importance":"high","Date":"Thu, 31 Oct 2024 11:08:26 +0100","Message-ID":"<87v7x8inz9.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31987,"web_url":"https://patchwork.libcamera.org/comment/31987/","msgid":"<87o730pex3.fsf@gmail.com>","date":"2024-10-31T13:39:02","subject":"Re: [PATCH RFC 1/3] ipa: core: add IPASensorDelays structure","submitter":{"id":146,"url":"https://patchwork.libcamera.org/api/people/146/","name":"Mikhail Rudenko","email":"mike.rudenko@gmail.com"},"content":"Hi Milan,\n\nOn 2024-10-31 at 11:08 +01, Milan Zamazal wrote:\n\n> Mikhail Rudenko writes:\n>\n>> Add struct IPASensorDelays for passing sensor delays from\n>> a CameraSensorHelper to a pipeline handler at initialization\n>> time. Distinct member variables instead of a map ensure at compile\n>> time that all delays required by the pipeline handler are defined.\n>>\n>> Signed-off-by: Mikhail Rudenko \n>> ---\n>> include/libcamera/ipa/core.mojom | 35 ++++++++++++++++++++++++++++++++\n>> 1 file changed, 35 insertions(+)\n>>\n>> diff --git a/include/libcamera/ipa/core.mojom b/include/libcamera/ipa/core.mojom\n>> index bce79724..c95cce4b 100644\n>> --- a/include/libcamera/ipa/core.mojom\n>> +++ b/include/libcamera/ipa/core.mojom\n>> @@ -341,3 +341,38 @@ struct IPAStream {\n>> \tuint32 pixelFormat;\n>> \tSize size;\n>> };\n>> +\n>> +/**\n>> + * \\struct IPASensorDelays\n>> + * \\brief Sensor control delays for the IPA interface\n>> + *\n>> + * The IPASensorDelays structure is used to pass sensoer control delays from\n>\n> sensoer -> sensor\n\nGood catch, thanks!\n\n--\nBest regards,\nMikhail Rudenko","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 11C7FC31E9\n\tfor ;\n\tThu, 31 Oct 2024 13:42:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 02C6C653A6;\n\tThu, 31 Oct 2024 14:42:23 +0100 (CET)","from mail-lf1-x130.google.com (mail-lf1-x130.google.com\n\t[IPv6:2a00:1450:4864:20::130])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B19A60360\n\tfor ;\n\tThu, 31 Oct 2024 14:42:22 +0100 (CET)","by mail-lf1-x130.google.com with SMTP id\n\t2adb3069b0e04-539f76a6f0dso947380e87.1\n\tfor ;\n\tThu, 31 Oct 2024 06:42:22 -0700 (PDT)","from razdolb ([77.220.204.220]) by smtp.gmail.com with ESMTPSA id\n\t2adb3069b0e04-53c7bcce425sm201642e87.170.2024.10.31.06.42.19\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 31 Oct 2024 06:42:20 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"SbOFeNu7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1730382142; x=1730986942;\n\tdarn=lists.libcamera.org; \n\th=mime-version:message-id:in-reply-to:date:subject:cc:to:from\n\t:user-agent:references:from:to:cc:subject:date:message-id:reply-to;\n\tbh=libxQ0Od7wLRnWIwLDMAVwFATRtUu3o5rvpz/LzOMM4=;\n\tb=SbOFeNu7SgT59jvkRx9GSRtDUu/5dIvdPIFbIB4d2Yye30cE4/wIakEiuFRVjELPQl\n\tlYKffxXGKBZjNddRCyRWyFdAW9cYyrAUGxyJTWlFwqmDPO7HK+0VrJGZA6ndDm4HShYn\n\t2F8CQpxZbjcPYY/woncnw7dM5UJ9GYJtr1F0i/UAJE3phPXbZCIHJ9pZmZGikTxUe3hW\n\t9DzUkYSiiVqSnX+lvsyym2y+sosQ31ZDTlH0PGByXNij+TXEZeG7FrakZulFIcibYqRm\n\t+S8MnwLg1B8SHFuNCgJ3a/Rs757fC5El+aXI2n3JtYtihKU9pObVoQX0xN5Ns/D0JlR1\n\tTpbQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1730382142; x=1730986942;\n\th=mime-version:message-id:in-reply-to:date:subject:cc:to:from\n\t:user-agent:references:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=libxQ0Od7wLRnWIwLDMAVwFATRtUu3o5rvpz/LzOMM4=;\n\tb=DrAzTZGIvjm3uGYIJZNg6BMIxuI94g05M30Ar5e9FzTRkpTWldh0dv/D7q6CoCd7Jt\n\taxZiv+zwkeXiWA3rsheOiAZtABewV0H3Rq1KIH679F0dznwLWDLX6EN3TuWaqdRstlCI\n\toX6NQO97jvfvehWZ+3Uqsr5Orw0c+bTro5uC30l19e1Hnj3ZmFAKCIpehIxAgRBaf/3I\n\tgCWdKHlnKMKfEELNcHjap2FCIB9ZJuqabIbRIVfU55tarE92ejh+sQnzlvmZw4eVHTGX\n\tRKz+QNjjlcZUX/yGf15BXLmTfVKmhCEQsE9EAJNLTqCUCpRxUZVKBF+Ni7sovLLITNx5\n\tJY+g==","X-Gm-Message-State":"AOJu0YzuQQVcIYXFkSH+msronx3oWhZ59kBEvAzG0D7zMIAAWQ1nOMeK\n\tJksFtfplw2Uo6EHrUrX+9xk1VCjpgoaGjSTR7gJExNxquLXvM5RA","X-Google-Smtp-Source":"AGHT+IF00Av7gKPOecawKdmH7HXtvKAu07gVkDp/9x8i0yCE/hAKAN3TQKq9riw2gZbyWqnwcEdIIQ==","X-Received":"by 2002:a05:6512:3f02:b0:53a:40e:d54f with SMTP id\n\t2adb3069b0e04-53c79e15751mr1805689e87.8.1730382141350; \n\tThu, 31 Oct 2024 06:42:21 -0700 (PDT)","References":"<20241028173659.247353-1-mike.rudenko@gmail.com>\n\t<20241028173659.247353-2-mike.rudenko@gmail.com>\n\t<87v7x8inz9.fsf@redhat.com>","User-agent":"mu4e 1.10.8; emacs 29.4.50","From":"Mikhail Rudenko ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org, Kieran Bingham\n\t, Laurent Pinchart\n\t","Subject":"Re: [PATCH RFC 1/3] ipa: core: add IPASensorDelays structure","Date":"Thu, 31 Oct 2024 16:39:02 +0300","In-reply-to":"<87v7x8inz9.fsf@redhat.com>","Message-ID":"<87o730pex3.fsf@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]