[{"id":31973,"web_url":"https://patchwork.libcamera.org/comment/31973/","msgid":"<08dd09d6-f241-441b-9acf-a700c5a2545c@ideasonboard.com>","date":"2024-10-31T05:44:28","subject":"Re: [PATCH] libcamera: rkisp1: Create main buffer pool out of\n\tif(!isRaw)","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Jacopo\n\nThank you for the patch.\n\nOn 28/10/24 3:45 pm, Jacopo Mondi wrote:\n> The \"useDewarper_\" class variable is set to true during configure\n> only if the configuration is !isRaw.\n>\n> The main path buffer pool creation can thus be moved out of the\n> if (!isRaw) block at allocateBuffers() time.\n>\n> Cosmetic change that will make it easier to create a buffer pool\n> for the main and self paths unconditionally in future.\n>\n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Umang Jain \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 16 ++++++++--------\n> 1 file changed, 8 insertions(+), 8 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 83b74b27652f..20fb9765727f 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -927,16 +927,16 @@ int PipelineHandlerRkISP1::allocateBuffers(Camera *camera)\n> \t\tret = stat_->allocateBuffers(maxCount, &statBuffers_);\n> \t\tif (ret < 0)\n> \t\t\tgoto error;\n> +\t}\n> \n> -\t\t/* If the dewarper is being used, allocate internal buffers for ISP. */\n> -\t\tif (useDewarper_) {\n> -\t\t\tret = mainPath_.exportBuffers(maxCount, &mainPathBuffers_);\n> -\t\t\tif (ret < 0)\n> -\t\t\t\tgoto error;\n> +\t/* If the dewarper is being used, allocate internal buffers for ISP. */\n> +\tif (useDewarper_) {\n> +\t\tret = mainPath_.exportBuffers(maxCount, &mainPathBuffers_);\n> +\t\tif (ret < 0)\n> +\t\t\tgoto error;\n> \n> -\t\t\tfor (std::unique_ptr &buffer : mainPathBuffers_)\n> -\t\t\t\tavailableMainPathBuffers_.push(buffer.get());\n> -\t\t}\n> +\t\tfor (std::unique_ptr &buffer : mainPathBuffers_)\n> +\t\t\tavailableMainPathBuffers_.push(buffer.get());\n> \t}\n> \n> \tfor (std::unique_ptr &buffer : paramBuffers_) {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96038C31E9\n\tfor ;\n\tThu, 31 Oct 2024 05:44:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B8402653AA;\n\tThu, 31 Oct 2024 06:44:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 926C86539A\n\tfor ;\n\tThu, 31 Oct 2024 06:44:32 +0100 (CET)","from [IPV6:2405:201:2015:f873:c173:4b:4a04:3a21] (unknown\n\t[IPv6:2405:201:2015:f873:c173:4b:4a04:3a21])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7CFC2842;\n\tThu, 31 Oct 2024 06:44:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tFLuB33Y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730353468;\n\tbh=A+PAMkV11h/oJKtNZrjiP8SVPx8Znk3od87CdeeBcRk=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=tFLuB33Y2l4W/KHyb/OOs8OlOkc/t7O2RcUHE8zg2iKyDHAa4uRc9NYU7bzvkXBxw\n\tyDg9OCu+UbLH/pqDR3dLx8HTqNECqKeVltfmRlaehnj1seBM+4EW4al7xsjeOzF2mI\n\t0DyAum0KfCvHVLVcATI9l52iJOX1CZB5zgi1dxdw=","Message-ID":"<08dd09d6-f241-441b-9acf-a700c5a2545c@ideasonboard.com>","Date":"Thu, 31 Oct 2024 11:14:28 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] libcamera: rkisp1: Create main buffer pool out of\n\tif(!isRaw)","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20241028101525.21369-1-jacopo.mondi@ideasonboard.com>","Content-Language":"en-US","From":"Umang Jain ","In-Reply-To":"<20241028101525.21369-1-jacopo.mondi@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]