[{"id":31930,"web_url":"https://patchwork.libcamera.org/comment/31930/","msgid":"<4wyxs2hl7hmdgmgn3do2fws722tjkmoce6os2l2a2injbymva7@2yrt2meapsgg>","date":"2024-10-28T07:28:01","subject":"Re: [PATCH v2] libcamera: formats: Change bytesPerGroup of RGB565\n\tand RGB565_BE from 3 to 2","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hello Hou Qui\n thanks for the patch\n\nOn Mon, Oct 28, 2024 at 12:04:28PM +0900, Hou Qi wrote:\n> The RGB565 and RGB565_BE formats incorrectly specify a wrong value\n> of 3 bytes per group of pixels, when they actually use 2. Fix them.\n>\n> Signed-off-by: Hou Qi \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/formats.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index dbefb094..bfcdfc08 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -157,7 +157,7 @@ const std::map pixelFormatInfo{\n> \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> \t\t.packed = false,\n> \t\t.pixelsPerGroup = 1,\n> -\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n> +\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n> \t} },\n> \t{ formats::RGB565_BE, {\n> \t\t.name = \"RGB565_BE\",\n> @@ -167,7 +167,7 @@ const std::map pixelFormatInfo{\n> \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> \t\t.packed = false,\n> \t\t.pixelsPerGroup = 1,\n> -\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n> +\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n> \t} },\n> \t{ formats::BGR888, {\n> \t\t.name = \"BGR888\",\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A403C3220\n\tfor ;\n\tMon, 28 Oct 2024 07:28:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 52C986539F;\n\tMon, 28 Oct 2024 08:28:08 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A8FD660360\n\tfor ;\n\tMon, 28 Oct 2024 08:28:06 +0100 (CET)","from ideasonboard.com (mob-5-90-59-111.net.vodafone.it\n\t[5.90.59.111])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D9BB7B0B;\n\tMon, 28 Oct 2024 08:28:04 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BbMsKCYy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730100485;\n\tbh=bTqeC4D4ZVkWXuHdSR5Js2ZwsfUolhkfo3bjeHq8vDY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BbMsKCYyeB8WcZNYH8V4LnkoQZT+iBOfXdUs4yGyYxZKhhTlSs6GjW6cj6SYL0Mzm\n\t61eEQIaQ+4peel2tA+W/cb5mMoq08O4XZvAgW1HwobhAWG//sM/QeZj/WDwj/jlLZq\n\t1+TriN0xYh5bMyFROpf3CS0SzE/gag7bEOPrWn90=","Date":"Mon, 28 Oct 2024 08:28:01 +0100","From":"Jacopo Mondi ","To":"Hou Qi ","Cc":"libcamera-devel@lists.libcamera.org, jared.hu@nxp.com, \n\tjulien.vuillaumier@nxp.com","Subject":"Re: [PATCH v2] libcamera: formats: Change bytesPerGroup of RGB565\n\tand RGB565_BE from 3 to 2","Message-ID":"<4wyxs2hl7hmdgmgn3do2fws722tjkmoce6os2l2a2injbymva7@2yrt2meapsgg>","References":"<20241028030428.1813579-1-qi.hou@nxp.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241028030428.1813579-1-qi.hou@nxp.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31943,"web_url":"https://patchwork.libcamera.org/comment/31943/","msgid":"<20241028163526.GC26852@pendragon.ideasonboard.com>","date":"2024-10-28T16:35:26","subject":"Re: [PATCH v2] libcamera: formats: Change bytesPerGroup of RGB565\n\tand RGB565_BE from 3 to 2","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hou,\n\nThank you for the patch.\n\nOn Mon, Oct 28, 2024 at 12:04:28PM +0900, Hou Qi wrote:\n> The RGB565 and RGB565_BE formats incorrectly specify a wrong value\n> of 3 bytes per group of pixels, when they actually use 2. Fix them.\n> \n> Signed-off-by: Hou Qi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/formats.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index dbefb094..bfcdfc08 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -157,7 +157,7 @@ const std::map pixelFormatInfo{\n> \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> \t\t.packed = false,\n> \t\t.pixelsPerGroup = 1,\n> -\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n> +\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n> \t} },\n> \t{ formats::RGB565_BE, {\n> \t\t.name = \"RGB565_BE\",\n> @@ -167,7 +167,7 @@ const std::map pixelFormatInfo{\n> \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> \t\t.packed = false,\n> \t\t.pixelsPerGroup = 1,\n> -\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n> +\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n> \t} },\n> \t{ formats::BGR888, {\n> \t\t.name = \"BGR888\",","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A2540C3220\n\tfor ;\n\tMon, 28 Oct 2024 16:35:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8FA786539E;\n\tMon, 28 Oct 2024 17:35:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CDCFA60367\n\tfor ;\n\tMon, 28 Oct 2024 17:35:31 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AC45F641;\n\tMon, 28 Oct 2024 17:35:29 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VjJB8EoN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730133329;\n\tbh=DASBa7VvBScHMLU9HtQE/OXgTawmhV48orelhRcqAhg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VjJB8EoNt9sgIHdDozwCZZh1+0C0b+xlYJBNC8J2oZHo8NP/hIgWTmUDOr9UDqv6O\n\ttut0iPFfhvr2PaWRWQUizIPyPAFMvJB39rLLi1mMTd5ArW12tnXjvs2Qpoy1YGU8f5\n\tfd96mR3/BVUuZeVXZfMkgCxeSR+fPxkTDQDR84Ik=","Date":"Mon, 28 Oct 2024 18:35:26 +0200","From":"Laurent Pinchart ","To":"Hou Qi ","Cc":"libcamera-devel@lists.libcamera.org, jared.hu@nxp.com,\n\tjulien.vuillaumier@nxp.com","Subject":"Re: [PATCH v2] libcamera: formats: Change bytesPerGroup of RGB565\n\tand RGB565_BE from 3 to 2","Message-ID":"<20241028163526.GC26852@pendragon.ideasonboard.com>","References":"<20241028030428.1813579-1-qi.hou@nxp.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241028030428.1813579-1-qi.hou@nxp.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]