[{"id":31929,"web_url":"https://patchwork.libcamera.org/comment/31929/","msgid":"","date":"2024-10-28T07:27:03","subject":"Re: [PATCH] ipa: libipa: Fix ExposureModeHelper function name in\n\tdocumentation","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Mon, Oct 28, 2024 at 03:14:59AM +0200, Laurent Pinchart wrote:\n> Previous iterations of the ExposureModeHelper class had a\n> setShutterGainLimits() function, which got renamed to setLimits(). The\n> documentation still uses the old name. Fix it.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n> ---\n> src/ipa/libipa/exposure_mode_helper.cpp | 13 +++++--------\n> 1 file changed, 5 insertions(+), 8 deletions(-)\n>\n> diff --git a/src/ipa/libipa/exposure_mode_helper.cpp b/src/ipa/libipa/exposure_mode_helper.cpp\n> index 7703becc4766..30da0c894044 100644\n> --- a/src/ipa/libipa/exposure_mode_helper.cpp\n> +++ b/src/ipa/libipa/exposure_mode_helper.cpp\n> @@ -67,7 +67,7 @@ namespace ipa {\n> * encompasses both analogue and digital gain.\n> *\n> * The vector of stages may be empty. In that case, the helper will simply use\n> - * the runtime limits set through setShutterGainLimits() instead.\n> + * the runtime limits set through setLimits() instead.\n> */\n> ExposureModeHelper::ExposureModeHelper(const Span> stages)\n> {\n> @@ -213,28 +213,25 @@ ExposureModeHelper::splitExposure(utils::Duration exposure) const\n> /**\n> * \\fn ExposureModeHelper::minShutter()\n> * \\brief Retrieve the configured minimum shutter time limit set through\n> - * setShutterGainLimits()\n> + * setLimits()\n> * \\return The minShutter_ value\n> */\n>\n> /**\n> * \\fn ExposureModeHelper::maxShutter()\n> - * \\brief Retrieve the configured maximum shutter time set through\n> - * setShutterGainLimits()\n> + * \\brief Retrieve the configured maximum shutter time set through setLimits()\n> * \\return The maxShutter_ value\n> */\n>\n> /**\n> * \\fn ExposureModeHelper::minGain()\n> - * \\brief Retrieve the configured minimum gain set through\n> - * setShutterGainLimits()\n> + * \\brief Retrieve the configured minimum gain set through setLimits()\n> * \\return The minGain_ value\n> */\n>\n> /**\n> * \\fn ExposureModeHelper::maxGain()\n> - * \\brief Retrieve the configured maximum gain set through\n> - * setShutterGainLimits()\n> + * \\brief Retrieve the configured maximum gain set through setLimits()\n> * \\return The maxGain_ value\n> */\n>\n>\n> base-commit: 80a7ccd3add45eb56fda6f1fb445017ac01fea7a\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7B0AFC3220\n\tfor ;\n\tMon, 28 Oct 2024 07:27:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A5BAA65399;\n\tMon, 28 Oct 2024 08:27:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E34D60360\n\tfor ;\n\tMon, 28 Oct 2024 08:27:09 +0100 (CET)","from ideasonboard.com (mob-5-90-59-111.net.vodafone.it\n\t[5.90.59.111])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0221D594;\n\tMon, 28 Oct 2024 08:27:06 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pMZXy+3S\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730100427;\n\tbh=kx8C3VTA6RItyyni+39gm3dHNs5KdFlplaAQc4oaX4I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pMZXy+3Sj4GFUHeX4O4Dqm5beX6xrvStDickC64XY+eauIf2c1ICtYn7J3cKWkyLp\n\tYFYDVoaMDDwLa4WFd2ZNQVUCkNXEMPpD6W1NDYjGpqfuqfQSKGi0+V1zk98uTRVR/I\n\tE4dJx7D4xdQWHBgzfCMbHvqvjN501RnvFOEW6nEc=","Date":"Mon, 28 Oct 2024 08:27:03 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] ipa: libipa: Fix ExposureModeHelper function name in\n\tdocumentation","Message-ID":"","References":"<20241028011459.696-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241028011459.696-1-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31931,"web_url":"https://patchwork.libcamera.org/comment/31931/","msgid":"","date":"2024-10-28T09:24:17","subject":"Re: [PATCH] ipa: libipa: Fix ExposureModeHelper function name in\n\tdocumentation","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Laurent\n\nOn 28/10/2024 01:14, Laurent Pinchart wrote:\n> Previous iterations of the ExposureModeHelper class had a\n> setShutterGainLimits() function, which got renamed to setLimits(). The\n> documentation still uses the old name.\n\n\nOops\n\n> Fix it.\n>\n> Signed-off-by: Laurent Pinchart \nReviewed-by: Daniel Scally \n> ---\n> src/ipa/libipa/exposure_mode_helper.cpp | 13 +++++--------\n> 1 file changed, 5 insertions(+), 8 deletions(-)\n>\n> diff --git a/src/ipa/libipa/exposure_mode_helper.cpp b/src/ipa/libipa/exposure_mode_helper.cpp\n> index 7703becc4766..30da0c894044 100644\n> --- a/src/ipa/libipa/exposure_mode_helper.cpp\n> +++ b/src/ipa/libipa/exposure_mode_helper.cpp\n> @@ -67,7 +67,7 @@ namespace ipa {\n> * encompasses both analogue and digital gain.\n> *\n> * The vector of stages may be empty. In that case, the helper will simply use\n> - * the runtime limits set through setShutterGainLimits() instead.\n> + * the runtime limits set through setLimits() instead.\n> */\n> ExposureModeHelper::ExposureModeHelper(const Span> stages)\n> {\n> @@ -213,28 +213,25 @@ ExposureModeHelper::splitExposure(utils::Duration exposure) const\n> /**\n> * \\fn ExposureModeHelper::minShutter()\n> * \\brief Retrieve the configured minimum shutter time limit set through\n> - * setShutterGainLimits()\n> + * setLimits()\n> * \\return The minShutter_ value\n> */\n> \n> /**\n> * \\fn ExposureModeHelper::maxShutter()\n> - * \\brief Retrieve the configured maximum shutter time set through\n> - * setShutterGainLimits()\n> + * \\brief Retrieve the configured maximum shutter time set through setLimits()\n> * \\return The maxShutter_ value\n> */\n> \n> /**\n> * \\fn ExposureModeHelper::minGain()\n> - * \\brief Retrieve the configured minimum gain set through\n> - * setShutterGainLimits()\n> + * \\brief Retrieve the configured minimum gain set through setLimits()\n> * \\return The minGain_ value\n> */\n> \n> /**\n> * \\fn ExposureModeHelper::maxGain()\n> - * \\brief Retrieve the configured maximum gain set through\n> - * setShutterGainLimits()\n> + * \\brief Retrieve the configured maximum gain set through setLimits()\n> * \\return The maxGain_ value\n> */\n> \n>\n> base-commit: 80a7ccd3add45eb56fda6f1fb445017ac01fea7a","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EE4B6C3220\n\tfor ;\n\tMon, 28 Oct 2024 09:24:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 03C2E6539E;\n\tMon, 28 Oct 2024 10:24:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9988060360\n\tfor ;\n\tMon, 28 Oct 2024 10:24:20 +0100 (CET)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DBBCA641\n\tfor ;\n\tMon, 28 Oct 2024 10:24:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"S6pA3pSk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730107458;\n\tbh=L07A7fEpbWZTVftpi2Yb9tqQS4UsH48Y3Prz8cuB/MA=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=S6pA3pSkY2T9gwPE+q+SyXpnZK4nCrjtc9Our4In5PcNGWuglZX8/uhwCcJyHjwHt\n\tjDOOWtQSj++L1ZwHuPKFKwSnPyK2lkVfMrGblmnNqTdvO0PtbitZaxdwiCLZNNlV4K\n\tqv87NLpTsxGfPzVS8bITnTJG4l1J4FsyOPgvUwS4=","Message-ID":"","Date":"Mon, 28 Oct 2024 09:24:17 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] ipa: libipa: Fix ExposureModeHelper function name in\n\tdocumentation","To":"libcamera-devel@lists.libcamera.org","References":"<20241028011459.696-1-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20241028011459.696-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]