[{"id":31918,"web_url":"https://patchwork.libcamera.org/comment/31918/","msgid":"<tfguhgirnnth2d7errw7unzazcmzdzmomnsbrndrqna7qxk7vj@nh6ikwewjrrr>","date":"2024-10-25T08:40:45","subject":"Re: [PATCH] libcamera: formats: Change bytesPerGroup of RGB16 from 3\n\tto 2","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Hou Qi,\n  thanks for the patch\n\nin subject: s/RGB16/RGB565/\n\nOn Fri, Oct 25, 2024 at 12:31:25PM +0900, Hou Qi wrote:\n> Change the bytesPerGroup in plane[0] of RGB16 format from 3 to 2,\n\nSame here, let's mention RGB565 and RGB565_BE formats explicitly\n\n> otherwise calculated stride using below formula will be incorrect.\n>\n> /* ceil(width / pixelsPerGroup) * bytesPerGroup */\n> unsigned int stride = (width + pixelsPerGroup - 1) / pixelsPerGroup\n> \t    * planes[plane].bytesPerGroup;\n> ---\n>  src/libcamera/formats.cpp | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index dbefb094..bfcdfc08 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -157,7 +157,7 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n>  \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n>  \t\t.packed = false,\n>  \t\t.pixelsPerGroup = 1,\n> -\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n> +\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n\nRGB565 is indeed 2 bytes per pixel group, unless I'm missing something\nreally obvious, as it seems weird this went unnoticed. Maybe RGB565 is\nnot that popular ?\n\nAnyway, to me this looks correct\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n\nThanks\n  j\n\n>  \t} },\n>  \t{ formats::RGB565_BE, {\n>  \t\t.name = \"RGB565_BE\",\n> @@ -167,7 +167,7 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n>  \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n>  \t\t.packed = false,\n>  \t\t.pixelsPerGroup = 1,\n> -\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n> +\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n>  \t} },\n>  \t{ formats::BGR888, {\n>  \t\t.name = \"BGR888\",\n> --\n> 2.34.1\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2B27BC3220\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 25 Oct 2024 08:40:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 790E365394;\n\tFri, 25 Oct 2024 10:40:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F98A6538A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 25 Oct 2024 10:40:48 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B0164670;\n\tFri, 25 Oct 2024 10:38:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"m3Fk4Kqd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729845539;\n\tbh=G8klyJZHnPTsdSe/qLpRzWS1J2JWX3h+xL/oFDZ/n6E=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=m3Fk4KqdkMm1rZhxTNSYbWcecaDLehQ0xjoOTmo9M3kYKTuSLSVZGpiPgoKBcUBku\n\tQovHtx/u6PVb8kpa/YrQ2516Xv2YglgCgA7QTUtP1u3KOjIuzFHHm2P9P8xawVDDaC\n\txiafclWGmDX/w1UQQ/TO7LdZT0+G4HxeEiT8yMis=","Date":"Fri, 25 Oct 2024 10:40:45 +0200","From":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","To":"Hou Qi <qi.hou@nxp.com>","Cc":"libcamera-devel@lists.libcamera.org, jared.hu@nxp.com, \n\tjulien.vuillaumier@nxp.com","Subject":"Re: [PATCH] libcamera: formats: Change bytesPerGroup of RGB16 from 3\n\tto 2","Message-ID":"<tfguhgirnnth2d7errw7unzazcmzdzmomnsbrndrqna7qxk7vj@nh6ikwewjrrr>","References":"<20241025033125.2275054-1-qi.hou@nxp.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241025033125.2275054-1-qi.hou@nxp.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":31925,"web_url":"https://patchwork.libcamera.org/comment/31925/","msgid":"<20241027180247.GA24052@pendragon.ideasonboard.com>","date":"2024-10-27T18:02:47","subject":"Re: [PATCH] libcamera: formats: Change bytesPerGroup of RGB16 from 3\n\tto 2","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Oct 25, 2024 at 10:40:45AM +0200, Jacopo Mondi wrote:\n> Hi Hou Qi,\n>   thanks for the patch\n> \n> in subject: s/RGB16/RGB565/\n> \n> On Fri, Oct 25, 2024 at 12:31:25PM +0900, Hou Qi wrote:\n> > Change the bytesPerGroup in plane[0] of RGB16 format from 3 to 2,\n> \n> Same here, let's mention RGB565 and RGB565_BE formats explicitly\n\nYou could write\n\nThe RGB565 and RGB565_BE formats incorrectly specify a wrong value of 3\nbytes per group of pixels, when they actually use 2. Fix them.\n\nor something like that.\n\n> > otherwise calculated stride using below formula will be incorrect.\n> >\n> > /* ceil(width / pixelsPerGroup) * bytesPerGroup */\n> > unsigned int stride = (width + pixelsPerGroup - 1) / pixelsPerGroup\n> > \t    * planes[plane].bytesPerGroup;\n\nYour Signed-off-by line is missing. See\nhttps://libcamera.org/contributing.html#submitting-patches\n\n> > ---\n> >  src/libcamera/formats.cpp | 4 ++--\n> >  1 file changed, 2 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> > index dbefb094..bfcdfc08 100644\n> > --- a/src/libcamera/formats.cpp\n> > +++ b/src/libcamera/formats.cpp\n> > @@ -157,7 +157,7 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n> >  \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> >  \t\t.packed = false,\n> >  \t\t.pixelsPerGroup = 1,\n> > -\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n> > +\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n> \n> RGB565 is indeed 2 bytes per pixel group, unless I'm missing something\n> really obvious, as it seems weird this went unnoticed. Maybe RGB565 is\n> not that popular ?\n> \n> Anyway, to me this looks correct\n> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n\nThe change looks fine. I could update the subject and commit message\nmyself, but I can't add your Signed-off-by line. Could you send a v2 ?\n\n> >  \t} },\n> >  \t{ formats::RGB565_BE, {\n> >  \t\t.name = \"RGB565_BE\",\n> > @@ -167,7 +167,7 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n> >  \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> >  \t\t.packed = false,\n> >  \t\t.pixelsPerGroup = 1,\n> > -\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n> > +\t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n> >  \t} },\n> >  \t{ formats::BGR888, {\n> >  \t\t.name = \"BGR888\",","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8117BC3226\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 27 Oct 2024 18:02:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6ADD46539E;\n\tSun, 27 Oct 2024 19:02:54 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 91E9E65398\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 27 Oct 2024 19:02:52 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1ECD9AF;\n\tSun, 27 Oct 2024 19:02:51 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CM8E2Ok2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730052171;\n\tbh=KV01xPU7nsfM6IPn8jJYWumwCzJWSWijSf8/xXljr4k=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CM8E2Ok2zBAcpnlG2vkp+CtuDNyknI75fJNKP4wQsoX8BXCHg/RUIdPyCk5/UwYvo\n\to2c/pUDtU9JjnHZtqo00vyej27spIagdGzUeJQ5EuAaq/HbXCII9ZWreDkdRdYfIIh\n\tIPufag8hcrRIkjo2tmmDgiOsFi+QKJ+tP1mjZIOw=","Date":"Sun, 27 Oct 2024 20:02:47 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Cc":"Hou Qi <qi.hou@nxp.com>, libcamera-devel@lists.libcamera.org,\n\tjared.hu@nxp.com, julien.vuillaumier@nxp.com","Subject":"Re: [PATCH] libcamera: formats: Change bytesPerGroup of RGB16 from 3\n\tto 2","Message-ID":"<20241027180247.GA24052@pendragon.ideasonboard.com>","References":"<20241025033125.2275054-1-qi.hou@nxp.com>\n\t<tfguhgirnnth2d7errw7unzazcmzdzmomnsbrndrqna7qxk7vj@nh6ikwewjrrr>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<tfguhgirnnth2d7errw7unzazcmzdzmomnsbrndrqna7qxk7vj@nh6ikwewjrrr>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":31928,"web_url":"https://patchwork.libcamera.org/comment/31928/","msgid":"<PAXPR04MB828501EC36782B58EA6E5A4D974A2@PAXPR04MB8285.eurprd04.prod.outlook.com>","date":"2024-10-28T03:06:55","subject":"RE: [EXT] Re: [PATCH] libcamera: formats: Change bytesPerGroup of\n\tRGB16 from 3 to 2","submitter":{"id":195,"url":"https://patchwork.libcamera.org/api/people/195/","name":"Qi Hou","email":"qi.hou@nxp.com"},"content":"Hi Laurent Pinchart and Jacopo Mondi\n\nThank you for your review, I have sent out the v2.\n\nRegards,\nQi Hou\n\n-----Original Message-----\nFrom: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSent: 2024年10月28日 2:03\nTo: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nCc: Qi Hou <qi.hou@nxp.com>; libcamera-devel@lists.libcamera.org; Jared Hu <jared.hu@nxp.com>; Julien Vuillaumier <julien.vuillaumier@nxp.com>\nSubject: [EXT] Re: [PATCH] libcamera: formats: Change bytesPerGroup of RGB16 from 3 to 2\n\nCaution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button\n\n\nOn Fri, Oct 25, 2024 at 10:40:45AM +0200, Jacopo Mondi wrote:\n> Hi Hou Qi,\n>   thanks for the patch\n>\n> in subject: s/RGB16/RGB565/\n>\n> On Fri, Oct 25, 2024 at 12:31:25PM +0900, Hou Qi wrote:\n> > Change the bytesPerGroup in plane[0] of RGB16 format from 3 to 2,\n>\n> Same here, let's mention RGB565 and RGB565_BE formats explicitly\n\nYou could write\n\nThe RGB565 and RGB565_BE formats incorrectly specify a wrong value of 3 bytes per group of pixels, when they actually use 2. Fix them.\n\nor something like that.\n\n> > otherwise calculated stride using below formula will be incorrect.\n> >\n> > /* ceil(width / pixelsPerGroup) * bytesPerGroup */ unsigned int\n> > stride = (width + pixelsPerGroup - 1) / pixelsPerGroup\n> >         * planes[plane].bytesPerGroup;\n\nYour Signed-off-by line is missing. See\nhttps://libcamera.org/contributing.html#submitting-patches\n\n> > ---\n> >  src/libcamera/formats.cpp | 4 ++--\n> >  1 file changed, 2 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> > index dbefb094..bfcdfc08 100644\n> > --- a/src/libcamera/formats.cpp\n> > +++ b/src/libcamera/formats.cpp\n> > @@ -157,7 +157,7 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n> >             .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> >             .packed = false,\n> >             .pixelsPerGroup = 1,\n> > -           .planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n> > +           .planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n>\n> RGB565 is indeed 2 bytes per pixel group, unless I'm missing something\n> really obvious, as it seems weird this went unnoticed. Maybe RGB565 is\n> not that popular ?\n>\n> Anyway, to me this looks correct\n> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n\nThe change looks fine. I could update the subject and commit message myself, but I can't add your Signed-off-by line. Could you send a v2 ?\n\n> >     } },\n> >     { formats::RGB565_BE, {\n> >             .name = \"RGB565_BE\",\n> > @@ -167,7 +167,7 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n> >             .colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> >             .packed = false,\n> >             .pixelsPerGroup = 1,\n> > -           .planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n> > +           .planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n> >     } },\n> >     { formats::BGR888, {\n> >             .name = \"BGR888\",\n\n--\nRegards,\n\nLaurent Pinchart","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 743F8BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 28 Oct 2024 03:07:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A54506539F;\n\tMon, 28 Oct 2024 04:07:00 +0100 (CET)","from EUR05-AM6-obe.outbound.protection.outlook.com\n\t(mail-am6eur05on20615.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:2612::615])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F0F060360\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Oct 2024 04:06:57 +0100 (CET)","from PAXPR04MB8285.eurprd04.prod.outlook.com\n\t(2603:10a6:102:1ca::15)\n\tby GVXPR04MB10518.eurprd04.prod.outlook.com (2603:10a6:150:1eb::15)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.25;\n\tMon, 28 Oct 2024 03:06:55 +0000","from PAXPR04MB8285.eurprd04.prod.outlook.com\n\t([fe80::e003:8fb:64ea:acfd]) by\n\tPAXPR04MB8285.eurprd04.prod.outlook.com\n\t([fe80::e003:8fb:64ea:acfd%6]) with mapi id 15.20.8093.021;\n\tMon, 28 Oct 2024 03:06:55 +0000"],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"m/W+mCvY\";\n\tdkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=er7moO/ON4XLnhbxOctSlySYNN7WO5WkUUnJje1Pdii6TzqeiQRBqOCn2MYHEA5uxQUKf5TFmvJ6wW2Ojj2KTRGxZBwgRRZXV2QH8SyDdv7t+hKo+4ApEBA6WCw9rBHBU4AB0Y7dhydHwlzYMr5Nf5we5wDtBD1MfJgJJuJQiaAJrgRnA2xfcJea9OtgyTc3twiK0Ur47AVChNuU0ZmXRx4i7e85VKuxJxQWYemv7FP/apxl2UAA9SdBb08YwuYOec97HMlrD+D2GMhuYtWfgiq5rPhEzCL4YCQ0nESmjoEAUxh2UcEty9mdSI4QZkORqgVuZPkFPuPHls7/neO6yw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=4bnpU7TK7zkDJCVIgugaXyGtmO9fCkWq/nk/nbUDFdU=;\n\tb=jIKzQgsknAx9PBwFJn4C4amjgS/Xymx166/DBnWOa5duorrLyiCi9InU8ENVtzLcaF+h1tse3RVg6xLncBSdQCo6fYE7QdFPEdHn/D6t2IXQSYqzv1K4lmcwVL7tdS3MnkjJhIh/fjLs10EVl5lyK8kex73GXWkqG6cGKYH4NYqq4uINLloSVaIPxyTXeFPMXKCbO/CU5JjK47WP6covpt7hx/SAyzwcbr8z0EoihHCC++1EIH+uTeFIQnpsnmRralOGUgqCybfwGmJqIRXxgXezmDzpDWNQe4Y2DlBQpAgRd2nY9ZvpMFm8UHd/+ZXqmDV5vaLAStAP5aZDnaUBOw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=4bnpU7TK7zkDJCVIgugaXyGtmO9fCkWq/nk/nbUDFdU=;\n\tb=m/W+mCvYcTO5l+9XEzHxRRkhL1RSiEDQx9OVqU6jGq8YIj70IJykxHxvMvLJREPYaM0wPxCYXPTk+tVegwr2PwEjzNaaYp0sGLyyRbWodumLMp/CPeIprUMbVXd8dOhUaFw12vY9cNZtUJAG1P/ezAX64SbgD+eccn2QbzsUfOGBfsJS68ZGvQqLHP//HITSmGf+y/3D0y60YqYXo6ZJqN9+5P/eYdvdn1poUMzu8mhK1Vtqg1u7krWR3sVxyaR1GDJXqw6OBlvJZkDPR28mAdQnVFHfEpqgrUrcn77+CPGOI1ASdWYLshaOmQaW64Kv9Hol0rk8/Us5EG03o1KCsg==","From":"Qi Hou <qi.hou@nxp.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Jacopo Mondi\n\t<jacopo.mondi@ideasonboard.com>","CC":"\"libcamera-devel@lists.libcamera.org\"\n\t<libcamera-devel@lists.libcamera.org>, Jared Hu <jared.hu@nxp.com>,\n\tJulien Vuillaumier <julien.vuillaumier@nxp.com>","Subject":"RE: [EXT] Re: [PATCH] libcamera: formats: Change bytesPerGroup of\n\tRGB16 from 3 to 2","Thread-Topic":"[EXT] Re: [PATCH] libcamera: formats: Change bytesPerGroup of\n\tRGB16 from 3 to 2","Thread-Index":"AQHbJo5t0qJHRz5WCEiGUA+L8Dy6jrKXJg2AgAPBsYCAAJeCYA==","Date":"Mon, 28 Oct 2024 03:06:55 +0000","Message-ID":"<PAXPR04MB828501EC36782B58EA6E5A4D974A2@PAXPR04MB8285.eurprd04.prod.outlook.com>","References":"<20241025033125.2275054-1-qi.hou@nxp.com>\n\t<tfguhgirnnth2d7errw7unzazcmzdzmomnsbrndrqna7qxk7vj@nh6ikwewjrrr>\n\t<20241027180247.GA24052@pendragon.ideasonboard.com>","In-Reply-To":"<20241027180247.GA24052@pendragon.ideasonboard.com>","Accept-Language":"zh-CN, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"m/W+mCvY\";\n\tdkim-atps=neutral","dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;"],"x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"PAXPR04MB8285:EE_|GVXPR04MB10518:EE_","x-ms-office365-filtering-correlation-id":"69344fa3-23ce-458f-7a4a-08dcf6fd947d","x-ld-processed":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n\tARA:13230040|376014|1800799024|366016|38070700018; ","x-microsoft-antispam-message-info":"=?gb2312?b?dkkzL1dOTTFJSWtoV2ZGa3Vn?=\n\t=?gb2312?b?NzhBd202QlMxWWt2bnlvSE5aYUNISTRuNk5PY1dHRjlDQjlYYTRO?=\n\t=?gb2312?b?QjVZZzJxTy9tOThsR0dhZUY1dk9yUGNWQ1JLS214UVJGQkcvQ24z?=\n\t=?gb2312?b?cXUweGtUdkhnT2Q5ek5wZ3N0WWNXZVN0ZlFWVzBTMnQ3SERUaUZ1?=\n\t=?gb2312?b?N3lQVUpIcWZSVlMrcStmbUdoMnIvQWhrcEMvK0VmYk9sTENJT21l?=\n\t=?gb2312?b?MktlZjNZUzRYb2E0ZnBYZHNqRXlDQ3FuQStuVFF3cHMrSjQwNkxW?=\n\t=?gb2312?b?S21TYXJScGxoQS9nVnhPSk1YREZPNXNYbWVsV29yR1pKRHUwV0tk?=\n\t=?gb2312?b?dHFXSTBnTzZodGh1L0JkVlhEVU5yYXB2SEtOSlpKUlRlSVJPUEdz?=\n\t=?gb2312?b?Qm1GeC9ORlRXKy85Uy8rVUpmMldlamgxUXE4YThDRUZ4WUpNVjlQ?=\n\t=?gb2312?b?WWU4enR4UlpYRjNYNmlTc0w5ZmJRZVRKR3lxbXNVbkVtdFErMG9F?=\n\t=?gb2312?b?cmJxSXlUZnN0RVI5aFNpUVdaYlAxZzNwUFZOZ0hZL1hTOEJPN1Q2?=\n\t=?gb2312?b?ZGErZjJBK0NWYzdqV3NFY3hKVFhGR2d5L2MzY3gvM2lidURCN3Rj?=\n\t=?gb2312?b?VTBPOHV6eWdmVUx6eHVydUdpTXJwVXhnWFNGTCtNcmFvaWd6Wm0r?=\n\t=?gb2312?b?YXBOYno5TEhHVFg5a2xsTW5PTTQ5SEIrVmtvTFpXZHE3S25SbW5W?=\n\t=?gb2312?b?UjBtQjNhM3cvYm9USkNMWnovbXc0a3RqNUFacUYvUnlVbUdBOVFh?=\n\t=?gb2312?b?QzAwSHl2R0cvdit3OGVvc0wyV0thZkQrSkhkWEJva2VhVVZrTXlV?=\n\t=?gb2312?b?MXl6b3RpQXNJZWROTjAvUzNOc1huS3pDb3lkMkdoSHZDNzNLcWdO?=\n\t=?gb2312?b?ZG5JSDJoZ25ONmU2V1dzTStIWStkK1lLSFlYdnRuUGdib3F4dEFi?=\n\t=?gb2312?b?Mk5pbWd6MFFaRUdBSkxmUjFKNGNXZFlDNWtPdzRNekU1eVdYNW1k?=\n\t=?gb2312?b?akhIaE9SK2xJaytYQVVlTjFCL1hIZGkxZTBZdUtIREswZkxUZzVN?=\n\t=?gb2312?b?U0dyUXJQc0RMQkNSMk8wSENDckFVV2Yvb2FxUDlUcFphOCtyRE9Q?=\n\t=?gb2312?b?R3lUTHc3Z2tveEFGTndDb1BuSlFqUDllelpFeUFJQnF6QkNhYmZ1?=\n\t=?gb2312?b?MnRRNzVsNkVqT0l4RUFhS2VmOFlLckduZ3g0NXlhR0hkZGYvSTlw?=\n\t=?gb2312?b?SDRLRW1zenVra25lenBTN1FxN3phZ0Q0ZFNmYU9hc1JYL0d2VVBY?=\n\t=?gb2312?b?aGxVdDU5MEVkYnJQRjd1SGNWc2dTOVdYL3BRNzFNYmdHcld4dWp4?=\n\t=?gb2312?b?bENta1A0QmRwWHlsS2xCbzFNa3I5Mm55dWJQb0pyZzd3dTVaSFZq?=\n\t=?gb2312?b?bTBOUnpnazRwZzl4eGc5RzJnNlpKSG1BajZDZUl5MTBRbjJHekcz?=\n\t=?gb2312?b?Vk1PWnUzalhoY0ZQM0s0akZWeUpFdmhFNmhaZkxKOXZ0N2tMNTQ0?=\n\t=?gb2312?b?dytGQXN0OVB3L0MzNjY2VXhYV0ozQllXdVRVc1RrSWRDK1B0cWlP?=\n\t=?gb2312?b?VjEzampMUHh3MWExSkdGSmNkeFRveCt3YnlleFRpS2hPU285bUZw?=\n\t=?gb2312?b?d3pqWm5hUkJLNXRseFA2Nkk0SzVHQkhwYndsQ3JHTjhJVTBybThV?=\n\t=?gb2312?b?ak9scVl5VjBYWVl6UXp0bFRkMDVOWjNVcytOK2FZYy9MSnExTHFt?=\n\t=?gb2312?b?cENNQzN3cDZ6N2RYVjVxdkxITjF3aGhpL1dkaEFPcXdHYjNGc0t1?=\n\t=?gb2312?b?SmJkRTFHRGg2VFc1SjVDdHdDTER1VkV2b1kvbUFXQ0I1RlhsVUlV?=\n\t=?gb2312?b?MDhLRkl4SVZhbU9iaDJJNFdDdWtCdGIvbmFiVFg5WHorc2VKNEpr?=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:zh-cn; SCL:1; \n\tSRV:; IPV:NLI; SFV:NSPM;\n\tH:PAXPR04MB8285.eurprd04.prod.outlook.com; PTR:; \n\tCAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(38070700018);\n\tDIR:OUT; SFP:1101; ","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"=?gb2312?b?MFAzSENaZkEwWkUrdS9PeHRE?=\n\t=?gb2312?b?ajg2c2drd1NoT09MR2dNdlpzZHI5elJqWjlIWG5mSklsNGpPSUl3?=\n\t=?gb2312?b?NVRaVmRWYUVDTDdoMTN5bUdQQXp0Tmd5MllUWlZORHhLbFo3MFc2?=\n\t=?gb2312?b?aFQ3YWt5MWpIVDNLU3drS1dxeFJIQkFjem5wOW5jMnJkZUoyUzB4?=\n\t=?gb2312?b?RlFVMXZQQWdWbzdYOGJtMlU4eHd6cVRMVkdKc2grc2VpWGwycnlN?=\n\t=?gb2312?b?dnFCZHRhbnV0YjNPejVuaEM4QzNlMHhrVEZXT0psNE9jNFZyTjVC?=\n\t=?gb2312?b?UjhZSGFGbExmN2g2WFNnTXc0SGt0MzJKS29XYmYySGlFQ2FoMjJm?=\n\t=?gb2312?b?NjZHVjk3YXhEWmNQbFNKSXhuNDJHZThCaWpsSU5vV28yNGY0Umpy?=\n\t=?gb2312?b?dGIwb1lFQ0oxMklZbmsraTZQczllK1ZVbk9sN2N3RlRxdS9QVC9I?=\n\t=?gb2312?b?cjZZY1l1RG80bEgzbGtJU2xiZEM0d010bkFVOTZuemxtNEt4Rk4x?=\n\t=?gb2312?b?cGFiUjY4cUJpNUZubmFIZ2FiQ1FoS0hWWjJkTjN2WHI1WEEvMUYr?=\n\t=?gb2312?b?YWJWa0U4MWFJc2dZOCtxZkxiU1VqV0FpcTlDd2h2VG9XUWhmMXUy?=\n\t=?gb2312?b?NWZrbkQ3eHcrWHVISVZrVFlWQThQRlNjZmlhejBoY25yZHdHcnVw?=\n\t=?gb2312?b?M0E3cWEyQUFpcDEvdW1oUngvYjFoemI3VnFtZnB5eW12aXpNMzQ3?=\n\t=?gb2312?b?V1JCVTd0RUx5TFNqUUFGWVNOMytSK0QvWHhwcURyVmF5Y1pwTThX?=\n\t=?gb2312?b?Si8vVTk2ekxvLzB6N0V3TkdSdisyY3ZQMnNvZVVrVTgyWHRmb0gr?=\n\t=?gb2312?b?M2lNNHNtK29pbk5xclJyOHk4a2JUdGxyU3cyWnUrN0ovWXZkUUc3?=\n\t=?gb2312?b?NDRrY1NiTnJuUk43UmZ3K1BlTHVKUDhLakpKbFlMeVY4WFNMTTA2?=\n\t=?gb2312?b?cEJLWkZJY09zVVBQVEV0b1ZubDNuVmJjZWNCMExPUTZ5RzNUNitx?=\n\t=?gb2312?b?MThmRndsNUM1YzNzcWsyWFZvNml6N1AzVHYvZzFzdFpqVDJVMVhh?=\n\t=?gb2312?b?NDQxd2VDc1ZJSU93c0JVbU1YZFNMby9tRUpqOVVpVE5vUWZmbUlH?=\n\t=?gb2312?b?cktjUHV1YStaQzJsZnhTNHQrRkl0TWI3eWlBYmZoaXM2SHNXZEVS?=\n\t=?gb2312?b?Ly9pT0puWDBlQ2pMOEQ4NHJGeWRIM0dLb0Z5Q3ZsTnpzMFljR1Jv?=\n\t=?gb2312?b?RFZsaEJCanUzVUtJV21xUFFXanJjMXk1bHdXa1lNMWcyYjMwRERQ?=\n\t=?gb2312?b?eG9pSkJRQXZmZFNaVGFVSjRDS0FFc1F4ME5NbTl1blp3SDU2ZkJO?=\n\t=?gb2312?b?QmZhbmI5MmJLM2dsUi9SK01JeHBzM29Kb2VyZFZpWUFSczlmNUtI?=\n\t=?gb2312?b?K2JJeVVucCtHNk4rdkcwQkpGdzFxQVNwMUlrbGJyb2ZJc0VKSnN1?=\n\t=?gb2312?b?T1lBM2tvSTBPaHptaWM5MkxsSUpERTZYL1ZtZ1A4eTdMbCtWMmJD?=\n\t=?gb2312?b?Qjl5VDdxNEFkblgxeVhRV0lkSFo0MDJNbEpzRjBOU0E4VmpBTmhY?=\n\t=?gb2312?b?aUxVZ1FqTlFiNStGb0lJU28waEdpcUlJREozNE9YMDZjWEhlMDJr?=\n\t=?gb2312?b?V0lwOVJ5S1c1R1UranpiM1hZSG5veGtvRWlxdlBhY0NjaW9VOE5Z?=\n\t=?gb2312?b?b3ljeHRtMGsxWlk4dWpaa0ZIZlpZY3RsTlhYclh5WHZDNkRJVVpi?=\n\t=?gb2312?b?Yy9tOGR3R1o3VElHd1NXK3VsUlhYaXZ4YmQ5bDNWOFo4Wm4xaEEw?=\n\t=?gb2312?b?YmlsS1pacW9YSDhUVzF5aUxiQTBEQmVBNlZiV3FYOUwvV1MrSEJG?=\n\t=?gb2312?b?YnllVlNDakRnUHdmQTNVZ1kzZ2FySjVPQTd2bDlhQUcyQTRlNHFq?=\n\t=?gb2312?b?SFRuUmJoSTIyRmNNZlFTbG5JdEdxVVB5dytWSEV0R1hCRlZDT1dI?=\n\t=?gb2312?b?Sm1oNHg2UjZwU2IzMzBjdk9mOS9DdFl5WEl3YWt3cFlsYzJicWli?=\n\t=?gb2312?b?bUJDYjlVSkJMc205QUdaZDRib1Z3UmlKYW1GN0lCbEVYaFRrd0hs?=\n\t=?gb2312?b?QlB3c0RuZHVoRHd6c01pbE5tcFYyRi9vUkZvWkRmNVlScVFMeXBT?=\n\t=?gb2312?b?UUZaY2dUTkU3WHd5MzFtaWt1OE1ZYWg5MTRGUlRhbHVGUmhJTzEx?=\n\t=?gb2312?b?OVFIa3g3WjlHVnVBbytqSWNnRnlPdFFrRU51Z1NDN1diVWlHeERy?=\n\t=?gb2312?b?WT0=?=","Content-Type":"text/plain; charset=\"gb2312\"","Content-Transfer-Encoding":"base64","MIME-Version":"1.0","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"PAXPR04MB8285.eurprd04.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"69344fa3-23ce-458f-7a4a-08dcf6fd947d","X-MS-Exchange-CrossTenant-originalarrivaltime":"28 Oct 2024 03:06:55.7877\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"crUgNWgNZuLaZqKONYVvejG0SmQf8xZt+557oQaSPc9eGZQM6J6inSqaaK815l93","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"GVXPR04MB10518","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]