[{"id":31913,"web_url":"https://patchwork.libcamera.org/comment/31913/","msgid":"<172981072579.2721096.9871832038460214204@ping.linuxembedded.co.uk>","date":"2024-10-24T22:58:45","subject":"Re: [PATCH v2 1/2] libcamera: Allow enumerating u32 control type","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Harvey Yang (2024-10-22 10:56:04)\n> From: Yudhistira Erlandinata <yerlandinata@chromium.org>\n> \n> Only allowing V4L2_CTRL_TYPE_U32 control type to be listed in the\n> V4L2Device::controls_, so it can be used together with function\n> V4L2Device::setExtControl. Like many other control types, this type\n> is still not supported in the V4L2Device::getControls and\n> V4L2Device::setControls.\n\nI like this patch, but the commit message ...\n\n'Only allowing' ... sure - of course it's only allowing...  And indeed -\nmany other types aren't supported, if they aren't used yet... Or are you\nsaying there is some missing implementation that even this patch doesn't\nyet add? Or does this patch 'fix' {get,set}Controls?\n\n\nLets try something more simple and clear:\n\n\"\"\"\nV4L2 Controls support a wide variety of types not yet supported by the\nControlValue type system.\n\nExtend the libcamera ControlValue types to support an explicit 32 bit\nunsigned integer type, and map that to the corresponding\nV4L2_CTRL_TYPE_U32 type within the v4l2_device support class.\n\"\"\"\n\nI think the same/similar could be said for the Unsigned 16-bits Control\ntype too..\n\n> \n> Signed-off-by: Yudhistira Erlandinata <yerlandinata@chromium.org>\n> Co-developed-by: Harvey Yang <chenghaoyang@chromium.org>\n> Signed-off-by: Harvey Yang <chenghaoyang@chromium.org>\n> ---\n>  include/libcamera/controls.h  |  7 +++++++\n>  src/libcamera/controls.cpp    | 12 ++++++++++--\n>  src/libcamera/v4l2_device.cpp | 13 +++++++++++++\n\nAll the other ControlTypes look like they have unit tests in\ntest/controls/control_value.cpp.\n\nCould you add something in there for Unsigned32 please?\n\nWith that to align with the other types I'd like to see this merged.\n\n\n\n>  3 files changed, 30 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index ca60bbaca..6da8ad2c3 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -29,6 +29,7 @@ enum ControlType {\n>         ControlTypeNone,\n>         ControlTypeBool,\n>         ControlTypeByte,\n> +       ControlTypeUnsigned32,\n>         ControlTypeInteger32,\n>         ControlTypeInteger64,\n>         ControlTypeFloat,\n> @@ -62,6 +63,12 @@ struct control_type<uint8_t> {\n>         static constexpr std::size_t size = 0;\n>  };\n>  \n> +template<>\n> +struct control_type<uint32_t> {\n> +       static constexpr ControlType value = ControlTypeUnsigned32;\n> +       static constexpr std::size_t size = 0;\n> +};\n> +\n>  template<>\n>  struct control_type<int32_t> {\n>         static constexpr ControlType value = ControlTypeInteger32;\n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index 62185d643..8ae295191 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -54,6 +54,7 @@ static constexpr size_t ControlValueSize[] = {\n>         [ControlTypeNone]               = 0,\n>         [ControlTypeBool]               = sizeof(bool),\n>         [ControlTypeByte]               = sizeof(uint8_t),\n> +       [ControlTypeUnsigned32]         = sizeof(uint32_t),\n>         [ControlTypeInteger32]          = sizeof(int32_t),\n>         [ControlTypeInteger64]          = sizeof(int64_t),\n>         [ControlTypeFloat]              = sizeof(float),\n> @@ -74,10 +75,12 @@ static constexpr size_t ControlValueSize[] = {\n>   * The control stores a boolean value\n>   * \\var ControlTypeByte\n>   * The control stores a byte value as an unsigned 8-bit integer\n> + * \\var ControlTypeUnsigned32\n> + * The control stores an unsigned 32-bit integer value\n>   * \\var ControlTypeInteger32\n> - * The control stores a 32-bit integer value\n> + * The control stores a signed 32-bit integer value\n>   * \\var ControlTypeInteger64\n> - * The control stores a 64-bit integer value\n> + * The control stores a signed 64-bit integer value\n>   * \\var ControlTypeFloat\n>   * The control stores a 32-bit floating point value\n>   * \\var ControlTypeString\n> @@ -230,6 +233,11 @@ std::string ControlValue::toString() const\n>                         str += std::to_string(*value);\n>                         break;\n>                 }\n> +               case ControlTypeUnsigned32: {\n> +                       const uint32_t *value = reinterpret_cast<const uint32_t *>(data);\n> +                       str += std::to_string(*value);\n> +                       break;\n> +               }\n>                 case ControlTypeInteger32: {\n>                         const int32_t *value = reinterpret_cast<const int32_t *>(data);\n>                         str += std::to_string(*value);\n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index 68add4f2e..0ba8dcfa0 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -9,6 +9,7 @@\n>  \n>  #include <fcntl.h>\n>  #include <map>\n> +#include <stdint.h>\n\nCurious that this wasn't already in, as the types are already used - but\nI think it's correct to add it ...\n\nRegards\n--\nKieran\n\n>  #include <stdlib.h>\n>  #include <string.h>\n>  #include <sys/ioctl.h>\n> @@ -17,11 +18,14 @@\n>  #include <vector>\n>  \n>  #include <linux/v4l2-mediabus.h>\n> +#include <linux/videodev2.h>\n>  \n>  #include <libcamera/base/event_notifier.h>\n>  #include <libcamera/base/log.h>\n>  #include <libcamera/base/utils.h>\n>  \n> +#include <libcamera/controls.h>\n> +\n>  #include \"libcamera/internal/formats.h\"\n>  #include \"libcamera/internal/sysfs.h\"\n>  \n> @@ -488,6 +492,9 @@ ControlType V4L2Device::v4l2CtrlType(uint32_t ctrlType)\n>         case V4L2_CTRL_TYPE_BOOLEAN:\n>                 return ControlTypeBool;\n>  \n> +       case V4L2_CTRL_TYPE_U32:\n> +               return ControlTypeUnsigned32;\n> +\n>         case V4L2_CTRL_TYPE_INTEGER:\n>                 return ControlTypeInteger32;\n>  \n> @@ -536,6 +543,11 @@ std::optional<ControlInfo> V4L2Device::v4l2ControlInfo(const v4l2_query_ext_ctrl\n>                                    static_cast<uint8_t>(ctrl.maximum),\n>                                    static_cast<uint8_t>(ctrl.default_value));\n>  \n> +       case V4L2_CTRL_TYPE_U32:\n> +               return ControlInfo(static_cast<uint32_t>(ctrl.minimum),\n> +                                  static_cast<uint32_t>(ctrl.maximum),\n> +                                  static_cast<uint32_t>(ctrl.default_value));\n> +\n>         case V4L2_CTRL_TYPE_BOOLEAN:\n>                 return ControlInfo(static_cast<bool>(ctrl.minimum),\n>                                    static_cast<bool>(ctrl.maximum),\n> @@ -622,6 +634,7 @@ void V4L2Device::listControls()\n>                 case V4L2_CTRL_TYPE_BITMASK:\n>                 case V4L2_CTRL_TYPE_INTEGER_MENU:\n>                 case V4L2_CTRL_TYPE_U8:\n> +               case V4L2_CTRL_TYPE_U32:\n>                         break;\n>                 /* \\todo Support other control types. */\n>                 default:\n> -- \n> 2.47.0.105.g07ac214952-goog\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E44D0C3220\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 24 Oct 2024 22:58:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 145EC65393;\n\tFri, 25 Oct 2024 00:58:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B26A36537E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 25 Oct 2024 00:58:48 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5CD86D21;\n\tFri, 25 Oct 2024 00:57:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WRiYuISN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729810620;\n\tbh=5MOR8lTPSJfNkHba3pKiDR+gcP26firwNQo2g00jtGY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=WRiYuISNKy8yme7sGxgl+zHAGen+Vzp1LPPaCJ73Y4E8N1aXdJjC2gHLLtPQJHSrC\n\tVAN6HfeRtMLf2lK7vVtIctF82KLeGcGb3yMIZ6dsisfHoGmN7UrW4oN9QGUy37p9pU\n\t3DB2vHOgRqyuoKDNVksk3T4L5chfNpdedeHsOz50=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241022095737.4127210-2-chenghaoyang@chromium.org>","References":"<20241022095737.4127210-1-chenghaoyang@chromium.org>\n\t<20241022095737.4127210-2-chenghaoyang@chromium.org>","Subject":"Re: [PATCH v2 1/2] libcamera: Allow enumerating u32 control type","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Yudhistira Erlandinata <yerlandinata@chromium.org>,\n\tHarvey Yang <chenghaoyang@chromium.org>","To":"Harvey Yang <chenghaoyang@chromium.org>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 24 Oct 2024 23:58:45 +0100","Message-ID":"<172981072579.2721096.9871832038460214204@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":31916,"web_url":"https://patchwork.libcamera.org/comment/31916/","msgid":"<CAEB1ahvgknsoEeYtPADexkbtfxodXgYee-Zj9xH+zMCU3AMNjg@mail.gmail.com>","date":"2024-10-25T05:32:42","subject":"Re: [PATCH v2 1/2] libcamera: Allow enumerating u32 control type","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"content":"Hi Kieran,\n\nOn Fri, Oct 25, 2024 at 6:58 AM Kieran Bingham\n<kieran.bingham@ideasonboard.com> wrote:\n>\n> Quoting Harvey Yang (2024-10-22 10:56:04)\n> > From: Yudhistira Erlandinata <yerlandinata@chromium.org>\n> >\n> > Only allowing V4L2_CTRL_TYPE_U32 control type to be listed in the\n> > V4L2Device::controls_, so it can be used together with function\n> > V4L2Device::setExtControl. Like many other control types, this type\n> > is still not supported in the V4L2Device::getControls and\n> > V4L2Device::setControls.\n>\n> I like this patch, but the commit message ...\n>\n> 'Only allowing' ... sure - of course it's only allowing...  And indeed -\n> many other types aren't supported, if they aren't used yet... Or are you\n> saying there is some missing implementation that even this patch doesn't\n> yet add? Or does this patch 'fix' {get,set}Controls?\n>\n>\n> Lets try something more simple and clear:\n>\n> \"\"\"\n> V4L2 Controls support a wide variety of types not yet supported by the\n> ControlValue type system.\n>\n> Extend the libcamera ControlValue types to support an explicit 32 bit\n> unsigned integer type, and map that to the corresponding\n> V4L2_CTRL_TYPE_U32 type within the v4l2_device support class.\n> \"\"\"\n>\n> I think the same/similar could be said for the Unsigned 16-bits Control\n> type too..\n\nThanks! Updated.\n\n>\n> >\n> > Signed-off-by: Yudhistira Erlandinata <yerlandinata@chromium.org>\n> > Co-developed-by: Harvey Yang <chenghaoyang@chromium.org>\n> > Signed-off-by: Harvey Yang <chenghaoyang@chromium.org>\n> > ---\n> >  include/libcamera/controls.h  |  7 +++++++\n> >  src/libcamera/controls.cpp    | 12 ++++++++++--\n> >  src/libcamera/v4l2_device.cpp | 13 +++++++++++++\n>\n> All the other ControlTypes look like they have unit tests in\n> test/controls/control_value.cpp.\n>\n> Could you add something in there for Unsigned32 please?\n\nSure, added and tested on gitlab pipeline.\n\nBR,\nHarvey\n\n>\n> With that to align with the other types I'd like to see this merged.\n>\n>\n>\n> >  3 files changed, 30 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> > index ca60bbaca..6da8ad2c3 100644\n> > --- a/include/libcamera/controls.h\n> > +++ b/include/libcamera/controls.h\n> > @@ -29,6 +29,7 @@ enum ControlType {\n> >         ControlTypeNone,\n> >         ControlTypeBool,\n> >         ControlTypeByte,\n> > +       ControlTypeUnsigned32,\n> >         ControlTypeInteger32,\n> >         ControlTypeInteger64,\n> >         ControlTypeFloat,\n> > @@ -62,6 +63,12 @@ struct control_type<uint8_t> {\n> >         static constexpr std::size_t size = 0;\n> >  };\n> >\n> > +template<>\n> > +struct control_type<uint32_t> {\n> > +       static constexpr ControlType value = ControlTypeUnsigned32;\n> > +       static constexpr std::size_t size = 0;\n> > +};\n> > +\n> >  template<>\n> >  struct control_type<int32_t> {\n> >         static constexpr ControlType value = ControlTypeInteger32;\n> > diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> > index 62185d643..8ae295191 100644\n> > --- a/src/libcamera/controls.cpp\n> > +++ b/src/libcamera/controls.cpp\n> > @@ -54,6 +54,7 @@ static constexpr size_t ControlValueSize[] = {\n> >         [ControlTypeNone]               = 0,\n> >         [ControlTypeBool]               = sizeof(bool),\n> >         [ControlTypeByte]               = sizeof(uint8_t),\n> > +       [ControlTypeUnsigned32]         = sizeof(uint32_t),\n> >         [ControlTypeInteger32]          = sizeof(int32_t),\n> >         [ControlTypeInteger64]          = sizeof(int64_t),\n> >         [ControlTypeFloat]              = sizeof(float),\n> > @@ -74,10 +75,12 @@ static constexpr size_t ControlValueSize[] = {\n> >   * The control stores a boolean value\n> >   * \\var ControlTypeByte\n> >   * The control stores a byte value as an unsigned 8-bit integer\n> > + * \\var ControlTypeUnsigned32\n> > + * The control stores an unsigned 32-bit integer value\n> >   * \\var ControlTypeInteger32\n> > - * The control stores a 32-bit integer value\n> > + * The control stores a signed 32-bit integer value\n> >   * \\var ControlTypeInteger64\n> > - * The control stores a 64-bit integer value\n> > + * The control stores a signed 64-bit integer value\n> >   * \\var ControlTypeFloat\n> >   * The control stores a 32-bit floating point value\n> >   * \\var ControlTypeString\n> > @@ -230,6 +233,11 @@ std::string ControlValue::toString() const\n> >                         str += std::to_string(*value);\n> >                         break;\n> >                 }\n> > +               case ControlTypeUnsigned32: {\n> > +                       const uint32_t *value = reinterpret_cast<const uint32_t *>(data);\n> > +                       str += std::to_string(*value);\n> > +                       break;\n> > +               }\n> >                 case ControlTypeInteger32: {\n> >                         const int32_t *value = reinterpret_cast<const int32_t *>(data);\n> >                         str += std::to_string(*value);\n> > diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> > index 68add4f2e..0ba8dcfa0 100644\n> > --- a/src/libcamera/v4l2_device.cpp\n> > +++ b/src/libcamera/v4l2_device.cpp\n> > @@ -9,6 +9,7 @@\n> >\n> >  #include <fcntl.h>\n> >  #include <map>\n> > +#include <stdint.h>\n>\n> Curious that this wasn't already in, as the types are already used - but\n> I think it's correct to add it ...\n>\n> Regards\n> --\n> Kieran\n>\n> >  #include <stdlib.h>\n> >  #include <string.h>\n> >  #include <sys/ioctl.h>\n> > @@ -17,11 +18,14 @@\n> >  #include <vector>\n> >\n> >  #include <linux/v4l2-mediabus.h>\n> > +#include <linux/videodev2.h>\n> >\n> >  #include <libcamera/base/event_notifier.h>\n> >  #include <libcamera/base/log.h>\n> >  #include <libcamera/base/utils.h>\n> >\n> > +#include <libcamera/controls.h>\n> > +\n> >  #include \"libcamera/internal/formats.h\"\n> >  #include \"libcamera/internal/sysfs.h\"\n> >\n> > @@ -488,6 +492,9 @@ ControlType V4L2Device::v4l2CtrlType(uint32_t ctrlType)\n> >         case V4L2_CTRL_TYPE_BOOLEAN:\n> >                 return ControlTypeBool;\n> >\n> > +       case V4L2_CTRL_TYPE_U32:\n> > +               return ControlTypeUnsigned32;\n> > +\n> >         case V4L2_CTRL_TYPE_INTEGER:\n> >                 return ControlTypeInteger32;\n> >\n> > @@ -536,6 +543,11 @@ std::optional<ControlInfo> V4L2Device::v4l2ControlInfo(const v4l2_query_ext_ctrl\n> >                                    static_cast<uint8_t>(ctrl.maximum),\n> >                                    static_cast<uint8_t>(ctrl.default_value));\n> >\n> > +       case V4L2_CTRL_TYPE_U32:\n> > +               return ControlInfo(static_cast<uint32_t>(ctrl.minimum),\n> > +                                  static_cast<uint32_t>(ctrl.maximum),\n> > +                                  static_cast<uint32_t>(ctrl.default_value));\n> > +\n> >         case V4L2_CTRL_TYPE_BOOLEAN:\n> >                 return ControlInfo(static_cast<bool>(ctrl.minimum),\n> >                                    static_cast<bool>(ctrl.maximum),\n> > @@ -622,6 +634,7 @@ void V4L2Device::listControls()\n> >                 case V4L2_CTRL_TYPE_BITMASK:\n> >                 case V4L2_CTRL_TYPE_INTEGER_MENU:\n> >                 case V4L2_CTRL_TYPE_U8:\n> > +               case V4L2_CTRL_TYPE_U32:\n> >                         break;\n> >                 /* \\todo Support other control types. */\n> >                 default:\n> > --\n> > 2.47.0.105.g07ac214952-goog\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2734EC3220\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 25 Oct 2024 05:32:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CDE5E65395;\n\tFri, 25 Oct 2024 07:32:55 +0200 (CEST)","from mail-lj1-x231.google.com (mail-lj1-x231.google.com\n\t[IPv6:2a00:1450:4864:20::231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0195A60366\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 25 Oct 2024 07:32:54 +0200 (CEST)","by mail-lj1-x231.google.com with SMTP id\n\t38308e7fff4ca-2fb5be4381dso18025581fa.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Oct 2024 22:32:53 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Jxf8OJOR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1729834373; x=1730439173;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=4vgIVG2eIDwMRpFBo1ghAFTw57IYrjhNZoYJgAAN4Mg=;\n\tb=Jxf8OJORVhKzFS8RH5DmfEWiQ8cfKXlN+Wy7CFY0xrdVSDnMZ3Si6HKkrlUS6j09Nf\n\tPJYGv0/zY8zBdy747RkgE/52yORihMFOrkwi1dwtnxYphu77alGfMft3RZCLHCw1ZXeY\n\thQqNXwxCOZtDi/VsBLcj0vXzKyHmIsKuh4OHU=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1729834373; x=1730439173;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=4vgIVG2eIDwMRpFBo1ghAFTw57IYrjhNZoYJgAAN4Mg=;\n\tb=OW56hEnBjo6qUPTVoTv7nTglJWTjsZ9+h4olrG9DXIZ79PJrGPlIK3MA+VUpdRZ+XM\n\tZfoqrdjG1Fq6UYm1WY/914gK/Y6iMW2gIlelcPEK+T7PaMjujErudqCNye3Jss+chjFF\n\tfyjRc9WgDLJjlh9m6b/lDQoFrAxAG5odhZ0CWhQauRb6/xS8Oqhr2T5BbloG2J0dEYKy\n\tISVPK5gDZtEaKkxQS0Q2MwWFg0lP1Y8uWKdM3QtQX/o4brsW67Uq4pkw4wgeA/0JiULm\n\tk8ffQLRrrFQxMsVVMhP8ONbm+T4PPKJ/pDeDOVxwTHzDRphDOn3vi8wfSajH+rymAyJB\n\tx0Ng==","X-Gm-Message-State":"AOJu0Yzc5lsRiofMvlhHi2lIoIHF7x+JNtNND8MpaaP8vSuaS/QCNz7B\n\t/f05rNqzab/eJtXHf27JGI6dNIWGneWWPMbNAcaX+8tGN24dgog2PgDlCD2Kd9n3XmBROPE3dHE\n\trrJZ2Y2Rg6aIFtVpGOrQUAyj2FJOP/s2R+fGqBkd1YPD7t4A=","X-Google-Smtp-Source":"AGHT+IEb+X3hYLFTAP9b/3ZmlyCqqBlI4qJqEHIxn00/VfKfxv5abtsI+9BxpEZZKEul/so4oegDUUs6sCOe4/KqaHQ=","X-Received":"by 2002:a05:651c:550:b0:2fb:4603:da13 with SMTP id\n\t38308e7fff4ca-2fca8265e94mr22858291fa.39.1729834373005;\n\tThu, 24 Oct 2024 22:32:53 -0700 (PDT)","MIME-Version":"1.0","References":"<20241022095737.4127210-1-chenghaoyang@chromium.org>\n\t<20241022095737.4127210-2-chenghaoyang@chromium.org>\n\t<172981072579.2721096.9871832038460214204@ping.linuxembedded.co.uk>","In-Reply-To":"<172981072579.2721096.9871832038460214204@ping.linuxembedded.co.uk>","From":"Cheng-Hao Yang <chenghaoyang@chromium.org>","Date":"Fri, 25 Oct 2024 13:32:42 +0800","Message-ID":"<CAEB1ahvgknsoEeYtPADexkbtfxodXgYee-Zj9xH+zMCU3AMNjg@mail.gmail.com>","Subject":"Re: [PATCH v2 1/2] libcamera: Allow enumerating u32 control type","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org, \n\tYudhistira Erlandinata <yerlandinata@chromium.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]