{"id":21721,"url":"https://patchwork.libcamera.org/api/patches/21721/?format=json","web_url":"https://patchwork.libcamera.org/patch/21721/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241021164946.11111-2-jaslo@ziska.de>","date":"2024-10-21T16:45:31","name":"[v4,1/3] gstreamer: Remove auto-focus-mode property from device provider","commit_ref":"327b0d16a1c7a352cf4a92303134dd2b57b59e6f","pull_url":null,"state":"accepted","archived":false,"hash":"5252e097f22592a18c93ceb04e2a8fe8a389daf9","submitter":{"id":173,"url":"https://patchwork.libcamera.org/api/people/173/?format=json","name":"Jaslo Ziska","email":"jaslo@ziska.de"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21721/mbox/","series":[{"id":4732,"url":"https://patchwork.libcamera.org/api/series/4732/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4732","date":"2024-10-21T16:45:30","name":"gstreamer: Generate controls from control_ids_*.yaml files","version":4,"mbox":"https://patchwork.libcamera.org/series/4732/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21721/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21721/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2083FBD808\n\tfor ;\n\tMon, 21 Oct 2024 16:50:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C26FE65393;\n\tMon, 21 Oct 2024 18:50:19 +0200 (CEST)","from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de\n\t[85.215.255.21])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 217DD65392\n\tfor ;\n\tMon, 21 Oct 2024 18:50:18 +0200 (CEST)","from archlinux.fritz.box by smtp.strato.de (RZmta 51.2.11 AUTH)\n\twith ESMTPSA id zf9ba109LGoHVdB\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits))\n\t(Client did not present a certificate);\n\tMon, 21 Oct 2024 18:50:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ziska.de header.i=@ziska.de header.b=\"jr53Ic8w\";\n\tdkim=permerror (0-bit key) header.d=ziska.de header.i=@ziska.de\n\theader.b=\"qF/byXMG\"; dkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1729529417; cv=none;\n\td=strato.com; s=strato-dkim-0002;\n\tb=RcEzFhtjA2OmKFzqvM5DyfYQoqIg8W4IvhkuuLPX3NqK8NIgTALghN9vx7mdqKpAHM\n\tdmYGHUqS1pkV23IGEzYf/0+zqgfQYWlJlpuCceMOxn+zHxfwni9J4OKd0kYpQBfOS8kb\n\t2NKFQuu6gDB5oq+/MlIWzTxyi1zc6HiS50yl+CBjGgwi87kv/pSAiL3EZWAbcTTm5fYK\n\tyNbgykdxOGpaGRRiaHrgwhzyUEgITmnXfU16Y8It/lJ4xBN/dzFNUdooDPZrqUVWSx3R\n\tuz+cKEHpLkXOVLc9cF2Nm3Ezfu/zbrjVxNaUUE2zP7BTPAOZjcDGFzmELn5lfcR982Pd\n\tbazQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; t=1729529417;\n\ts=strato-dkim-0002; d=strato.com;\n\th=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=xOSoFeA0z8O9FKjGXe4HKPUWSnHPlBoUHZc6/XPEKjs=;\n\tb=nhubI8S1aqfQ6iyPrMVIyYZOxEs50Vm3lIYTy3tC7VvaiKCBhsVq3Z+MfvSWG5PS39\n\t10NdMzfEYimOrqzkayoY21AxlB6ygdG9XDE1wLXROZAcZ6WVjIxX3ou1H15K+f0N3DBY\n\to5TKbbvuE1enrSqgbiLi3JM49A+D05rwYlEQG5wbgWdEDi923mN5svpwtXZSa9yJFp4I\n\tyzGNjuu62U/hafFVJsZFDJvR2KWvwVfhpKn2S1HXO4vkOyAeT2MFQzQtjmkfnhkVIz+Y\n\tNKBkFKhfhoUCuBglPrRL916g8nK0K2S9Rk2Y1gsMY6lnUJ0GFm0wDVvtme7xG0JOka9M\n\t6r8Q==","ARC-Authentication-Results":"i=1; strato.com;\n arc=none;\n dkim=none","X-RZG-CLASS-ID":"mo00","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; t=1729529417;\n\ts=strato-dkim-0002; d=ziska.de;\n\th=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=xOSoFeA0z8O9FKjGXe4HKPUWSnHPlBoUHZc6/XPEKjs=;\n\tb=jr53Ic8wPIfG8hF2Z2zxEcSmhZOPVL/0k/6YwGbGucqwKa5Izys5ualuuTja9K4W4y\n\tCnJUzlDVXesX4sbku4sA01HaG6joyRbfP+TndCOoQ7YeGruHT8RIjRhBPTnB7GgnqoWO\n\tDzDdVBf24940wd01YyfIUsmMtmB7BaBw1o3N85uyM9/B5mcQ+Tuyk9As+rxl7TLFtmjZ\n\torWKJub2bJHOdZfXYXjV2GbLiUUYiNxH3Di4HvhNynk0hv+cwNt5dcyUpwTa2h1G0CGQ\n\taxhtSmwzqbiDuZaLcnTxSuVoLe3R9DnU838Kire6/nlrFBKID0Yj97vlEXjAT6uvMPv5\n\thEiQ==","v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1729529417;\n\ts=strato-dkim-0003; d=ziska.de;\n\th=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=xOSoFeA0z8O9FKjGXe4HKPUWSnHPlBoUHZc6/XPEKjs=;\n\tb=qF/byXMGflEgOlXPCL4PeFCvZakc/LdwqHjBtlKqR1pS6XRoTEm6Tyogg8LvlyAd+z\n\t3kxsDFRN/OtRRRqvbzCw=="],"X-RZG-AUTH":"\":Jm0XeU+IYfb0x77LHmrjN5Wlb7TBwusDqIM6Hizy8VdfzvKi4yoFC9cEiIqwXfJa0UVFIOBpUYAtVOpHIoJG1qZybSPb\"","From":"Jaslo Ziska ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jaslo Ziska ,\n\tLaurent Pinchart ,\n\tKieran Bingham ","Subject":"[PATCH v4 1/3] gstreamer: Remove auto-focus-mode property from\n\tdevice provider","Date":"Mon, 21 Oct 2024 18:45:31 +0200","Message-ID":"<20241021164946.11111-2-jaslo@ziska.de>","X-Mailer":"git-send-email 2.47.0","In-Reply-To":"<20241021164946.11111-1-jaslo@ziska.de>","References":"<20241021164946.11111-1-jaslo@ziska.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"us-ascii\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The device provider is not supposed to have control properties, remove\nthe auto-focus-mode property which was introduced by accident.\n\nFixes: 5a142438b025 (\"gstreamer: Add enable_auto_focus option to the GStreamer plugin\")\nSigned-off-by: Jaslo Ziska \nReviewed-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n src/gstreamer/gstlibcameraprovider.cpp | 15 ---------------\n 1 file changed, 15 deletions(-)","diff":"diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp\nindex 4fb1b007..5da96ea3 100644\n--- a/src/gstreamer/gstlibcameraprovider.cpp\n+++ b/src/gstreamer/gstlibcameraprovider.cpp\n@@ -33,7 +33,6 @@ GST_DEBUG_CATEGORY_STATIC(provider_debug);\n \n enum {\n \tPROP_DEVICE_NAME = 1,\n-\tPROP_AUTO_FOCUS_MODE = 2,\n };\n \n #define GST_TYPE_LIBCAMERA_DEVICE gst_libcamera_device_get_type()\n@@ -43,7 +42,6 @@ G_DECLARE_FINAL_TYPE(GstLibcameraDevice, gst_libcamera_device,\n struct _GstLibcameraDevice {\n \tGstDevice parent;\n \tgchar *name;\n-\tcontrols::AfModeEnum auto_focus_mode = controls::AfModeManual;\n };\n \n G_DEFINE_TYPE(GstLibcameraDevice, gst_libcamera_device, GST_TYPE_DEVICE)\n@@ -60,7 +58,6 @@ gst_libcamera_device_create_element(GstDevice *device, const gchar *name)\n \tg_assert(source);\n \n \tg_object_set(source, \"camera-name\", GST_LIBCAMERA_DEVICE(device)->name, nullptr);\n-\tg_object_set(source, \"auto-focus-mode\", GST_LIBCAMERA_DEVICE(device)->auto_focus_mode, nullptr);\n \n \treturn source;\n }\n@@ -87,9 +84,6 @@ gst_libcamera_device_set_property(GObject *object, guint prop_id,\n \tcase PROP_DEVICE_NAME:\n \t\tdevice->name = g_value_dup_string(value);\n \t\tbreak;\n-\tcase PROP_AUTO_FOCUS_MODE:\n-\t\tdevice->auto_focus_mode = static_cast(g_value_get_enum(value));\n-\t\tbreak;\n \tdefault:\n \t\tG_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);\n \t\tbreak;\n@@ -129,15 +123,6 @@ gst_libcamera_device_class_init(GstLibcameraDeviceClass *klass)\n \t\t\t\t\t\t(GParamFlags)(G_PARAM_STATIC_STRINGS | G_PARAM_WRITABLE |\n \t\t\t\t\t\t\t G_PARAM_CONSTRUCT_ONLY));\n \tg_object_class_install_property(object_class, PROP_DEVICE_NAME, pspec);\n-\n-\tpspec = g_param_spec_enum(\"auto-focus-mode\",\n-\t\t\t\t \"Set auto-focus mode\",\n-\t\t\t\t \"Available options: AfModeManual, \"\n-\t\t\t\t \"AfModeAuto or AfModeContinuous.\",\n-\t\t\t\t gst_libcamera_auto_focus_get_type(),\n-\t\t\t\t static_cast(controls::AfModeManual),\n-\t\t\t\t G_PARAM_WRITABLE);\n-\tg_object_class_install_property(object_class, PROP_AUTO_FOCUS_MODE, pspec);\n }\n \n static GstDevice *\n","prefixes":["v4","1/3"]}