[{"id":32295,"web_url":"https://patchwork.libcamera.org/comment/32295/","msgid":"<173205892722.2275610.5501386914805509977@ping.linuxembedded.co.uk>","date":"2024-11-19T23:28:47","subject":"Re: [PATCH v3] Add .editorconfig file","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Robert Mader (2024-10-20 17:49:26)\n> To make contributing to libcamera more fun, see\n> https://editorconfig.org/\n> \n> Signed-off-by: Robert Mader \n> Acked-by: Kieran Bingham \n\nAny objections to me merging this one ? or Additional review comments,\nor tags ?\n\n--\nKieran\n\n\n> \n> ---\n> \n> Changes in version 3:\n> - changed indent_size for meson files to 4\n> - dropped meson.options from v2 again\n> - added sections for .json and .yaml\n> - dropped section for .xml\n> - collected Acked-by\n> \n> Changes in version 2:\n> - require insert_final_newline for all files, including the file added here\n> - add python config\n> - add more meson file types\n> ---\n> .editorconfig | 29 +++++++++++++++++++++++++++++\n> 1 file changed, 29 insertions(+)\n> create mode 100644 .editorconfig\n> \n> diff --git a/.editorconfig b/.editorconfig\n> new file mode 100644\n> index 00000000..a76b36a7\n> --- /dev/null\n> +++ b/.editorconfig\n> @@ -0,0 +1,29 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +\n> +root = true\n> +\n> +[*]\n> +charset = utf-8\n> +end_of_line = lf\n> +insert_final_newline = true\n> +trim_trailing_whitespace = true\n> +\n> +[*.{cpp,h}]\n> +indent_size = 8\n> +indent_style = tab\n> +\n> +[*.json]\n> +indent_size = 4\n> +indent_style = space\n> +\n> +[*.py]\n> +indent_size = 4\n> +indent_style = space\n> +\n> +[*.yaml]\n> +indent_size = 2\n> +indent_style = space\n> +\n> +[{meson.build,meson_options.txt}]\n> +indent_size = 4\n> +indent_style = space\n> -- \n> 2.47.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2314DC326B\n\tfor ;\n\tTue, 19 Nov 2024 23:28:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 50D3E65F2B;\n\tWed, 20 Nov 2024 00:28:53 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9743A658F0\n\tfor ;\n\tWed, 20 Nov 2024 00:28:50 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C4789465;\n\tWed, 20 Nov 2024 00:28:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JAiQ96gc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732058912;\n\tbh=hHa2BWll08tKlfsyYWyl8y74LisXhwKSPNUNDNEgJ2Y=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=JAiQ96gcw3Yhhvro+tf+kCObggcSHEL9tVitOgHuKe8a2p5IOJmq0JPe2sRlXwu0X\n\tn7FlbSLxNlZYRIDUZeh+4LxinlzWDg3h2u1MUOAql4TyjKfdVyDzNMc9P4+yhzQ8le\n\tT+qfShPIxX09wHoXbbkyZSMQDlXiSzxz93Ix9Wfw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241020164926.255457-1-robert.mader@collabora.com>","References":"<20241020164926.255457-1-robert.mader@collabora.com>","Subject":"Re: [PATCH v3] Add .editorconfig file","From":"Kieran Bingham ","Cc":"Robert Mader ","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 19 Nov 2024 23:28:47 +0000","Message-ID":"<173205892722.2275610.5501386914805509977@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32296,"web_url":"https://patchwork.libcamera.org/comment/32296/","msgid":"<20241119234905.GV31681@pendragon.ideasonboard.com>","date":"2024-11-19T23:49:05","subject":"Re: [PATCH v3] Add .editorconfig file","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Nov 19, 2024 at 11:28:47PM +0000, Kieran Bingham wrote:\n> Quoting Robert Mader (2024-10-20 17:49:26)\n> > To make contributing to libcamera more fun, see\n> > https://editorconfig.org/\n> > \n> > Signed-off-by: Robert Mader \n> > Acked-by: Kieran Bingham \n> \n> Any objections to me merging this one ? or Additional review comments,\n> or tags ?\n\nI'm not a huge fan of having tool-specific configuration files in the\nsource tree (except for tools libcamera uses explicitly of course, such\nas clang-format), but as editorconfig is trying to set some sort of\nstandard, even if it's not that widespread (yet?), I have no objection.\n\n> > ---\n> > \n> > Changes in version 3:\n> > - changed indent_size for meson files to 4\n> > - dropped meson.options from v2 again\n> > - added sections for .json and .yaml\n> > - dropped section for .xml\n> > - collected Acked-by\n> > \n> > Changes in version 2:\n> > - require insert_final_newline for all files, including the file added here\n> > - add python config\n> > - add more meson file types\n> > ---\n> > .editorconfig | 29 +++++++++++++++++++++++++++++\n> > 1 file changed, 29 insertions(+)\n> > create mode 100644 .editorconfig\n> > \n> > diff --git a/.editorconfig b/.editorconfig\n> > new file mode 100644\n> > index 00000000..a76b36a7\n> > --- /dev/null\n> > +++ b/.editorconfig\n> > @@ -0,0 +1,29 @@\n> > +# SPDX-License-Identifier: CC0-1.0\n> > +\n> > +root = true\n> > +\n> > +[*]\n> > +charset = utf-8\n> > +end_of_line = lf\n> > +insert_final_newline = true\n> > +trim_trailing_whitespace = true\n> > +\n> > +[*.{cpp,h}]\n> > +indent_size = 8\n> > +indent_style = tab\n> > +\n> > +[*.json]\n> > +indent_size = 4\n> > +indent_style = space\n> > +\n> > +[*.py]\n> > +indent_size = 4\n> > +indent_style = space\n> > +\n> > +[*.yaml]\n> > +indent_size = 2\n> > +indent_style = space\n> > +\n> > +[{meson.build,meson_options.txt}]\n> > +indent_size = 4\n> > +indent_style = space","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 847EEC32F5\n\tfor ;\n\tTue, 19 Nov 2024 23:49:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 68CD165F2E;\n\tWed, 20 Nov 2024 00:49:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 30A74658F0\n\tfor ;\n\tWed, 20 Nov 2024 00:49:15 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2F46A465;\n\tWed, 20 Nov 2024 00:48:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Fd/Q3Dlx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732060137;\n\tbh=GzeP0ZZqHYIMPpMDnrwUsXEKdIOWDTdU55Fg9qWl3ow=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Fd/Q3Dlx2y59JfId/3CnZwFCyU7km20/jBkO+X97+nFOnHbbDLjPuwrj2QKV0ZD6g\n\txgNNtnjEvQOShLYFtQxLEyB6FWex9eD7cNt/JwxVwrF5Hk75W9cJ73vWS9VlnXNSIh\n\tGPHHRB9weqsqVGnBemavGiE1RXjHBuDQCbjSlLx8=","Date":"Wed, 20 Nov 2024 01:49:05 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3] Add .editorconfig file","Message-ID":"<20241119234905.GV31681@pendragon.ideasonboard.com>","References":"<20241020164926.255457-1-robert.mader@collabora.com>\n\t<173205892722.2275610.5501386914805509977@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<173205892722.2275610.5501386914805509977@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]