[{"id":2876,"web_url":"https://patchwork.libcamera.org/comment/2876/","msgid":"<20191013150327.64hbwiayneat533s@uno.localdomain>","date":"2019-10-13T15:03:27","subject":"Re: [libcamera-devel] [PATCH v2 10/14] libcamera: v4l2_controls:\n\tAdd V4L2ControlId","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Sat, Oct 12, 2019 at 09:44:03PM +0300, Laurent Pinchart wrote:\n> Add a V4L2 specialisation of the ControlId class, in order to construct\n> a ControlId from a v4l2_query_ext_ctrl. The V4L2ControlId is embedded in\n> V4L2ControlInfo, and thus needs to be copyable to allow for\n> V4L2ControlInfo to be passed to IPAs. The ControlId copy constructor and\n> assignment operators are thus restored, but made protected to avoid the\n> Control class being copyable.\n>\n> This is needed in order to use ControlList for V4L2 controls, as\n> ControlList requires ControlId instances for all controls.\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/controls.h | 7 +--\n> src/libcamera/include/v4l2_controls.h | 12 +++--\n> src/libcamera/v4l2_controls.cpp | 67 +++++++++++++++++++++++----\n> src/libcamera/v4l2_device.cpp | 4 +-\n> 4 files changed, 72 insertions(+), 18 deletions(-)\n>\n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index 5e6708fe570b..ebc4204f98fd 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -68,11 +68,12 @@ protected:\n> \t\t: id_(id), name_(name), type_(type)\n> \t{\n> \t}\n> +#ifndef __DOXYGEN__\n> +\tControlId &operator=(const ControlId &) = default;\n> +\tControlId(const ControlId &) = default;\n> +#endif\n>\n> private:\n> -\tControlId(const ControlId &) = delete;\n> -\tControlId &operator=(const ControlId &) = delete;\n> -\n> \tunsigned int id_;\n> \tstd::string name_;\n> \tControlType type_;\n> diff --git a/src/libcamera/include/v4l2_controls.h b/src/libcamera/include/v4l2_controls.h\n> index b39370b2e90e..71ce377fe4c5 100644\n> --- a/src/libcamera/include/v4l2_controls.h\n> +++ b/src/libcamera/include/v4l2_controls.h\n> @@ -20,23 +20,27 @@\n>\n> namespace libcamera {\n>\n> +class V4L2ControlId : public ControlId\n> +{\n> +public:\n> +\tV4L2ControlId(const struct v4l2_query_ext_ctrl &ctrl);\n> +};\n> +\n> class V4L2ControlInfo\n> {\n> public:\n> \tV4L2ControlInfo(const struct v4l2_query_ext_ctrl &ctrl);\n>\n> -\tunsigned int id() const { return id_; }\n> +\tconst ControlId &id() const { return id_; }\n> \tunsigned int type() const { return type_; }\n> \tsize_t size() const { return size_; }\n> -\tconst std::string &name() const { return name_; }\n>\n> \tconst ControlRange &range() const { return range_; }\n>\n> private:\n> -\tunsigned int id_;\n> +\tV4L2ControlId id_;\n> \tunsigned int type_;\n> \tsize_t size_;\n> -\tstd::string name_;\n>\n> \tControlRange range_;\n> };\n> diff --git a/src/libcamera/v4l2_controls.cpp b/src/libcamera/v4l2_controls.cpp\n> index 6f5f1578b139..a630a2583d33 100644\n> --- a/src/libcamera/v4l2_controls.cpp\n> +++ b/src/libcamera/v4l2_controls.cpp\n> @@ -7,6 +7,8 @@\n>\n> #include \"v4l2_controls.h\"\n>\n> +#include \n> +\n> /**\n> * \\file v4l2_controls.h\n> * \\brief Support for V4L2 Controls using the V4L2 Extended Controls APIs\n> @@ -47,6 +49,60 @@\n>\n> namespace libcamera {\n>\n> +namespace {\n> +\n> +std::string v4l2_ctrl_name(const struct v4l2_query_ext_ctrl &ctrl)\n> +{\n> +\tsize_t len = strnlen(ctrl.name, sizeof(ctrl.name));\n> +\treturn std::string(static_cast(ctrl.name), len);\n> +}\n> +\n> +ControlType v4l2_ctrl_type(const struct v4l2_query_ext_ctrl &ctrl)\n> +{\n> +\tswitch (ctrl.type) {\n> +\tcase V4L2_CTRL_TYPE_BOOLEAN:\n> +\t\treturn ControlTypeBool;\n> +\n> +\tcase V4L2_CTRL_TYPE_INTEGER:\n> +\t\treturn ControlTypeInteger32;\n> +\n> +\tcase V4L2_CTRL_TYPE_INTEGER64:\n> +\t\treturn ControlTypeInteger64;\n> +\n> +\tcase V4L2_CTRL_TYPE_MENU:\n> +\tcase V4L2_CTRL_TYPE_BUTTON:\n> +\tcase V4L2_CTRL_TYPE_BITMASK:\n> +\tcase V4L2_CTRL_TYPE_INTEGER_MENU:\n> +\t\t/*\n> +\t\t * More precise types may be needed, for now use a 32-bit\n> +\t\t * integer type.\n> +\t\t */\n> +\t\treturn ControlTypeInteger32;\n> +\n> +\tdefault:\n> +\t\treturn ControlTypeNone;\n> +\t}\n> +}\n> +\n> +} /* namespace */\n> +\n> +/**\n> + * \\class V4L2ControlId\n> + * \\brief V4L2 control static metadata\n> + *\n> + * The V4L2ControlId class is a specialisation of the ControlId for V4L2\n> + * controls.\n> + */\n> +\n> +/**\n> + * \\brief Construct a V4L2ControlId from a struct v4l2_query_ext_ctrl\n> + * \\param[in] ctrl The struct v4l2_query_ext_ctrl as returned by the kernel\n> + */\n> +V4L2ControlId::V4L2ControlId(const struct v4l2_query_ext_ctrl &ctrl)\n> +\t: ControlId(ctrl.id, v4l2_ctrl_name(ctrl), v4l2_ctrl_type(ctrl))\n> +{\n> +}\n> +\n> /**\n> * \\class V4L2ControlInfo\n> * \\brief Information on a V4L2 control\n> @@ -66,13 +122,12 @@ namespace libcamera {\n>\n> /**\n> * \\brief Construct a V4L2ControlInfo from a struct v4l2_query_ext_ctrl\n> - * \\param ctrl The struct v4l2_query_ext_ctrl as returned by the kernel\n> + * \\param[in] ctrl The struct v4l2_query_ext_ctrl as returned by the kernel\n> */\n> V4L2ControlInfo::V4L2ControlInfo(const struct v4l2_query_ext_ctrl &ctrl)\n> +\t: id_(ctrl)\n> {\n> -\tid_ = ctrl.id;\n> \ttype_ = ctrl.type;\n> -\tname_ = static_cast(ctrl.name);\n> \tsize_ = ctrl.elem_size * ctrl.elems;\n>\n> \tif (ctrl.type == V4L2_CTRL_TYPE_INTEGER64)\n> @@ -101,12 +156,6 @@ V4L2ControlInfo::V4L2ControlInfo(const struct v4l2_query_ext_ctrl &ctrl)\n> * \\return The V4L2 control value data size\n> */\n>\n> -/**\n> - * \\fn V4L2ControlInfo::name()\n> - * \\brief Retrieve the control user readable name\n> - * \\return The V4L2 control user readable name\n> - */\n> -\n> /**\n> * \\fn V4L2ControlInfo::range()\n> * \\brief Retrieve the control value range\n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index 3bd82ff23212..466c3d41f6e3 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -184,7 +184,7 @@ int V4L2Device::getControls(V4L2ControlList *ctrls)\n>\n> \t\tconst V4L2ControlInfo *info = &iter->second;\n> \t\tcontrolInfo[i] = info;\n> -\t\tv4l2Ctrls[i].id = info->id();\n> +\t\tv4l2Ctrls[i].id = ctrl->id();\n> \t}\n>\n> \tstruct v4l2_ext_controls v4l2ExtCtrls = {};\n> @@ -259,7 +259,7 @@ int V4L2Device::setControls(V4L2ControlList *ctrls)\n>\n> \t\tconst V4L2ControlInfo *info = &iter->second;\n> \t\tcontrolInfo[i] = info;\n> -\t\tv4l2Ctrls[i].id = info->id();\n> +\t\tv4l2Ctrls[i].id = ctrl->id();\n>\n> \t\t/* Set the v4l2_ext_control value for the write operation. */\n> \t\tswitch (info->type()) {\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 90BA761562\n\tfor ;\n\tSun, 13 Oct 2019 17:01:39 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 2D281E0002;\n\tSun, 13 Oct 2019 15:01:39 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Sun, 13 Oct 2019 17:03:27 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191013150327.64hbwiayneat533s@uno.localdomain>","References":"<20191012184407.31684-1-laurent.pinchart@ideasonboard.com>\n\t<20191012184407.31684-11-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"v5g3or54vdr73gv4\"","Content-Disposition":"inline","In-Reply-To":"<20191012184407.31684-11-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v2 10/14] libcamera: v4l2_controls:\n\tAdd V4L2ControlId","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 13 Oct 2019 15:01:39 -0000"}},{"id":2887,"web_url":"https://patchwork.libcamera.org/comment/2887/","msgid":"<20191013160544.GS23166@bigcity.dyn.berto.se>","date":"2019-10-13T16:05:44","subject":"Re: [libcamera-devel] [PATCH v2 10/14] libcamera: v4l2_controls:\n\tAdd V4L2ControlId","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-10-12 21:44:03 +0300, Laurent Pinchart wrote:\n> Add a V4L2 specialisation of the ControlId class, in order to construct\n> a ControlId from a v4l2_query_ext_ctrl. The V4L2ControlId is embedded in\n> V4L2ControlInfo, and thus needs to be copyable to allow for\n> V4L2ControlInfo to be passed to IPAs. The ControlId copy constructor and\n> assignment operators are thus restored, but made protected to avoid the\n> Control class being copyable.\n> \n> This is needed in order to use ControlList for V4L2 controls, as\n> ControlList requires ControlId instances for all controls.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/controls.h | 7 +--\n> src/libcamera/include/v4l2_controls.h | 12 +++--\n> src/libcamera/v4l2_controls.cpp | 67 +++++++++++++++++++++++----\n> src/libcamera/v4l2_device.cpp | 4 +-\n> 4 files changed, 72 insertions(+), 18 deletions(-)\n> \n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index 5e6708fe570b..ebc4204f98fd 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -68,11 +68,12 @@ protected:\n> \t\t: id_(id), name_(name), type_(type)\n> \t{\n> \t}\n> +#ifndef __DOXYGEN__\n> +\tControlId &operator=(const ControlId &) = default;\n> +\tControlId(const ControlId &) = default;\n> +#endif\n> \n> private:\n> -\tControlId(const ControlId &) = delete;\n> -\tControlId &operator=(const ControlId &) = delete;\n> -\n> \tunsigned int id_;\n> \tstd::string name_;\n> \tControlType type_;\n> diff --git a/src/libcamera/include/v4l2_controls.h b/src/libcamera/include/v4l2_controls.h\n> index b39370b2e90e..71ce377fe4c5 100644\n> --- a/src/libcamera/include/v4l2_controls.h\n> +++ b/src/libcamera/include/v4l2_controls.h\n> @@ -20,23 +20,27 @@\n> \n> namespace libcamera {\n> \n> +class V4L2ControlId : public ControlId\n> +{\n> +public:\n> +\tV4L2ControlId(const struct v4l2_query_ext_ctrl &ctrl);\n> +};\n> +\n> class V4L2ControlInfo\n> {\n> public:\n> \tV4L2ControlInfo(const struct v4l2_query_ext_ctrl &ctrl);\n> \n> -\tunsigned int id() const { return id_; }\n> +\tconst ControlId &id() const { return id_; }\n> \tunsigned int type() const { return type_; }\n> \tsize_t size() const { return size_; }\n> -\tconst std::string &name() const { return name_; }\n> \n> \tconst ControlRange &range() const { return range_; }\n> \n> private:\n> -\tunsigned int id_;\n> +\tV4L2ControlId id_;\n> \tunsigned int type_;\n> \tsize_t size_;\n> -\tstd::string name_;\n> \n> \tControlRange range_;\n> };\n> diff --git a/src/libcamera/v4l2_controls.cpp b/src/libcamera/v4l2_controls.cpp\n> index 6f5f1578b139..a630a2583d33 100644\n> --- a/src/libcamera/v4l2_controls.cpp\n> +++ b/src/libcamera/v4l2_controls.cpp\n> @@ -7,6 +7,8 @@\n> \n> #include \"v4l2_controls.h\"\n> \n> +#include \n> +\n> /**\n> * \\file v4l2_controls.h\n> * \\brief Support for V4L2 Controls using the V4L2 Extended Controls APIs\n> @@ -47,6 +49,60 @@\n> \n> namespace libcamera {\n> \n> +namespace {\n> +\n> +std::string v4l2_ctrl_name(const struct v4l2_query_ext_ctrl &ctrl)\n> +{\n> +\tsize_t len = strnlen(ctrl.name, sizeof(ctrl.name));\n> +\treturn std::string(static_cast(ctrl.name), len);\n> +}\n> +\n> +ControlType v4l2_ctrl_type(const struct v4l2_query_ext_ctrl &ctrl)\n> +{\n> +\tswitch (ctrl.type) {\n> +\tcase V4L2_CTRL_TYPE_BOOLEAN:\n> +\t\treturn ControlTypeBool;\n> +\n> +\tcase V4L2_CTRL_TYPE_INTEGER:\n> +\t\treturn ControlTypeInteger32;\n> +\n> +\tcase V4L2_CTRL_TYPE_INTEGER64:\n> +\t\treturn ControlTypeInteger64;\n> +\n> +\tcase V4L2_CTRL_TYPE_MENU:\n> +\tcase V4L2_CTRL_TYPE_BUTTON:\n> +\tcase V4L2_CTRL_TYPE_BITMASK:\n> +\tcase V4L2_CTRL_TYPE_INTEGER_MENU:\n> +\t\t/*\n> +\t\t * More precise types may be needed, for now use a 32-bit\n> +\t\t * integer type.\n> +\t\t */\n> +\t\treturn ControlTypeInteger32;\n> +\n> +\tdefault:\n> +\t\treturn ControlTypeNone;\n> +\t}\n> +}\n> +\n> +} /* namespace */\n> +\n> +/**\n> + * \\class V4L2ControlId\n> + * \\brief V4L2 control static metadata\n> + *\n> + * The V4L2ControlId class is a specialisation of the ControlId for V4L2\n> + * controls.\n> + */\n> +\n> +/**\n> + * \\brief Construct a V4L2ControlId from a struct v4l2_query_ext_ctrl\n> + * \\param[in] ctrl The struct v4l2_query_ext_ctrl as returned by the kernel\n> + */\n> +V4L2ControlId::V4L2ControlId(const struct v4l2_query_ext_ctrl &ctrl)\n> +\t: ControlId(ctrl.id, v4l2_ctrl_name(ctrl), v4l2_ctrl_type(ctrl))\n> +{\n> +}\n> +\n> /**\n> * \\class V4L2ControlInfo\n> * \\brief Information on a V4L2 control\n> @@ -66,13 +122,12 @@ namespace libcamera {\n> \n> /**\n> * \\brief Construct a V4L2ControlInfo from a struct v4l2_query_ext_ctrl\n> - * \\param ctrl The struct v4l2_query_ext_ctrl as returned by the kernel\n> + * \\param[in] ctrl The struct v4l2_query_ext_ctrl as returned by the kernel\n> */\n> V4L2ControlInfo::V4L2ControlInfo(const struct v4l2_query_ext_ctrl &ctrl)\n> +\t: id_(ctrl)\n> {\n> -\tid_ = ctrl.id;\n> \ttype_ = ctrl.type;\n> -\tname_ = static_cast(ctrl.name);\n> \tsize_ = ctrl.elem_size * ctrl.elems;\n> \n> \tif (ctrl.type == V4L2_CTRL_TYPE_INTEGER64)\n> @@ -101,12 +156,6 @@ V4L2ControlInfo::V4L2ControlInfo(const struct v4l2_query_ext_ctrl &ctrl)\n> * \\return The V4L2 control value data size\n> */\n> \n> -/**\n> - * \\fn V4L2ControlInfo::name()\n> - * \\brief Retrieve the control user readable name\n> - * \\return The V4L2 control user readable name\n> - */\n> -\n> /**\n> * \\fn V4L2ControlInfo::range()\n> * \\brief Retrieve the control value range\n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index 3bd82ff23212..466c3d41f6e3 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -184,7 +184,7 @@ int V4L2Device::getControls(V4L2ControlList *ctrls)\n> \n> \t\tconst V4L2ControlInfo *info = &iter->second;\n> \t\tcontrolInfo[i] = info;\n> -\t\tv4l2Ctrls[i].id = info->id();\n> +\t\tv4l2Ctrls[i].id = ctrl->id();\n> \t}\n> \n> \tstruct v4l2_ext_controls v4l2ExtCtrls = {};\n> @@ -259,7 +259,7 @@ int V4L2Device::setControls(V4L2ControlList *ctrls)\n> \n> \t\tconst V4L2ControlInfo *info = &iter->second;\n> \t\tcontrolInfo[i] = info;\n> -\t\tv4l2Ctrls[i].id = info->id();\n> +\t\tv4l2Ctrls[i].id = ctrl->id();\n> \n> \t\t/* Set the v4l2_ext_control value for the write operation. */\n> \t\tswitch (info->type()) {\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD31F61562\n\tfor ;\n\tSun, 13 Oct 2019 18:05:45 +0200 (CEST)","by mail-lf1-x143.google.com with SMTP id c195so10108656lfg.9\n\tfor ;\n\tSun, 13 Oct 2019 09:05:45 -0700 (PDT)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\ts7sm3486613ljs.16.2019.10.13.09.05.44\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 13 Oct 2019 09:05:44 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=AKAYVF5jwvWDUY1/WPOBDJK7/LM23uW6JAcLxTArTsY=;\n\tb=NJChllBE30JTc4rccKf3q7Ma4iG4wLASk9EJ9d7C23mAwVvjCog2HtD/ISGlP/srXp\n\t7yR5ooqKomrAz4jJLQqNyE94BXEvCLEwSEiMHLerJzuqRyx2yFYpybyvZFFruv0AitRn\n\t4HoscX48g0iJhhsJGBFxdXeuSMf3QUEg2u1E1CPmKJ/c+85519LgIhKzNriGobUwjpma\n\tk3jcpy3d/QAVsWPU+sJRO+y7l3p0Wo/GbTrerWTk/G97nID3Q5blKWghfLnL5MkBKh2C\n\tlEAFBSWVkyqHi2I72peFKHsqgi0X+d0EpTTUdi5Dne1G6XR7VIncLJaqVsjj26VpipFw\n\tX2wg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=AKAYVF5jwvWDUY1/WPOBDJK7/LM23uW6JAcLxTArTsY=;\n\tb=Ls+Tdg6YrBPbPXA+GZZws2wn/vzHzsYuojzHluw0Df/ZVsUNRKuayoQRqVHXK+troZ\n\tZThIECygAnqw3FV2CvySPnIKJmIv2TEh+ynYAlbZyOPPLoMdagB9rgXw6dUd9J0HrPY0\n\tMAK0n5+oQ4Nma3Q83VX26x1AeRoBuRqZBAVOzGksPnjRhP2vvo4R65OrXqI1mBcbqxRa\n\tttGsm7EZCX28EpoTzIbXMu04DxTRUiyukwOYa8ttC4Lp2k3CMm1Kr8ZPxbCXvj6Yu3tL\n\tb6syoqW+drOZfAH1sJI7+STBP2PNvggoiCapNP2pR1psDB8tw3VcWI+2XKCUg+Xq956l\n\ta1HQ==","X-Gm-Message-State":"APjAAAU78Efxk5uuNwELmsLVrWJcrZi6nbocy42+mPWn2Cw4cXFwe11C\n\tPiK7tagrf7nlIwYFpfqIN+jxlpHgoRk=","X-Google-Smtp-Source":"APXvYqzZExJQqXPtELBC0/LFgW0aps8WqD9wXEY/wVnOpfVgLDqAtwFsm+QcyLJnC4EKvVB8S1xTAA==","X-Received":"by 2002:ac2:420a:: with SMTP id\n\ty10mr14508107lfh.65.1570982745216; \n\tSun, 13 Oct 2019 09:05:45 -0700 (PDT)","Date":"Sun, 13 Oct 2019 18:05:44 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191013160544.GS23166@bigcity.dyn.berto.se>","References":"<20191012184407.31684-1-laurent.pinchart@ideasonboard.com>\n\t<20191012184407.31684-11-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191012184407.31684-11-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v2 10/14] libcamera: v4l2_controls:\n\tAdd V4L2ControlId","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 13 Oct 2019 16:05:46 -0000"}}]