[{"id":31848,"web_url":"https://patchwork.libcamera.org/comment/31848/","msgid":"<87v7xld9wz.fsf@redhat.com>","date":"2024-10-21T10:31:40","subject":"Re: [PATCH 2/2] ipa/simple: Add tuning file for IMX355","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Robert Mader writes:\n\n> 64 at 10 bits. The value was guessed from known values for similar\n> sensors and testing - on a Google Pixel 3a - suggest it's correct.\n>\n> Adding this tuning file is partly motivated in order to serve as\n> example, as it's the first one for the simple IPA.\n>\n> Signed-off-by: Robert Mader \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/ipa/simple/data/imx355.yaml | 11 +++++++++++\n> src/ipa/simple/data/meson.build | 1 +\n> 2 files changed, 12 insertions(+)\n> create mode 100644 src/ipa/simple/data/imx355.yaml\n>\n> diff --git a/src/ipa/simple/data/imx355.yaml b/src/ipa/simple/data/imx355.yaml\n> new file mode 100644\n> index 00000000..f7d01b73\n> --- /dev/null\n> +++ b/src/ipa/simple/data/imx355.yaml\n> @@ -0,0 +1,11 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +%YAML 1.1\n> +---\n> +version: 1\n> +algorithms:\n> + - BlackLevel:\n> + blackLevel: 4096\n> + - Awb:\n> + - Lut:\n> + - Agc:\n> +...\n> diff --git a/src/ipa/simple/data/meson.build b/src/ipa/simple/data/meson.build\n> index 92795ee4..6e690f82 100644\n> --- a/src/ipa/simple/data/meson.build\n> +++ b/src/ipa/simple/data/meson.build\n> @@ -1,6 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> conf_files = files([\n> + 'imx355.yaml',\n> 'uncalibrated.yaml',\n> ])","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D5FA0C3304\n\tfor ;\n\tMon, 21 Oct 2024 10:31:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 795ED65392;\n\tMon, 21 Oct 2024 12:31:49 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F6766538A\n\tfor ;\n\tMon, 21 Oct 2024 12:31:47 +0200 (CEST)","from mail-ej1-f70.google.com (mail-ej1-f70.google.com\n\t[209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-464-dXFnzXIkMSSJh0ysFPPsng-1; Mon, 21 Oct 2024 06:31:44 -0400","by mail-ej1-f70.google.com with SMTP id\n\ta640c23a62f3a-a9a0c259715so291510866b.0\n\tfor ;\n\tMon, 21 Oct 2024 03:31:43 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-a9a91597c10sm183776866b.200.2024.10.21.03.31.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 21 Oct 2024 03:31:41 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"PckhoTVC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1729506706;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=ESTaAdaoqiC/tAugZCuGaJaofyIKwSWswLxwHWAjeEY=;\n\tb=PckhoTVCkjYpIscaa0ySrzTzQvqluc/8EfHP6g1Dh/nNWM+28NO91mJc9s1MNTRgFVKnaE\n\tB/5qcvLZpNWhefgvhp33bqx0/wj3w8rDxIkg7DqSMhM9Ni4jTziRohHLVOYck2MCi+qcdZ\n\tD1uadixoRuRaGAhJMDJRKkAoSKwGgN4=","X-MC-Unique":"dXFnzXIkMSSJh0ysFPPsng-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1729506702; x=1730111502;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=ESTaAdaoqiC/tAugZCuGaJaofyIKwSWswLxwHWAjeEY=;\n\tb=ufQap+uCjue0FTwK99pvkxZTj9n91zSqw6FlZGD4K9FAkCptAH7QRsCwK3ZAunhBwU\n\t+AI3c0eKPQdn8cAUk85OpftJjTdngcC8s//BVUw89tnr5XZdnkt6uzZVA2vHck/NS0QT\n\tcLnzGchFbytvoK5t3ncAr7s1+VIFdfK3YDX5mSfGTJ7i8UuMKhJoarPc3rL102u96+RF\n\t00KolIy573FwOL66xJgZHzil8ZovF5e++wrk7aQzAbcPTB5qTWbXCn5rSDV6b5m1Y5HM\n\tDiE4DPPiUy1oV0qZp/Da1s5E6GzmAcMsQ02P4PDoJshcNFFSwZ+3lA5Y57NSSjPgpRZv\n\tMPpw==","X-Gm-Message-State":"AOJu0YyDpJ/b+SOrvkvdpe7kuvbdz3uZvOYOaf/AOP9KZRp6hSTy0ra3\n\tAvL4HadV544pmG4oaq6t2jPqterPw6XN7UI3HJyxliBwili2laUOcwFiRDCtFb5Rjx6ysd/pOhR\n\tjwHZDN9DF6SyRi47GS5OjrXT1QqXhegaeWUDsMjNZ1nqV0Y685Mu2LNKQvC3IcplWF7DhVSVbRm\n\tyZgJk99Zz6+vjMnsAZg9CpuchDq0O5wwH9evb84x5YRWlqoC8RWJp2uGQ=","X-Received":["by 2002:a17:907:980e:b0:a9a:6dc:b39d with SMTP id\n\ta640c23a62f3a-a9a69c99707mr1066667266b.41.1729506702499; \n\tMon, 21 Oct 2024 03:31:42 -0700 (PDT)","by 2002:a17:907:980e:b0:a9a:6dc:b39d with SMTP id\n\ta640c23a62f3a-a9a69c99707mr1066665066b.41.1729506702019; \n\tMon, 21 Oct 2024 03:31:42 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IHrdIDYVlt4vC2KJLZXttLN57IDuGwzYhBAI7O3b+d7FVE+Fm1tY701jHqHDsrpT8e27wGCYw==","From":"Milan Zamazal ","To":"Robert Mader ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/2] ipa/simple: Add tuning file for IMX355","In-Reply-To":"<20241019184340.111785-2-robert.mader@collabora.com> (Robert\n\tMader's message of \"Sat, 19 Oct 2024 20:43:40 +0200\")","References":"<20241019184340.111785-1-robert.mader@collabora.com>\n\t<20241019184340.111785-2-robert.mader@collabora.com>","Date":"Mon, 21 Oct 2024 12:31:40 +0200","Message-ID":"<87v7xld9wz.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32048,"web_url":"https://patchwork.libcamera.org/comment/32048/","msgid":"<20241106123039.GD9369@pendragon.ideasonboard.com>","date":"2024-11-06T12:30:39","subject":"Re: [PATCH 2/2] ipa/simple: Add tuning file for IMX355","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Robert,\n\nThank you for the patch.\n\nOn Sat, Oct 19, 2024 at 08:43:40PM +0200, Robert Mader wrote:\n> 64 at 10 bits. The value was guessed from known values for similar\n> sensors and testing - on a Google Pixel 3a - suggest it's correct.\n> \n> Adding this tuning file is partly motivated in order to serve as\n> example, as it's the first one for the simple IPA.\n> \n> Signed-off-by: Robert Mader \n> ---\n> src/ipa/simple/data/imx355.yaml | 11 +++++++++++\n> src/ipa/simple/data/meson.build | 1 +\n> 2 files changed, 12 insertions(+)\n> create mode 100644 src/ipa/simple/data/imx355.yaml\n> \n> diff --git a/src/ipa/simple/data/imx355.yaml b/src/ipa/simple/data/imx355.yaml\n> new file mode 100644\n> index 00000000..f7d01b73\n> --- /dev/null\n> +++ b/src/ipa/simple/data/imx355.yaml\n> @@ -0,0 +1,11 @@\n> +# SPDX-License-Identifier: CC0-1.0\n> +%YAML 1.1\n> +---\n> +version: 1\n> +algorithms:\n> + - BlackLevel:\n> + blackLevel: 4096\n> + - Awb:\n> + - Lut:\n> + - Agc:\n> +...\n\nTo be absolutely honest, I'm not very keen on adding a tuning file for a\nsensor that is not supported in the IPA sensor helpers :-S\n\nWe're considering a tool to characterize the gain model of sensors, I\nwonder if it could be extended to the black level as well. It would be\nnicer if we could capture optical black lines.\n\n> diff --git a/src/ipa/simple/data/meson.build b/src/ipa/simple/data/meson.build\n> index 92795ee4..6e690f82 100644\n> --- a/src/ipa/simple/data/meson.build\n> +++ b/src/ipa/simple/data/meson.build\n> @@ -1,6 +1,7 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> conf_files = files([\n> + 'imx355.yaml',\n> 'uncalibrated.yaml',\n> ])\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B729BE173\n\tfor ;\n\tWed, 6 Nov 2024 12:30:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 827516541E;\n\tWed, 6 Nov 2024 13:30:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 55B49653C5\n\tfor ;\n\tWed, 6 Nov 2024 13:30:46 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EF9E059D;\n\tWed, 6 Nov 2024 13:30:37 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"anEGQfLN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730896238;\n\tbh=QZc5yHe5zQIsWg455DjjPNbLfb2pqDud0/jIRHfiN7o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=anEGQfLN6QkqyWY/rEDEbOTCPx4tGnaA01obGcY+9u0CHEvkRCd/x8Go93KXhq3o6\n\tGq0cLF7VgDQXqj59iGgBRZ2I5maqGRy9hgWq8RGc9LqKd0Y2Mr9BhR0/k+V4AAqNuN\n\tyRNcBMxWmA4SlOdnhMJ4yXYcWyZamjQzGZog9mS4=","Date":"Wed, 6 Nov 2024 14:30:39 +0200","From":"Laurent Pinchart ","To":"Robert Mader ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/2] ipa/simple: Add tuning file for IMX355","Message-ID":"<20241106123039.GD9369@pendragon.ideasonboard.com>","References":"<20241019184340.111785-1-robert.mader@collabora.com>\n\t<20241019184340.111785-2-robert.mader@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241019184340.111785-2-robert.mader@collabora.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32121,"web_url":"https://patchwork.libcamera.org/comment/32121/","msgid":"<29e9c070-af72-44b9-8e34-322c06f6891c@collabora.com>","date":"2024-11-12T11:52:39","subject":"Re: [PATCH 2/2] ipa/simple: Add tuning file for IMX355","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"FTR., using\n\ngainType_ = AnalogueGainExponential;\ngainConstants_.exp = { 1.0, expGainDb(0.3) };\n\nas used by several other IMX sensors seems to work fine - I just don't \nhave the bandwidth to prove it somehow. But if you'd consider accepting \nsuch a helper non the less, I'd be happy to submit a corresponding patch.\n\nOn 06.11.24 13:30, Laurent Pinchart wrote:\n> Hi Robert,\n>\n> Thank you for the patch.\n>\n> On Sat, Oct 19, 2024 at 08:43:40PM +0200, Robert Mader wrote:\n>> 64 at 10 bits. The value was guessed from known values for similar\n>> sensors and testing - on a Google Pixel 3a - suggest it's correct.\n>>\n>> Adding this tuning file is partly motivated in order to serve as\n>> example, as it's the first one for the simple IPA.\n>>\n>> Signed-off-by: Robert Mader\n>> ---\n>> src/ipa/simple/data/imx355.yaml | 11 +++++++++++\n>> src/ipa/simple/data/meson.build | 1 +\n>> 2 files changed, 12 insertions(+)\n>> create mode 100644 src/ipa/simple/data/imx355.yaml\n>>\n>> diff --git a/src/ipa/simple/data/imx355.yaml b/src/ipa/simple/data/imx355.yaml\n>> new file mode 100644\n>> index 00000000..f7d01b73\n>> --- /dev/null\n>> +++ b/src/ipa/simple/data/imx355.yaml\n>> @@ -0,0 +1,11 @@\n>> +# SPDX-License-Identifier: CC0-1.0\n>> +%YAML 1.1\n>> +---\n>> +version: 1\n>> +algorithms:\n>> + - BlackLevel:\n>> + blackLevel: 4096\n>> + - Awb:\n>> + - Lut:\n>> + - Agc:\n>> +...\n> To be absolutely honest, I'm not very keen on adding a tuning file for a\n> sensor that is not supported in the IPA sensor helpers :-S\n>\n> We're considering a tool to characterize the gain model of sensors, I\n> wonder if it could be extended to the black level as well. It would be\n> nicer if we could capture optical black lines.\n>\n>> diff --git a/src/ipa/simple/data/meson.build b/src/ipa/simple/data/meson.build\n>> index 92795ee4..6e690f82 100644\n>> --- a/src/ipa/simple/data/meson.build\n>> +++ b/src/ipa/simple/data/meson.build\n>> @@ -1,6 +1,7 @@\n>> # SPDX-License-Identifier: CC0-1.0\n>> \n>> conf_files = files([\n>> + 'imx355.yaml',\n>> 'uncalibrated.yaml',\n>> ])\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AED60C324C\n\tfor ;\n\tTue, 12 Nov 2024 11:52:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CFD7D657F1;\n\tTue, 12 Nov 2024 12:52:47 +0100 (CET)","from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D48ED657B0\n\tfor ;\n\tTue, 12 Nov 2024 12:52:45 +0100 (CET)","by mx.zohomail.com with SMTPS id 1731412361639292.2716290976929;\n\tTue, 12 Nov 2024 03:52:41 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"ZHYQDCUD\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1731412363; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=nQSZRM3XqgUeNC0M4+aqk5CJfldlHiZtQE8XNi8sSG6Zel9ZpqHZjKd6ul7q8TL5+nLlrvvWitzAqmojTxY6hoajixQkTP8XgCxxcQ/sVN2fRw/JGscHQabnQT07xeKKn0039i66bmqAzqdWC/WTyyjR8fZQdpQNy43iQFqe6qs=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1731412363;\n\th=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=azq1cEeRRomiEgKryVfIdtRjaHX40lcyJUvdL7gZro8=; \n\tb=lTX7Nxq6xD6SQwVILe8nO1P1Ni4mdV1pCG/Cn/Uj6bda9aFhYJf/uo9rIgt50cAHsLAsi/Gdt6I5h9fq5VplwaXunQqPS+SMSgBKddK9dMIIl9SKkvBNOfDCK/Gd7izQP48XqkKeiyuLx4JsQFQ1Q0lnvzn4FdNZS8CAWmXQUw0=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1731412363;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Content-Type:Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Message-Id:Reply-To;\n\tbh=azq1cEeRRomiEgKryVfIdtRjaHX40lcyJUvdL7gZro8=;\n\tb=ZHYQDCUDeJQdBeORvjM/5qItCQCZ6vX7aWlF0v+VNiPnsL4pO5L0ipnJ74zUacQu\n\tBz59pHFO1nBeWmXHQLDqCEK7iRE1z1DqiEtlgGxnjGVFHGilhPK1tCD5LMrrhG3iAAu\n\t92ulJJhK4/VQGKAvsfI82U6vMij5FIgBFuSLTC1c=","Content-Type":"multipart/alternative;\n\tboundary=\"------------1VQMM2JmX0JzjSRJeyOZdvDA\"","Message-ID":"<29e9c070-af72-44b9-8e34-322c06f6891c@collabora.com>","Date":"Tue, 12 Nov 2024 12:52:39 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 2/2] ipa/simple: Add tuning file for IMX355","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20241019184340.111785-1-robert.mader@collabora.com>\n\t<20241019184340.111785-2-robert.mader@collabora.com>\n\t<20241106123039.GD9369@pendragon.ideasonboard.com>","Content-Language":"en-US, de-DE","From":"Robert Mader ","In-Reply-To":"<20241106123039.GD9369@pendragon.ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32127,"web_url":"https://patchwork.libcamera.org/comment/32127/","msgid":"<20241112181935.GD24067@pendragon.ideasonboard.com>","date":"2024-11-12T18:19:35","subject":"Re: [PATCH 2/2] ipa/simple: Add tuning file for IMX355","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Nov 12, 2024 at 12:52:39PM +0100, Robert Mader wrote:\n> FTR., using\n> \n> gainType_ = AnalogueGainExponential;\n> gainConstants_.exp = { 1.0, expGainDb(0.3) };\n> \n> as used by several other IMX sensors seems to work fine - I just don't \n> have the bandwidth to prove it somehow. But if you'd consider accepting \n> such a helper non the less, I'd be happy to submit a corresponding patch.\n\nI'd be fine with that as a first step.\n\n> On 06.11.24 13:30, Laurent Pinchart wrote:\n> > Hi Robert,\n> >\n> > Thank you for the patch.\n> >\n> > On Sat, Oct 19, 2024 at 08:43:40PM +0200, Robert Mader wrote:\n> >> 64 at 10 bits. The value was guessed from known values for similar\n> >> sensors and testing - on a Google Pixel 3a - suggest it's correct.\n> >>\n> >> Adding this tuning file is partly motivated in order to serve as\n> >> example, as it's the first one for the simple IPA.\n> >>\n> >> Signed-off-by: Robert Mader\n> >> ---\n> >> src/ipa/simple/data/imx355.yaml | 11 +++++++++++\n> >> src/ipa/simple/data/meson.build | 1 +\n> >> 2 files changed, 12 insertions(+)\n> >> create mode 100644 src/ipa/simple/data/imx355.yaml\n> >>\n> >> diff --git a/src/ipa/simple/data/imx355.yaml b/src/ipa/simple/data/imx355.yaml\n> >> new file mode 100644\n> >> index 00000000..f7d01b73\n> >> --- /dev/null\n> >> +++ b/src/ipa/simple/data/imx355.yaml\n> >> @@ -0,0 +1,11 @@\n> >> +# SPDX-License-Identifier: CC0-1.0\n> >> +%YAML 1.1\n> >> +---\n> >> +version: 1\n> >> +algorithms:\n> >> + - BlackLevel:\n> >> + blackLevel: 4096\n> >> + - Awb:\n> >> + - Lut:\n> >> + - Agc:\n> >> +...\n> > To be absolutely honest, I'm not very keen on adding a tuning file for a\n> > sensor that is not supported in the IPA sensor helpers :-S\n> >\n> > We're considering a tool to characterize the gain model of sensors, I\n> > wonder if it could be extended to the black level as well. It would be\n> > nicer if we could capture optical black lines.\n> >\n> >> diff --git a/src/ipa/simple/data/meson.build b/src/ipa/simple/data/meson.build\n> >> index 92795ee4..6e690f82 100644\n> >> --- a/src/ipa/simple/data/meson.build\n> >> +++ b/src/ipa/simple/data/meson.build\n> >> @@ -1,6 +1,7 @@\n> >> # SPDX-License-Identifier: CC0-1.0\n> >> \n> >> conf_files = files([\n> >> + 'imx355.yaml',\n> >> 'uncalibrated.yaml',\n> >> ])\n> >>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3A727BE173\n\tfor ;\n\tTue, 12 Nov 2024 18:19:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 938FA657F7;\n\tTue, 12 Nov 2024 19:19:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1134E657B0\n\tfor ;\n\tTue, 12 Nov 2024 19:19:44 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 346AF710;\n\tTue, 12 Nov 2024 19:19:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aWM9ui7A\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731435571;\n\tbh=EOdJ1z4W+tBCK8vwTF5oXA3tvmO1z2+OT2uIqyNMrds=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=aWM9ui7AU1lEzxlGBeZ+tndbYu8jXWVsaL1CZq+/4kNurosYAFZTQPXTFf9hWIC+Y\n\tzHc3LlOtvpc0QOuwpKRyVrcrXD2p9Opg8UaSKR27aLPYWB0EfzAtM29z6/jqjVkYXj\n\tdRAHU5UJ99z9+zJjgfDxWWUJUSL3OjvdfVnbCayw=","Date":"Tue, 12 Nov 2024 20:19:35 +0200","From":"Laurent Pinchart ","To":"Robert Mader ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/2] ipa/simple: Add tuning file for IMX355","Message-ID":"<20241112181935.GD24067@pendragon.ideasonboard.com>","References":"<20241019184340.111785-1-robert.mader@collabora.com>\n\t<20241019184340.111785-2-robert.mader@collabora.com>\n\t<20241106123039.GD9369@pendragon.ideasonboard.com>\n\t<29e9c070-af72-44b9-8e34-322c06f6891c@collabora.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<29e9c070-af72-44b9-8e34-322c06f6891c@collabora.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]