[{"id":31847,"web_url":"https://patchwork.libcamera.org/comment/31847/","msgid":"<87zfmxd9z7.fsf@redhat.com>","date":"2024-10-21T10:30:20","subject":"Re: [PATCH 1/2] libcamera: software_isp: Stop clearing context\n\tconfig and state again","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Robert,\n\nthank you for the patch.\n\nRobert Mader <robert.mader@collabora.com> writes:\n\n> This partly reverts commit 41e3d61c, removing parts that had unintended\n> side effects as the intention for the commit was purely to fix crashes.\n>\n> Clearing the configuration turned out to be problematic as some values such\n> as configuration.black.level only get on initialization and thus were never\n> used.\n\nOh, indeed, I must have done some mistake when testing this. :-(\n\nBut rather than not clearing the configuration, a better approach should\nbe to store the black level from a tuning file to a class variable\nrather than to the context.\n\n> Clearing the activeState resulted in additional, arguably undesired churn,\n> very noticable when switching back and forth between cameras. \n\nDo you know what causes this?  Is it related to black level reset or\nsomething else?\n\n> Whether this is desirable is AFAIK a matter of taste/policy and\n> shouldn't have been done as part of a crash fix.\n>\n> Fixes: 41e3d61c (\"libcamera: software_isp: Clear IPA context on configure and stop\")\n> Signed-off-by: Robert Mader <robert.mader@collabora.com>\n> ---\n>  src/ipa/simple/soft_simple.cpp | 2 --\n>  1 file changed, 2 deletions(-)\n>\n> diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\n> index c8ad55a2..065673dc 100644\n> --- a/src/ipa/simple/soft_simple.cpp\n> +++ b/src/ipa/simple/soft_simple.cpp\n> @@ -185,8 +185,6 @@ int IPASoftSimple::configure(const IPAConfigInfo &configInfo)\n>  \tconst ControlInfo &gainInfo = sensorInfoMap_.find(V4L2_CID_ANALOGUE_GAIN)->second;\n>  \n>  \t/* Clear the IPA context before the streaming session. */\n> -\tcontext_.configuration = {};\n> -\tcontext_.activeState = {};\n>  \tcontext_.frameContexts.clear();\n>  \n>  \tcontext_.configuration.agc.exposureMin = exposureInfo.min().get<int32_t>();","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EC436C32A3\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 21 Oct 2024 10:30:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 80F4165392;\n\tMon, 21 Oct 2024 12:30:30 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54A336538A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Oct 2024 12:30:27 +0200 (CEST)","from mail-ej1-f72.google.com (mail-ej1-f72.google.com\n\t[209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-159-0_kvOiQ_POCt2QKKq6-ZSQ-1; Mon, 21 Oct 2024 06:30:24 -0400","by mail-ej1-f72.google.com with SMTP id\n\ta640c23a62f3a-a8711c48990so312657566b.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Oct 2024 03:30:24 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-a9a912d6551sm186844766b.39.2024.10.21.03.30.21\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 21 Oct 2024 03:30:21 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"i+i48fjn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1729506625;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=bhfbNA2nUw2LmZBjqjbGeI9LmRlrCl4dO68+93wWeks=;\n\tb=i+i48fjnZjm6Ort0sheemau0Cw6yX42ZrtQOH+xbAc/RQHVuzjXP8UJmd7s1FGMA6QkRtj\n\tDk9Mx/z2CHAIqM/ocxA3JWZckNb1oSWbnoI9XAysU4jvfsXcIkQt/SpdtfnAJcXjAwY/L7\n\tTxVUVg8xUaDcmrHHGlgA6Rn2aW8bYEs=","X-MC-Unique":"0_kvOiQ_POCt2QKKq6-ZSQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1729506623; x=1730111423;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=bhfbNA2nUw2LmZBjqjbGeI9LmRlrCl4dO68+93wWeks=;\n\tb=F53AqEQMXwhswuK5ypHsKiLF9idoPDmue4xxsZCpCF0N6ALvl0Y7Df1WCoXsLumpeF\n\tS7kpHU15e1HpXkW6OkDSczi3gyHhVRJds1YZjM1GTNxQmHEllecC6g9aETB/R6B7tUwa\n\t/Bmz/QnbmwR1bEAZKVYfX7ItUh6OP1fGCSl4MXGYb0qV0XlIBm63w/ClpRNVgWhpgcks\n\trYNxxvqrg+W+EqAMvPPr9vDFdLstUJVfooaaVwg4S3Cg8nz15stKgPaAfveNGuH2VknE\n\trqvQLoEgzKlmg/Y/VNAKH16vNcqYzH9HsT07BlNsWcCqzIkUKs+WvapUyDj2P7pocoy1\n\tjOvA==","X-Gm-Message-State":"AOJu0Yzove+FgFJEVpJokNkRQvMz1zpV6N1YmSjgG4w6jw/11iSQamGs\n\tpHhw0U1/9YXWH2EeitCiaCIvyrI3AJ9oQMmHKAv4wtXujn5tJH5OFqkoz2q57j2kdrvPQFGJ/bd\n\tqcFIX4Rh18H94SRvv9s6uKl/CelVTdbnaVMUUwzoeysdjsFc4TDA3xBhrMp3n4D3AngTIwrL7yO\n\tLswoG1yDBjJOcAbpLQ+fTrC6VezzkLd/2Me8xEeMVouWgksRNw/PCvpoQ=","X-Received":["by 2002:a17:907:9629:b0:a99:43b2:417e with SMTP id\n\ta640c23a62f3a-a9a69ce1072mr1250485966b.62.1729506622685; \n\tMon, 21 Oct 2024 03:30:22 -0700 (PDT)","by 2002:a17:907:9629:b0:a99:43b2:417e with SMTP id\n\ta640c23a62f3a-a9a69ce1072mr1250483266b.62.1729506622241; \n\tMon, 21 Oct 2024 03:30:22 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IHBJOutNtphHM/ePp4ckyvNskaMS+O64i7Kb0pNPHZa+ywWVuNg/rqJ4CngmzL6UbFCd1mR6w==","From":"Milan Zamazal <mzamazal@redhat.com>","To":"Robert Mader <robert.mader@collabora.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/2] libcamera: software_isp: Stop clearing context\n\tconfig and state again","In-Reply-To":"<20241019184340.111785-1-robert.mader@collabora.com> (Robert\n\tMader's message of \"Sat, 19 Oct 2024 20:43:39 +0200\")","References":"<20241019184340.111785-1-robert.mader@collabora.com>","Date":"Mon, 21 Oct 2024 12:30:20 +0200","Message-ID":"<87zfmxd9z7.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":32040,"web_url":"https://patchwork.libcamera.org/comment/32040/","msgid":"<87ed3ohcqy.fsf@redhat.com>","date":"2024-11-06T10:34:29","subject":"Re: [PATCH 1/2] libcamera: software_isp: Stop clearing context\n\tconfig and state again","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Milan Zamazal <mzamazal@redhat.com> writes:\n\n> Hi Robert,\n>\n> thank you for the patch.\n>\n> Robert Mader <robert.mader@collabora.com> writes:\n>\n>> This partly reverts commit 41e3d61c, removing parts that had unintended\n>> side effects as the intention for the commit was purely to fix crashes.\n>>\n>> Clearing the configuration turned out to be problematic as some values such\n>> as configuration.black.level only get on initialization and thus were never\n>> used.\n>\n> Oh, indeed, I must have done some mistake when testing this. :-(\n>\n> But rather than not clearing the configuration, a better approach should\n> be to store the black level from a tuning file to a class variable\n> rather than to the context.\n\nHi Robert,\n\ndo you plan to proceed with the patch or should I do something about it?\n\n>> Clearing the activeState resulted in additional, arguably undesired churn,\n>> very noticable when switching back and forth between cameras. \n>\n> Do you know what causes this?  Is it related to black level reset or\n> something else?\n>\n>> Whether this is desirable is AFAIK a matter of taste/policy and\n>> shouldn't have been done as part of a crash fix.\n>>\n>> Fixes: 41e3d61c (\"libcamera: software_isp: Clear IPA context on configure and stop\")\n>> Signed-off-by: Robert Mader <robert.mader@collabora.com>\n>> ---\n>>  src/ipa/simple/soft_simple.cpp | 2 --\n>>  1 file changed, 2 deletions(-)\n>>\n>> diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\n>> index c8ad55a2..065673dc 100644\n>> --- a/src/ipa/simple/soft_simple.cpp\n>> +++ b/src/ipa/simple/soft_simple.cpp\n>> @@ -185,8 +185,6 @@ int IPASoftSimple::configure(const IPAConfigInfo &configInfo)\n>>  \tconst ControlInfo &gainInfo = sensorInfoMap_.find(V4L2_CID_ANALOGUE_GAIN)->second;\n>>  \n>>  \t/* Clear the IPA context before the streaming session. */\n>> -\tcontext_.configuration = {};\n>> -\tcontext_.activeState = {};\n>>  \tcontext_.frameContexts.clear();\n>>  \n>>  \tcontext_.configuration.agc.exposureMin = exposureInfo.min().get<int32_t>();","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C126BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  6 Nov 2024 10:34:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 32C7C6541A;\n\tWed,  6 Nov 2024 11:34:37 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6B7D760393\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  6 Nov 2024 11:34:35 +0100 (CET)","from mail-ej1-f69.google.com (mail-ej1-f69.google.com\n\t[209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-221-5fXHyMmUOZqt0krF-40MrQ-1; Wed, 06 Nov 2024 05:34:33 -0500","by mail-ej1-f69.google.com with SMTP id\n\ta640c23a62f3a-a99ea3e1448so492123466b.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 06 Nov 2024 02:34:32 -0800 (PST)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-a9eb16d6749sm263142866b.62.2024.11.06.02.34.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 06 Nov 2024 02:34:30 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"UfbLk7jS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1730889274;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=2670Dvqi2t8ZZR+plTA5daLikQ5nlo4jHseKCDRtOdk=;\n\tb=UfbLk7jSBEJwpSHMAD6Fx0H5tnzAsoB5yUwUFqqCVL697pOe7uGdHKGYQSiT1NZKymM1F9\n\tgEvoW+DdtjDkWhNt9++UZoo9SRMecmraqfq3Q+KsPY6GWmdQA7KLvFArzpKX6hTrioA1Vf\n\tZtKa0dfKBCuGxJM8mrCk81uRUzWr3IU=","X-MC-Unique":"5fXHyMmUOZqt0krF-40MrQ-1","X-Mimecast-MFC-AGG-ID":"5fXHyMmUOZqt0krF-40MrQ","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1730889271; x=1731494071;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=2670Dvqi2t8ZZR+plTA5daLikQ5nlo4jHseKCDRtOdk=;\n\tb=WCKnZpjmkttIfyJNfTXZ4n9QNjmCdu5yxrgtcIF7vwHmiwRBscpdotcKy3jE3YdvOi\n\txsYPKUPQlYpvBhUoecXNgLoS16G1H5gcauJ6hMbyEncJ1HiZ+yo5E8XYtiKhlFua0nrY\n\tIoKhU1pfg4BI3EbSdR3C/QkxagD8d95RRu4cpHzpGc5JcibGPo9yf//BhyO5AcnqbRbm\n\tY5pSKdzT53t8hrKVOK9oF+6pbkiRtwxiOn7oSANnQMsDDPiSSl3Cq6KV7oPCwZB+yFEL\n\tMxDypSmIcoBfTRFOrHnvIE/oRsaJ/nXM9Y2azzN5t9SYi6sp29dgGMV0dL92PM67njV7\n\t1jWQ==","X-Gm-Message-State":"AOJu0YxfeTZP4XuFNFl310F8LND1qYJCnrtf/OobAwpDdykA7Loya0qm\n\t1/UNp+f/CT0dL1gJRml5iP1XUCuHvdEdEzoKc7FN+t9annO//G2W/WzSRMMgfUEZ8rDq8A0TLAn\n\tyli2NkB+EPv1QfHoNmo46kQGtdiTF4Mlhsipqzfx5oZZTSohQAW2d8C9M7L4cNJEQKR9dMc39NS\n\tN47H2/Lsoa0VePJ/GijGN1f0wtMGNqwF8Z4sOLGAfygu+/61XudX3kY4c=","X-Received":["by 2002:a17:907:cca3:b0:a9e:4b88:e03b with SMTP id\n\ta640c23a62f3a-a9e4b88e2famr1697785166b.0.1730889271532; \n\tWed, 06 Nov 2024 02:34:31 -0800 (PST)","by 2002:a17:907:cca3:b0:a9e:4b88:e03b with SMTP id\n\ta640c23a62f3a-a9e4b88e2famr1697783066b.0.1730889270971; \n\tWed, 06 Nov 2024 02:34:30 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IFNsa4npIjKVuBiem0EYyJLnp/omGTO4f49ICxTT5DJYr/Gin2oG34O6Y2pu7f5ssTgjtNx0g==","From":"Milan Zamazal <mzamazal@redhat.com>","To":"Robert Mader <robert.mader@collabora.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/2] libcamera: software_isp: Stop clearing context\n\tconfig and state again","In-Reply-To":"<87zfmxd9z7.fsf@redhat.com> (Milan Zamazal's message of \"Mon, 21\n\tOct 2024 12:30:20 +0200\")","References":"<20241019184340.111785-1-robert.mader@collabora.com>\n\t<87zfmxd9z7.fsf@redhat.com>","Date":"Wed, 06 Nov 2024 11:34:29 +0100","Message-ID":"<87ed3ohcqy.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"bTG1rwVe3UpPk8MwMVAY04xGdJLSFWqUTGF67a8epbo_1730889272","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":32041,"web_url":"https://patchwork.libcamera.org/comment/32041/","msgid":"<06bd57f2-f9ed-4b8e-b69f-99affb382c57@collabora.com>","date":"2024-11-06T10:43:12","subject":"Re: [PATCH 1/2] libcamera: software_isp: Stop clearing context\n\tconfig and state again","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"On 06.11.24 11:34, Milan Zamazal wrote:\n> Milan Zamazal <mzamazal@redhat.com> writes:\n>\n>> Hi Robert,\n>>\n>> thank you for the patch.\n>>\n>> Robert Mader <robert.mader@collabora.com> writes:\n>>\n>>> This partly reverts commit 41e3d61c, removing parts that had unintended\n>>> side effects as the intention for the commit was purely to fix crashes.\n>>>\n>>> Clearing the configuration turned out to be problematic as some values such\n>>> as configuration.black.level only get on initialization and thus were never\n>>> used.\n>> Oh, indeed, I must have done some mistake when testing this. :-(\n>>\n>> But rather than not clearing the configuration, a better approach should\n>> be to store the black level from a tuning file to a class variable\n>> rather than to the context.\n> Hi Robert,\n>\n> do you plan to proceed with the patch or should I do something about it?\n\nHey Milan, I'd try to get back to it (and other pending patches) in the \ncoming weeks -  specifically I wanted to check how this one relates to \n\"libcamera: software_isp: Initialize exposure+gain before agc \ncalculations\" etc. But please feel free to pick it up!\n\n>\n>>> Clearing the activeState resulted in additional, arguably undesired churn,\n>>> very noticable when switching back and forth between cameras.\n>> Do you know what causes this?  Is it related to black level reset or\n>> something else?\n>>\n>>> Whether this is desirable is AFAIK a matter of taste/policy and\n>>> shouldn't have been done as part of a crash fix.\n>>>\n>>> Fixes: 41e3d61c (\"libcamera: software_isp: Clear IPA context on configure and stop\")\n>>> Signed-off-by: Robert Mader <robert.mader@collabora.com>\n>>> ---\n>>>   src/ipa/simple/soft_simple.cpp | 2 --\n>>>   1 file changed, 2 deletions(-)\n>>>\n>>> diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\n>>> index c8ad55a2..065673dc 100644\n>>> --- a/src/ipa/simple/soft_simple.cpp\n>>> +++ b/src/ipa/simple/soft_simple.cpp\n>>> @@ -185,8 +185,6 @@ int IPASoftSimple::configure(const IPAConfigInfo &configInfo)\n>>>   \tconst ControlInfo &gainInfo = sensorInfoMap_.find(V4L2_CID_ANALOGUE_GAIN)->second;\n>>>   \n>>>   \t/* Clear the IPA context before the streaming session. */\n>>> -\tcontext_.configuration = {};\n>>> -\tcontext_.activeState = {};\n>>>   \tcontext_.frameContexts.clear();\n>>>   \n>>>   \tcontext_.configuration.agc.exposureMin = exposureInfo.min().get<int32_t>();","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 62BF7BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  6 Nov 2024 10:43:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 736636541B;\n\tWed,  6 Nov 2024 11:43:22 +0100 (CET)","from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E8EAE60393\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  6 Nov 2024 11:43:19 +0100 (CET)","by mx.zohomail.com with SMTPS id 1730889794525480.84323872108496; \n\tWed, 6 Nov 2024 02:43:14 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"ACdmUn9Q\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1730889796; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=R0jSdnHlmDZNhaeiOJZbQ5JIdMeKz7SRrQg9nZKHheG5SGTrCcaC6Oavj212Fg63DKUdTBwiylTqjI2BvTh4gbZv+tus6m3WdGpXqT7WtmKvSeVvidspNWdjYoR5q53xK3QO+4eKojr4vL4twKa5uXOZtFjqCyFcjQXW3AIPR8Y=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1730889796;\n\th=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=Nd7bkkq+vKDm/N6wDhGyYbuQLm5vjJZ9fm//tJxw/Fk=; \n\tb=PLFdZ9o4YW9ScBr6qq59ffp5deEbeuLi9oxrrQWKUS5vGXnUEji8/drfCvRQQIaXmcAcwmk9Y1q9KgAAZZRuPjEcAjqLg5a0DeHdOBvjuKc9TODqtKqx/Kl3Q0UCqJrtpuOaPWVnyVpqqlfLHDnOuU1Z2uVOflYJOxR1lSAYpgY=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass  header.i=collabora.com;\n\tspf=pass  smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1730889796;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=Nd7bkkq+vKDm/N6wDhGyYbuQLm5vjJZ9fm//tJxw/Fk=;\n\tb=ACdmUn9QjiklYNE0O5bjyLYx3vnZlkRzrmzWUBVct6VDy2iA3Uxps5Jbqj/++tN6\n\trTjY3ydrrYRk6SBo/TTOFUxWbfTSsCZK/bmjj+c/4oVmYTzaphakAu9iQ6KeWycJWmn\n\tH+VdBeoEeva8MfR+GGfJ+MBnyrR+HvlzKfMIsjsw=","Message-ID":"<06bd57f2-f9ed-4b8e-b69f-99affb382c57@collabora.com>","Date":"Wed, 6 Nov 2024 11:43:12 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/2] libcamera: software_isp: Stop clearing context\n\tconfig and state again","To":"Milan Zamazal <mzamazal@redhat.com>","Cc":"libcamera-devel@lists.libcamera.org","References":"<20241019184340.111785-1-robert.mader@collabora.com>\n\t<87zfmxd9z7.fsf@redhat.com> <87ed3ohcqy.fsf@redhat.com>","Content-Language":"en-US","From":"Robert Mader <robert.mader@collabora.com>","In-Reply-To":"<87ed3ohcqy.fsf@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]