{"id":21692,"url":"https://patchwork.libcamera.org/api/patches/21692/?format=json","web_url":"https://patchwork.libcamera.org/patch/21692/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241018160638.936993-2-stefan.klug@ideasonboard.com>","date":"2024-10-18T16:06:30","name":"[v4,1/4] ipa: rkisp1: algorithms: agc: Check for correct stats type","commit_ref":"0e0e32b1890c97343ade0f91cb643a1c4da9064f","pull_url":null,"state":"accepted","archived":false,"hash":"4821d11e85f9d153f59472919f1b77348fcb893a","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21692/mbox/","series":[{"id":4722,"url":"https://patchwork.libcamera.org/api/series/4722/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4722","date":"2024-10-18T16:06:29","name":"A few small fixes","version":4,"mbox":"https://patchwork.libcamera.org/series/4722/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21692/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21692/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A0C7CC32FE\n\tfor ;\n\tFri, 18 Oct 2024 16:06:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5332A6538A;\n\tFri, 18 Oct 2024 18:06:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D3AD9633C7\n\tfor ;\n\tFri, 18 Oct 2024 18:06:44 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:77a0:ddb9:22bf:b8d9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1C5A521C;\n\tFri, 18 Oct 2024 18:05:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"U/YDhagi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729267501;\n\tbh=lJVBcic6UlnU4cvTpoFO80fKah+GR0BP2eHxCGetaVQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=U/YDhagiWLROyDoTb0mmPjQAdn74vAPhYXdWT4+gt1Kewr2zyfeHKDIocUGM9MqN3\n\tZ1MYEuFWjSrDm+tp8r2tqRDNZc4v+pNTZrCkTEWOI9zsbL92FpFMY3m+zYiezy5dPJ\n\tQXZLz9djMibJwg0ZGsZPAUJnOvpLImrOPOXMUGKs=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tKieran Bingham ,\n\tLaurent Pinchart ,\n\tPaul Elder ","Subject":"[PATCH v4 1/4] ipa: rkisp1: algorithms: agc: Check for correct stats\n\ttype","Date":"Fri, 18 Oct 2024 18:06:30 +0200","Message-ID":"<20241018160638.936993-2-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20241018160638.936993-1-stefan.klug@ideasonboard.com>","References":"<20241018160638.936993-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Sometimes the ISP produces statistics only with a subset of statistic\ntypes being valid. It doesn't happen normally, but was observed in the\nwild. Check for the RKISP1_CIF_ISP_STAT_AUTOEXP bit to prevent using\ninvalid or outdated data. As it doesn't happen regularly add an error\nmessage to get notified when it happens.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \nReviewed-by: Paul Elder \n\n---\nChanges in v4:\n- Fix missing fillMetadata introduced in v3.\n\nChanges in v3:\n- Split check for stats and type, to silence messages in raw mode\n\nChanges in v2:\n- Added error message\n- Made condition more readable\n- Collected tags\n---\n src/ipa/rkisp1/algorithms/agc.cpp | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex 17d074d9c03e..301b7ec26508 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -402,6 +402,12 @@ void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame,\n \t\tfillMetadata(context, frameContext, metadata);\n \t\treturn;\n \t}\n+\t\n+\tif (!(stats->meas_type & RKISP1_CIF_ISP_STAT_AUTOEXP)) {\n+\t\tfillMetadata(context, frameContext, metadata);\n+\t\tLOG(RkISP1Agc, Error) << \"AUTOEXP data is missing in statistics\";\n+\t\treturn;\n+\t}\n \n \t/*\n \t * \\todo Verify that the exposure and gain applied by the sensor for\n@@ -412,7 +418,6 @@ void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame,\n \t */\n \n \tconst rkisp1_cif_isp_stat *params = &stats->params;\n-\tASSERT(stats->meas_type & RKISP1_CIF_ISP_STAT_AUTOEXP);\n \n \t/* The lower 4 bits are fractional and meant to be discarded. */\n \tHistogram hist({ params->hist.hist_bins, context.hw->numHistogramBins },\n","prefixes":["v4","1/4"]}