[{"id":31798,"web_url":"https://patchwork.libcamera.org/comment/31798/","msgid":"<172926190042.3353069.5371018904191289717@ping.linuxembedded.co.uk>","date":"2024-10-18T14:31:40","subject":"Re: [PATCH] qcam: Automatically select the camera if only one is\n\tavailable","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stanislaw Gruszka (2024-10-18 15:29:16)\n> When only a single camera is available, showing the camera selection\n> dialog is unnecessary. It's better to automatically select the available\n> camera without prompting the user for input.\n> \n> Signed-off-by: Stanislaw Gruszka \n> ---\n> src/apps/qcam/main_window.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/apps/qcam/main_window.cpp b/src/apps/qcam/main_window.cpp\n> index 5144c6b3..b0dfd850 100644\n> --- a/src/apps/qcam/main_window.cpp\n> +++ b/src/apps/qcam/main_window.cpp\n> @@ -303,6 +303,8 @@ int MainWindow::openCamera()\n> */\n> if (options_.isSet(OptCamera))\n> cameraName = static_cast(options_[OptCamera]);\n> + else if (cm_->cameras().size() == 1)\n> + cameraName = cm_->cameras()[0]->id();\n\nI'm sold on that. I've wanted to do the same for some time ;-)\n\nReviewed-by: Kieran Bingham \n\n> else\n> cameraName = chooseCamera();\n> \n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BC424C32FE\n\tfor ;\n\tFri, 18 Oct 2024 14:31:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 899D16538B;\n\tFri, 18 Oct 2024 16:31:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C9BF633C6\n\tfor ;\n\tFri, 18 Oct 2024 16:31:43 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 91C73514;\n\tFri, 18 Oct 2024 16:29:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IdVLSxfy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729261799;\n\tbh=bt8Q2LO/N4K8wU0XAQYCLASkgSdTWvknfg4INgLO/yg=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=IdVLSxfyXWVnNYAd1ebqKrzib49Oj/QThcdT5DBvpmob0CZZ0hdkXwFyvC7h79UPu\n\tWi0TId9B9JV7s0KYlOrJZKx7XQxCruXHTNAVR9pG/hrxWR23HKXfRAjJMC6ksfpK9f\n\tNO+Wy9EinojoeRtpNMfhW6elXJeQr3/DtUV/+FQA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241018142916.23578-1-stanislaw.gruszka@linux.intel.com>","References":"<20241018142916.23578-1-stanislaw.gruszka@linux.intel.com>","Subject":"Re: [PATCH] qcam: Automatically select the camera if only one is\n\tavailable","From":"Kieran Bingham ","To":"Stanislaw Gruszka ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 18 Oct 2024 15:31:40 +0100","Message-ID":"<172926190042.3353069.5371018904191289717@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31805,"web_url":"https://patchwork.libcamera.org/comment/31805/","msgid":"<20241018205955.GE20855@pendragon.ideasonboard.com>","date":"2024-10-18T20:59:55","subject":"Re: [PATCH] qcam: Automatically select the camera if only one is\n\tavailable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Oct 18, 2024 at 03:31:40PM +0100, Kieran Bingham wrote:\n> Quoting Stanislaw Gruszka (2024-10-18 15:29:16)\n> > When only a single camera is available, showing the camera selection\n> > dialog is unnecessary. It's better to automatically select the available\n> > camera without prompting the user for input.\n> > \n> > Signed-off-by: Stanislaw Gruszka \n> > ---\n> > src/apps/qcam/main_window.cpp | 2 ++\n> > 1 file changed, 2 insertions(+)\n> > \n> > diff --git a/src/apps/qcam/main_window.cpp b/src/apps/qcam/main_window.cpp\n> > index 5144c6b3..b0dfd850 100644\n> > --- a/src/apps/qcam/main_window.cpp\n> > +++ b/src/apps/qcam/main_window.cpp\n> > @@ -303,6 +303,8 @@ int MainWindow::openCamera()\n> > */\n> > if (options_.isSet(OptCamera))\n> > cameraName = static_cast(options_[OptCamera]);\n> > + else if (cm_->cameras().size() == 1)\n> > + cameraName = cm_->cameras()[0]->id();\n\nThere's a TOC-TOU race, this will crash if the camera is unplugged\nbetween the check and use.\n\n> \n> I'm sold on that. I've wanted to do the same for some time ;-)\n> \n> Reviewed-by: Kieran Bingham \n> \n> > else\n> > cameraName = chooseCamera();\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9F3C5C32FE\n\tfor ;\n\tFri, 18 Oct 2024 21:00:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 908B86538A;\n\tFri, 18 Oct 2024 23:00:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37608633C6\n\tfor ;\n\tFri, 18 Oct 2024 23:00:01 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E5A1421C;\n\tFri, 18 Oct 2024 22:58:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XpOfkSm6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729285097;\n\tbh=+SAS1bMz8h1rcanGYpoUbWg4qCxIlUzkS2q4QtNoES8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XpOfkSm6sktzFWQHJJ/squQckIT6bxFB6RBMBKhtTPs4khKkE7UHoGFKSbaYEn6hG\n\tnl4vxliGfvnAjyKHGNGo8XakUoUV6YPYu+F4miMMFNMbyqvQIF64ioGdEEeAVGw33R\n\tOMHhkZ1DLUGk2vnjbkB8yeSAafM8P7ub8b+eNkgI=","Date":"Fri, 18 Oct 2024 23:59:55 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Stanislaw Gruszka ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] qcam: Automatically select the camera if only one is\n\tavailable","Message-ID":"<20241018205955.GE20855@pendragon.ideasonboard.com>","References":"<20241018142916.23578-1-stanislaw.gruszka@linux.intel.com>\n\t<172926190042.3353069.5371018904191289717@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<172926190042.3353069.5371018904191289717@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]