[{"id":2883,"web_url":"https://patchwork.libcamera.org/comment/2883/","msgid":"<20191013153350.GO23166@bigcity.dyn.berto.se>","date":"2019-10-13T15:33:50","subject":"Re: [libcamera-devel] [PATCH v2 06/14] libcamera: controls: Store\n\tcontrol name in ControlId","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-10-12 21:43:59 +0300, Laurent Pinchart wrote:\n> The ControlId class stores a pointer to the control name. This works\n> fine for statically-defined controls, but requires code that allocates\n> controls dynamically (for instance based on control discovery on a V4L2\n> device) to keep a list of control names in separate storage. To ease\n> usage of dynamically allocated controls, store a copy of the control\n> name string in the ControlId class.\n> \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/controls.h | 6 +++---\n> src/libcamera/controls.cpp | 2 +-\n> 2 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index 12a13aacb198..999fcf7a3a62 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -60,11 +60,11 @@ class ControlId\n> {\n> public:\n> \tunsigned int id() const { return id_; }\n> -\tconst char *name() const { return name_; }\n> +\tconst std::string &name() const { return name_; }\n> \tControlType type() const { return type_; }\n> \n> protected:\n> -\tControlId(unsigned int id, const char *name, ControlType type)\n> +\tControlId(unsigned int id, const std::string &name, ControlType type)\n> \t\t: id_(id), name_(name), type_(type)\n> \t{\n> \t}\n> @@ -74,7 +74,7 @@ private:\n> \tControlId &operator=(const ControlId &) = delete;\n> \n> \tunsigned int id_;\n> -\tconst char *name_;\n> +\tstd::string name_;\n> \tControlType type_;\n> };\n> \n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index bfab177fc508..292e48cd6d25 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -232,7 +232,7 @@ bool ControlValue::operator==(const ControlValue &other) const\n> */\n> \n> /**\n> - * \\fn ControlId::ControlId(unsigned int id, const char *name, ControlType type)\n> + * \\fn ControlId::ControlId(unsigned int id, const std::string &name, ControlType type)\n> * \\brief Construct a ControlId instance\n> * \\param[in] id The control numerical ID\n> * \\param[in] name The control name\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1795261562\n\tfor ;\n\tSun, 13 Oct 2019 17:33:52 +0200 (CEST)","by mail-lf1-x144.google.com with SMTP id d17so10101698lfa.7\n\tfor ;\n\tSun, 13 Oct 2019 08:33:52 -0700 (PDT)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tb20sm3477453ljo.106.2019.10.13.08.33.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 13 Oct 2019 08:33:51 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=pQY1ebRLBTW6Uz7oUnYB1APlyMVSdfoF7so1c9Moaug=;\n\tb=dQvO9hUPdXkBn1PstO6botRjYcvCp+l9D26XL48oGnfj+JG+2g6qKIQrMH6RF3gHsE\n\tizaxJdE0JAT9qGz/FTbPMNhSHZEQ94/xjYA3Ag4GjjhkTBM3OTsEQsNXf1x7W/Mpw+OU\n\tBFPZcpDWL0SOY3eI52cf/WZzaXPRUjY6zhRaq5A3rUBZARcdrsgi9A/NXMKJowHlifjL\n\tZnw0Jcy2gD5ioQDrgXRfAmL+alSF+K3kBQbAsIIPu5f0d2imXyDaGXI5zuClVWVkkiAE\n\tcZBTfuLIJ88WEBPqI8hscnIXjhRCFlOisXgku5s8toANYP6BDac+7TB2Kvvme+W1Ntjf\n\tNhbA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=pQY1ebRLBTW6Uz7oUnYB1APlyMVSdfoF7so1c9Moaug=;\n\tb=icmrKF8HrIPkA8/cDvyaY+onpTKCZzkirkdsmfXJZck2sBHzccaneoIkYWVOoFydwC\n\t83kjFiNXj8jz9Si4Ig1lVzRlWxIxaaT87QJ0k7A0VuZdxPpqjbdycX8VCrLXI/NAAr61\n\ttN6MsGFxAbAL3OSR8Ze9l8cFZ7a9RaZ3kZ0iYkrf/6ZbZCfwzyBIwwxUzoEgErF2w9GX\n\trh+8QXyM8VVJLPG/VY12YmwubGq518CFvYxDoQSMATncmDsepxptuWgteB4ee6Kt99um\n\tZmSkc4APK+OZodsknKDWaGiTQc2ScCSw7Pdl0gAZez3s/gUQO0qVdQN0XlCKo82yHC5x\n\tHUsA==","X-Gm-Message-State":"APjAAAWseOISGg8KS3LJfYz0XykpdmmS5D+EgVJYpUfgOaEVpbrHSydO\n\tnffh/FTbw4PHDbf6yr750EphF0C98K8=","X-Google-Smtp-Source":"APXvYqwn3H2GEinCS6MIsF0U/nJp/zP9Hg0oY89fyh5BlE59hZZ9JREXqA01CjfmkatjY3IP018MmA==","X-Received":"by 2002:a05:6512:25b:: with SMTP id\n\tb27mr8068603lfo.146.1570980831542; \n\tSun, 13 Oct 2019 08:33:51 -0700 (PDT)","Date":"Sun, 13 Oct 2019 17:33:50 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191013153350.GO23166@bigcity.dyn.berto.se>","References":"<20191012184407.31684-1-laurent.pinchart@ideasonboard.com>\n\t<20191012184407.31684-7-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191012184407.31684-7-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v2 06/14] libcamera: controls: Store\n\tcontrol name in ControlId","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 13 Oct 2019 15:33:52 -0000"}}]