[{"id":31789,"web_url":"https://patchwork.libcamera.org/comment/31789/","msgid":"","date":"2024-10-18T07:54:00","subject":"Re: [PATCH] libcamera: mtkisp7: Change ipa_control_value_entry.count\n\tto 32 bits","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"content":"Sorry, should've removed the prefix \"mtkisp7\".\nWill fix it in the next version.\n\nOn Fri, Oct 18, 2024 at 3:52 PM Harvey Yang wrote:\n>\n> From: Xing-Gu Chen \n>\n> Change ipa_control_value_entry.count to uint32_t because the\n> element count of JpegApplicationSegmentContent is bigger than\n> 65536.\n>\n> Signed-off-by: Xing-Gu Chen \n> Co-developed-by: Harvey Yang \n> Signed-off-by: Harvey Yang \n> ---\n> include/libcamera/ipa/ipa_controls.h | 2 +-\n> src/libcamera/ipa_controls.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/include/libcamera/ipa/ipa_controls.h b/include/libcamera/ipa/ipa_controls.h\n> index 5fd13394f..7a8051695 100644\n> --- a/include/libcamera/ipa/ipa_controls.h\n> +++ b/include/libcamera/ipa/ipa_controls.h\n> @@ -37,7 +37,7 @@ struct ipa_control_value_entry {\n> uint32_t id;\n> uint8_t type;\n> uint8_t is_array;\n> - uint16_t count;\n> + uint32_t count;\n> uint32_t offset;\n> uint32_t padding[1];\n> };\n> diff --git a/src/libcamera/ipa_controls.cpp b/src/libcamera/ipa_controls.cpp\n> index 9420c889f..a1ccc7d61 100644\n> --- a/src/libcamera/ipa_controls.cpp\n> +++ b/src/libcamera/ipa_controls.cpp\n> @@ -207,7 +207,7 @@ static_assert(sizeof(ipa_controls_header) == 32,\n> * Padding bytes (shall be set to 0)\n> */\n>\n> -static_assert(sizeof(ipa_control_value_entry) == 16,\n> +static_assert(sizeof(ipa_control_value_entry) == 20,\n> \"Invalid ABI size change for struct ipa_control_value_entry\");\n>\n> /**\n> --\n> 2.47.0.rc1.288.g06298d1525-goog\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 463AEC32FE\n\tfor ;\n\tFri, 18 Oct 2024 07:54:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DEB646538B;\n\tFri, 18 Oct 2024 09:54:14 +0200 (CEST)","from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com\n\t[IPv6:2a00:1450:4864:20::22b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B00065379\n\tfor ;\n\tFri, 18 Oct 2024 09:54:13 +0200 (CEST)","by mail-lj1-x22b.google.com with SMTP id\n\t38308e7fff4ca-2fb5638dd57so20847911fa.0\n\tfor ;\n\tFri, 18 Oct 2024 00:54:13 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"DfxUG3wL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1729238052; x=1729842852;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=vfdccyKHBpB80qE/QBrH4mWReLiAwP298SYWTFdWzYk=;\n\tb=DfxUG3wLzK3QcdRAFbG4AbTT7xHbSKj76BXFquWbXcqBctHInbRQVkE50G5VYcurcL\n\tKq+WcGGu2N1lD7QrxxA9MiPb/4AIQBz5WDEDtRk4AkMkYt+iAzpqs5OVILaYKosvwAJB\n\txa0+gQJZ6mGceKKpgsgiu2PzuZvP4yiOx6F3w=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1729238052; x=1729842852;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=vfdccyKHBpB80qE/QBrH4mWReLiAwP298SYWTFdWzYk=;\n\tb=bKoS0swOcGipetF/HssxBalKNWEfDyBcVnNXEedblsHaruORSlfMYT7tVLTg/kg2iM\n\tq28GO8mc8wsFzjVYvW+QHZRsZLMPXE52Sl2DrT+gzyKXXBxuSfWUE/rcJoEfJCGeYNnK\n\tNe66iYaQzatTVSX6v2/RHNmvpQua5YirQmzOT6V1IX6QVRKjKEfj/IbY0+Hir1MSLV0T\n\tRt1lHam7gUzcZrFjAg4qBBJFR6EJrt3fXyvimkdel+IYca75yBbUzS6GCCkLgBinqbw9\n\tFm+4tm9mWkKgZvLQEYHioXvsOAJh8JFf8ubQVoFPkIzIRGiq0HVvuT3LajAj+wUk7J8i\n\tUQOw==","X-Gm-Message-State":"AOJu0YxCQstzsJesg9AKB+XlTJZH+qPdc9+O5y4WCKr4FUwWCZ95BnQp\n\tD77M0atA5p7dtrF1B3sVNtKg03scPvQ/z3nl4w8eYfgUAGjP7YO/nqq9ythWqsBa3SuszWUm1uJ\n\tG59y811R2SBYhnZykFR6ARpmp0oItfcxl4d+g6mPTSvCHL9s=","X-Google-Smtp-Source":"AGHT+IFcMrFPRXm+k94b61C4uQLzdQvg3ArecduOcMFjnPLPDQe9GQSuuYBhGM7xVFFfXUWExEAktkdGaJOoXn28Itw=","X-Received":"by 2002:a05:651c:221e:b0:2fb:5e64:327e with SMTP id\n\t38308e7fff4ca-2fb83200aeemr6439741fa.33.1729238052016;\n\tFri, 18 Oct 2024 00:54:12 -0700 (PDT)","MIME-Version":"1.0","References":"<20241018075242.1143876-1-chenghaoyang@chromium.org>","In-Reply-To":"<20241018075242.1143876-1-chenghaoyang@chromium.org>","From":"Cheng-Hao Yang ","Date":"Fri, 18 Oct 2024 15:54:00 +0800","Message-ID":"","Subject":"Re: [PATCH] libcamera: mtkisp7: Change ipa_control_value_entry.count\n\tto 32 bits","To":"libcamera-devel@lists.libcamera.org","Cc":"Xing-Gu Chen ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31791,"web_url":"https://patchwork.libcamera.org/comment/31791/","msgid":"<20241018125046.GA19219@pendragon.ideasonboard.com>","date":"2024-10-18T12:50:46","subject":"Re: [PATCH] libcamera: mtkisp7: Change ipa_control_value_entry.count\n\tto 32 bits","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Harvey, Xing-Gu,\n\nThank you for the patch.\n\nOn Fri, Oct 18, 2024 at 07:52:37AM +0000, Harvey Yang wrote:\n> From: Xing-Gu Chen \n> \n> Change ipa_control_value_entry.count to uint32_t because the\n> element count of JpegApplicationSegmentContent is bigger than\n> 65536.\n\nTransporting large data over controls is inefficients, as control lists\nget copied multiple time with isolated IPA modules. Is this a sign we\nneed to think about a more efficient mechanism ? I'm also thinking we\nshould review how JpegApplicationSegmentContent is handled first.\n\n> Signed-off-by: Xing-Gu Chen \n> Co-developed-by: Harvey Yang \n> Signed-off-by: Harvey Yang \n> ---\n> include/libcamera/ipa/ipa_controls.h | 2 +-\n> src/libcamera/ipa_controls.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/ipa_controls.h b/include/libcamera/ipa/ipa_controls.h\n> index 5fd13394f..7a8051695 100644\n> --- a/include/libcamera/ipa/ipa_controls.h\n> +++ b/include/libcamera/ipa/ipa_controls.h\n> @@ -37,7 +37,7 @@ struct ipa_control_value_entry {\n> \tuint32_t id;\n> \tuint8_t type;\n> \tuint8_t is_array;\n> -\tuint16_t count;\n> +\tuint32_t count;\n> \tuint32_t offset;\n> \tuint32_t padding[1];\n> };\n> diff --git a/src/libcamera/ipa_controls.cpp b/src/libcamera/ipa_controls.cpp\n> index 9420c889f..a1ccc7d61 100644\n> --- a/src/libcamera/ipa_controls.cpp\n> +++ b/src/libcamera/ipa_controls.cpp\n> @@ -207,7 +207,7 @@ static_assert(sizeof(ipa_controls_header) == 32,\n> * Padding bytes (shall be set to 0)\n> */\n> \n> -static_assert(sizeof(ipa_control_value_entry) == 16,\n> +static_assert(sizeof(ipa_control_value_entry) == 20,\n> \t \"Invalid ABI size change for struct ipa_control_value_entry\");\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9921BC32FE\n\tfor ;\n\tFri, 18 Oct 2024 12:50:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7D2ED6538A;\n\tFri, 18 Oct 2024 14:50:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D16F633C6\n\tfor ;\n\tFri, 18 Oct 2024 14:50:52 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 036C521C;\n\tFri, 18 Oct 2024 14:49:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SRZ6kDHt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729255748;\n\tbh=NI5hMwhnCsB25o7F9sLJfLI/j1dnfiLgQNPt65BgDiA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SRZ6kDHt5CJc3bo/91kXQ6YqPeetqleid+WgxHT+cSlBNxI4o/CV/mzqa67CvU0TC\n\tSbkvWTdpVtrb2jMAzwfSnjxz4Qkx9/MARRlQJ1bQRcjQLO66D2+W9MySMDN7ml2TYm\n\teLSseMQBA54B+gBrnFCx7JQvEHMEC4cmOu/2Xz8c=","Date":"Fri, 18 Oct 2024 15:50:46 +0300","From":"Laurent Pinchart ","To":"Harvey Yang ","Cc":"libcamera-devel@lists.libcamera.org, Xing-Gu Chen ","Subject":"Re: [PATCH] libcamera: mtkisp7: Change ipa_control_value_entry.count\n\tto 32 bits","Message-ID":"<20241018125046.GA19219@pendragon.ideasonboard.com>","References":"<20241018075242.1143876-1-chenghaoyang@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241018075242.1143876-1-chenghaoyang@chromium.org>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31873,"web_url":"https://patchwork.libcamera.org/comment/31873/","msgid":"","date":"2024-10-22T09:32:36","subject":"Re: [PATCH] libcamera: mtkisp7: Change ipa_control_value_entry.count\n\tto 32 bits","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"content":"Hi Laurent,\n\nOn Fri, Oct 18, 2024 at 8:50 PM Laurent Pinchart\n wrote:\n>\n> Hi Harvey, Xing-Gu,\n>\n> Thank you for the patch.\n>\n> On Fri, Oct 18, 2024 at 07:52:37AM +0000, Harvey Yang wrote:\n> > From: Xing-Gu Chen \n> >\n> > Change ipa_control_value_entry.count to uint32_t because the\n> > element count of JpegApplicationSegmentContent is bigger than\n> > 65536.\n>\n> Transporting large data over controls is inefficients, as control lists\n> get copied multiple time with isolated IPA modules. Is this a sign we\n> need to think about a more efficient mechanism ? I'm also thinking we\n> should review how JpegApplicationSegmentContent is handled first.\n\nYou mean serializing (multiple resizes as well) and deserializing?\nDo we consider using DMA buffer to pass this for instance?\nOr libcamera::SharedMem.\n\nI also just realized that JpegApplicationSegmentContent was added\nby us [1]. I found that this is only needed for a debugging module in\nmtkisp7, which we might not end up upstreaming.\nDo you think JpegApplicationSegmentContent makes sense and it's\nsomething that upstream libcamera would like to have?\nIf this is controversial, we can also skip this for now.\n\nBR,\nHarvey\n\n[1]: https://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/5233122\n\n\n>\n> > Signed-off-by: Xing-Gu Chen \n> > Co-developed-by: Harvey Yang \n> > Signed-off-by: Harvey Yang \n> > ---\n> > include/libcamera/ipa/ipa_controls.h | 2 +-\n> > src/libcamera/ipa_controls.cpp | 2 +-\n> > 2 files changed, 2 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/include/libcamera/ipa/ipa_controls.h b/include/libcamera/ipa/ipa_controls.h\n> > index 5fd13394f..7a8051695 100644\n> > --- a/include/libcamera/ipa/ipa_controls.h\n> > +++ b/include/libcamera/ipa/ipa_controls.h\n> > @@ -37,7 +37,7 @@ struct ipa_control_value_entry {\n> > uint32_t id;\n> > uint8_t type;\n> > uint8_t is_array;\n> > - uint16_t count;\n> > + uint32_t count;\n> > uint32_t offset;\n> > uint32_t padding[1];\n> > };\n> > diff --git a/src/libcamera/ipa_controls.cpp b/src/libcamera/ipa_controls.cpp\n> > index 9420c889f..a1ccc7d61 100644\n> > --- a/src/libcamera/ipa_controls.cpp\n> > +++ b/src/libcamera/ipa_controls.cpp\n> > @@ -207,7 +207,7 @@ static_assert(sizeof(ipa_controls_header) == 32,\n> > * Padding bytes (shall be set to 0)\n> > */\n> >\n> > -static_assert(sizeof(ipa_control_value_entry) == 16,\n> > +static_assert(sizeof(ipa_control_value_entry) == 20,\n> > \"Invalid ABI size change for struct ipa_control_value_entry\");\n> >\n> > /**\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6D76BC3272\n\tfor ;\n\tTue, 22 Oct 2024 09:32:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3B69265392;\n\tTue, 22 Oct 2024 11:32:50 +0200 (CEST)","from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com\n\t[IPv6:2a00:1450:4864:20::22e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 99CA66053E\n\tfor ;\n\tTue, 22 Oct 2024 11:32:48 +0200 (CEST)","by mail-lj1-x22e.google.com with SMTP id\n\t38308e7fff4ca-2fb6110c8faso55086591fa.1\n\tfor ;\n\tTue, 22 Oct 2024 02:32:48 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"CWUzHaB4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1729589568; x=1730194368;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=pRVWJ7d0yCzzx3f/koy71xYkE9Q78gRwrEs2Pv/OTJA=;\n\tb=CWUzHaB4RNe2NREHS9S/9J5WXkXu2r3lu9JA0aC2WjtzZBX7s6gCnu72Kxvxay2AYt\n\tye0Ouzo1VUveAT9fyDjkkfytghKuxn7T9w75vz1rA+4XSsrTWOcaa1oozF7sEHuVe1tC\n\tV9dwYIhlkHMUg42xqbAiuVrpZYtRlMtVDEoGg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1729589568; x=1730194368;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=pRVWJ7d0yCzzx3f/koy71xYkE9Q78gRwrEs2Pv/OTJA=;\n\tb=ZM1/5u0LzinYHyL4wlbhVVgFp4Zf1Sg+tZ31dz0jLaqFSqGrpo5yAgr02vcj0ES9uJ\n\teGh8vXiwl6ef47hJxs8rnFe2IBNbtjTRxzDkN1G8LeOjqo+oCjoirWdsVcip/43QdC4F\n\ti7EOtHQxQAbKBDqa3Fejr4wCsG74vrsxZ62n5GwTbE1v3mO+0ssN/DSmzT1vdihGSgZC\n\tdVbtRhEIhlUS4rs78h9YakCkcAs0yAm6lc1endXp2EiKbc2hpU+rbosIIBPjXJvdAmIg\n\tH9CIq0dE3Nw8cNSl3/j4spQzaX01R3M7dpBIFvKTc6Y/gaYHAROL3yogyTSs5k819+DG\n\tpdvQ==","X-Gm-Message-State":"AOJu0YxsmbmCfHNKqjaZWU7GHF+PrcnP2r8Tgtm+aTX2/w7Y/cu4pY9R\n\tJHc4pU+hNKknIDQ143geAFd9X3DjBpaGCPS+jccmRVaRBVkw/Mce4nkyhPGkTkXkB0VifhzYtYq\n\tqkYfNEyNXhM2EcEDh/1hMLivby2W3w4Yr2YkLs34YmRpCgj9mDg==","X-Google-Smtp-Source":"AGHT+IHesdVhXKh2L3e1Ptw49gsZ22YawQK1nj3SwVh78HGfZyxZyV5IqJuZElvtsS77mRcMgcm/oC2BoE4rtnCvs3U=","X-Received":"by 2002:a05:651c:154a:b0:2fb:5bb8:7c24 with SMTP id\n\t38308e7fff4ca-2fb82eb71a0mr55140401fa.8.1729589567709;\n\tTue, 22 Oct 2024 02:32:47 -0700 (PDT)","MIME-Version":"1.0","References":"<20241018075242.1143876-1-chenghaoyang@chromium.org>\n\t<20241018125046.GA19219@pendragon.ideasonboard.com>","In-Reply-To":"<20241018125046.GA19219@pendragon.ideasonboard.com>","From":"Cheng-Hao Yang ","Date":"Tue, 22 Oct 2024 17:32:36 +0800","Message-ID":"","Subject":"Re: [PATCH] libcamera: mtkisp7: Change ipa_control_value_entry.count\n\tto 32 bits","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, Xing-Gu Chen ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]