[{"id":31795,"web_url":"https://patchwork.libcamera.org/comment/31795/","msgid":"<172926082945.3353069.12425952353436315505@ping.linuxembedded.co.uk>","date":"2024-10-18T14:13:49","subject":"Re: [PATCH v3 1/3] gstreamer: Remove auto-focus-mode property from\n\tdevice provider","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jaslo Ziska (2024-10-17 18:04:13)\n> The device provider is not supposed to have control properties, remove\n> the auto-focus-mode property which was introduced by accident.\n> \n> Fixes: 5a142438b025 (\"gstreamer: Add enable_auto_focus option to the GStreamer plugin\")\n> Signed-off-by: Jaslo Ziska \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/gstreamer/gstlibcameraprovider.cpp | 15 ---------------\n> 1 file changed, 15 deletions(-)\n> \n> diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp\n> index 4fb1b007..5da96ea3 100644\n> --- a/src/gstreamer/gstlibcameraprovider.cpp\n> +++ b/src/gstreamer/gstlibcameraprovider.cpp\n> @@ -33,7 +33,6 @@ GST_DEBUG_CATEGORY_STATIC(provider_debug);\n> \n> enum {\n> PROP_DEVICE_NAME = 1,\n> - PROP_AUTO_FOCUS_MODE = 2,\n> };\n> \n> #define GST_TYPE_LIBCAMERA_DEVICE gst_libcamera_device_get_type()\n> @@ -43,7 +42,6 @@ G_DECLARE_FINAL_TYPE(GstLibcameraDevice, gst_libcamera_device,\n> struct _GstLibcameraDevice {\n> GstDevice parent;\n> gchar *name;\n> - controls::AfModeEnum auto_focus_mode = controls::AfModeManual;\n> };\n> \n> G_DEFINE_TYPE(GstLibcameraDevice, gst_libcamera_device, GST_TYPE_DEVICE)\n> @@ -60,7 +58,6 @@ gst_libcamera_device_create_element(GstDevice *device, const gchar *name)\n> g_assert(source);\n> \n> g_object_set(source, \"camera-name\", GST_LIBCAMERA_DEVICE(device)->name, nullptr);\n> - g_object_set(source, \"auto-focus-mode\", GST_LIBCAMERA_DEVICE(device)->auto_focus_mode, nullptr);\n> \n> return source;\n> }\n> @@ -87,9 +84,6 @@ gst_libcamera_device_set_property(GObject *object, guint prop_id,\n> case PROP_DEVICE_NAME:\n> device->name = g_value_dup_string(value);\n> break;\n> - case PROP_AUTO_FOCUS_MODE:\n> - device->auto_focus_mode = static_cast(g_value_get_enum(value));\n> - break;\n> default:\n> G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);\n> break;\n> @@ -129,15 +123,6 @@ gst_libcamera_device_class_init(GstLibcameraDeviceClass *klass)\n> (GParamFlags)(G_PARAM_STATIC_STRINGS | G_PARAM_WRITABLE |\n> G_PARAM_CONSTRUCT_ONLY));\n> g_object_class_install_property(object_class, PROP_DEVICE_NAME, pspec);\n> -\n> - pspec = g_param_spec_enum(\"auto-focus-mode\",\n> - \"Set auto-focus mode\",\n> - \"Available options: AfModeManual, \"\n> - \"AfModeAuto or AfModeContinuous.\",\n> - gst_libcamera_auto_focus_get_type(),\n> - static_cast(controls::AfModeManual),\n> - G_PARAM_WRITABLE);\n> - g_object_class_install_property(object_class, PROP_AUTO_FOCUS_MODE, pspec);\n> }\n> \n> static GstDevice *\n> -- \n> 2.46.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 41DCFC32AF\n\tfor ;\n\tFri, 18 Oct 2024 14:13:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E40E46538C;\n\tFri, 18 Oct 2024 16:13:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F496633C6\n\tfor ;\n\tFri, 18 Oct 2024 16:13:52 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8D4B1514;\n\tFri, 18 Oct 2024 16:12:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fAP3exph\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729260728;\n\tbh=i1tPA40s9V83RqE2JSzN0E8DMnHx7ONGSbQvmSt2Vv0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=fAP3exph97JtTbZY8hxdvtUf9ctJw1vselKJhDSuNk8LVABPb8Fu+Tu4i1FckdLRh\n\thVASUOjx2DDD5x6+d1QSHoy0OTYTFMLPQQtET9e2haICSMUAc5H/+Gyy8EDZ7WpJL3\n\t/Z9fB3S1+sN0b/30R7muyt8EFAR4Pi0lKbQbD7Xc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241017172331.16377-2-jaslo@ziska.de>","References":"<20241017172331.16377-1-jaslo@ziska.de>\n\t<20241017172331.16377-2-jaslo@ziska.de>","Subject":"Re: [PATCH v3 1/3] gstreamer: Remove auto-focus-mode property from\n\tdevice provider","From":"Kieran Bingham ","Cc":"Jaslo Ziska ,\n\tLaurent Pinchart ","To":"Jaslo Ziska , libcamera-devel@lists.libcamera.org","Date":"Fri, 18 Oct 2024 15:13:49 +0100","Message-ID":"<172926082945.3353069.12425952353436315505@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]