[{"id":2882,"web_url":"https://patchwork.libcamera.org/comment/2882/","msgid":"<20191013153108.GN23166@bigcity.dyn.berto.se>","date":"2019-10-13T15:31:08","subject":"Re: [libcamera-devel] [PATCH v2 05/14] libcamera: controls: Default\n\tControlList validator argument to nullptr","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-10-12 21:43:58 +0300, Laurent Pinchart wrote:\n> The ControlList constructor takes a validator pointer that can be null.\n> Set its default value to nullptr to simplify code in users of\n> ControlList.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/controls.h | 2 +-\n> src/ipa/rkisp1/rkisp1.cpp | 2 +-\n> src/libcamera/request.cpp | 2 +-\n> 3 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index 342251c21018..12a13aacb198 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -126,7 +126,7 @@ private:\n> \tusing ControlListMap = std::unordered_map;\n> \n> public:\n> -\tControlList(ControlValidator *validator);\n> +\tControlList(ControlValidator *validator = nullptr);\n> \n> \tusing iterator = ControlListMap::iterator;\n> \tusing const_iterator = ControlListMap::const_iterator;\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 02419e254f2d..80138f196184 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -220,7 +220,7 @@ void IPARkISP1::setControls(unsigned int frame)\n> \n> void IPARkISP1::metadataReady(unsigned int frame, unsigned int aeState)\n> {\n> -\tControlList ctrls(nullptr);\n> +\tControlList ctrls;\n> \n> \tif (aeState)\n> \t\tctrls.set(controls::AeLocked, aeState == 2);\n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index 23d3ab6f422c..e800f1449888 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -69,7 +69,7 @@ Request::Request(Camera *camera, uint64_t cookie)\n> \t/**\n> \t * \\todo: Add a validator for metadata controls.\n> \t */\n> -\tmetadata_ = new ControlList(nullptr);\n> +\tmetadata_ = new ControlList();\n> }\n> \n> Request::~Request()\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2A02561562\n\tfor ;\n\tSun, 13 Oct 2019 17:31:10 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id y23so14152910lje.9\n\tfor ;\n\tSun, 13 Oct 2019 08:31:10 -0700 (PDT)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\t134sm3527891lfk.70.2019.10.13.08.31.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 13 Oct 2019 08:31:08 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=4xknXyo1RWm4s+ktEavpd/GPcZCtnfDkJmjCVYDqgVo=;\n\tb=zZTc6ejw4w3265cnb9exm+XRm9F7hFLPuFyN3muPi7NUvVmv4oSGhgNYhOee6XNTOT\n\t2kjPcf6eTlolIy5JtbFzt0FmDih6w4LbYXKWKqsagmbqeHr3XaByXdzcZNv+NJyxBoQ6\n\tDFWoCI/4qWlJyNZAKWMIw/A1dWIceCYr2b8kn6L2FbnnrIVzgnMANeRkiCaMdWJcI+kX\n\tSIS8UdrojC+v62lYr6p3COhpaXl3VUNfTrLrA7ZWbz2ApyxLBcCQnuzaOd4LvcC/tfW3\n\tN0qvvwaX+0DeJoTSGMZ/+d5v62OIdYZcW8QVGOJhOMBCXvakzPrfa81Kabmttkm70+qQ\n\t5ClQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=4xknXyo1RWm4s+ktEavpd/GPcZCtnfDkJmjCVYDqgVo=;\n\tb=BYyeNlMqmQCBRZl4sTeWS6tNYW8dBkyUYve23Jywpirt5r23L35fxBN3+WOmHgAEgC\n\tRDSJEDlFFeNWcCZ8qctWgWot6ZtbuauArU+axp+LNjI/7ToiXbdMNyFTehmBHuUIN1Vv\n\to9MKKdHWJjIp0TKGImWESR4LvVMJmrpbt6+g2ir1jxkXppfaH0rVAoVzZyPoSRZmoHFV\n\tYyW83/f32PBF7P7VAVIq1lonwsiZ6vKz6vCHX/HY482iTbTIcNjcqNQxsFsW560r5eyr\n\tgBBh7i/8wvmi1xSOOh6pe2ZxDS2WUpI4opFtecJFlFO7DQs2Dy2+79y/vxm/OpkrKwCU\n\tULCg==","X-Gm-Message-State":"APjAAAXfOrJTasERNhxJ7rCxaxA4I3l19KJGx3cuS4gbflblsmcOB9k6\n\toKvoD+gRTRND+BzDalWJ8P2/xg==","X-Google-Smtp-Source":"APXvYqzyMtrK23v6uy3SJMiyHM5hnzvld7Y776jTOawHZ4ZBZzZpzWnZIr7bvzSIgnujVeaOqDXMXQ==","X-Received":"by 2002:a2e:a0ca:: with SMTP id\n\tf10mr15221364ljm.83.1570980669616; \n\tSun, 13 Oct 2019 08:31:09 -0700 (PDT)","Date":"Sun, 13 Oct 2019 17:31:08 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191013153108.GN23166@bigcity.dyn.berto.se>","References":"<20191012184407.31684-1-laurent.pinchart@ideasonboard.com>\n\t<20191012184407.31684-6-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191012184407.31684-6-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v2 05/14] libcamera: controls: Default\n\tControlList validator argument to nullptr","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 13 Oct 2019 15:31:10 -0000"}}]