[{"id":31814,"web_url":"https://patchwork.libcamera.org/comment/31814/","msgid":"<172937569660.2485972.15289888440584142513@ping.linuxembedded.co.uk>","date":"2024-10-19T22:08:16","subject":"Re: [PATCH v2 3/3] py: Add bindings for ControlId vendor information","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder (2024-10-16 12:19:43)\n> Add python bindings for quering vendor information from a ControlId.\n> While at it, update __repr__ so that it also prints the vendor.\n> \n> Example usage:\n> >>> cid\n> libcamera.ControlId(20, libcamera.Saturation, ControlType.Float)\n\nThanks!\n\nReviewed-by: Kieran Bingham \n\n\n> >>> cid.vendor\n> 'libcamera'\n> \n> Signed-off-by: Paul Elder \n> ---\n> Changes in v2:\n> - reorder code so vendor comes immediately after name\n> - update repr\n> ---\n> src/py/libcamera/py_main.cpp | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\n> index 983b76f6e998..09b6f9db0650 100644\n> --- a/src/py/libcamera/py_main.cpp\n> +++ b/src/py/libcamera/py_main.cpp\n> @@ -399,11 +399,12 @@ PYBIND11_MODULE(_libcamera, m)\n> pyControlId\n> .def_property_readonly(\"id\", &ControlId::id)\n> .def_property_readonly(\"name\", &ControlId::name)\n> + .def_property_readonly(\"vendor\", &ControlId::vendor)\n> .def_property_readonly(\"type\", &ControlId::type)\n> .def(\"__str__\", [](const ControlId &self) { return self.name(); })\n> .def(\"__repr__\", [](const ControlId &self) {\n> - return py::str(\"libcamera.ControlId({}, {}, {})\")\n> - .format(self.id(), self.name(), self.type());\n> + return py::str(\"libcamera.ControlId({}, {}.{}, {})\")\n> + .format(self.id(), self.vendor(), self.name(), self.type());\n> })\n> .def(\"enumerators\", &ControlId::enumerators);\n> \n> -- \n> 2.39.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C77EC3302\n\tfor ;\n\tSat, 19 Oct 2024 22:08:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 231676538E;\n\tSun, 20 Oct 2024 00:08:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C835F65382\n\tfor ;\n\tSun, 20 Oct 2024 00:08:19 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 296F5526;\n\tSun, 20 Oct 2024 00:06:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"il+EMVqz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729375595;\n\tbh=Ya+RcbDB8kM83PHwFwrVUUjETpDIDq6GkI6GeIehVjQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=il+EMVqzTCvFTicvKPswJiCnqK5faSaRh+a95eY6EjPAGyz1fR4U6apUaBdKTTA3j\n\thFN2wetcjTsFecZtZDPQlOea9EvUniuvYsdjLWFwLwtWECHBP7afXpS/r29/3yIRpU\n\tUUa+39DKu57NOGQjjrtwA0v+u1CVefNGsPtDkfuo=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241016111943.1411372-4-paul.elder@ideasonboard.com>","References":"<20241016111943.1411372-1-paul.elder@ideasonboard.com>\n\t<20241016111943.1411372-4-paul.elder@ideasonboard.com>","Subject":"Re: [PATCH v2 3/3] py: Add bindings for ControlId vendor information","From":"Kieran Bingham ","Cc":"Paul Elder ","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sat, 19 Oct 2024 23:08:16 +0100","Message-ID":"<172937569660.2485972.15289888440584142513@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31840,"web_url":"https://patchwork.libcamera.org/comment/31840/","msgid":"<20241020211913.GK7770@pendragon.ideasonboard.com>","date":"2024-10-20T21:19:13","subject":"Re: [PATCH v2 3/3] py: Add bindings for ControlId vendor information","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Oct 16, 2024 at 08:19:43PM +0900, Paul Elder wrote:\n> Add python bindings for quering vendor information from a ControlId.\n> While at it, update __repr__ so that it also prints the vendor.\n> \n> Example usage:\n> >>> cid\n> libcamera.ControlId(20, libcamera.Saturation, ControlType.Float)\n> >>> cid.vendor\n> 'libcamera'\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Changes in v2:\n> - reorder code so vendor comes immediately after name\n> - update repr\n> ---\n> src/py/libcamera/py_main.cpp | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\n> index 983b76f6e998..09b6f9db0650 100644\n> --- a/src/py/libcamera/py_main.cpp\n> +++ b/src/py/libcamera/py_main.cpp\n> @@ -399,11 +399,12 @@ PYBIND11_MODULE(_libcamera, m)\n> \tpyControlId\n> \t\t.def_property_readonly(\"id\", &ControlId::id)\n> \t\t.def_property_readonly(\"name\", &ControlId::name)\n> +\t\t.def_property_readonly(\"vendor\", &ControlId::vendor)\n> \t\t.def_property_readonly(\"type\", &ControlId::type)\n> \t\t.def(\"__str__\", [](const ControlId &self) { return self.name(); })\n> \t\t.def(\"__repr__\", [](const ControlId &self) {\n> -\t\t\treturn py::str(\"libcamera.ControlId({}, {}, {})\")\n> -\t\t\t\t.format(self.id(), self.name(), self.type());\n> +\t\t\treturn py::str(\"libcamera.ControlId({}, {}.{}, {})\")\n> +\t\t\t\t.format(self.id(), self.vendor(), self.name(), self.type());\n> \t\t})\n> \t\t.def(\"enumerators\", &ControlId::enumerators);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 74EA5C3304\n\tfor ;\n\tSun, 20 Oct 2024 21:19:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 49A3C65391;\n\tSun, 20 Oct 2024 23:19:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D6F465379\n\tfor ;\n\tSun, 20 Oct 2024 23:19:19 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A549F502;\n\tSun, 20 Oct 2024 23:17:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"APfP+YPH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729459053;\n\tbh=ESwi/pZdwkU8w33HSAWsp8LHVQCma3AHIX/88k+xOM0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=APfP+YPHpQkXBazSfv0O6+kL5V+haSlYeJ9C0D33XGE4za2pwe2PN9cygI+F2CtLz\n\tltxDY2gSKQYiCaTNDkm951Avn5urpQN4QN2Uckv4YOs4puJMY9GHNynHHU/qYXJ0Yv\n\t+6xVKRMIsazKj3BenTgbD489npUgifdpxzyXC1pc=","Date":"Mon, 21 Oct 2024 00:19:13 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 3/3] py: Add bindings for ControlId vendor information","Message-ID":"<20241020211913.GK7770@pendragon.ideasonboard.com>","References":"<20241016111943.1411372-1-paul.elder@ideasonboard.com>\n\t<20241016111943.1411372-4-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241016111943.1411372-4-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]