[{"id":31813,"web_url":"https://patchwork.libcamera.org/comment/31813/","msgid":"<172937562008.2485972.16883017766227407345@ping.linuxembedded.co.uk>","date":"2024-10-19T22:07:00","subject":"Re: [PATCH v2 2/3] apps: cam: Print control vendor information when\n\tlisting controls","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder (2024-10-16 12:19:42)\n> Now that the vendor of the control can be queried, print it in\n> --list-controls.\n> \n> Example output:\n> $ cam -c 1 --list-controls\n> Using camera platform/vimc.0 Sensor B as cam0\n> Control: libcamera::Brightness: [-1.000000..1.000000]\n> Control: libcamera::Contrast: [0.000000..2.000000]\n> Control: libcamera::Saturation: [0.000000..2.000000]\n> \n> Signed-off-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> \n> ---\n> No change in v2\n> ---\n> src/apps/cam/camera_session.cpp | 7 +++++--\n> 1 file changed, 5 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\n> index edc49b875450..6e9890ccfda1 100644\n> --- a/src/apps/cam/camera_session.cpp\n> +++ b/src/apps/cam/camera_session.cpp\n> @@ -160,10 +160,13 @@ void CameraSession::listControls() const\n> {\n> for (const auto &[id, info] : camera_->controls()) {\n> if (info.values().empty()) {\n> - std::cout << \"Control: \" << id->name() << \": \"\n> + std::cout << \"Control: \"\n> + << id->vendor() << \"::\" << id->name() << \": \"\n> << info.toString() << std::endl;\n> } else {\n> - std::cout << \"Control: \" << id->name() << \":\" << std::endl;\n> + std::cout << \"Control: \"\n> + << id->vendor() << \"::\" << id->name() << \":\"\n> + << std::endl;\n> for (const auto &value : info.values()) {\n> int32_t val = value.get();\n> const auto &it = id->enumerators().find(val);\n> -- \n> 2.39.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F09C3C3302\n\tfor ;\n\tSat, 19 Oct 2024 22:07:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 97E886538C;\n\tSun, 20 Oct 2024 00:07:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3D617633C6\n\tfor ;\n\tSun, 20 Oct 2024 00:07:03 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 94391526;\n\tSun, 20 Oct 2024 00:05:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fPMOsXhu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729375518;\n\tbh=GqgbC+GpIdVHI5krA3HeOG+nsIs7VteQY26VqutpMbU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=fPMOsXhuqzyoVcPHYUX8bFasuwNlcYmqkhpt84ODgfemSDwNQ0Gelq6UPKkFeSb2S\n\tF4Eb7heYrw5AewgeqUCt6p8XvURQQKaI9y8ZTRr9JjKi0b+gPreHXOyza2qSu37CTi\n\tfyypBjFZGU3R1gvZF7LQJCx85muPzYs4VIWGLdmA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241016111943.1411372-3-paul.elder@ideasonboard.com>","References":"<20241016111943.1411372-1-paul.elder@ideasonboard.com>\n\t<20241016111943.1411372-3-paul.elder@ideasonboard.com>","Subject":"Re: [PATCH v2 2/3] apps: cam: Print control vendor information when\n\tlisting controls","From":"Kieran Bingham ","Cc":"Paul Elder ,\n\tLaurent Pinchart ","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sat, 19 Oct 2024 23:07:00 +0100","Message-ID":"<172937562008.2485972.16883017766227407345@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]