{"id":21639,"url":"https://patchwork.libcamera.org/api/patches/21639/?format=json","web_url":"https://patchwork.libcamera.org/patch/21639/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241016111943.1411372-3-paul.elder@ideasonboard.com>","date":"2024-10-16T11:19:42","name":"[v2,2/3] apps: cam: Print control vendor information when listing controls","commit_ref":"b777d8272af030f66b1a3636d6ffc9b41be58e24","pull_url":null,"state":"accepted","archived":false,"hash":"c485d457cb8277d02036eb13864f381a168810d9","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21639/mbox/","series":[{"id":4704,"url":"https://patchwork.libcamera.org/api/series/4704/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4704","date":"2024-10-16T11:19:40","name":"libcamera: controls: Add namespace to ControlId","version":2,"mbox":"https://patchwork.libcamera.org/series/4704/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21639/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21639/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64BF2C326C\n\tfor ;\n\tWed, 16 Oct 2024 11:20:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E039C65384;\n\tWed, 16 Oct 2024 13:20:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD3DC6537E\n\tfor ;\n\tWed, 16 Oct 2024 13:19:56 +0200 (CEST)","from neptunite.flets-east.jp (unknown\n\t[IPv6:2404:7a81:160:2100:b5b2:fcb4:385e:af78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B421BA2F;\n\tWed, 16 Oct 2024 13:18:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MH0N9OBX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729077493;\n\tbh=Wezd4VcDkjihNmNpd33Z/q/o4Hw3ghbqN++Z69jicXk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=MH0N9OBX0tnDcV7UCj1ep6ElPYfEJcLHly+85DNHXrOc2TB6VKcX1Wy6I7d7CMsDg\n\tjIy66ZwP2vgGOKeTHoWnp+fIpImD5tZMMzBDFEyuek0NJOou1EK3zjepBLMAho9R3k\n\tvMAKMuBE+4vb0Ju2G+orusAznTWig7/7IjwbS1YI=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Cc":"Paul Elder ,\n\tLaurent Pinchart ","Subject":"[PATCH v2 2/3] apps: cam: Print control vendor information when\n\tlisting controls","Date":"Wed, 16 Oct 2024 20:19:42 +0900","Message-Id":"<20241016111943.1411372-3-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.39.2","In-Reply-To":"<20241016111943.1411372-1-paul.elder@ideasonboard.com>","References":"<20241016111943.1411372-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that the vendor of the control can be queried, print it in\n--list-controls.\n\nExample output:\n$ cam -c 1 --list-controls\nUsing camera platform/vimc.0 Sensor B as cam0\nControl: libcamera::Brightness: [-1.000000..1.000000]\nControl: libcamera::Contrast: [0.000000..2.000000]\nControl: libcamera::Saturation: [0.000000..2.000000]\n\nSigned-off-by: Paul Elder \nReviewed-by: Laurent Pinchart \n\n---\nNo change in v2\n---\n src/apps/cam/camera_session.cpp | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)","diff":"diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\nindex edc49b875450..6e9890ccfda1 100644\n--- a/src/apps/cam/camera_session.cpp\n+++ b/src/apps/cam/camera_session.cpp\n@@ -160,10 +160,13 @@ void CameraSession::listControls() const\n {\n \tfor (const auto &[id, info] : camera_->controls()) {\n \t\tif (info.values().empty()) {\n-\t\t\tstd::cout << \"Control: \" << id->name() << \": \"\n+\t\t\tstd::cout << \"Control: \"\n+\t\t\t\t << id->vendor() << \"::\" << id->name() << \": \"\n \t\t\t\t << info.toString() << std::endl;\n \t\t} else {\n-\t\t\tstd::cout << \"Control: \" << id->name() << \":\" << std::endl;\n+\t\t\tstd::cout << \"Control: \"\n+\t\t\t\t << id->vendor() << \"::\" << id->name() << \":\"\n+\t\t\t\t << std::endl;\n \t\t\tfor (const auto &value : info.values()) {\n \t\t\t\tint32_t val = value.get();\n \t\t\t\tconst auto &it = id->enumerators().find(val);\n","prefixes":["v2","2/3"]}