[{"id":31765,"web_url":"https://patchwork.libcamera.org/comment/31765/","msgid":"<172908857756.877857.2649046341201068328@ping.linuxembedded.co.uk>","date":"2024-10-16T14:22:57","subject":"Re: [PATCH v1 3/4] libcamera: controls: Add missing size to\n\tcontrol_type","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2024-10-15 21:38:14)\n> The size member is missing in control_type. Add it.\n> \n> Fixes: 200d535ca85f (\"libcamera: controls: Add ControlTypePoint\")\n> Signed-off-by: Stefan Klug \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/controls.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index ca60bbacad17..28fec767fae1 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -101,6 +101,7 @@ struct control_type {\n> template<>\n> struct control_type {\n> static constexpr ControlType value = ControlTypePoint;\n> + static constexpr std::size_t size = 0;\n> };\n> \n> template\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 432DFC32FA\n\tfor ;\n\tWed, 16 Oct 2024 14:23:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E7C7865383;\n\tWed, 16 Oct 2024 16:23:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7FEAC6537E\n\tfor ;\n\tWed, 16 Oct 2024 16:23:00 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E8F5BA2F;\n\tWed, 16 Oct 2024 16:21:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oO92OK69\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729088478;\n\tbh=20KbTycf36gjQ5lY+xG5ipokmURM23Z3gapNqDmlw1Q=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=oO92OK69hvFsK9EyIt3v9H9dbRzsPhV9z3Yd4j+Y+ULvcCqi/LvhMs1/I9bKagMqC\n\tpcYgkj7AZN4PI3tz9mnHyqXgs5USdsyqUExAL5kcFfyKIz2tLjVlbmflK0j+JOpwBq\n\tHB6Ubnu3SRWhwWCEf0YdZ7R7xhqJO7ApMdCNGFvs=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241015203820.574326-4-stefan.klug@ideasonboard.com>","References":"<20241015203820.574326-1-stefan.klug@ideasonboard.com>\n\t<20241015203820.574326-4-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v1 3/4] libcamera: controls: Add missing size to\n\tcontrol_type","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 16 Oct 2024 15:22:57 +0100","Message-ID":"<172908857756.877857.2649046341201068328@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31768,"web_url":"https://patchwork.libcamera.org/comment/31768/","msgid":"<20241016144010.GB30496@pendragon.ideasonboard.com>","date":"2024-10-16T14:40:10","subject":"Re: [PATCH v1 3/4] libcamera: controls: Add missing size to\n\tcontrol_type","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Tue, Oct 15, 2024 at 10:38:14PM +0200, Stefan Klug wrote:\n> The size member is missing in control_type. Add it.\n\nYou may want to describe here what issue(s) this causes.\n\n> Fixes: 200d535ca85f (\"libcamera: controls: Add ControlTypePoint\")\n> Signed-off-by: Stefan Klug \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/controls.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index ca60bbacad17..28fec767fae1 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -101,6 +101,7 @@ struct control_type {\n> template<>\n> struct control_type {\n> \tstatic constexpr ControlType value = ControlTypePoint;\n> +\tstatic constexpr std::size_t size = 0;\n> };\n> \n> template","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EC96EC32FA\n\tfor ;\n\tWed, 16 Oct 2024 14:40:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 900D765385;\n\tWed, 16 Oct 2024 16:40:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 646896537F\n\tfor ;\n\tWed, 16 Oct 2024 16:40:15 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AB934A2F;\n\tWed, 16 Oct 2024 16:38:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"D0OmMlQ7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729089512;\n\tbh=q55TcR7st/xG1//kWZaZ0jB8Q906EP8ZwU6lG6pfDdw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=D0OmMlQ7T75jQOCp8zsEh0oMN0tjyUvC7gYYp8IC8noxTXz4l9+Jj+l7b3Tb7xwPb\n\t0zuxd9nutZ0RSAn0qQh6QmPW22770YOmLbp6t7O0/4IbUJiRbkW3ToDV2+113zVwaI\n\tsDsi6qCfDD7C1GlPXUHNFZfrJrUyOvAGCr7RXMbA=","Date":"Wed, 16 Oct 2024 17:40:10 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 3/4] libcamera: controls: Add missing size to\n\tcontrol_type","Message-ID":"<20241016144010.GB30496@pendragon.ideasonboard.com>","References":"<20241015203820.574326-1-stefan.klug@ideasonboard.com>\n\t<20241015203820.574326-4-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241015203820.574326-4-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31779,"web_url":"https://patchwork.libcamera.org/comment/31779/","msgid":"","date":"2024-10-17T01:32:21","subject":"Re: [PATCH v1 3/4] libcamera: controls: Add missing size to\n\tcontrol_type","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Tue, Oct 15, 2024 at 10:38:14PM +0200, Stefan Klug wrote:\n> The size member is missing in control_type. Add it.\n\nOops.\n\nReviewed-by: Paul Elder \n\n> \n> Fixes: 200d535ca85f (\"libcamera: controls: Add ControlTypePoint\")\n> Signed-off-by: Stefan Klug \n> ---\n> include/libcamera/controls.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index ca60bbacad17..28fec767fae1 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -101,6 +101,7 @@ struct control_type {\n> template<>\n> struct control_type {\n> \tstatic constexpr ControlType value = ControlTypePoint;\n> +\tstatic constexpr std::size_t size = 0;\n> };\n> \n> template\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 84AA9C326C\n\tfor ;\n\tThu, 17 Oct 2024 01:32:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E5A2C65387;\n\tThu, 17 Oct 2024 03:32:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B655633C7\n\tfor ;\n\tThu, 17 Oct 2024 03:32:27 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:da41:46b1:7eef:1e0d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 98E09968;\n\tThu, 17 Oct 2024 03:30:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"F6SxXdfr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729128644;\n\tbh=NTVm4p2/dZhFi+TUxy0Gt9V92GQ35nVr3bcnskoBnMQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=F6SxXdfr5P185cLpI+fDPGY1PTePzMX7nTSDjXNkV/rwmHhc1dCktNafz2iR4utia\n\t2zkfAMFlUw0KrNoSP98IxahU0B6LwIWrRs948mNZic4lOHUgO05umXRtFdG9RIgdHC\n\t1SuI0jDPXm0KoufQIvhpy8ma7RkpxKJHKG/Y6tw0=","Date":"Thu, 17 Oct 2024 10:32:21 +0900","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 3/4] libcamera: controls: Add missing size to\n\tcontrol_type","Message-ID":"","References":"<20241015203820.574326-1-stefan.klug@ideasonboard.com>\n\t<20241015203820.574326-4-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20241015203820.574326-4-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]