[{"id":31774,"web_url":"https://patchwork.libcamera.org/comment/31774/","msgid":"<20241016171507.GB20855@pendragon.ideasonboard.com>","date":"2024-10-16T17:15:07","subject":"Re: [PATCHv3] Fix copyright year","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Bernhard,\n\nThank you for the patch.\n\nThe subject line should read\n\nlibcamera: tracepoints: Fix copyright year for reproducible builds\n\nor something like that. checkstyle.py should have mentioned that the\nsubject line is missing a prefix. You can automate running checkstyle.py\nby installing the git post-commit hook with\n\ncp utils/hooks/post-commit .git/hooks/post-commit\n\nOn Tue, Oct 15, 2024 at 06:50:07PM +0200, libcamerabmw+ml@lsmod.de wrote:\n> From: \"Bernhard M. Wiedemann\" \n> \n> without this patch, openSUSE's debugsource package would vary over time,\n> breaking reproducible builds.\n> Also a copyright of 2025 is factually wrong,\n> because nobody did anything copyright-worthy in that year.\n> If updating the year manually is too hard (it is optional anyway),\n> using the mtime of input file(s) could work as well.\n> \n> By moving the year to tracepoints.h.in it can easily be updated\n> along with the content.\n> \n> The diff was:\n> /usr/src/debug/libcamera-0.3.1/x86_64-suse-linux/include/libcamera/internal/tracepoints.h 2024-08-20 09:37:46.000000000 +0200\n> @@ -1,6 +1,6 @@\n> /* SPDX-License-Identifier: LGPL-2.1-or-later */\n> /*\n> - * Copyright (C) 2024, Google Inc.\n> + * Copyright (C) 2025, Google Inc.\n\nI have a hard time parsing the commit message, I don't see where \"2025\"\ncomes from here. Also, now that we've settled on not updating the year,\nI think the mention of mtime is not applicable anymore. How about the\nfollowing commit message ?\n\n---\nlibcamera: tracepoints: Fix copyright year for reproducible builds\n\nThe tracepoints.h file is generated from the tracepoints.h.in template\nby the gen-tp-header.py script. The template contains a {{year}}\nplaceholder for the copyright year, which the script fills with the\ncurrent year. This breaks reproducible builds with at least the openSUSE\ndebugsource package.\n\nAs the gen-tp-header.py script doesn't add any copyrightable contents to\nthe tracepoints.h file, fix this by replacing the {{year}} placeholder\nwith the year of the last copyright-worthy change to tracepoints.h.in.\n---\n\nIf you're fine with this, you can reply with an ack instead of sending a\nv4 and I'll update the commit message when applying the patch.\n\nReviewed-by: Laurent Pinchart \n\n> Signed-off-by: Bernhard M. Wiedemann \n> ---\n> include/libcamera/internal/tracepoints.h.in | 2 +-\n> utils/codegen/gen-tp-header.py | 4 +---\n> 2 files changed, 2 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/libcamera/internal/tracepoints.h.in b/include/libcamera/internal/tracepoints.h.in\n> index f0962091..385f9f54 100644\n> --- a/include/libcamera/internal/tracepoints.h.in\n> +++ b/include/libcamera/internal/tracepoints.h.in\n> @@ -1,6 +1,6 @@\n> /* SPDX-License-Identifier: LGPL-2.1-or-later */\n> /*\n> - * Copyright (C) {{year}}, Google Inc.\n> + * Copyright (C) 2020, Google Inc.\n> *\n> * Tracepoints with lttng\n> *\n> diff --git a/utils/codegen/gen-tp-header.py b/utils/codegen/gen-tp-header.py\n> index 83606c32..6769c7ce 100755\n> --- a/utils/codegen/gen-tp-header.py\n> +++ b/utils/codegen/gen-tp-header.py\n> @@ -6,7 +6,6 @@\n> #\n> # Generate header file to contain lttng tracepoints\n> \n> -import datetime\n> import jinja2\n> import pathlib\n> import os\n> @@ -20,7 +19,6 @@ def main(argv):\n> output = argv[2]\n> template = argv[3]\n> \n> - year = datetime.datetime.now().year\n> path = pathlib.Path(output).absolute().relative_to(argv[1])\n> \n> source = ''\n> @@ -28,7 +26,7 @@ def main(argv):\n> source += open(fname, 'r', encoding='utf-8').read() + '\\n\\n'\n> \n> template = jinja2.Template(open(template, 'r', encoding='utf-8').read())\n> - string = template.render(year=year, path=path, source=source)\n> + string = template.render(path=path, source=source)\n> \n> f = open(output, 'w', encoding='utf-8').write(string)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3EADCC326C\n\tfor ;\n\tWed, 16 Oct 2024 17:15:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F2FDD65384;\n\tWed, 16 Oct 2024 19:15:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6703F6537F\n\tfor ;\n\tWed, 16 Oct 2024 19:15:12 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9FD92A57;\n\tWed, 16 Oct 2024 19:13:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QhnMw8z3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729098809;\n\tbh=piRpe2UgAZYHon+BNJMLsvFs/o/RjH9n/NJ8wrIvUdU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QhnMw8z3gNTi9ZRVXmI5Lj8q7mTWfMxkBD0AbZ0vGPlip2j0h3po+667F2rLHlxAY\n\ttdc7D3hhcE9iz3DS1lMwugfaY9vrneLNzBzecr3T8oRQCJh5PCEpaUKn1laMspBiLV\n\tPEm/OJdb+DzumiiHn4OqK7CuZo7hQXT4T125RGuc=","Date":"Wed, 16 Oct 2024 20:15:07 +0300","From":"Laurent Pinchart ","To":"libcamerabmw+ml@lsmod.de","Cc":"libcamera-devel@lists.libcamera.org,\n\t\"Bernhard M. Wiedemann\" ","Subject":"Re: [PATCHv3] Fix copyright year","Message-ID":"<20241016171507.GB20855@pendragon.ideasonboard.com>","References":"<20241014181640.GA5522@pendragon.ideasonboard.com>\n\t<20241015165006.1547318-2-libcamerabmw+ml@lsmod.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241015165006.1547318-2-libcamerabmw+ml@lsmod.de>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31782,"web_url":"https://patchwork.libcamera.org/comment/31782/","msgid":"<9ace2401-96f8-48e8-a151-db174c8f29c9@suse.de>","date":"2024-10-17T02:46:10","subject":"Re: [PATCHv3] Fix copyright year","submitter":{"id":210,"url":"https://patchwork.libcamera.org/api/people/210/","name":"Bernhard M. Wiedemann","email":"bwiedemann@suse.de"},"content":"On 16/10/2024 19.15, Laurent Pinchart wrote:\n> The template contains a {{year}} placeholder\n\nAck.\n\nThough I would use past tense:\nThe template contained a {{year}} placeholder","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 439E5C326C\n\tfor ;\n\tThu, 17 Oct 2024 06:44:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0261165383;\n\tThu, 17 Oct 2024 08:44:18 +0200 (CEST)","from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B603633C7\n\tfor ;\n\tThu, 17 Oct 2024 04:46:16 +0200 (CEST)","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n\t[IPv6:2a07:de40:b281:104:10:150:64:97])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby smtp-out2.suse.de (Postfix) with ESMTPS id C36A21FCFD;\n\tThu, 17 Oct 2024 02:46:15 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 90F3E13A42;\n\tThu, 17 Oct 2024 02:46:15 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n\tby imap1.dmz-prg2.suse.org with ESMTPSA id Te3GIHd6EGdoXwAAD6G6ig\n\t(envelope-from ); Thu, 17 Oct 2024 02:46:15 +0000"],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=suse.de header.i=@suse.de header.b=\"edH+7GjV\";\n\tdkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de\n\theader.b=\"9SklF3Uo\"; \n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n\theader.b=\"edH+7GjV\"; \n\tdkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de\n\theader.b=\"9SklF3Uo\"; dkim-atps=neutral","smtp-out2.suse.de;\n\tdkim=pass header.d=suse.de header.s=susede2_rsa header.b=edH+7GjV;\n\tdkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=9SklF3Uo"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_rsa; t=1729133175;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\tmime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references:autocrypt:autocrypt;\n\tbh=TQvu2AzmLliemDsnlkD3fZCN68koNAiE6lxdXuafyw4=;\n\tb=edH+7GjVy1PzOjd8OoyHWXuP5iHOYim2fvt3E2v7phakGb7AO69PBdW8Kob+EtXKOzZDn2\n\tefcaxpLWbuPi9dyyudGG7Cv6DhH4Ex1apRueOazyQ6HsJYgUEySWTXE+es75shk/ygwkwO\n\tZ3VL4No2ppWDO+DHA6y5fdxbGaXtGRg=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_ed25519; t=1729133175;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\tmime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references:autocrypt:autocrypt;\n\tbh=TQvu2AzmLliemDsnlkD3fZCN68koNAiE6lxdXuafyw4=;\n\tb=9SklF3UoFLRiptaOG4unNElz7kB3XbWqSpfNZvIE1VUusfErk7vnpoaKlbNhXWf+SlVS+E\n\t542NF80cd3h8jGCw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_rsa; t=1729133175;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\tmime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references:autocrypt:autocrypt;\n\tbh=TQvu2AzmLliemDsnlkD3fZCN68koNAiE6lxdXuafyw4=;\n\tb=edH+7GjVy1PzOjd8OoyHWXuP5iHOYim2fvt3E2v7phakGb7AO69PBdW8Kob+EtXKOzZDn2\n\tefcaxpLWbuPi9dyyudGG7Cv6DhH4Ex1apRueOazyQ6HsJYgUEySWTXE+es75shk/ygwkwO\n\tZ3VL4No2ppWDO+DHA6y5fdxbGaXtGRg=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n\ts=susede2_ed25519; t=1729133175;\n\th=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n\tmime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references:autocrypt:autocrypt;\n\tbh=TQvu2AzmLliemDsnlkD3fZCN68koNAiE6lxdXuafyw4=;\n\tb=9SklF3UoFLRiptaOG4unNElz7kB3XbWqSpfNZvIE1VUusfErk7vnpoaKlbNhXWf+SlVS+E\n\t542NF80cd3h8jGCw=="],"Message-ID":"<9ace2401-96f8-48e8-a151-db174c8f29c9@suse.de>","Date":"Thu, 17 Oct 2024 04:46:10 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCHv3] Fix copyright year","To":"Laurent Pinchart ,\n\tlibcamerabmw+ml@lsmod.de","Cc":"libcamera-devel@lists.libcamera.org","References":"<20241014181640.GA5522@pendragon.ideasonboard.com>\n\t<20241015165006.1547318-2-libcamerabmw+ml@lsmod.de>\n\t<20241016171507.GB20855@pendragon.ideasonboard.com>","Content-Language":"en-US","From":"\"Bernhard M. Wiedemann\" ","Autocrypt":"addr=bwiedemann@suse.de; keydata=\n\txsDiBDa4Do4RBADrHxWZStG7ZjH+EKgROa9ISXQi21wGNSPOA0XiAExp4gotZ7yZJwLL2vkt\n\t71vNDdLoAexG7cU1jq3aK273qGBF4QOzO/OqUmtq3eugIpGR89Fd3gHFTl7ob62iUyu2Rr9p\n\t4PV/BHwjAVJQac9Oa9gUjk2J6/FD0aERZLY3MTbj0QCg/3vFC6whS1SLF9dOM9EeqWXyJY8E\n\tANnSpHRCUBaehuE/p41sozVhvlDcUuI4JQ4QovTQ1YTHSz6yVARoJ2r2cndoVMVgrBCXcCpk\n\tgZxirB0Qa7ndYVuqliKSPDmxZCnbPT1P7Guq//VF9+pW6Iaubm9VSL1nnW//ICIOUEfYtbHq\n\tkpdVdG8sPzBrry7qfqwhOgch6R2FBADevQvDx3CEEEXONlTMNhgW0EjlWfLuHZAyOfDTWCub\n\tiODbcOHw+e/tTljqSeqSHJmp4H/3UADZd6GIy2BMYJX10mlqJYi07f8U17y/GBozPyLzuZd5\n\teFSpmbaJT6iZ84BAG6PIEXugO31A9hvAANUUzEK/K4rsfVH14af9KaAJLs0qQmVybmhhcmQg\n\tTS4gV2llZGVtYW5uIDxid2llZGVtYW5uQHN1c2UuZGU+wmEEExEIACEFAk0Qo7MCGwMFCwkI\n\tBwMFFQoJCAsFFgIDAQACHgECF4AACgkQSTYLOx37oWTS8gCg/cwbku8C8/WZ/3UvydSgHAt9\n\t+LwAoKwqpGwEYs8Ma11lM6rTtomunKL7zsNNBDa4FrIQD/4/V5EEDWT1IlJhGu05woTvkFCc\n\tgD8L11bX+xP+IWhpez12nuGLcDwH1WJj510YadRe1eLu6eoFgQa0rkowWeyjrA24vbfeVBnC\n\tqotuKfd924clVippfysI6SqXHjU/X4/xayAPfpIY/tf+xN/UEdcTThv/vWUnIWL6OxtbnNlB\n\tBRZM5HjbRbhap7IMkAe7+Z+fjS20/iqd7qcWx0oBFjCWCSoEBdyg2WFp1J2sE2ACWSrmU3N2\n\t+BZ/+xHlWlm9WOUsp70RnXXvCu2U8CmdIxMp397AxjMpPtwNLR6zB08W0ewRGTaHleoVPFwY\n\tGyNPqFrXXdxPScToNqYCi9rhGXVqj9/BbMddBj6uf1MubW5aayEnRfXwtUZYind18vFh0qgj\n\txTVMWiQ/ph7aoqCAWpwuQMx1lWtvuiKw1k6C34JFrNpeXGyiZN/7cCWwwkfmIHe3d0QgCxsR\n\tj1nMg5eVEK7RWIgu3A/Ff4aYZ4gRrh8HSk31EGEEGuRaTj9nebFI6wxZOC/SGmpmCijxcfnK\n\tsGBjup54Wdv5Cb5viJyxwAkSCUFRfh3J5a1DpKI4pD/Ew0qwfYsB9BdOFObBfo2APXD/92tS\n\tqRdsEys+cPWm+J80o9b+JelPOeJygGUSRfATYjz6/q/gdGjz8XA9Dwp4RAyrjd1wC4txqnIi\n\tyq5kRIxMFwACAg/+IpbFy+a/b5tL8C7L3lWGHoWcBkQU3F0GgP8G7V9wXKd7AGy4gkMvEeXU\n\tLJjZJJwfMVoxCCSK6DiMJig6sLux+qDLp73opskLH9Qj3lTCHcqCb9PnWDeLhsIimS9GcNwP\n\t7arwh/92Xo6AAvnVKt9QJq4aW6Vf6PVyuWKZzS1lQX0gw7hH0zkg1C6Qeba+A+sNbKnXDFj6\n\tcSDSiVCK7PwIkahapuP9N6IaVmHEKgeGVTyZZm7e9urs62XrcrcocH7+EV9Ky9kF3DrOK0Lb\n\twm5tvIbSgq5hg5fdvBCOFGDUt56nJmTuNBaE7HiCQ63z1YdUPV9O/yuys85O/5xxcLk3mlxW\n\tGbgs0CBotl+PnJ7wNMVZNzq+9bOGqabxoVaM1RO+BdPog4h81+uM0UJW6luJLQ1CNymdoPKS\n\tvOFK3UAsgj2WLeuKyvnYRJxEmUrtjmSU1JoffMlSuble01yP076N0PvDsfxwrEuW/i1wfYZ5\n\tKNNHw5RpW83FY6UYGgSHccfs8DDs1NChI2ShuCVdOpu/TX/6BUUtPEVQsW1O+7S6EX/bto22\n\t0PN7j7QA8GmLMb02RLnlietf73t0A59+mK6vAD4Ccb2yckpVEENtEHqxwH1JLPW5nggxmOgl\n\t3KyKjHCGPm6UanugKIEIf4rgxrYzu/PEvk3CI5q/k5axFCPPZ/vCTgQYEQIABgUCNrgWsgAS\n\tCRBJNgs7HfuhZAdlR1BHAAEBn/EAoK+4TcGOJD3w02lSkjaZ8dws4140AJ9LR1WGvnu6Xs+0\n\t12bW2FfpiwAGOQ==","In-Reply-To":"<20241016171507.GB20855@pendragon.ideasonboard.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"------------0oFUCSuvjpVSvRZY0hob21MR\"","X-Rspamd-Queue-Id":"C36A21FCFD","X-Spam-Score":"-5.51","X-Rspamd-Action":"no action","X-Spamd-Result":"default: False [-5.51 / 50.00]; BAYES_HAM(-3.00)[99.99%];\n\tSIGNED_PGP(-2.00)[]; MIME_BASE64_TEXT_BOGUS(1.00)[];\n\tNEURAL_HAM_LONG(-1.00)[-1.000];\n\tR_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; \n\tMIME_GOOD(-0.20)[multipart/signed,multipart/mixed,text/plain];\n\tNEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_BASE64_TEXT(0.10)[];\n\tMX_GOOD(-0.01)[];\n\tRBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n\tTO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[];\n\tDKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n\tMIME_TRACE(0.00)[0:+,1:+,2:+,3:~]; ARC_NA(0.00)[];\n\tFROM_HAS_DN(0.00)[]; HAS_ATTACHMENT(0.00)[];\n\tSPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n\tMID_RHS_MATCH_FROM(0.00)[];\n\tRECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received];\n\tRCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[];\n\tRCVD_TLS_ALL(0.00)[]; TAGGED_RCPT(0.00)[ml];\n\tASN(0.00)[asn:25478, ipnet:::/0, country:RU];\n\tRCVD_VIA_SMTP_AUTH(0.00)[]; DKIM_TRACE(0.00)[suse.de:+];\n\tRCPT_COUNT_THREE(0.00)[3];\n\tDBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,\n\timap1.dmz-prg2.suse.org:helo, suse.de:mid, suse.de:dkim]","X-Rspamd-Server":"rspamd1.dmz-prg2.suse.org","X-Spam-Flag":"NO","X-Spam-Level":"","X-Mailman-Approved-At":"Thu, 17 Oct 2024 08:44:16 +0200","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31787,"web_url":"https://patchwork.libcamera.org/comment/31787/","msgid":"<172917234827.3353069.65704539654786402@ping.linuxembedded.co.uk>","date":"2024-10-17T13:39:08","subject":"Re: [PATCHv3] Fix copyright year","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Bernhard M. Wiedemann (2024-10-17 03:46:10)\n> \n> \n> On 16/10/2024 19.15, Laurent Pinchart wrote:\n> > The template contains a {{year}} placeholder\n> \n> Ack.\n> \n> Though I would use past tense:\n> The template contained a {{year}} placeholder\n\nWe use the imperative for commit messages. i.e.\n\n\"The template contains a {{year}} place holder which prevents\nreproducible builds. Change it to be a hardcoded value based on the\nactual copyright modifications...\"\n\nThis patch is 'doing' the change, it didn't do it in the past.\n\nhttps://cbea.ms/git-commit/#imperative (Well, all of those points) are\nmy usual reference for writing commit messages.\n\n--\nKieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 74262C32FC\n\tfor ;\n\tThu, 17 Oct 2024 13:39:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F1E6165383;\n\tThu, 17 Oct 2024 15:39:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 844696353B\n\tfor ;\n\tThu, 17 Oct 2024 15:39:11 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 36820669;\n\tThu, 17 Oct 2024 15:37:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fVAifEEQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1729172248;\n\tbh=XFIm+GtKm2GAGCFRdge4qJQAaG/np/iBllivfJLIqVg=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=fVAifEEQ/cbsoVB2QAwH6bcp8QX45f9KfsGz3c601coADwuXtLeLWWDqP4R+e6GEp\n\tePkbX46uMJHq/GDPK+c5D269RBhKlFQEC9m3I+cxncSYEx5X4HY368cBdwtA2Zq9SA\n\t5b2DJy42LN6dlBhsLtfpcuXAX2I+6+d7AeEw+CkY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<9ace2401-96f8-48e8-a151-db174c8f29c9@suse.de>","References":"<20241014181640.GA5522@pendragon.ideasonboard.com>\n\t<20241015165006.1547318-2-libcamerabmw+ml@lsmod.de>\n\t<20241016171507.GB20855@pendragon.ideasonboard.com>\n\t<9ace2401-96f8-48e8-a151-db174c8f29c9@suse.de>","Subject":"Re: [PATCHv3] Fix copyright year","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"Bernhard M. Wiedemann ,\n\tLaurent Pinchart ,\n\tlibcamerabmw+ml@lsmod.de","Date":"Thu, 17 Oct 2024 14:39:08 +0100","Message-ID":"<172917234827.3353069.65704539654786402@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]