[{"id":31748,"web_url":"https://patchwork.libcamera.org/comment/31748/","msgid":"<20241015113919.GC2712@pendragon.ideasonboard.com>","date":"2024-10-15T11:39:19","subject":"Re: [PATCHv2] Fix copyright year","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Bernhard,\n\nThank you for the patch.\n\nOn Tue, Oct 15, 2024 at 10:20:25AM +0200, libcamerabmw+ml@lsmod.de wrote:\n> From: \"Bernhard M. Wiedemann\" \n> \n> without this patch, openSUSE's debugsource package would vary over time,\n> breaking reproducible builds.\n> Also a copyright of 2025 is factually wrong,\n> because nobody did anything copyright-worthy in that year.\n> If updating the year manually is too hard (it is optional anyway),\n> using the mtime of input file(s) could work as well.\n> \n> By moving the year to tracepoints.h.in it can easily be updated\n> along with the content.\n> \n> The diff was:\n> /usr/src/debug/libcamera-0.3.1/x86_64-suse-linux/include/libcamera/internal/tracepoints.h 2024-08-20 09:37:46.000000000 +0200\n> @@ -1,6 +1,6 @@\n> /* SPDX-License-Identifier: LGPL-2.1-or-later */\n> /*\n> - * Copyright (C) 2024, Google Inc.\n> + * Copyright (C) 2025, Google Inc.\n\nI'm a bit confused, where does this diff come from ?\n\n> \n> Signed-off-by: Bernhard M. Wiedemann \n> ---\n> include/libcamera/internal/tracepoints.h.in | 2 +-\n> utils/codegen/gen-tp-header.py | 4 +---\n> 2 files changed, 2 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/libcamera/internal/tracepoints.h.in b/include/libcamera/internal/tracepoints.h.in\n> index f0962091..ff5c581b 100644\n> --- a/include/libcamera/internal/tracepoints.h.in\n> +++ b/include/libcamera/internal/tracepoints.h.in\n> @@ -1,6 +1,6 @@\n> /* SPDX-License-Identifier: LGPL-2.1-or-later */\n> /*\n> - * Copyright (C) {{year}}, Google Inc.\n> + * Copyright (C) 2024, Google Inc.\n\nThis should be 2020, the file hasn't received any copyrightable change\nsince then.\n\n> *\n> * Tracepoints with lttng\n> *\n> diff --git a/utils/codegen/gen-tp-header.py b/utils/codegen/gen-tp-header.py\n> index 83606c32..6769c7ce 100755\n> --- a/utils/codegen/gen-tp-header.py\n> +++ b/utils/codegen/gen-tp-header.py\n> @@ -6,7 +6,6 @@\n> #\n> # Generate header file to contain lttng tracepoints\n> \n> -import datetime\n> import jinja2\n> import pathlib\n> import os\n> @@ -20,7 +19,6 @@ def main(argv):\n> output = argv[2]\n> template = argv[3]\n> \n> - year = datetime.datetime.now().year\n> path = pathlib.Path(output).absolute().relative_to(argv[1])\n> \n> source = ''\n> @@ -28,7 +26,7 @@ def main(argv):\n> source += open(fname, 'r', encoding='utf-8').read() + '\\n\\n'\n> \n> template = jinja2.Template(open(template, 'r', encoding='utf-8').read())\n> - string = template.render(year=year, path=path, source=source)\n> + string = template.render(path=path, source=source)\n\nLooks good.\n\n> \n> f = open(output, 'w', encoding='utf-8').write(string)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 00A43C0F2A\n\tfor ;\n\tTue, 15 Oct 2024 11:39:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E559563525;\n\tTue, 15 Oct 2024 13:39:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 83D3160537\n\tfor ;\n\tTue, 15 Oct 2024 13:39:22 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [185.143.39.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D3669A27;\n\tTue, 15 Oct 2024 13:37:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hbcwnlsL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1728992260;\n\tbh=W4r92vAmWvgUlIfVmrYmFTa1mrqcDferpvg+qInSmkA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hbcwnlsLOYJveMBnNfvLdrsXH8l7ZXMNKA3geooB+OtrHyLWBedOEI/yG2TVEEVwe\n\tem8WMbIceiLXVjzYwuRARcERk/JKfNACtWYzgED+F+0CAgHXv7yR81TdlzWuVucCvn\n\tpjComwJa8Rxs+Z2d6K+1BJ1IHe6YDwOeUmZx6wU4=","Date":"Tue, 15 Oct 2024 14:39:19 +0300","From":"Laurent Pinchart ","To":"libcamerabmw+ml@lsmod.de","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ,\n\t\"Bernhard M. Wiedemann\" ","Subject":"Re: [PATCHv2] Fix copyright year","Message-ID":"<20241015113919.GC2712@pendragon.ideasonboard.com>","References":"<20241014181640.GA5522@pendragon.ideasonboard.com>\n\t<20241015082207.640731-2-libcamerabmw+ml@lsmod.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241015082207.640731-2-libcamerabmw+ml@lsmod.de>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]